From: Eric Anholt Subject: [PATCH] drm/vc4: Fix race between page flip completion event and clean-up Date: Mon, 28 Nov 2016 14:31:04 -0800 Message-ID: <20161128223104.28645-1-eric@anholt.net> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from anholt.net (anholt.net [50.246.234.109]) by gabe.freedesktop.org (Postfix) with ESMTP id E8ADA6E5FB for ; Mon, 28 Nov 2016 22:31:05 +0000 (UTC) List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: dri-devel@lists.freedesktop.org Cc: Derek Foreman , linux-kernel@vger.kernel.org List-Id: dri-devel@lists.freedesktop.org RnJvbTogRGVyZWsgRm9yZW1hbiA8ZGVyZWtmQG9zZy5zYW1zdW5nLmNvbT4KClRoZXJlIHdhcyBh IHNtYWxsIHdpbmRvdyB3aGVyZSBhIHVzZXJzcGFjZSBwcm9ncmFtIGNvdWxkIHN1Ym1pdAphIHBh Z2VmbGlwIGFmdGVyIHJlY2VpdmluZyBhIHBhZ2VmbGlwIGNvbXBsZXRpb24gZXZlbnQgeWV0IHN0 aWxsCnJlY2VpdmUgRUJVU1kuCgpTaWduZWQtb2ZmLWJ5OiBEZXJlayBGb3JlbWFuIDxkZXJla2ZA b3NnLnNhbXN1bmcuY29tPgpTaWduZWQtb2ZmLWJ5OiBFcmljIEFuaG9sdCA8ZXJpY0BhbmhvbHQu bmV0PgpSZXZpZXdlZC1ieTogRXJpYyBBbmhvbHQgPGVyaWNAYW5ob2x0Lm5ldD4KLS0tCiBkcml2 ZXJzL2dwdS9kcm0vdmM0L3ZjNF9jcnRjLmMgfCAgOCArKysrKysrKwogZHJpdmVycy9ncHUvZHJt L3ZjNC92YzRfZHJ2LmggIHwgIDEgKwogZHJpdmVycy9ncHUvZHJtL3ZjNC92YzRfa21zLmMgIHwg MzMgKysrKysrKysrKysrKysrKysrKysrKysrKy0tLS0tLS0tCiAzIGZpbGVzIGNoYW5nZWQsIDM0 IGluc2VydGlvbnMoKyksIDggZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUv ZHJtL3ZjNC92YzRfY3J0Yy5jIGIvZHJpdmVycy9ncHUvZHJtL3ZjNC92YzRfY3J0Yy5jCmluZGV4 IDdmMDhkNjgxYTc0Yi4uODJmOTE0YWY0MTU2IDEwMDY0NAotLS0gYS9kcml2ZXJzL2dwdS9kcm0v dmM0L3ZjNF9jcnRjLmMKKysrIGIvZHJpdmVycy9ncHUvZHJtL3ZjNC92YzRfY3J0Yy5jCkBAIC02 NjksNiArNjY5LDE0IEBAIHZvaWQgdmM0X2Rpc2FibGVfdmJsYW5rKHN0cnVjdCBkcm1fZGV2aWNl ICpkZXYsIHVuc2lnbmVkIGludCBjcnRjX2lkKQogCUNSVENfV1JJVEUoUFZfSU5URU4sIDApOwog fQogCisvKiBNdXN0IGJlIGNhbGxlZCB3aXRoIHRoZSBldmVudCBsb2NrIGhlbGQgKi8KK2Jvb2wg dmM0X2V2ZW50X3BlbmRpbmcoc3RydWN0IGRybV9jcnRjICpjcnRjKQoreworCXN0cnVjdCB2YzRf Y3J0YyAqdmM0X2NydGMgPSB0b192YzRfY3J0YyhjcnRjKTsKKworCXJldHVybiAhIXZjNF9jcnRj LT5ldmVudDsKK30KKwogc3RhdGljIHZvaWQgdmM0X2NydGNfaGFuZGxlX3BhZ2VfZmxpcChzdHJ1 Y3QgdmM0X2NydGMgKnZjNF9jcnRjKQogewogCXN0cnVjdCBkcm1fY3J0YyAqY3J0YyA9ICZ2YzRf Y3J0Yy0+YmFzZTsKZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS92YzQvdmM0X2Rydi5oIGIv ZHJpdmVycy9ncHUvZHJtL3ZjNC92YzRfZHJ2LmgKaW5kZXggZmVmMTcyODA0MzQ1Li5iMzA2NGUy ZTc5YzEgMTAwNjQ0Ci0tLSBhL2RyaXZlcnMvZ3B1L2RybS92YzQvdmM0X2Rydi5oCisrKyBiL2Ry aXZlcnMvZ3B1L2RybS92YzQvdmM0X2Rydi5oCkBAIC00NDIsNiArNDQyLDcgQEAgaW50IHZjNF9i b19zdGF0c19kZWJ1Z2ZzKHN0cnVjdCBzZXFfZmlsZSAqbSwgdm9pZCAqYXJnKTsKIGV4dGVybiBz dHJ1Y3QgcGxhdGZvcm1fZHJpdmVyIHZjNF9jcnRjX2RyaXZlcjsKIGludCB2YzRfZW5hYmxlX3Zi bGFuayhzdHJ1Y3QgZHJtX2RldmljZSAqZGV2LCB1bnNpZ25lZCBpbnQgY3J0Y19pZCk7CiB2b2lk IHZjNF9kaXNhYmxlX3ZibGFuayhzdHJ1Y3QgZHJtX2RldmljZSAqZGV2LCB1bnNpZ25lZCBpbnQg Y3J0Y19pZCk7Citib29sIHZjNF9ldmVudF9wZW5kaW5nKHN0cnVjdCBkcm1fY3J0YyAqY3J0Yyk7 CiBpbnQgdmM0X2NydGNfZGVidWdmc19yZWdzKHN0cnVjdCBzZXFfZmlsZSAqbSwgdm9pZCAqYXJn KTsKIGludCB2YzRfY3J0Y19nZXRfc2Nhbm91dHBvcyhzdHJ1Y3QgZHJtX2RldmljZSAqZGV2LCB1 bnNpZ25lZCBpbnQgY3J0Y19pZCwKIAkJCSAgICB1bnNpZ25lZCBpbnQgZmxhZ3MsIGludCAqdnBv cywgaW50ICpocG9zLApkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL3ZjNC92YzRfa21zLmMg Yi9kcml2ZXJzL2dwdS9kcm0vdmM0L3ZjNF9rbXMuYwppbmRleCBjMWY2NWM2YzhlNjAuLjY3YWYy YWY3MGFmMCAxMDA2NDQKLS0tIGEvZHJpdmVycy9ncHUvZHJtL3ZjNC92YzRfa21zLmMKKysrIGIv ZHJpdmVycy9ncHUvZHJtL3ZjNC92YzRfa21zLmMKQEAgLTExOSwxNyArMTE5LDM0IEBAIHN0YXRp YyBpbnQgdmM0X2F0b21pY19jb21taXQoc3RydWN0IGRybV9kZXZpY2UgKmRldiwKIAogCS8qIE1h a2Ugc3VyZSB0aGF0IGFueSBvdXRzdGFuZGluZyBtb2Rlc2V0cyBoYXZlIGZpbmlzaGVkLiAqLwog CWlmIChub25ibG9jaykgewotCQlyZXQgPSBkb3duX3RyeWxvY2soJnZjNC0+YXN5bmNfbW9kZXNl dCk7Ci0JCWlmIChyZXQpIHsKKwkJc3RydWN0IGRybV9jcnRjICpjcnRjOworCQlzdHJ1Y3QgZHJt X2NydGNfc3RhdGUgKmNydGNfc3RhdGU7CisJCXVuc2lnbmVkIGxvbmcgZmxhZ3M7CisJCWJvb2wg YnVzeSA9IGZhbHNlOworCisJCS8qCisJCSAqIElmIHRoZXJlJ3MgYW4gdW5kaXNwYXRjaGVkIGV2 ZW50IHRvIHNlbmQgdGhlbiB3ZSdyZQorCQkgKiBvYnZpb3VzbHkgc3RpbGwgYnVzeS4gIElmIHRo ZXJlIGlzbid0LCB0aGVuIHdlIGNhbgorCQkgKiB1bmNvbmRpdGlvbmFsbHkgd2FpdCBmb3IgdGhl IHNlbWFwaG9yZSBiZWNhdXNlIGl0CisJCSAqIHNob3VsZG4ndCBiZSBjb250ZW5kZWQgKGZvciBs b25nKS4KKwkJICoKKwkJICogVGhpcyBpcyB0byBwcmV2ZW50IGEgcmFjZSB3aGVyZSBxdWV1aW5n IGEgbmV3IGZsaXAKKwkJICogZnJvbSB1c2Vyc3BhY2UgaW1tZWRpYXRlbHkgb24gcmVjZWlwdCBv ZiBhbiBldmVudAorCQkgKiBiZWF0cyBvdXIgY2xlYW4tdXAgYW5kIHJldHVybnMgRUJVU1kuCisJ CSAqLworCQlzcGluX2xvY2tfaXJxc2F2ZSgmZGV2LT5ldmVudF9sb2NrLCBmbGFncyk7CisJCWZv cl9lYWNoX2NydGNfaW5fc3RhdGUoc3RhdGUsIGNydGMsIGNydGNfc3RhdGUsIGkpCisJCQlidXN5 IHw9IHZjNF9ldmVudF9wZW5kaW5nKGNydGMpOworCQlzcGluX3VubG9ja19pcnFyZXN0b3JlKCZk ZXYtPmV2ZW50X2xvY2ssIGZsYWdzKTsKKwkJaWYgKGJ1c3kpIHsKIAkJCWtmcmVlKGMpOwogCQkJ cmV0dXJuIC1FQlVTWTsKIAkJfQotCX0gZWxzZSB7Ci0JCXJldCA9IGRvd25faW50ZXJydXB0aWJs ZSgmdmM0LT5hc3luY19tb2Rlc2V0KTsKLQkJaWYgKHJldCkgewotCQkJa2ZyZWUoYyk7Ci0JCQly ZXR1cm4gcmV0OwotCQl9CisJfQorCXJldCA9IGRvd25faW50ZXJydXB0aWJsZSgmdmM0LT5hc3lu Y19tb2Rlc2V0KTsKKwlpZiAocmV0KSB7CisJCWtmcmVlKGMpOworCQlyZXR1cm4gcmV0OwogCX0K IAogCXJldCA9IGRybV9hdG9taWNfaGVscGVyX3ByZXBhcmVfcGxhbmVzKGRldiwgc3RhdGUpOwot LSAKMi4xMC4yCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f XwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcK aHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK