From: Jarkko Sakkinen Subject: Re: [PATCH v2 3/3] tpm_crb: request and relinquish locality 0 Date: Tue, 6 Dec 2016 20:40:07 +0200 Message-ID: <20161206184007.vffsjwix5zdqlngl@intel.com> References: <20161203175213.10210-1-jarkko.sakkinen@linux.intel.com> <20161203175213.10210-4-jarkko.sakkinen@linux.intel.com> <20161205163235.GA24852@obsidianresearch.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <20161205163235.GA24852-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: tpmdd-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org To: Jason Gunthorpe Cc: "moderated list:TPM DEVICE DRIVER" , open list List-Id: tpmdd-devel@lists.sourceforge.net On Mon, Dec 05, 2016 at 09:32:35AM -0700, Jason Gunthorpe wrote: > On Sat, Dec 03, 2016 at 07:52:13PM +0200, Jarkko Sakkinen wrote: > > + iowrite32(CRB_LOC_CTRL_RELINQUISH, &priv->regs_h->loc_ctrl); > > Since regs_h can be null shouldn't there be some guards ? Yes, there should. Thanks for pointing this out! /Jarkko ------------------------------------------------------------------------------ Developer Access Program for Intel Xeon Phi Processors Access to Intel Xeon Phi processor-based developer platforms. With one year of Intel Parallel Studio XE. Training and support from Colfax. Order your platform today.http://sdm.link/xeonphi