From: Daniel Vetter Subject: Re: [PATCH 1/2] drm/i915: Remove crtc->config usage from intel_modeset_readout_hw_state() Date: Tue, 27 Dec 2016 15:56:54 +0100 Message-ID: <20161227145654.GF31952@dvetter-linux.ger.corp.intel.com> References: <20161222140442.7204-1-ville.syrjala@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wj0-x242.google.com (mail-wj0-x242.google.com [IPv6:2a00:1450:400c:c01::242]) by gabe.freedesktop.org (Postfix) with ESMTPS id A1D848991D for ; Tue, 27 Dec 2016 14:56:59 +0000 (UTC) Received: by mail-wj0-x242.google.com with SMTP id j10so51794516wjb.3 for ; Tue, 27 Dec 2016 06:56:59 -0800 (PST) Content-Disposition: inline In-Reply-To: <20161222140442.7204-1-ville.syrjala@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: ville.syrjala@linux.intel.com Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gVGh1LCBEZWMgMjIsIDIwMTYgYXQgMDQ6MDQ6NDFQTSArMDIwMCwgdmlsbGUuc3lyamFsYUBs aW51eC5pbnRlbC5jb20gd3JvdGU6Cj4gRnJvbTogVmlsbGUgU3lyasOkbMOkIDx2aWxsZS5zeXJq YWxhQGxpbnV4LmludGVsLmNvbT4KPiAKPiBjcnRjLT5jb25maWcgaXMgb24gaXRzIHdheSBvdXQu IExldCdzIHJlZHVjZSBvdXIgZGVwZW5kZW5jZSBvbiBpdCBhCj4gbGl0dGxlIGJpdCBieSByZW1v dmluZyBpdCBmcm9tIGludGVsX21vZGVzZXRfcmVhZG91dF9od19zdGF0ZSgpLgo+IAo+IEFsc28g cmVwbGFjZSBjcnRjLT5hY3R0aXZlIGNoZWNrcyB3aXRoIGNydGNfc3RhdGUtPmJhc2UuYWN0aXZl IGNoZWNrcy4KPiAKPiBDYzogTWFhcnRlbiBMYW5raG9yc3QgPG1hYXJ0ZW4ubGFua2hvcnN0QGxp bnV4LmludGVsLmNvbT4KPiBTdWdnZXN0ZWQtYnk6IE1hYXJ0ZW4gTGFua2hvcnN0IDxtYWFydGVu Lmxhbmtob3JzdEBsaW51eC5pbnRlbC5jb20+Cj4gU2lnbmVkLW9mZi1ieTogVmlsbGUgU3lyasOk bMOkIDx2aWxsZS5zeXJqYWxhQGxpbnV4LmludGVsLmNvbT4KClJldmlld2VkLWJ5OiBEYW5pZWwg VmV0dGVyIDxkYW5pZWwudmV0dGVyQGZmd2xsLmNoPgoKSWRsaW5nIG11c2luZzogSSB3b25kZXIg d2hldGhlciB3ZSBzaG91bGQgY29udmVydCB0aGUgcmVhZG91dCBjb2RlIHRvIHVzZQphbiBlbnRp cmVseSBmcmVlLXN0YW5kaW5nIGF0b21pYyBzdGF0aWMgdHJhY2tlZCBpbiBkcm1fYXRvbWljX2Nv bW1pdC4gQW5kCnRoZW4gYXBwbHkgaXQgd2l0aCBhIGRpcmVjdGx5IGNhbGwgdG8gc3dhcF9zdGF0 ZS4gVGhhdCB3YXkgd2UgY291bGQgcmV1c2UKYWxsIHRoZSBuZWF0IGl0ZXJhdG9ycy4KCk5vdCBz dXJlIHRoYXQncyBhIGdvb2QgaWRlYSB0aG91Z2guCi1EYW5pZWwKCj4gLS0tCj4gIGRyaXZlcnMv Z3B1L2RybS9pOTE1L2ludGVsX2Rpc3BsYXkuYyB8IDM4ICsrKysrKysrKysrKysrKysrKysrKysr LS0tLS0tLS0tLS0tLQo+ICAxIGZpbGUgY2hhbmdlZCwgMjQgaW5zZXJ0aW9ucygrKSwgMTQgZGVs ZXRpb25zKC0pCj4gCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rp c3BsYXkuYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rpc3BsYXkuYwo+IGluZGV4IGQ4 ZWZmZDRkYTAzNC4uMDkxYzE5MmM2YzVjIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9p OTE1L2ludGVsX2Rpc3BsYXkuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rp c3BsYXkuYwo+IEBAIC0xNzAzMiw3ICsxNzAzMiw4IEBAIHN0YXRpYyB2b2lkIGludGVsX21vZGVz ZXRfcmVhZG91dF9od19zdGF0ZShzdHJ1Y3QgZHJtX2RldmljZSAqZGV2KQo+ICAJZGV2X3ByaXYt PmFjdGl2ZV9jcnRjcyA9IDA7Cj4gIAo+ICAJZm9yX2VhY2hfaW50ZWxfY3J0YyhkZXYsIGNydGMp IHsKPiAtCQlzdHJ1Y3QgaW50ZWxfY3J0Y19zdGF0ZSAqY3J0Y19zdGF0ZSA9IGNydGMtPmNvbmZp ZzsKPiArCQlzdHJ1Y3QgaW50ZWxfY3J0Y19zdGF0ZSAqY3J0Y19zdGF0ZSA9Cj4gKwkJCXRvX2lu dGVsX2NydGNfc3RhdGUoY3J0Yy0+YmFzZS5zdGF0ZSk7Cj4gIAo+ICAJCV9fZHJtX2F0b21pY19o ZWxwZXJfY3J0Y19kZXN0cm95X3N0YXRlKCZjcnRjX3N0YXRlLT5iYXNlKTsKPiAgCQltZW1zZXQo Y3J0Y19zdGF0ZSwgMCwgc2l6ZW9mKCpjcnRjX3N0YXRlKSk7Cj4gQEAgLTE3MDUxLDcgKzE3MDUy LDcgQEAgc3RhdGljIHZvaWQgaW50ZWxfbW9kZXNldF9yZWFkb3V0X2h3X3N0YXRlKHN0cnVjdCBk cm1fZGV2aWNlICpkZXYpCj4gIAo+ICAJCURSTV9ERUJVR19LTVMoIltDUlRDOiVkOiVzXSBodyBz dGF0ZSByZWFkb3V0OiAlc1xuIiwKPiAgCQkJICAgICAgY3J0Yy0+YmFzZS5iYXNlLmlkLCBjcnRj LT5iYXNlLm5hbWUsCj4gLQkJCSAgICAgIGVuYWJsZWRkaXNhYmxlZChjcnRjLT5hY3RpdmUpKTsK PiArCQkJICAgICAgZW5hYmxlZGRpc2FibGVkKGNydGNfc3RhdGUtPmJhc2UuYWN0aXZlKSk7Cj4g IAl9Cj4gIAo+ICAJZm9yIChpID0gMDsgaSA8IGRldl9wcml2LT5udW1fc2hhcmVkX2RwbGw7IGkr Kykgewo+IEBAIC0xNzA2MSw3ICsxNzA2MiwxMSBAQCBzdGF0aWMgdm9pZCBpbnRlbF9tb2Rlc2V0 X3JlYWRvdXRfaHdfc3RhdGUoc3RydWN0IGRybV9kZXZpY2UgKmRldikKPiAgCQkJCQkJICAmcGxs LT5jb25maWcuaHdfc3RhdGUpOwo+ICAJCXBsbC0+Y29uZmlnLmNydGNfbWFzayA9IDA7Cj4gIAkJ Zm9yX2VhY2hfaW50ZWxfY3J0YyhkZXYsIGNydGMpIHsKPiAtCQkJaWYgKGNydGMtPmFjdGl2ZSAm JiBjcnRjLT5jb25maWctPnNoYXJlZF9kcGxsID09IHBsbCkKPiArCQkJc3RydWN0IGludGVsX2Ny dGNfc3RhdGUgKmNydGNfc3RhdGUgPQo+ICsJCQkJdG9faW50ZWxfY3J0Y19zdGF0ZShjcnRjLT5i YXNlLnN0YXRlKTsKPiArCj4gKwkJCWlmIChjcnRjX3N0YXRlLT5iYXNlLmFjdGl2ZSAmJgo+ICsJ CQkgICAgY3J0Y19zdGF0ZS0+c2hhcmVkX2RwbGwgPT0gcGxsKQo+ICAJCQkJcGxsLT5jb25maWcu Y3J0Y19tYXNrIHw9IDEgPDwgY3J0Yy0+cGlwZTsKPiAgCQl9Cj4gIAkJcGxsLT5hY3RpdmVfbWFz ayA9IHBsbC0+Y29uZmlnLmNydGNfbWFzazsKPiBAQCAtMTcwNzQsMTEgKzE3MDc5LDE0IEBAIHN0 YXRpYyB2b2lkIGludGVsX21vZGVzZXRfcmVhZG91dF9od19zdGF0ZShzdHJ1Y3QgZHJtX2Rldmlj ZSAqZGV2KQo+ICAJCXBpcGUgPSAwOwo+ICAKPiAgCQlpZiAoZW5jb2Rlci0+Z2V0X2h3X3N0YXRl KGVuY29kZXIsICZwaXBlKSkgewo+ICsJCQlzdHJ1Y3QgaW50ZWxfY3J0Y19zdGF0ZSAqY3J0Y19z dGF0ZTsKPiArCj4gIAkJCWNydGMgPSBpbnRlbF9nZXRfY3J0Y19mb3JfcGlwZShkZXZfcHJpdiwg cGlwZSk7Cj4gKwkJCWNydGNfc3RhdGUgPSB0b19pbnRlbF9jcnRjX3N0YXRlKGNydGMtPmJhc2Uu c3RhdGUpOwo+ICAKPiAgCQkJZW5jb2Rlci0+YmFzZS5jcnRjID0gJmNydGMtPmJhc2U7Cj4gLQkJ CWNydGMtPmNvbmZpZy0+b3V0cHV0X3R5cGVzIHw9IDEgPDwgZW5jb2Rlci0+dHlwZTsKPiAtCQkJ ZW5jb2Rlci0+Z2V0X2NvbmZpZyhlbmNvZGVyLCBjcnRjLT5jb25maWcpOwo+ICsJCQljcnRjX3N0 YXRlLT5vdXRwdXRfdHlwZXMgfD0gMSA8PCBlbmNvZGVyLT50eXBlOwo+ICsJCQllbmNvZGVyLT5n ZXRfY29uZmlnKGVuY29kZXIsIGNydGNfc3RhdGUpOwo+ICAJCX0gZWxzZSB7Cj4gIAkJCWVuY29k ZXItPmJhc2UuY3J0YyA9IE5VTEw7Cj4gIAkJfQo+IEBAIC0xNzExOSwxNCArMTcxMjcsMTYgQEAg c3RhdGljIHZvaWQgaW50ZWxfbW9kZXNldF9yZWFkb3V0X2h3X3N0YXRlKHN0cnVjdCBkcm1fZGV2 aWNlICpkZXYpCj4gIAl9Cj4gIAo+ICAJZm9yX2VhY2hfaW50ZWxfY3J0YyhkZXYsIGNydGMpIHsK PiArCQlzdHJ1Y3QgaW50ZWxfY3J0Y19zdGF0ZSAqY3J0Y19zdGF0ZSA9Cj4gKwkJCXRvX2ludGVs X2NydGNfc3RhdGUoY3J0Yy0+YmFzZS5zdGF0ZSk7Cj4gIAkJaW50IHBpeGNsayA9IDA7Cj4gIAo+ IC0JCWNydGMtPmJhc2UuaHdtb2RlID0gY3J0Yy0+Y29uZmlnLT5iYXNlLmFkanVzdGVkX21vZGU7 Cj4gKwkJY3J0Yy0+YmFzZS5od21vZGUgPSBjcnRjX3N0YXRlLT5iYXNlLmFkanVzdGVkX21vZGU7 Cj4gIAo+ICAJCW1lbXNldCgmY3J0Yy0+YmFzZS5tb2RlLCAwLCBzaXplb2YoY3J0Yy0+YmFzZS5t b2RlKSk7Cj4gLQkJaWYgKGNydGMtPmJhc2Uuc3RhdGUtPmFjdGl2ZSkgewo+IC0JCQlpbnRlbF9t b2RlX2Zyb21fcGlwZV9jb25maWcoJmNydGMtPmJhc2UubW9kZSwgY3J0Yy0+Y29uZmlnKTsKPiAt CQkJaW50ZWxfbW9kZV9mcm9tX3BpcGVfY29uZmlnKCZjcnRjLT5iYXNlLnN0YXRlLT5hZGp1c3Rl ZF9tb2RlLCBjcnRjLT5jb25maWcpOwo+ICsJCWlmIChjcnRjX3N0YXRlLT5iYXNlLmFjdGl2ZSkg ewo+ICsJCQlpbnRlbF9tb2RlX2Zyb21fcGlwZV9jb25maWcoJmNydGMtPmJhc2UubW9kZSwgY3J0 Y19zdGF0ZSk7Cj4gKwkJCWludGVsX21vZGVfZnJvbV9waXBlX2NvbmZpZygmY3J0Y19zdGF0ZS0+ YmFzZS5hZGp1c3RlZF9tb2RlLCBjcnRjX3N0YXRlKTsKPiAgCQkJV0FSTl9PTihkcm1fYXRvbWlj X3NldF9tb2RlX2Zvcl9jcnRjKGNydGMtPmJhc2Uuc3RhdGUsICZjcnRjLT5iYXNlLm1vZGUpKTsK PiAgCj4gIAkJCS8qCj4gQEAgLTE3MTQ2LDE3ICsxNzE1NiwxNyBAQCBzdGF0aWMgdm9pZCBpbnRl bF9tb2Rlc2V0X3JlYWRvdXRfaHdfc3RhdGUoc3RydWN0IGRybV9kZXZpY2UgKmRldikKPiAgCQkJ ICogbW9kZSBjaGFuZ2UsIHdoaWNoIG1lYW5zIGl0J3Mgc2FmZSB0byBkbyBhIGZ1bGwKPiAgCQkJ ICogcmVjYWxjdWxhdGlvbi4KPiAgCQkJICovCj4gLQkJCWNydGMtPmJhc2Uuc3RhdGUtPm1vZGUu cHJpdmF0ZV9mbGFncyA9IEk5MTVfTU9ERV9GTEFHX0lOSEVSSVRFRDsKPiArCQkJY3J0Y19zdGF0 ZS0+YmFzZS5tb2RlLnByaXZhdGVfZmxhZ3MgPSBJOTE1X01PREVfRkxBR19JTkhFUklURUQ7Cj4g IAo+ICAJCQlpZiAoSU5URUxfR0VOKGRldl9wcml2KSA+PSA5IHx8IElTX0JST0FEV0VMTChkZXZf cHJpdikpCj4gLQkJCQlwaXhjbGsgPSBpbGtfcGlwZV9waXhlbF9yYXRlKGNydGMtPmNvbmZpZyk7 Cj4gKwkJCQlwaXhjbGsgPSBpbGtfcGlwZV9waXhlbF9yYXRlKGNydGNfc3RhdGUpOwo+ICAJCQll bHNlIGlmIChJU19WQUxMRVlWSUVXKGRldl9wcml2KSB8fCBJU19DSEVSUllWSUVXKGRldl9wcml2 KSkKPiAtCQkJCXBpeGNsayA9IGNydGMtPmNvbmZpZy0+YmFzZS5hZGp1c3RlZF9tb2RlLmNydGNf Y2xvY2s7Cj4gKwkJCQlwaXhjbGsgPSBjcnRjX3N0YXRlLT5iYXNlLmFkanVzdGVkX21vZGUuY3J0 Y19jbG9jazsKPiAgCQkJZWxzZQo+ICAJCQkJV0FSTl9PTihkZXZfcHJpdi0+ZGlzcGxheS5tb2Rl c2V0X2NhbGNfY2RjbGspOwo+ICAKPiAgCQkJLyogcGl4ZWwgcmF0ZSBtdXN0bid0IGV4Y2VlZCA5 NSUgb2YgY2RjbGsgd2l0aCBJUFMgb24gQkRXICovCj4gLQkJCWlmIChJU19CUk9BRFdFTEwoZGV2 X3ByaXYpICYmIGNydGMtPmNvbmZpZy0+aXBzX2VuYWJsZWQpCj4gKwkJCWlmIChJU19CUk9BRFdF TEwoZGV2X3ByaXYpICYmIGNydGNfc3RhdGUtPmlwc19lbmFibGVkKQo+ICAJCQkJcGl4Y2xrID0g RElWX1JPVU5EX1VQKHBpeGNsayAqIDEwMCwgOTUpOwo+ICAKPiAgCQkJZHJtX2NhbGNfdGltZXN0 YW1waW5nX2NvbnN0YW50cygmY3J0Yy0+YmFzZSwgJmNydGMtPmJhc2UuaHdtb2RlKTsKPiBAQCAt MTcxNjUsNyArMTcxNzUsNyBAQCBzdGF0aWMgdm9pZCBpbnRlbF9tb2Rlc2V0X3JlYWRvdXRfaHdf c3RhdGUoc3RydWN0IGRybV9kZXZpY2UgKmRldikKPiAgCj4gIAkJZGV2X3ByaXYtPm1pbl9waXhj bGtbY3J0Yy0+cGlwZV0gPSBwaXhjbGs7Cj4gIAo+IC0JCWludGVsX3BpcGVfY29uZmlnX3Nhbml0 eV9jaGVjayhkZXZfcHJpdiwgY3J0Yy0+Y29uZmlnKTsKPiArCQlpbnRlbF9waXBlX2NvbmZpZ19z YW5pdHlfY2hlY2soZGV2X3ByaXYsIGNydGNfc3RhdGUpOwo+ICAJfQo+ICB9Cj4gIAo+IC0tIAo+ IDIuMTAuMgo+IAo+IF9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fCj4gSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdAo+IEludGVsLWdmeEBsaXN0cy5mcmVlZGVza3Rv cC5vcmcKPiBodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2lu dGVsLWdmeAoKLS0gCkRhbmllbCBWZXR0ZXIKU29mdHdhcmUgRW5naW5lZXIsIEludGVsIENvcnBv cmF0aW9uCmh0dHA6Ly9ibG9nLmZmd2xsLmNoCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3Rz LmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xp c3RpbmZvL2ludGVsLWdmeAo=