From: Daniel Vetter Subject: Re: [PATCH v3] drm/i915: Check HAS_PCH_NOP when install or reset dispaly IRQ Date: Tue, 27 Dec 2016 16:04:00 +0100 Message-ID: <20161227150400.GH31952@dvetter-linux.ger.corp.intel.com> References: <20161215125833.GA31595@intel.com> <87zijxnt7b.fsf@intel.com> <955C0369EB5C9C4BACD49E5B6D8EA39011E0DA78@SHSMSX103.ccr.corp.intel.com> <955C0369EB5C9C4BACD49E5B6D8EA39011E1E6EC@SHSMSX103.ccr.corp.intel.com> <87k2asmlld.fsf@intel.com> <955C0369EB5C9C4BACD49E5B6D8EA39011E1E761@SHSMSX103.ccr.corp.intel.com> <87h95wmjle.fsf@intel.com> <20161222111816.ic3bcd4dqxja2n33@boom> <20161227144141.GC31952@dvetter-linux.ger.corp.intel.com> <87eg0t4egf.fsf@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wj0-x242.google.com (mail-wj0-x242.google.com [IPv6:2a00:1450:400c:c01::242]) by gabe.freedesktop.org (Postfix) with ESMTPS id A580389AF3 for ; Tue, 27 Dec 2016 15:04:05 +0000 (UTC) Received: by mail-wj0-x242.google.com with SMTP id j10so51813812wjb.3 for ; Tue, 27 Dec 2016 07:04:05 -0800 (PST) Content-Disposition: inline In-Reply-To: <87eg0t4egf.fsf@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Jani Nikula Cc: "Wang, Elaine" , "intel-gfx@lists.freedesktop.org" List-Id: intel-gfx@lists.freedesktop.org T24gVHVlLCBEZWMgMjcsIDIwMTYgYXQgMDQ6NDY6NDBQTSArMDIwMCwgSmFuaSBOaWt1bGEgd3Jv dGU6Cj4gT24gVHVlLCAyNyBEZWMgMjAxNiwgRGFuaWVsIFZldHRlciA8ZGFuaWVsQGZmd2xsLmNo PiB3cm90ZToKPiA+IE9uIFRodSwgRGVjIDIyLCAyMDE2IGF0IDAxOjE4OjE2UE0gKzAyMDAsIERh dmlkIFdlaW5laGFsbCB3cm90ZToKPiA+PiBPbiBUaHUsIERlYyAyMiwgMjAxNiBhdCAxMDo1Mjoy OUFNICswMjAwLCBKYW5pIE5pa3VsYSB3cm90ZToKPiA+PiA+IE9uIFRodSwgMjIgRGVjIDIwMTYs ICJXYW5nLCBFbGFpbmUiIDxlbGFpbmUud2FuZ0BpbnRlbC5jb20+IHdyb3RlOgo+ID4+ID4gPj4g Cj4gPj4gPiA+PiBPbiBUaHUsIDIyIERlYyAyMDE2LCAiV2FuZywgRWxhaW5lIiA8ZWxhaW5lLndh bmdAaW50ZWwuY29tPiB3cm90ZToKPiA+PiA+ID4+ID4gSGkgSmFuaSwgVmlsbGUsCj4gPj4gPiA+ PiA+Cj4gPj4gPiA+PiA+IEFueSBjb21tZW50IGFib3V0IHRoZSAiUENIX05PUCIgdnMgIm51bV9w aXBlcyA9PSAwIj8KPiA+PiA+ID4+ID4KPiA+PiA+ID4+ID4gVGhhbmtzLAo+ID4+ID4gPj4gPiBF bGFpbmUKPiA+PiA+ID4+ID4+IE9uIFRodSwgMTUgRGVjIDIwMTYsIFZpbGxlIFN5cmrDpGzDpCA8 dmlsbGUuc3lyamFsYUBsaW51eC5pbnRlbC5jb20+IHdyb3RlOgo+ID4+ID4gPj4gPj4gPiBPbiBN b24sIERlYyAxMiwgMjAxNiBhdCAwMjo1Nzo0NFBNICswODAwLCBXYW5nIEVsYWluZSB3cm90ZToK PiA+PiA+ID4+ID4+ID4+IEZyb206IEVsYWluZSBXYW5nIDxlbGFpbmUud2FuZ0BpbnRlbC5jb20+ Cj4gPj4gPiA+PiA+PiA+Pgo+ID4+ID4gPj4gPj4gPj4gU29tZSBwbGF0Zm9ybXMgZG9uJ3QgaGF2 ZSBkaXNwbGF5LiBUbyBhdm9pZCBhY2Nlc3NpbmcgdGhlCj4gPj4gPiA+PiA+PiA+PiBub24tZXhp c3RlbnQgcmVnaXN0ZXJzLCBjaGVjayBIQVNfUENIX05PUCBiZWZvcmUgaW52b2tpbmcgZGlzcGxh eQo+ID4+ID4gPj4gPj4gPj4gSVJRIGluc3RhbGwgb3IgcmVzZXQgZnVuY3Rpb24uCj4gPj4gPiA+ PiA+PiA+Pgo+ID4+ID4gPj4gPj4gPj4gQ2M6IENocmlzIFdpbHNvbiA8Y2hyaXNAY2hyaXMtd2ls c29uLmNvLnVrPgo+ID4+ID4gPj4gPj4gPj4gQ2M6IEpvb25hcyBMYWh0aW5lbiA8am9vbmFzLmxh aHRpbmVuQGxpbnV4LmludGVsLmNvbT4KPiA+PiA+ID4+ID4+ID4+IFNpZ25lZC1vZmYtYnk6IEVs YWluZSBXYW5nIDxlbGFpbmUud2FuZ0BpbnRlbC5jb20+Cj4gPj4gPiA+PiA+PiA+PiAtLS0KPiA+ PiA+ID4+ID4+ID4+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2lycS5jIHwgMTAgKysrKysr Ky0tLQo+ID4+ID4gPj4gPj4gPj4gIDEgZmlsZSBjaGFuZ2VkLCA3IGluc2VydGlvbnMoKyksIDMg ZGVsZXRpb25zKC0pCj4gPj4gPiA+PiA+PiA+Pgo+ID4+ID4gPj4gPj4gPj4gZGlmZiAtLWdpdCBh L2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfaXJxLmMKPiA+PiA+ID4+ID4+ID4+IGIvZHJpdmVy cy9ncHUvZHJtL2k5MTUvaTkxNV9pcnEuYyBpbmRleCAwYjExOWI5Li4zNjlhMDM4IDEwMDY0NAo+ ID4+ID4gPj4gPj4gPj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9pcnEuYwo+ID4+ ID4gPj4gPj4gPj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9pcnEuYwo+ID4+ID4g Pj4gPj4gPj4gQEAgLTI5OTAsOCArMjk5MCwxMCBAQCBzdGF0aWMgdm9pZCBnZW44X2lycV9yZXNl dChzdHJ1Y3QKPiA+PiA+ID4+ID4+ID4+IGRybV9kZXZpY2UKPiA+PiA+ID4+ID4+ICpkZXYpCj4g Pj4gPiA+PiA+PiA+Pgo+ID4+ID4gPj4gPj4gUE9XRVJfRE9NQUlOX1BJUEUocGlwZSkpKQo+ID4+ ID4gPj4gPj4gPj4gIAkJCUdFTjhfSVJRX1JFU0VUX05EWChERV9QSVBFLCBwaXBlKTsKPiA+PiA+ ID4+ID4+ID4+Cj4gPj4gPiA+PiA+PiA+PiAtCUdFTjVfSVJRX1JFU0VUKEdFTjhfREVfUE9SVF8p Owo+ID4+ID4gPj4gPj4gPj4gLQlHRU41X0lSUV9SRVNFVChHRU44X0RFX01JU0NfKTsKPiA+PiA+ ID4+ID4+ID4+ICsJaWYgKCFIQVNfUENIX05PUChkZXZfcHJpdikpIHsKPiA+PiA+ID4+ID4+ID4+ ICsJCUdFTjVfSVJRX1JFU0VUKEdFTjhfREVfUE9SVF8pOwo+ID4+ID4gPj4gPj4gPj4gKwkJR0VO NV9JUlFfUkVTRVQoR0VOOF9ERV9NSVNDXyk7Cj4gPj4gPiA+PiA+PiA+PiArCX0KPiA+PiA+ID4+ ID4+ID4KPiA+PiA+ID4+ID4+ID4gSG1tLiBUaGVzZSBhcmUgbm9ydGggc2lkZSByZWdpc3RlcnMg c28gbG9va2luZyBhdCBQQ0hfTk9QIGZlZWxzCj4gPj4gPiA+PiA+PiA+IHF1ZXN0aW9uYWJsZS4K PiA+PiA+ID4+ID4+Cj4gPj4gPiA+PiA+PiBJbmRlZWQsIG51bV9waXBlcyA9PSAwIGlzbid0IGV4 YWN0bHkgdGhlIHNhbWUgdGhpbmcgYXMgSEFTX1BDSF9OT1AuCj4gPj4gPiA+PiA+Pgo+ID4+ID4g Pj4gPj4gSmFuaS4KPiA+PiA+ID4+ID4KPiA+PiA+ID4+ID4gSSB0aG91Z2h0IEhBU19QQ0hfTk9Q IGhhZCBzYW1lIG1lYW5pbmcgYXMgbnVtX3BpcGVzID09IDAgYmVjYXVzZSBJCj4gPj4gPiA+PiBz YXcKPiA+PiA+ID4+ID4gZm9sbG93aW5nIGNvZGUgaW4gaTkxNV9kcnYuYy4gSXMgdGhlcmUgYW55 IGV4Y2VwdGlvbj8KPiA+PiA+ID4+ID4KPiA+PiA+ID4+ID4gaHR0cHM6Ly9jZ2l0LmZyZWVkZXNr dG9wLm9yZy9kcm0taW50ZWwvdHJlZS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1Xwo+ID4+ID4g Pj4gPiBkcnYuYz9oPWRybS1pbnRlbC1uaWdodGx5I24xNDUgc3RhdGljIHZvaWQgaW50ZWxfZGV0 ZWN0X3BjaChzdHJ1Y3QKPiA+PiA+ID4+ID4gZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYpIHsK PiA+PiA+ID4+ID4gCXN0cnVjdCBwY2lfZGV2ICpwY2ggPSBOVUxMOwo+ID4+ID4gPj4gPgo+ID4+ ID4gPj4gPiAJLyogSW4gYWxsIGN1cnJlbnQgY2FzZXMsIG51bV9waXBlcyBpcyBlcXVpdmFsZW50 IHRvIHRoZSBQQ0hfTk9QCj4gPj4gPiA+PiBzZXR0aW5nCj4gPj4gPiA+PiA+IAkgKiAod2hpY2gg cmVhbGx5IGFtb3VudHMgdG8gYSBQQ0ggYnV0IG5vIFNvdXRoIERpc3BsYXkpLgo+ID4+ID4gPj4g PiAJICovCj4gPj4gPiA+PiAKPiA+PiA+ID4+IFRoZSBrZXkgaXMgaW4gdGhpcyBjb21tZW50OyAi SW4gYWxsIGN1cnJlbnQgY2FzZXMiLCB3aGVyZSAiY3VycmVudCIgaXMgM8K9IHllYXJzCj4gPj4g PiA+PiBhZ28uIElJUkMgdGhpcyB3YXMgd3JpdHRlbiBmb3Igc29tZSBYZW9ucyB3aGljaCBkaWQg aGF2ZSBhIFBDSCBidXQgbm8KPiA+PiA+ID4+IGRpc3BsYXkuIFBDSF9OT1AgaXMgYSBraW5kIG9m IGhhY2sgZm9yIHRob3NlLiBOb3dhZGF5cyB5b3UgZG9uJ3QgYWx3YXlzCj4gPj4gPiA+PiBoYXZl IGEgUENIIG9uIGdlbiA1KyAoVkxWLCBDSFYsIEJYVCwgLi4uKS4gWW91IG1pZ2h0IGhhdmUgYSBQ Q0ggYnV0IG9ubHkKPiA+PiA+ID4+IG5lZWQgdGhlIE5vcnRoIERpc3BsYXkgZm9yIHNvbWUgb3V0 cHV0cy4gQW5kIEkgZ3Vlc3MgeW91IG1pZ2h0IHN0aWxsIGhhdmUgYQo+ID4+ID4gPj4gUENIIGJ1 dCBubyBkaXNwbGF5IGF0IGFsbC4KPiA+PiA+ID4+IAo+ID4+ID4gPj4gSSdtIGp1c3Qgc2F5aW5n LCB3ZSBzaG91bGQgbm90IG92ZXJsb2FkIHRoaXMgaGFjayB0bywgc2F5LCBjb3ZlciBwbGF0Zm9y bXMgdGhhdAo+ID4+ID4gPj4gZG9uJ3QgZXZlbiBoYXZlIGEgUENILCBvciBwbGF0Zm9ybXMgdGhh dCBoYXZlIGEgUENIIGJ1dCBhIGZ1bmN0aW9uaW5nIE5vcnRoCj4gPj4gPiA+PiBEaXNwbGF5Lgo+ ID4+ID4gPj4gCj4gPj4gPiA+PiBCUiwKPiA+PiA+ID4+IEphbmkuCj4gPj4gPiA+PiAKPiA+PiA+ ID4gSSB1bmRlcnN0YW5kIHlvdXIgcG9pbnQgbm93LiBUaGFuayB5b3UgZm9yIGV4cGxhaW5pbmcg dGhpcy4gSSdsbCB1cGRhdGUgdGhlIHBhdGNoIGFuZAo+ID4+ID4gPiBVc2UgbnVtX3BpcGVzIGZv ciBjaGVja2luZyB3aGV0aGVyIGRpc3BsYXkgZW5naW5lIGV4aXN0cy4KPiA+PiA+IAo+ID4+ID4g VmlsbGUsIGhvdyBhYm91dCBhZGRpbmcgc29tZXRoaW5nIGxpa2U6Cj4gPj4gPiAKPiA+PiA+ICNk ZWZpbmUgSEFTX0RJU1BMQVkoZGV2X3ByaXYpIChJTlRFTF9JTkZPKGRldl9wcml2KS0+bnVtX3Bp cGVzID09IDApCj4gPj4gPiAKPiA+PiA+IGFuZCBwb3NzaWJseQo+ID4+ID4gCj4gPj4gPiAjZGVm aW5lIEhBU19TT1VUSF9ESVNQTEFZKGRldl9wcml2KSBIQVNfUENIX05PUChkZXZfcHJpdikKPiA+ PiA+IAo+ID4+ID4gU28gd2UgY291bGQgY2xhcmlmeSB0aGUgY29kZSwgYW5kIGFic3RyYWN0IHRo ZSBydWxlcywgc28gaXQnbGwgcGVyaGFwcwo+ID4+ID4gYmUgZWFzaWVyIHRvIGNoYW5nZSB0aGVt IGxhdGVyPwo+ID4+ID4gCj4gPj4gPiBUaG91Z2ggSSBmZWFyIHdlIG1heSBlbmQgdXAgbmVlZGlu ZyB0byBhZGQgYSBmaW5lciBncmFudWxhcml0eSBkZXBlbmRpbmcKPiA+PiA+IG9uIHdoaWNoIHBh cnRzIHdlIGRvIG5lZWQgdG8gYW5kIG11c3Qgbm90IHRvdWNoLCBhbmQgdGhhdCBtaWdodCBub3QK PiA+PiA+IGFsd2F5cyBtYXAgdG8gbG93IGdyYW51bGFyaXR5IG5vcnRoL3NvdXRoIGRpc3BsYXku ICpzaHJ1ZyoKPiA+PiAKPiA+PiBFdmVuIGlmIHdlIG1pZ2h0IGVuZCB1cCBtYWtpbmcgdGhpbmdz IG1vcmUgZ3JhbnVsYXIgbGF0ZXIgb24sCj4gPj4gSSdtIGEgYmlnIGZhbiBvZiBzZWxmLWRvY3Vt ZW50aW5nIGNvZGUuIEhBU19ESVNQTEFZKCkgY2xlYXJseQo+ID4+IGV4cGxhaW5zIHdoYXQgd2Un cmUgdGVzdGluZyBmb3IsIGFzIGRvZXMgSEFTX1NPVVRIX0RJU1BMQVkoKS4KPiA+Cj4gPiArMSBv biBIQVNfRElTUExBWS4KPiA+Cj4gPiBSZSBQQ0hfTk9QIHZzLiBQQ0hfTk9ORToKPiA+IC0gUENI X05PTkUgaXMgZm9yIHBsYXRmb3JtcyB3aGVyZSB0aGVyZSdzIHJlYWxseSBubyBQQ0ggYW55d2hl cmUuCj4gPiAtIFBDSF9OT1AgaXMgZm9yIHBsYXRmb3JtcyB0aGF0IGluIGdlbmVyYWwgaGF2ZSBp dCwgYnV0IGRvbid0IHRvdWNoIGl0Cj4gPiAgIGl0J3Mga2luZGEgZGlzYWJsZWQuIFRoaXMgaXMg c29tZXdoYXQgcmVsZXZhbnQgdG8gbWFrZSBzdXJlIGFsbCB0aGUKPiA+ICAgSEFTX1BDSF9TUExJ VCBjaGVja3MgKG9mIHdoaWNoIG5vdCBhbGwgYXJlIGV4Y2x1c2l2ZWx5IGluIGRpc3BsYXktb25s eQo+ID4gICBjb2RlKSBzdGlsbCB3b3JrIGNvcnJlY3RseSBmb3IgdGhvc2UgcGxhdGZvcm1zLgo+ ID4KPiA+IEdpdmVuIHRoYXQgSSdtIG5vdCBlbnRpcmVseSBzdXJlIHdoYXQgeW91J3JlIGFpbWlu ZyBmb3Igd2l0aAo+ID4gSEFTX1NPVVRIX0RJU1BMQVkgLi4uCj4gCj4gUG90ZW50aWFsbHkgYSBt b3JlIHNlbnNpYmxlIHNvdW5kaW5nIGNoZWNrIHRoYW4gSEFTX1BDSF9OT1AuCgpIbSwgaXNuJ3Qg dGhhdCBjb3ZlcmVkIHdpdGggSEFTX1BDSF9TUExJVCBhbHJlYWR5PwotRGFuaWVsCi0tIApEYW5p ZWwgVmV0dGVyClNvZnR3YXJlIEVuZ2luZWVyLCBJbnRlbCBDb3Jwb3JhdGlvbgpodHRwOi8vYmxv Zy5mZndsbC5jaApfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f XwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcK aHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK