From: Arkadiusz Hiler Subject: Re: [PATCH 4/5] drm/i915/guc: Extract param logic form guc_init Date: Tue, 27 Dec 2016 17:26:36 +0100 Message-ID: <20161227162636.GD27822@ahiler-desk.igk.intel.com> References: <20161215154708.31521-1-arkadiusz.hiler@intel.com> <20161215154708.31521-5-arkadiusz.hiler@intel.com> <223ad7eb-0150-a411-ec78-9701ddcd23d5@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by gabe.freedesktop.org (Postfix) with ESMTPS id 2089F890BA for ; Tue, 27 Dec 2016 16:26:41 +0000 (UTC) Content-Disposition: inline In-Reply-To: <223ad7eb-0150-a411-ec78-9701ddcd23d5@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Daniele Ceraolo Spurio Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gRnJpLCBEZWMgMjMsIDIwMTYgYXQgMDE6MTk6MThQTSAtMDgwMCwgRGFuaWVsZSBDZXJhb2xv IFNwdXJpbyB3cm90ZToKPiAKPiAKPiBPbiAxNS8xMi8xNiAwNzo0NywgQXJrYWRpdXN6IEhpbGVy IHdyb3RlOgo+ID4gTGV0IGludGVsX2d1Y19pbml0KCkgZm9jdXMgb24gZGV0ZXJtaW5pbmcgYW5k IGZldGNoaW5nIHRoZSBjb3JyZWN0Cj4gPiBmaXJtd2FyZS4KPiA+IAo+ID4gVGhpcyBwYXRjaCBp bnRyb2R1Y2VzIGludGVsX3Nhbml0aXplX3VjX3BhcmFtcygpIHRoYXQgaXMgY2FsbGVkIGZyb20K PiA+IGludGVsX3VjX2luaXQoKS4KPiA+IAo+ID4gVGhlbiwgaWYgd2UgaGF2ZSBHdUMsIHdlIGNh biBjYWxsIGludGVsX2d1Y19pbml0KCkgY29uZGl0aW9uYWxseSBhbmQgd2UKPiA+IGRvIG5vdCBo YXZlIHRvIGRvIGludGVybmFsIGNoZWNrcy4KPiA+IAo+ID4gSXQgY2FuIGJlIGVhc2lseSBleHRl bmRlZCB0byBzdXBwb3J0IEh1QyBjYXNlIGFzIHdlbGwuCj4gPiAKPiA+IENjOiBBbnVzaGEgU3Jp dmF0c2EgPGFudXNoYS5zcml2YXRzYUBpbnRlbC5jb20+Cj4gPiBDYzogSmVmZiBNY0dlZSA8amVm Zi5tY2dlZUBpbnRlbC5jb20+Cj4gPiBDYzogTWljaGFsIFdpbmlhcnNraSA8bWljaGFsLndpbmlh cnNraUBpbnRlbC5jb20+Cj4gPiBTaWduZWQtb2ZmLWJ5OiBBcmthZGl1c3ogSGlsZXIgPGFya2Fk aXVzei5oaWxlckBpbnRlbC5jb20+Cj4gPiAtLS0KPiA+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9p bnRlbF9ndWNfbG9hZGVyLmMgfCAxOSArLS0tLS0tLS0tLS0tLS0tLS0tCj4gPiAgZHJpdmVycy9n cHUvZHJtL2k5MTUvaW50ZWxfdWMuYyAgICAgICAgIHwgMjMgKysrKysrKysrKysrKysrKysrKysr Ky0KPiA+ICAyIGZpbGVzIGNoYW5nZWQsIDIzIGluc2VydGlvbnMoKyksIDE5IGRlbGV0aW9ucygt KQo+ID4gCj4gPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZ3VjX2xv YWRlci5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZ3VjX2xvYWRlci5jCj4gPiBpbmRl eCBiNzZiNTU2Li4wYmI1ZmQxIDEwMDY0NAo+ID4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUv aW50ZWxfZ3VjX2xvYWRlci5jCj4gPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9n dWNfbG9hZGVyLmMKPiA+IEBAIC02MTcsNyArNjE3LDcgQEAgc3RhdGljIHZvaWQgZ3VjX2Z3X2Zl dGNoKHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiwKPiA+ICB9Cj4gPiAKPiA+ICAv KioKPiA+IC0gKiBpbnRlbF9ndWNfaW5pdCgpIC0gZGVmaW5lIHBhcmFtZXRlcnMgYW5kIGZldGNo IGZpcm13YXJlCj4gPiArICogaW50ZWxfZ3VjX2luaXQoKSAtIGRldGVybWluZSBhbmQgZmV0Y2gg ZmlybXdhcmUKPiA+ICAgKiBAZGV2X3ByaXY6CWk5MTUgZGV2aWNlIHByaXZhdGUKPiA+ICAgKgo+ ID4gICAqIENhbGxlZCBlYXJseSBkdXJpbmcgZHJpdmVyIGxvYWQsIGJ1dCBhZnRlciBHRU0gaXMg aW5pdGlhbGlzZWQuCj4gPiBAQCAtNjMwLDE3ICs2MzAsNiBAQCB2b2lkIGludGVsX2d1Y19pbml0 KHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdikKPiA+ICAJc3RydWN0IGludGVsX2d1 Y19mdyAqZ3VjX2Z3ID0gJmRldl9wcml2LT5ndWMuZ3VjX2Z3Owo+ID4gIAljb25zdCBjaGFyICpm d19wYXRoOwo+ID4gCj4gPiAtCWlmICghSEFTX0dVQyhkZXZfcHJpdikpIHsKPiA+IC0JCWk5MTUu ZW5hYmxlX2d1Y19sb2FkaW5nID0gMDsKPiA+IC0JCWk5MTUuZW5hYmxlX2d1Y19zdWJtaXNzaW9u ID0gMDsKPiA+IC0JfSBlbHNlIHsKPiA+IC0JCS8qIEEgbmVnYXRpdmUgdmFsdWUgbWVhbnMgInVz ZSBwbGF0Zm9ybSBkZWZhdWx0IiAqLwo+ID4gLQkJaWYgKGk5MTUuZW5hYmxlX2d1Y19sb2FkaW5n IDwgMCkKPiA+IC0JCQlpOTE1LmVuYWJsZV9ndWNfbG9hZGluZyA9IEhBU19HVUNfVUNPREUoZGV2 X3ByaXYpOwo+ID4gLQkJaWYgKGk5MTUuZW5hYmxlX2d1Y19zdWJtaXNzaW9uIDwgMCkKPiA+IC0J CQlpOTE1LmVuYWJsZV9ndWNfc3VibWlzc2lvbiA9IEhBU19HVUNfU0NIRUQoZGV2X3ByaXYpOwo+ ID4gLQl9Cj4gPiAtCj4gPiAgCWlmICghSEFTX0dVQ19VQ09ERShkZXZfcHJpdikpIHsKPiA+ICAJ CWZ3X3BhdGggPSBOVUxMOwo+ID4gIAl9IGVsc2UgaWYgKElTX1NLWUxBS0UoZGV2X3ByaXYpKSB7 Cj4gPiBAQCAtNjYzLDEzICs2NTIsNyBAQCB2b2lkIGludGVsX2d1Y19pbml0KHN0cnVjdCBkcm1f aTkxNV9wcml2YXRlICpkZXZfcHJpdikKPiA+ICAJZ3VjX2Z3LT5ndWNfZndfZmV0Y2hfc3RhdHVz ID0gR1VDX0ZJUk1XQVJFX05PTkU7Cj4gPiAgCWd1Y19mdy0+Z3VjX2Z3X2xvYWRfc3RhdHVzID0g R1VDX0ZJUk1XQVJFX05PTkU7Cj4gPiAKPiA+IC0JLyogY2FuJ3QgZW5hYmxlIGd1YyBzdWJtaXNz aW9uIHdpdGhvdXQgZ3VjICovCj4gPiAtCWlmICghaTkxNS5lbmFibGVfZ3VjX2xvYWRpbmcpCj4g PiAtCQlpOTE1LmVuYWJsZV9ndWNfc3VibWlzc2lvbiA9IDA7Cj4gPiAtCj4gPiAgCS8qIEVhcmx5 IChhbmQgc2lsZW50KSByZXR1cm4gaWYgR3VDIGxvYWRpbmcgaXMgZGlzYWJsZWQgKi8KPiA+IC0J aWYgKCFpOTE1LmVuYWJsZV9ndWNfbG9hZGluZykKPiA+IC0JCXJldHVybjsKPiA+ICAJaWYgKGZ3 X3BhdGggPT0gTlVMTCkKPiA+ICAJCXJldHVybjsKPiA+ICAJaWYgKCpmd19wYXRoID09ICdcMCcp Cj4gPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfdWMuYyBiL2RyaXZl cnMvZ3B1L2RybS9pOTE1L2ludGVsX3VjLmMKPiA+IGluZGV4IDRlMTg0ZWRiLi5lNzJmNzg0IDEw MDY0NAo+ID4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfdWMuYwo+ID4gKysrIGIv ZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfdWMuYwo+ID4gQEAgLTI1LDYgKzI1LDI0IEBACj4g PiAgI2luY2x1ZGUgImk5MTVfZHJ2LmgiCj4gPiAgI2luY2x1ZGUgImludGVsX3VjLmgiCj4gPiAK PiA+ICtzdGF0aWMgdm9pZCBpbnRlbF9zYW5pdGl6ZV91Y19wYXJhbXMoc3RydWN0IGRybV9pOTE1 X3ByaXZhdGUgKmRldl9wcml2KQo+ID4gK3sKPiA+ICsJaWYgKCFIQVNfR1VDKGRldl9wcml2KSkg ewo+ID4gKwkJaTkxNS5lbmFibGVfZ3VjX2xvYWRpbmcgPSAwOwo+ID4gKwkJaTkxNS5lbmFibGVf Z3VjX3N1Ym1pc3Npb24gPSAwOwo+ID4gKwl9IGVsc2Ugewo+ID4gKwkJLyogQSBuZWdhdGl2ZSB2 YWx1ZSBtZWFucyAidXNlIHBsYXRmb3JtIGRlZmF1bHQiICovCj4gPiArCQlpZiAoaTkxNS5lbmFi bGVfZ3VjX2xvYWRpbmcgPCAwKQo+ID4gKwkJCWk5MTUuZW5hYmxlX2d1Y19sb2FkaW5nID0gSEFT X0dVQ19VQ09ERShkZXZfcHJpdik7Cj4gPiArCQlpZiAoaTkxNS5lbmFibGVfZ3VjX3N1Ym1pc3Np b24gPCAwKQo+ID4gKwkJCWk5MTUuZW5hYmxlX2d1Y19zdWJtaXNzaW9uID0gSEFTX0dVQ19TQ0hF RChkZXZfcHJpdik7Cj4gPiArCX0KPiA+ICsKPiA+ICsJLyogY2FuJ3QgZW5hYmxlIGd1YyBzdWJt aXNzaW9uIHdpdGhvdXQgZ3VjICovCj4gPiArCWlmICghaTkxNS5lbmFibGVfZ3VjX2xvYWRpbmcp Cj4gPiArCQlpOTE1LmVuYWJsZV9ndWNfc3VibWlzc2lvbiA9IDA7Cj4gPiArfQo+ID4gKwo+ID4g IHZvaWQgaW50ZWxfdWNfaW5pdF9lYXJseShzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3By aXYpCj4gPiAgewo+ID4gIAltdXRleF9pbml0KCZkZXZfcHJpdi0+Z3VjLnNlbmRfbXV0ZXgpOwo+ ID4gQEAgLTMyLDcgKzUwLDEwIEBAIHZvaWQgaW50ZWxfdWNfaW5pdF9lYXJseShzdHJ1Y3QgZHJt X2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYpCj4gPiAKPiA+ICB2b2lkIGludGVsX3VjX2luaXQoc3Ry dWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2KQo+ID4gIHsKPiA+IC0JaW50ZWxfZ3VjX2lu aXQoZGV2X3ByaXYpOwo+ID4gKwlpbnRlbF9zYW5pdGl6ZV91Y19wYXJhbXMoZGV2X3ByaXYpOwo+ IAo+IElmIHdlIHBsYWNlIGludGVsX3Nhbml0aXplX3VjX3BhcmFtcyBpbiBpbnRlbF9zYW5pdGl6 ZV9vcHRpb25zIHdlIGNhbiBoYXZlCj4gdGhlIHBhcmFtZXRlcnMgcmVzb2x2ZWQgZWFybGllciBh bmQgd2Ugc2hvdWxkIHRoZXJlZm9yZSBiZSBhYmxlIHRvIHVzZSB0aGVtCj4gdG8gYmV0dGVyIGhh bmRsZSBHdUMtcmVsYXRlZCBkaWZmZXJlbmNlcyBkdXJpbmcgZHJpdmVyIGxvYWQuCj4gCj4gRGFu aWVsZQoKQWdyZWUuIEkgaGF2ZW4ndCBub3RpY2VkIHRoZSBpbnRlbF9zYW5pdGl6ZV9vcHRpb25z KCkuCgo+IAo+ID4gKwo+ID4gKwlpZiAoaTkxNS5lbmFibGVfZ3VjX2xvYWRpbmcpCj4gPiArCQlp bnRlbF9ndWNfaW5pdChkZXZfcHJpdik7Cj4gPiAgfQo+ID4gCj4gPiAgaW50IGludGVsX3VjX2xv YWQoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2KQo+ID4gCgotLSAKQ2hlZXJzLApB cmVrCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkludGVs LWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczov L2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo=