From: Donny Yang Subject: [PATCH] drm/amdgpu: Use signed arithmetic for overdrive clock calculations Date: Fri, 13 Jan 2017 19:52:39 +1100 Message-ID: <20170113085239.24362-1-work@kota.moe> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: amd-gfx-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Sender: "amd-gfx" To: amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Cc: Donny Yang U2lnbmVkLW9mZi1ieTogRG9ubnkgWWFuZyA8d29ya0Brb3RhLm1vZT4KLS0tCiBkcml2ZXJzL2dw dS9kcm0vYW1kL3Bvd2VycGxheS9od21nci9zbXU3X2h3bWdyLmMgfCA3MCArKysrKysrLS0tLS0t LS0tLS0tLS0tLS0KIDEgZmlsZSBjaGFuZ2VkLCAyMSBpbnNlcnRpb25zKCspLCA0OSBkZWxldGlv bnMoLSkKCmRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vYW1kL3Bvd2VycGxheS9od21nci9z bXU3X2h3bWdyLmMgYi9kcml2ZXJzL2dwdS9kcm0vYW1kL3Bvd2VycGxheS9od21nci9zbXU3X2h3 bWdyLmMKaW5kZXggYTc0ZjYwYTUuLmY2YzAxZTE5IDEwMDY0NAotLS0gYS9kcml2ZXJzL2dwdS9k cm0vYW1kL3Bvd2VycGxheS9od21nci9zbXU3X2h3bWdyLmMKKysrIGIvZHJpdmVycy9ncHUvZHJt L2FtZC9wb3dlcnBsYXkvaHdtZ3Ivc211N19od21nci5jCkBAIC0zMzQ5LDcgKzMzNDksOCBAQCBz dGF0aWMgaW50IHNtdTdfcG9wdWxhdGVfYW5kX3VwbG9hZF9zY2xrX21jbGtfZHBtX2xldmVscygK IAlzdHJ1Y3Qgc211N19kcG1fdGFibGUgKmRwbV90YWJsZSA9ICZkYXRhLT5kcG1fdGFibGU7CiAK IAlzdHJ1Y3Qgc211N19kcG1fdGFibGUgKmdvbGRlbl9kcG1fdGFibGUgPSAmZGF0YS0+Z29sZGVu X2RwbV90YWJsZTsKLQl1aW50MzJfdCBkcG1fY291bnQsIGNsb2NrX3BlcmNlbnQ7CisJdWludDMy X3QgZHBtX2NvdW50OworCWludDMyX3QgY2xvY2tfcGVyY2VudDsKIAl1aW50MzJfdCBpOwogCiAJ aWYgKDAgPT0gZGF0YS0+bmVlZF91cGRhdGVfc211N19kcG1fdGFibGUpCkBAIC0zMzcxLDMyICsz MzcyLDE2IEBAIHN0YXRpYyBpbnQgc211N19wb3B1bGF0ZV9hbmRfdXBsb2FkX3NjbGtfbWNsa19k cG1fbGV2ZWxzKAogCQkJCXJldHVybiAtRUlOVkFMKTsKIAkJCWRwbV9jb3VudCA9IGRwbV90YWJs ZS0+c2Nsa190YWJsZS5jb3VudCA8IDIgPyAwIDogZHBtX3RhYmxlLT5zY2xrX3RhYmxlLmNvdW50 IC0gMjsKIAorCQkJY2xvY2tfcGVyY2VudCA9CisJCQkJKChzY2xrCisJCQkJLSBnb2xkZW5fZHBt X3RhYmxlLT5zY2xrX3RhYmxlLmRwbV9sZXZlbHNbZ29sZGVuX2RwbV90YWJsZS0+c2Nsa190YWJs ZS5jb3VudC0xXS52YWx1ZQorCQkJCSkgKiAxMDApCisJCQkJLyBnb2xkZW5fZHBtX3RhYmxlLT5z Y2xrX3RhYmxlLmRwbV9sZXZlbHNbZ29sZGVuX2RwbV90YWJsZS0+c2Nsa190YWJsZS5jb3VudC0x XS52YWx1ZTsKIAkJCWZvciAoaSA9IGRwbV9jb3VudDsgaSA+IDE7IGktLSkgewotCQkJCWlmIChz Y2xrID4gZ29sZGVuX2RwbV90YWJsZS0+c2Nsa190YWJsZS5kcG1fbGV2ZWxzW2dvbGRlbl9kcG1f dGFibGUtPnNjbGtfdGFibGUuY291bnQtMV0udmFsdWUpIHsKLQkJCQkJY2xvY2tfcGVyY2VudCA9 Ci0JCQkJCSAgICAgICgoc2NsawotCQkJCQkJLSBnb2xkZW5fZHBtX3RhYmxlLT5zY2xrX3RhYmxl LmRwbV9sZXZlbHNbZ29sZGVuX2RwbV90YWJsZS0+c2Nsa190YWJsZS5jb3VudC0xXS52YWx1ZQot CQkJCQkJKSAqIDEwMCkKLQkJCQkJCS8gZ29sZGVuX2RwbV90YWJsZS0+c2Nsa190YWJsZS5kcG1f bGV2ZWxzW2dvbGRlbl9kcG1fdGFibGUtPnNjbGtfdGFibGUuY291bnQtMV0udmFsdWU7Ci0KLQkJ CQkJZHBtX3RhYmxlLT5zY2xrX3RhYmxlLmRwbV9sZXZlbHNbaV0udmFsdWUgPQotCQkJCQkJCWdv bGRlbl9kcG1fdGFibGUtPnNjbGtfdGFibGUuZHBtX2xldmVsc1tpXS52YWx1ZSArCi0JCQkJCQkJ KGdvbGRlbl9kcG1fdGFibGUtPnNjbGtfdGFibGUuZHBtX2xldmVsc1tpXS52YWx1ZSAqCi0JCQkJ CQkJCWNsb2NrX3BlcmNlbnQpLzEwMDsKLQotCQkJCX0gZWxzZSBpZiAoZ29sZGVuX2RwbV90YWJs ZS0+c2Nsa190YWJsZS5kcG1fbGV2ZWxzW2RwbV90YWJsZS0+c2Nsa190YWJsZS5jb3VudC0xXS52 YWx1ZSA+IHNjbGspIHsKLQkJCQkJY2xvY2tfcGVyY2VudCA9Ci0JCQkJCQkoKGdvbGRlbl9kcG1f dGFibGUtPnNjbGtfdGFibGUuZHBtX2xldmVsc1tnb2xkZW5fZHBtX3RhYmxlLT5zY2xrX3RhYmxl LmNvdW50IC0gMV0udmFsdWUKLQkJCQkJCS0gc2NsaykgKiAxMDApCi0JCQkJCQkvIGdvbGRlbl9k cG1fdGFibGUtPnNjbGtfdGFibGUuZHBtX2xldmVsc1tnb2xkZW5fZHBtX3RhYmxlLT5zY2xrX3Rh YmxlLmNvdW50LTFdLnZhbHVlOwotCi0JCQkJCWRwbV90YWJsZS0+c2Nsa190YWJsZS5kcG1fbGV2 ZWxzW2ldLnZhbHVlID0KLQkJCQkJCQlnb2xkZW5fZHBtX3RhYmxlLT5zY2xrX3RhYmxlLmRwbV9s ZXZlbHNbaV0udmFsdWUgLQotCQkJCQkJCShnb2xkZW5fZHBtX3RhYmxlLT5zY2xrX3RhYmxlLmRw bV9sZXZlbHNbaV0udmFsdWUgKgotCQkJCQkJCQkJY2xvY2tfcGVyY2VudCkgLyAxMDA7Ci0JCQkJ fSBlbHNlCi0JCQkJCWRwbV90YWJsZS0+c2Nsa190YWJsZS5kcG1fbGV2ZWxzW2ldLnZhbHVlID0K LQkJCQkJCQlnb2xkZW5fZHBtX3RhYmxlLT5zY2xrX3RhYmxlLmRwbV9sZXZlbHNbaV0udmFsdWU7 CisJCQkJZHBtX3RhYmxlLT5zY2xrX3RhYmxlLmRwbV9sZXZlbHNbaV0udmFsdWUgPQorCQkJCQkJ Z29sZGVuX2RwbV90YWJsZS0+c2Nsa190YWJsZS5kcG1fbGV2ZWxzW2ldLnZhbHVlICsKKwkJCQkJ CShnb2xkZW5fZHBtX3RhYmxlLT5zY2xrX3RhYmxlLmRwbV9sZXZlbHNbaV0udmFsdWUgKgorCQkJ CQkJCQljbG9ja19wZXJjZW50KSAvIDEwMDsKIAkJCX0KIAkJfQogCX0KQEAgLTM0MTQsMzAgKzMz OTksMTcgQEAgc3RhdGljIGludCBzbXU3X3BvcHVsYXRlX2FuZF91cGxvYWRfc2Nsa19tY2xrX2Rw bV9sZXZlbHMoCiAJCQkJCSJEaXZpZGUgYnkgMCEiLAogCQkJCQlyZXR1cm4gLUVJTlZBTCk7CiAJ CQlkcG1fY291bnQgPSBkcG1fdGFibGUtPm1jbGtfdGFibGUuY291bnQgPCAyID8gMCA6IGRwbV90 YWJsZS0+bWNsa190YWJsZS5jb3VudCAtIDI7CisKKwkJCWNsb2NrX3BlcmNlbnQgPQorCQkJCSgo bWNsaworCQkJCS0gZ29sZGVuX2RwbV90YWJsZS0+bWNsa190YWJsZS5kcG1fbGV2ZWxzW2dvbGRl bl9kcG1fdGFibGUtPm1jbGtfdGFibGUuY291bnQtMV0udmFsdWUKKwkJCQkpICogMTAwKQorCQkJ CS8gZ29sZGVuX2RwbV90YWJsZS0+bWNsa190YWJsZS5kcG1fbGV2ZWxzW2dvbGRlbl9kcG1fdGFi bGUtPm1jbGtfdGFibGUuY291bnQtMV0udmFsdWU7CiAJCQlmb3IgKGkgPSBkcG1fY291bnQ7IGkg PiAxOyBpLS0pIHsKLQkJCQlpZiAoZ29sZGVuX2RwbV90YWJsZS0+bWNsa190YWJsZS5kcG1fbGV2 ZWxzW2dvbGRlbl9kcG1fdGFibGUtPm1jbGtfdGFibGUuY291bnQtMV0udmFsdWUgPCBtY2xrKSB7 Ci0JCQkJCWNsb2NrX3BlcmNlbnQgPSAoKG1jbGsgLQotCQkJCQlnb2xkZW5fZHBtX3RhYmxlLT5t Y2xrX3RhYmxlLmRwbV9sZXZlbHNbZ29sZGVuX2RwbV90YWJsZS0+bWNsa190YWJsZS5jb3VudC0x XS52YWx1ZSkgKiAxMDApCi0JCQkJCS8gZ29sZGVuX2RwbV90YWJsZS0+bWNsa190YWJsZS5kcG1f bGV2ZWxzW2dvbGRlbl9kcG1fdGFibGUtPm1jbGtfdGFibGUuY291bnQtMV0udmFsdWU7Ci0KLQkJ CQkJZHBtX3RhYmxlLT5tY2xrX3RhYmxlLmRwbV9sZXZlbHNbaV0udmFsdWUgPQotCQkJCQkJCWdv bGRlbl9kcG1fdGFibGUtPm1jbGtfdGFibGUuZHBtX2xldmVsc1tpXS52YWx1ZSArCi0JCQkJCQkJ KGdvbGRlbl9kcG1fdGFibGUtPm1jbGtfdGFibGUuZHBtX2xldmVsc1tpXS52YWx1ZSAqCi0JCQkJ CQkJY2xvY2tfcGVyY2VudCkgLyAxMDA7Ci0KLQkJCQl9IGVsc2UgaWYgKGdvbGRlbl9kcG1fdGFi bGUtPm1jbGtfdGFibGUuZHBtX2xldmVsc1tkcG1fdGFibGUtPm1jbGtfdGFibGUuY291bnQtMV0u dmFsdWUgPiBtY2xrKSB7Ci0JCQkJCWNsb2NrX3BlcmNlbnQgPSAoCi0JCQkJCSAoZ29sZGVuX2Rw bV90YWJsZS0+bWNsa190YWJsZS5kcG1fbGV2ZWxzW2dvbGRlbl9kcG1fdGFibGUtPm1jbGtfdGFi bGUuY291bnQtMV0udmFsdWUgLSBtY2xrKQotCQkJCQkqIDEwMCkKLQkJCQkJLyBnb2xkZW5fZHBt X3RhYmxlLT5tY2xrX3RhYmxlLmRwbV9sZXZlbHNbZ29sZGVuX2RwbV90YWJsZS0+bWNsa190YWJs ZS5jb3VudC0xXS52YWx1ZTsKLQotCQkJCQlkcG1fdGFibGUtPm1jbGtfdGFibGUuZHBtX2xldmVs c1tpXS52YWx1ZSA9Ci0JCQkJCQkJZ29sZGVuX2RwbV90YWJsZS0+bWNsa190YWJsZS5kcG1fbGV2 ZWxzW2ldLnZhbHVlIC0KLQkJCQkJCQkoZ29sZGVuX2RwbV90YWJsZS0+bWNsa190YWJsZS5kcG1f bGV2ZWxzW2ldLnZhbHVlICoKLQkJCQkJCQkJCWNsb2NrX3BlcmNlbnQpIC8gMTAwOwotCQkJCX0g ZWxzZQotCQkJCQlkcG1fdGFibGUtPm1jbGtfdGFibGUuZHBtX2xldmVsc1tpXS52YWx1ZSA9Ci0J CQkJCQkJZ29sZGVuX2RwbV90YWJsZS0+bWNsa190YWJsZS5kcG1fbGV2ZWxzW2ldLnZhbHVlOwor CQkJCWRwbV90YWJsZS0+bWNsa190YWJsZS5kcG1fbGV2ZWxzW2ldLnZhbHVlID0KKwkJCQkJCWdv bGRlbl9kcG1fdGFibGUtPm1jbGtfdGFibGUuZHBtX2xldmVsc1tpXS52YWx1ZSArCisJCQkJCQko Z29sZGVuX2RwbV90YWJsZS0+bWNsa190YWJsZS5kcG1fbGV2ZWxzW2ldLnZhbHVlICoKKwkJCQkJ CWNsb2NrX3BlcmNlbnQpIC8gMTAwOwogCQkJfQogCQl9CiAJfQotLSAKMi4xMS4wCgpfX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwphbWQtZ2Z4IG1haWxpbmcg bGlzdAphbWQtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNr dG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2FtZC1nZngK