Return-Path: Received: from mail-out.m-online.net (mail-out.m-online.net [212.18.0.9]) by mail.openembedded.org (Postfix) with ESMTP id 84E2171DF7 for ; Fri, 20 Jan 2017 00:15:21 +0000 (UTC) Received: from mail.nefkom.net (unknown [192.168.6.184]) by mail-out.m-online.net (Postfix) with ESMTP id 3v4Lnj3YJyz3hjXD; Fri, 20 Jan 2017 01:15:21 +0100 (CET) X-Auth-Info: 2tRO5MtCE+uUcRn0lxtzkB8P8n5NgO86g9YFguH3JeA= Received: from kurokawa.lan (unknown [195.140.253.167]) by smtp-auth.mnet-online.de (Postfix) with ESMTPA id 3v4Lnj2PBCzvdWS; Fri, 20 Jan 2017 01:15:21 +0100 (CET) From: Marek Vasut To: openembedded-devel@lists.openembedded.org Date: Fri, 20 Jan 2017 01:15:16 +0100 Message-Id: <20170120001516.1625-1-marex@denx.de> X-Mailer: git-send-email 2.11.0 Cc: Marek Vasut Subject: [PATCH V2] picocom: Fix build X-BeenThere: openembedded-devel@lists.openembedded.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: Using the OpenEmbedded metadata to build Distributions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 20 Jan 2017 00:15:22 -0000 The picocom complains about missing GNU_HASH from the binary during QA stage, this is because the picocom Makefile overrides CPPFLAGS, CFLAGS and LDFLAGS. Fix this by passing those as an argument to make. Moreover, since picocom 1.7 now accepts VERSION variable and the UUCP_LOCK_DIR is set to /var/lock by default, drop the CPPFLAGS override altogether and replace it simply with passing VERSION argument to make to precisely retain the original intention. Signed-off-by: Marek Vasut --- V2: Use EXTRA_OEMAKE instead of custom do_configure --- meta-oe/recipes-support/picocom/picocom_1.7.bb | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/meta-oe/recipes-support/picocom/picocom_1.7.bb b/meta-oe/recipes-support/picocom/picocom_1.7.bb index dbee65609..ca0b8f419 100644 --- a/meta-oe/recipes-support/picocom/picocom_1.7.bb +++ b/meta-oe/recipes-support/picocom/picocom_1.7.bb @@ -9,7 +9,8 @@ SRC_URI = "http://picocom.googlecode.com/files/picocom-${PV}.tar.gz" SRC_URI[md5sum] = "8eaba1d31407e8408674d6e57af447ef" SRC_URI[sha256sum] = "d0f31c8f7a215a76922d30c81a52b9a2348c89e02a84935517002b3bc2c1129e" -CPPFLAGS_append = '-DVERSION_STR=\\"${PV}\\" -DUUCP_LOCK_DIR=\\"/var/lock\\" -DHIGH_BAUD' +EXTRA_OEMAKE_append = "'CC=${CC}' 'LD=${LD}' 'VERSION=${PV}' \ + 'CFLAGS=${CFLAGS}' 'LDFLAGS=${LDFLAGS}'" do_install () { install -d ${D}${bindir} -- 2.11.0