From: Tom Rini Date: Sat, 28 Jan 2017 15:02:49 -0500 Subject: [U-Boot] [PATCH 3/3] env: Add support for FS environment In-Reply-To: <1485334393-179182-4-git-send-email-fiach.antaw@uqconnect.edu.au> References: <1485334393-179182-1-git-send-email-fiach.antaw@uqconnect.edu.au> <1485334393-179182-4-git-send-email-fiach.antaw@uqconnect.edu.au> Message-ID: <20170128200249.GE22316@bill-the-cat> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Wed, Jan 25, 2017 at 06:53:13PM +1000, Fiach Antaw wrote: > This patch adds support for fat/ext4-style environments on top of > the FS api, allowing any filesystem to be used to store the u-boot > environment. This implementation also support redundancy in the > form of a secondary environment file on the same filesystem. > > Signed-off-by: Fiach Antaw > > --- > > README | 22 ++++++++ > cmd/nvedit.c | 1 + > common/Makefile | 1 + > common/env_fs.c | 126 +++++++++++++++++++++++++++++++++++++++++++ > include/environment.h | 16 ++++++ > scripts/config_whitelist.txt | 5 ++ > 6 files changed, 171 insertions(+) > create mode 100644 common/env_fs.c Functionally, I like this idea, it's a step in the right direction. My first question is, did you test this on some real hardware that's using environment stored in a filesystem, on another media not listed here (say SATA?) ? Second, it's really, really, not a good idea to add more Kconfig options to the whitelist. Can you please take a look at starting to move the env choices to Kconfig (I would assume ENV_IS_NOWHERE would be the easiest to move) ? Then we can add this there, thanks! -- Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 819 bytes Desc: Digital signature URL: