From: Dan Carpenter Date: Mon, 30 Jan 2017 15:03:52 +0300 Subject: [lustre-devel] [PATCH 13/60] staging: lustre: obdclass: health_check to report unhealthy upon LBUG In-Reply-To: <1485648328-2141-14-git-send-email-jsimmons@infradead.org> References: <1485648328-2141-1-git-send-email-jsimmons@infradead.org> <1485648328-2141-14-git-send-email-jsimmons@infradead.org> Message-ID: <20170130120352.GC6881@mwanda> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: James Simmons Cc: Greg Kroah-Hartman , devel@driverdev.osuosl.org, Andreas Dilger , Oleg Drokin , Bruno Faccini , Linux Kernel Mailing List , Lustre Development List Wat? I'm sorry but this patch makes no sense at all. On Sat, Jan 28, 2017 at 07:04:41PM -0500, James Simmons wrote: > From: Bruno Faccini > > When a LBUG has occurred, without panic_on_lbug being set, > health_check sysfs file must return an unhealthy state. Why? > > Signed-off-by: Bruno Faccini > Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-7486 > Reviewed-on: http://review.whamcloud.com/17981 > Reviewed-by: Bobi Jam > Reviewed-by: Niu Yawei > Reviewed-by: James Simmons > Reviewed-by: Oleg Drokin > Signed-off-by: James Simmons > --- > drivers/staging/lustre/lustre/obdclass/linux/linux-module.c | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/drivers/staging/lustre/lustre/obdclass/linux/linux-module.c b/drivers/staging/lustre/lustre/obdclass/linux/linux-module.c > index 22e6d1f..ef25db6 100644 > --- a/drivers/staging/lustre/lustre/obdclass/linux/linux-module.c > +++ b/drivers/staging/lustre/lustre/obdclass/linux/linux-module.c > @@ -224,8 +224,10 @@ static ssize_t pinger_show(struct kobject *kobj, struct attribute *attr, > int i; > size_t len = 0; > > - if (libcfs_catastrophe) > - return sprintf(buf, "LBUG\n"); > + if (libcfs_catastrophe) { > + len = sprintf(buf, "LBUG\n"); This line is dead code, now. > + healthy = false; > + } > regards, dan carpenter