From: Gustavo Padovan Subject: Re: [PATCH] drm/atomic: Fix double free in drm_atomic_state_default_clear Date: Tue, 31 Jan 2017 10:04:09 -0200 Message-ID: <20170131120409.GB11823@joana> References: <1485854725-27640-1-git-send-email-maarten.lankhorst@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <1485854725-27640-1-git-send-email-maarten.lankhorst@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Maarten Lankhorst Cc: daniel.vetter@ffwll.ch, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org SGkgTWFhcnRlbiwKCjIwMTctMDEtMzEgTWFhcnRlbiBMYW5raG9yc3QgPG1hYXJ0ZW4ubGFua2hv cnN0QGxpbnV4LmludGVsLmNvbT46Cgo+IGRybV9hdG9taWNfaGVscGVyX3BhZ2VfZmxpcCBhbmQg ZHJtX2F0b21pY19pb2N0bCBzZXQgdGhlaXIgb3duIGV2ZW50cwo+IGluIGNydGNfc3RhdGUtPmV2 ZW50LiBCdXQgd2hlbiBpdCdzIHNldCB0aGUgZXZlbnQgaXMgZnJlZWQgaW4gMiBwbGFjZXMuCj4g Cj4gU29sdmUgdGhpcyBieSBvbmx5IGZyZWVpbmcgdGhlIGV2ZW50IGluIHRoZSBhdG9taWMgaW9j dGwgd2hlbiBpdAo+IGFsbG9jYXRlZCBpdHMgb3duIGV2ZW50Lgo+IAo+IFRoaXMgaGFzIGJlZW4g YnJva2VuIHR3aWNlLiBUaGUgZmlyc3QgdGltZSB3aGVuIHRoZSBjb2RlIHdhcyBpbnRyb2R1Y2Vk LAo+IGJ1dCBvbmx5IGluIHRoZSBjb3JuZXIgY2FzZSB3aGVuIGFuIGV2ZW50IGlzIGFsbG9jYXRl ZCwgYnV0IG1vcmUgY3J0YydzCj4gd2VyZSBpbmNsdWRlZCBieSBhdG9taWMgY2hlY2sgYW5kIHRo ZW4gZmFpbGluZy4gVGhpcyBjYW4gbW9zdGx5Cj4gaGFwcGVuIHdoZW4geW91IGRvIGFuIGF0b21p YyBtb2Rlc2V0IGluIGk5MTUgYW5kIHRoZSBkaXNwbGF5IGNsb2NrIGlzCj4gY2hhbmdlZCwgd2hp Y2ggZm9yY2VzIGFsbCBjcnRjJ3MgdG8gYmUgaW5jbHVkZWQgdG8gdGhlIHN0YXRlLgo+IAo+IFRo aXMgaGFzIGJlZW4gYnJva2VuIHdvcnNlIGJ5IGFkZGluZyBpbi1mZW5jZXMgc3VwcG9ydCwgd2hp Y2ggY2F1c2VkCj4gdGhlIGRvdWJsZSBmcmVlIHRvIGJlIGRvbmUgdW5jb25kaXRpb25hbGx5Lgo+ IAo+IFtJR1RdIGttc19yb3RhdGlvbl9jcmM6IHN0YXJ0aW5nIHN1YnRlc3QgcHJpbWFyeS1yb3Rh dGlvbi0xODAKPiA9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQo+IEJVRyBrbWFsbG9jLTEyOCAoVGFpbnRl ZDogRyAgICAgVSAgICAgICAgICk6IE9iamVjdCBhbHJlYWR5IGZyZWUKPiAtLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLQo+IAo+IERpc2FibGluZyBsb2NrIGRlYnVnZ2luZyBkdWUgdG8ga2VybmVsIHRhaW50 Cj4gSU5GTzogQWxsb2NhdGVkIGluIGRybV9hdG9taWNfaGVscGVyX3NldHVwX2NvbW1pdCsweDI4 NS8weDJmMCBbZHJtX2ttc19oZWxwZXJdIGFnZT0wIGNwdT0zIHBpZD0xNTI5Cj4gIF9fX3NsYWJf YWxsb2MrMHgzMDgvMHgzYjAKPiAgX19zbGFiX2FsbG9jKzB4ZC8weDIwCj4gIGttZW1fY2FjaGVf YWxsb2NfdHJhY2UrMHg5Mi8weDFjMAo+ICBkcm1fYXRvbWljX2hlbHBlcl9zZXR1cF9jb21taXQr MHgyODUvMHgyZjAgW2RybV9rbXNfaGVscGVyXQo+ICBpbnRlbF9hdG9taWNfY29tbWl0KzB4MzUv MHg0ZjAgW2k5MTVdCj4gIGRybV9hdG9taWNfY29tbWl0KzB4NDYvMHg1MCBbZHJtXQo+ICBkcm1f bW9kZV9hdG9taWNfaW9jdGwrMHg3ZDQvMHhhYjAgW2RybV0KPiAgZHJtX2lvY3RsKzB4MmIzLzB4 NDkwIFtkcm1dCj4gIGRvX3Zmc19pb2N0bCsweDY5Yy8weDcwMAo+ICBTeVNfaW9jdGwrMHg0ZS8w eDgwCj4gIGVudHJ5X1NZU0NBTExfNjRfZmFzdHBhdGgrMHgxMy8weDk0Cj4gSU5GTzogRnJlZWQg aW4gZHJtX2V2ZW50X2NhbmNlbF9mcmVlKzB4YTMvMHhiMCBbZHJtXSBhZ2U9MCBjcHU9MyBwaWQ9 MTUyOQo+ICBfX3NsYWJfZnJlZSsweDQ4LzB4MmUwCj4gIGtmcmVlKzB4MTU5LzB4MWEwCj4gIGRy bV9ldmVudF9jYW5jZWxfZnJlZSsweGEzLzB4YjAgW2RybV0KPiAgZHJtX21vZGVfYXRvbWljX2lv Y3RsKzB4ODZkLzB4YWIwIFtkcm1dCj4gIGRybV9pb2N0bCsweDJiMy8weDQ5MCBbZHJtXQo+ICBk b192ZnNfaW9jdGwrMHg2OWMvMHg3MDAKPiAgU3lTX2lvY3RsKzB4NGUvMHg4MAo+ICBlbnRyeV9T WVNDQUxMXzY0X2Zhc3RwYXRoKzB4MTMvMHg5NAo+IElORk86IFNsYWIgMHhmZmZmZGUxZjA5OTdi MDgwIG9iamVjdHM9MTcgdXNlZD0yIGZwPTB4ZmZmZjkyZmI2NWVjMjU3OCBmbGFncz0weDIwMDAw MDAwMDAwODEwMQo+IElORk86IE9iamVjdCAweGZmZmY5MmZiNjVlYzI1NzggQG9mZnNldD0xNDAw IGZwPTB4ZmZmZjkyZmI2NWVjMmFlOAo+IAo+IFJlZHpvbmUgZmZmZjkyZmI2NWVjMjU3MDogYmIg YmIgYmIgYmIgYmIgYmIgYmIgYmIgICAgICAgICAgICAgICAgICAgICAgICAgIC4uLi4uLi4uCj4g T2JqZWN0IGZmZmY5MmZiNjVlYzI1Nzg6IDZiIDZiIDZiIDZiIDZiIDZiIDZiIDZiIDZiIDZiIDZi IDZiIDZiIDZiIDZiIDZiICBra2tra2tra2tra2tra2trCj4gT2JqZWN0IGZmZmY5MmZiNjVlYzI1 ODg6IDZiIDZiIDZiIDZiIDZiIDZiIDZiIDZiIDZiIDZiIDZiIDZiIDZiIDZiIDZiIDZiICBra2tr a2tra2tra2tra2trCj4gT2JqZWN0IGZmZmY5MmZiNjVlYzI1OTg6IDZiIDZiIDZiIDZiIDZiIDZi IDZiIDZiIDZiIDZiIDZiIDZiIDZiIDZiIDZiIDZiICBra2tra2tra2tra2tra2trCj4gT2JqZWN0 IGZmZmY5MmZiNjVlYzI1YTg6IDZiIDZiIDZiIDZiIDZiIDZiIDZiIDZiIDZiIDZiIDZiIDZiIDZi IDZiIDZiIDZiICBra2tra2tra2tra2tra2trCj4gT2JqZWN0IGZmZmY5MmZiNjVlYzI1Yjg6IDZi IDZiIDZiIDZiIDZiIDZiIDZiIDZiIDZiIDZiIDZiIDZiIDZiIDZiIDZiIDZiICBra2tra2tra2tr a2tra2trCj4gT2JqZWN0IGZmZmY5MmZiNjVlYzI1Yzg6IDZiIDZiIDZiIDZiIDZiIDZiIDZiIDZi IDZiIDZiIDZiIDZiIDZiIDZiIDZiIDZiICBra2tra2tra2tra2tra2trCj4gT2JqZWN0IGZmZmY5 MmZiNjVlYzI1ZDg6IDZiIDZiIDZiIDZiIDZiIDZiIDZiIDZiIDZiIDZiIDZiIDZiIDZiIDZiIDZi IDZiICBra2tra2tra2tra2tra2trCj4gT2JqZWN0IGZmZmY5MmZiNjVlYzI1ZTg6IDZiIDZiIDZi IDZiIDZiIDZiIDZiIDZiIDZiIDZiIDZiIDZiIDZiIDZiIDZiIGE1ICBra2tra2tra2tra2tra2su Cj4gUmVkem9uZSBmZmZmOTJmYjY1ZWMyNWY4OiBiYiBiYiBiYiBiYiBiYiBiYiBiYiBiYiAgICAg ICAgICAgICAgICAgICAgICAgICAgLi4uLi4uLi4KPiBQYWRkaW5nIGZmZmY5MmZiNjVlYzI3Mzg6 IDVhIDVhIDVhIDVhIDVhIDVhIDVhIDVhICAgICAgICAgICAgICAgICAgICAgICAgICBaWlpaWlpa Wgo+IENQVTogMyBQSUQ6IDE4MCBDb21tOiBrd29ya2VyLzM6MiBUYWludGVkOiBHICAgIEJVICAg ICAgICAgIDQuMTAuMC1yYzYtcGF0c2VyKyAjNTAzOQo+IEhhcmR3YXJlIG5hbWU6ICAgICAgICAg ICAgICAgICAgL05VQzVQUFlCLCBCSU9TIFBZQlNXQ0VMLjg2QS4wMDMxLjIwMTUuMDYwMS4xNzEy IDA2LzAxLzIwMTUKPiBXb3JrcXVldWU6IGV2ZW50cyBpbnRlbF9hdG9taWNfaGVscGVyX2ZyZWVf c3RhdGUgW2k5MTVdCj4gQ2FsbCBUcmFjZToKPiAgZHVtcF9zdGFjaysweDRkLzB4NmQKPiAgcHJp bnRfdHJhaWxlcisweDIwYy8weDIyMAo+ICBmcmVlX2RlYnVnX3Byb2Nlc3NpbmcrMHgxYzYvMHgz MzAKPiAgPyBkcm1fYXRvbWljX3N0YXRlX2RlZmF1bHRfY2xlYXIrMHhmNy8weDFjMCBbZHJtXQo+ ICBfX3NsYWJfZnJlZSsweDQ4LzB4MmUwCj4gID8gZHJtX2F0b21pY19zdGF0ZV9kZWZhdWx0X2Ns ZWFyKzB4ZjcvMHgxYzAgW2RybV0KPiAga2ZyZWUrMHgxNTkvMHgxYTAKPiAgZHJtX2F0b21pY19z dGF0ZV9kZWZhdWx0X2NsZWFyKzB4ZjcvMHgxYzAgW2RybV0KPiAgPyBkcm1fYXRvbWljX3N0YXRl X2NsZWFyKzB4MzAvMHgzMCBbZHJtXQo+ICBpbnRlbF9hdG9taWNfc3RhdGVfY2xlYXIrMHhkLzB4 MjAgW2k5MTVdCj4gIGRybV9hdG9taWNfc3RhdGVfY2xlYXIrMHgxYS8weDMwIFtkcm1dCj4gIF9f ZHJtX2F0b21pY19zdGF0ZV9mcmVlKzB4MTMvMHg2MCBbZHJtXQo+ICBpbnRlbF9hdG9taWNfaGVs cGVyX2ZyZWVfc3RhdGUrMHg1ZC8weDcwIFtpOTE1XQo+ICBwcm9jZXNzX29uZV93b3JrKzB4MjYw LzB4NGEwCj4gIHdvcmtlcl90aHJlYWQrMHgyZDEvMHg0ZjAKPiAga3RocmVhZCsweDEyNy8weDEz MAo+ICA/IHByb2Nlc3Nfb25lX3dvcmsrMHg0YTAvMHg0YTAKPiAgPyBrdGhyZWFkX3N0b3ArMHgx MjAvMHgxMjAKPiAgcmV0X2Zyb21fZm9yaysweDI5LzB4NDAKPiBGSVgga21hbGxvYy0xMjg6IE9i amVjdCBhdCAweGZmZmY5MmZiNjVlYzI1Nzggbm90IGZyZWVkCj4gCj4gRml4ZXM6IDNiMjRmN2Q2 NzU4MSAoImRybS9hdG9taWM6IEFkZCBzdHJ1Y3QgZHJtX2NydGNfY29tbWl0IHRvIHRyYWNrIGFz eW5jIHVwZGF0ZXMiKQo+IEZpeGVzOiA5NjI2MDE0MjU4YTUgKCJkcm0vZmVuY2U6IGFkZCBpbi1m ZW5jZXMgc3VwcG9ydCIpCj4gQ2M6IDxzdGFibGVAdmdlci5rZXJuZWwub3JnPiAjIHY0LjgrCj4g Q2M6IERhbmllbCBWZXR0ZXIgPGRhbmllbC52ZXR0ZXJAZmZ3bGwuY2g+Cj4gU2lnbmVkLW9mZi1i eTogTWFhcnRlbiBMYW5raG9yc3QgPG1hYXJ0ZW4ubGFua2hvcnN0QGxpbnV4LmludGVsLmNvbT4K PiBSZXZpZXdlZC1ieTogRGFuaWVsIFZldHRlciA8ZGFuaWVsLnZldHRlckBmZndsbC5jaD4KPiAt LS0KPiAgZHJpdmVycy9ncHUvZHJtL2RybV9hdG9taWMuYyB8IDEzICsrKysrKysrLS0tLS0KPiAg MSBmaWxlIGNoYW5nZWQsIDggaW5zZXJ0aW9ucygrKSwgNSBkZWxldGlvbnMoLSkKPiAKPiBkaWZm IC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2RybV9hdG9taWMuYyBiL2RyaXZlcnMvZ3B1L2RybS9k cm1fYXRvbWljLmMKPiBpbmRleCA1MGY1Y2Y3YjY5ZDEuLmZkZmIxZWMxN2U2NiAxMDA2NDQKPiAt LS0gYS9kcml2ZXJzL2dwdS9kcm0vZHJtX2F0b21pYy5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJt L2RybV9hdG9taWMuYwo+IEBAIC0yMDMyLDEzICsyMDMyLDE2IEBAIHN0YXRpYyB2b2lkIGNvbXBs ZXRlX2NydGNfc2lnbmFsaW5nKHN0cnVjdCBkcm1fZGV2aWNlICpkZXYsCj4gIAl9Cj4gIAo+ICAJ Zm9yX2VhY2hfY3J0Y19pbl9zdGF0ZShzdGF0ZSwgY3J0YywgY3J0Y19zdGF0ZSwgaSkgewo+ICsJ CXN0cnVjdCBkcm1fcGVuZGluZ192YmxhbmtfZXZlbnQgKmV2ZW50ID0gY3J0Y19zdGF0ZS0+ZXZl bnQ7Cj4gIAkJLyoKPiAtCQkgKiBURVNUX09OTFkgYW5kIFBBR0VfRkxJUF9FVkVOVCBhcmUgbXV0 dWFsbHkKPiAtCQkgKiBleGNsdXNpdmUsIGlmIHRoZXkgd2VyZW4ndCwgdGhpcyBjb2RlIHNob3Vs ZCBiZQo+IC0JCSAqIGNhbGxlZCBvbiBzdWNjZXNzIGZvciBURVNUX09OTFkgdG9vLgo+ICsJCSAq IEZyZWUgdGhlIGFsbG9jYXRlZCBldmVudC4gZHJtX2F0b21pY19oZWxwZXJfc2V0dXBfY29tbWl0 Cj4gKwkJICogY2FuIGFsbG9jYXRlIGFuIGV2ZW50IHRvbywgc28gb25seSBmcmVlIGl0IGlmIGl0 J3Mgb3Vycwo+ICsJCSAqIHRvIHByZXZlbnQgYSBkb3VibGUgZnJlZSBpbiBkcm1fYXRvbWljX3N0 YXRlX2NsZWFyLgo+ICAJCSAqLwo+IC0JCWlmIChjcnRjX3N0YXRlLT5ldmVudCkKPiAtCQkJZHJt X2V2ZW50X2NhbmNlbF9mcmVlKGRldiwgJmNydGNfc3RhdGUtPmV2ZW50LT5iYXNlKTsKPiArCQlp ZiAoZXZlbnQgJiYgKGV2ZW50LT5iYXNlLmZlbmNlIHx8IGV2ZW50LT5iYXNlLmZpbGVfcHJpdikp IHsKPiArCQkJZHJtX2V2ZW50X2NhbmNlbF9mcmVlKGRldiwgJmV2ZW50LT5iYXNlKTsKPiArCQkJ Y3J0Y19zdGF0ZS0+ZXZlbnQgPSBOVUxMOwo+ICsJCX0KClRoaXMgbWFrZXMgc2Vuc2UgdG8gbWU6 CgpSZXZpZXdlZC1ieTogR3VzdGF2byBQYWRvdmFuIDxndXN0YXZvLnBhZG92YW5AY29sbGFib3Jh LmNvbT4KCkd1c3Rhdm8KCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9w Lm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVs LWdmeAo=