From: Greg Kroah-Hartman Date: Thu, 2 Feb 2017 10:54:53 +0100 Subject: [lustre-devel] [PATCH] staging: lustre: shut up clang warnings on CLASSERT() In-Reply-To: References: <20170201165314.2588373-1-arnd@arndb.de> Message-ID: <20170202095453.GA30437@kroah.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: "Dilger, Andreas" Cc: Arnd Bergmann , "Drokin, Oleg" , James Simmons , "Eremin, Dmitry" , Lustre Development List , "devel@driverdev.osuosl.org" , LKML On Thu, Feb 02, 2017 at 07:50:24AM +0000, Dilger, Andreas wrote: > On Feb 1, 2017, at 09:52, Arnd Bergmann wrote: > > > > lustre uses a fake switch() statement as a compile-time assert, but unfortunately > > each use of that causes a warning when building with clang: > > > > drivers/staging/lustre/lnet/klnds/socklnd/socklnd.c:2907:2: warning: no case matching constant switch condition '42' > > drivers/staging/lustre/lnet/klnds/socklnd/../../../include/linux/libcfs/libcfs_private.h:294:36: note: expanded from macro 'CLASSERT' > > #define CLASSERT(cond) do {switch (42) {case (cond): case 0: break; } } while (0) > > > > Adding a 'default:' label in there shuts up the warning. > > > > Signed-off-by: Arnd Bergmann > > Reviewed-by: Andreas Dilger > > > --- > > drivers/staging/lustre/include/linux/libcfs/libcfs_private.h | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/staging/lustre/include/linux/libcfs/libcfs_private.h b/drivers/staging/lustre/include/linux/libcfs/libcfs_private.h > > index aab15d8112a4..2d5435029185 100644 > > --- a/drivers/staging/lustre/include/linux/libcfs/libcfs_private.h > > +++ b/drivers/staging/lustre/include/linux/libcfs/libcfs_private.h > > @@ -291,7 +291,7 @@ do { \ > > * value after conversion... > > * > > */ > > -#define CLASSERT(cond) do {switch (42) {case (cond): case 0: break; } } while (0) > > +#define CLASSERT(cond) do {switch (42) {case (cond): case 0: default: break; } } while (0) Ugh, why not just use the in-kernel ASSERT macro instead? thanks, greg k-h