Return-Path: Received: from mx2.suse.de ([195.135.220.15]:34432 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751308AbdBBPG4 (ORCPT ); Thu, 2 Feb 2017 10:06:56 -0500 Date: Thu, 2 Feb 2017 16:06:52 +0100 From: Jan Kara To: Amir Goldstein Cc: Jan Kara , linux-fsdevel , Paul Moore , Miklos Szeredi Subject: Re: [PATCH 08/25] fsnotify: Lock object list with connector lock Message-ID: <20170202150652.GC15545@quack2.suse.cz> References: <20170201104457.23194-1-jack@suse.cz> <20170201104457.23194-9-jack@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Wed 01-02-17 15:22:12, Amir Goldstein wrote: > > + conn = mark->connector; > > + spin_lock(&conn->lock); > > + hlist_del_init_rcu(&mark->obj_list); > > + if (hlist_empty(&conn->list)) { > > + if (conn->flags & FSNOTIFY_OBJ_TYPE_INODE) > > + inode = conn->inode; > > + } else > > + __fsnotify_recalc_mask(conn); > > I was told that "if {} else ;" is a coding practice that asks for > trouble and I tend to agree, > so please add {} to else case. Right. Fixed. Thanks for review. Honza -- Jan Kara SUSE Labs, CR