From: Daniel Vetter Subject: Re: [RFC][PATCH 1/2] drm/probe-helper: Add mode_valid check to drm_crtc_helper_funcs Date: Tue, 14 Feb 2017 21:22:29 +0100 Message-ID: <20170214202229.GG22762@dvetter-linux.ger.corp.intel.com> References: <1487100302-9445-1-git-send-email-john.stultz@linaro.org> <1487100302-9445-2-git-send-email-john.stultz@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-ot0-x242.google.com (mail-ot0-x242.google.com [IPv6:2607:f8b0:4003:c0f::242]) by gabe.freedesktop.org (Postfix) with ESMTPS id D511389CF9 for ; Tue, 14 Feb 2017 20:22:33 +0000 (UTC) Received: by mail-ot0-x242.google.com with SMTP id 73so18838539otj.1 for ; Tue, 14 Feb 2017 12:22:33 -0800 (PST) Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: John Stultz Cc: Chen Feng , lkml , dri-devel , Xinliang Liu , Xinwei Kong , Rongrong Zou , Daniel Vetter List-Id: dri-devel@lists.freedesktop.org T24gVHVlLCBGZWIgMTQsIDIwMTcgYXQgMTE6NDU6NTRBTSAtMDgwMCwgSm9obiBTdHVsdHogd3Jv dGU6Cj4gT24gVHVlLCBGZWIgMTQsIDIwMTcgYXQgMTE6MzggQU0sIERhbmllbCBWZXR0ZXIgPGRh bmllbEBmZndsbC5jaD4gd3JvdGU6Cj4gPiBPbiBUdWUsIEZlYiAxNCwgMjAxNyBhdCA4OjI1IFBN LCBKb2huIFN0dWx0eiA8am9obi5zdHVsdHpAbGluYXJvLm9yZz4gd3JvdGU6Cj4gPj4gQ3VycmVu dGx5LCBvbiB0aGUgaGlrZXkgYm9hcmQsIHdlIGhhdmUgdGhlIGFkdjc1MTEgYnJpZGdlIHdpcmVk Cj4gPj4gdXAgdG8gdGhlIGtpcmluIGFkZSBkcm0gZHJpdmVyLiBVbmZvcnR1bmF0ZWx5LCB0aGUg a2lyaW4gYWRlCj4gPj4gY29yZSBjYW5ub3QgZ2VuZXJhdGUgYWNjdXJhdGUgYnl0ZWNsb2NrcyBm b3IgYWxsIHBpeGVsIGNsb2NrCj4gPj4gdmFsdWVzLgo+ID4+Cj4gPj4gVGh1cyBpZiBhIG1vZGUg Y2xvY2sgaXMgc2VsZWN0ZWQgdGhhdCB3ZSBjYW5ub3QgY2FsY3VsYXRlIGEKPiA+PiBtYXRjaGlu ZyBieXRlY2xvY2ssIHRoZSBkZXZpY2Ugd2lsbCBib290IHdpdGggYSBibGFuayBzY3JlZW4uCj4g Pj4KPiA+PiBVbmZvcnR1bmF0ZWx5LCBjdXJyZW50bHkgdGhlIG9ubHkgcGxhY2Ugd2UgY2FuIHBy b3Blcmx5IGNoZWNrCj4gPj4gcG90ZW50aWFsIG1vZGVzIGZvciB0aGlzIGlzc3VlIGluIHRoZSBj b25uZWN0b3IgbW9kZV92YWxpZAo+ID4+IGhlbHBlci4gQWdhaW4sIGhpa2V5IHVzZXMgdGhlIGFk djc1MTEgYnJpZGdlLCB3aGljaCBpcyBzaGFyZWQKPiA+PiBiZXR3ZWVuIGEgbnVtYmVyIG9mIGRp ZmZlcmVudCBkZXZpY2VzLCBzbyBpdHMgaW1wcm9wZXIgdG8gcHV0Cj4gPj4gcmVzdHJpY3Rpb25z IGNhdXNlZCBieSB0aGUga2lyaW4gZHJtIGRyaXZlciBpbiB0aGUgYWR2NzUxMQo+ID4+IGxvZ2lj Lgo+ID4+Cj4gPj4gU28gdGhpcyBwYXRjaCB0cmllcyB0byBjb3JyZWN0IGZvciB0aGF0LCBieSBh ZGRpbmcgc29tZQo+ID4+IGluZnJhc3RydWN0dXJlIHNvIHRoYXQgdGhlIGRybV9jcnRjX2hlbHBl cl9mdW5jcyBjYW4gb3B0aW9uYWxseQo+ID4+IGltcGxlbWVudCBhIG1vZGVfdmFsaWQgY2hlY2ss IHNvIHRoYXQgdGhlIHByb2JlIGhlbHBlcnMgY2FuCj4gPj4gY2hlY2sgdG8gbWFrZSBzdXJlIHRo ZXJlIGFyZSBub3QgYW55IHJlc3RyaWN0aW9ucyBhdCB0aGUgY3J0Ywo+ID4+IGxldmVsIGFzIHdl bGwuCj4gPj4KPiA+PiBDYzogRGFuaWVsIFZldHRlciA8ZGFuaWVsLnZldHRlckBpbnRlbC5jb20+ Cj4gPj4gQ2M6IEphbmkgTmlrdWxhIDxqYW5pLm5pa3VsYUBsaW51eC5pbnRlbC5jb20+Cj4gPj4g Q2M6IFNlYW4gUGF1bCA8c2VhbnBhdWxAY2hyb21pdW0ub3JnPgo+ID4+IENjOiBEYXZpZCBBaXJs aWUgPGFpcmxpZWRAbGludXguaWU+Cj4gPj4gQ2M6IFJvYiBDbGFyayA8cm9iZGNsYXJrQGdtYWls LmNvbT4KPiA+PiBDYzogWGlubGlhbmcgTGl1IDx4aW5saWFuZy5saXVAbGluYXJvLm9yZz4KPiA+ PiBDYzogWGlubGlhbmcgTGl1IDx6LmxpdXhpbmxpYW5nQGhpc2lsaWNvbi5jb20+Cj4gPj4gQ2M6 IFJvbmdyb25nIFpvdSA8em91cm9uZ3JvbmdAZ21haWwuY29tPgo+ID4+IENjOiBYaW53ZWkgS29u ZyA8a29uZy5rb25neGlud2VpQGhpc2lsaWNvbi5jb20+Cj4gPj4gQ2M6IENoZW4gRmVuZyA8cHVj ay5jaGVuQGhpc2lsaWNvbi5jb20+Cj4gPj4gQ2M6IEFyY2hpdCBUYW5lamEgPGFyY2hpdHRAY29k ZWF1cm9yYS5vcmc+Cj4gPj4gQ2M6IGRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKPiA+ PiBTaWduZWQtb2ZmLWJ5OiBKb2huIFN0dWx0eiA8am9obi5zdHVsdHpAbGluYXJvLm9yZz4KPiA+ Cj4gPiBTbyBJJ20gZ29pbmcgdG8gYmUgc3VwZXItYW5ub3lpbmcgaGVyZSBhbmQgYXNrIGZvciBh IGNvbXBsZXRlCj4gPiBzb2x1dGlvbi4gVGhpcyBoZXJlIGlzIGRlZmFjdG8gd2hhdCBldmVyIGRy aXZlciBhbHJlYWR5IGRvZXMgKG9yIGhhcwo+ID4gdG9vKSwgYnV0IGl0IGRvZXNuJ3QgcmVhbGx5 IHNvbHZlIHRoZSBvdmVyYWxsIGlzc3VlIG9mIGhhdmluZyBlbnRpcmVseQo+ID4gc2VwYXJhdGUg dmFsaWRhdGlvbiBwYXRocyBmb3IgcHJvYmUgYW5kIGF0b21pY19jaGVjayBwYXRocy4gSSB0aGlu ayBpZgo+ID4gd2Ugd2FuIHRvIHNvbHZlIHRoaXMsIHdlIG5lZWQgdG8gc29sdmUgdGhpcyBwcm9w ZXJseSwgd2l0aCBhIGdlbmVyaWMKPiA+IHNvbHV0aW9uLiBUaGF0IHdvdWxkIG1lYW46Cj4gPiAt IHN0aWxsIGluIGhlbHBlcnMsIHRvIG1ha2UgaXQgYWxsIG9wdC1pbnQKPiAKPiBKdXN0IHRvIGJl IGNsZWFyLCBJIGJlbGlldmUgd2hhdCBJIHByb3Bvc2VkIGlzIG9wdC1pbiwgYnV0IEkgYXNzdW1l Cj4geW91IHdhbnQgdGhhdCBpbiBhZGRpdGlvbiB0byB0aGUgZm9sbG93aW5nLCByaWdodD8KPiAK PiA+IC0gY292ZXJzIGNydGMgYW5kIGVuY29kZXJzIGFuZCBicmlkZ2VzCj4gCj4gU28geW91J2Qg bGlrZSBzaW1pbGFyIG1vZGVfdmFsaWQoKSBjYWxscyBpbiB0aGUgY3J0Yy9lbmNvZGVyL2JyaWRn ZQo+IGhlbHBlcnM/IHJpZ2h0Pwo+IAo+ID4gLSBhbGxvd3MgeW91IHRvIGltcGxlbWVudCB0aGUg Y3VycmVudCBtb2RlX3ZhbGlkIGluIHRlcm1zIG9mIHRoZSBuZXcKPiA+IHN0dWZmIChtYXliZSBh cyBhIGRlZmF1bHQgaG9vaykKPiAKPiBUaGlzIGJpdCBJJ20gbm90IHN1cmUgSSdtIGZvbGxvd2lu Zy4gVGhlIGN1cnJlbnQgZHJtX2Nvbm5lY3RvcidzCj4gbW9kZV92YWxpZCBpbiB0ZXJtcyBvZiBh IG5ldyBtb2RlX3ZhbGlkIGNhbGwgdGhhdCBhbHNvIGxvb2tzIGF0Cj4gY3J0Yy9lbmNvZGVyL2Jy aWRnZXM/IE9yIGRvIHlvdSBtZWFuIHNvbWV0aGluZyBlbHNlPwo+IAo+ID4gLSBhbGxvd3MgeW91 IHRvIGltcGxlbWVudCB0aGUgY3VycmVudCBhc3NvcnRtZW50IG9mIG1vZGVfZml4dXAgYW5kL29y Cj4gPiBhdG9taWNfY2hlY2sgaW4gdGVybXMgb2YgdGhlIG5ldyBzdHVmZiwgb3IgYXQgbGVhc3Qg dG8gbm90IGhhdmUgdG8KPiA+IGR1cGxpY2F0ZSBsb2dpYyBpbiB0aGVyZQo+IAo+IFRoaXMgaXMg b3ZlciBteSBoZWFkLCBzbyBJJ2xsIGhhdmUgdG8gcmVzZWFyY2ggdG8gYmV0dGVyIHVuZGVyc3Rh bmQuCj4gCj4gPiBEb2NzIGZvciBhbGwgdGhpcywgZXNwZWNpYWxseSB1cGRhdGluZyBhbGwgdGhl IHdhcm5pbmdzIG9uIGhvdyB0byB1c2UKPiA+IHRoZSBleGlzdGluZyBob29rcyBjb3JyZWN0bHku Cj4gCj4gVGhhdCdzIGZhaXIuCj4gCj4gPiBJIHRoaW5rIGp1c3QgcHVzaGluZyB0aGlzIHNwZWNp ZmljIGNhc2UgaW50byB0aGUgaGVscGVycywgd2l0aG91dAo+ID4gcmV0aGlua2luZyB0aGUgb3Zl cmFsbCBiaWcgcGljdHVyZSwgaXNuJ3QgZ2FpbmluZyB1cyBhbGwgdGhhdCBtdWNoLgo+ID4gRm9y IGp1c3QgdGhpcyBJJ2Qgc2F5IGp1c3QgcHV0IGl0IGludG8gZHJpdmVycywgdW50aWwgd2UgaGF2 ZSBzb21lCj4gCj4gTm90IGZvbGxvd2luZyBoZXJlLiBXaGF0IGRvIHlvdSBtZWFuIGJ5ICJwdXQg aXQgaW50byBkcml2ZXJzIj8gIFdoZXJlPwoKSW4geW91ciBkcml2ZXIgY2FsbGJhY2sgZm9yIC0+ bW9kZV92YWxpZCwgY2FsbCBpbnRvIGEgc2hhcmVkIGZ1bmN0aW9uIHRvCnZhbGlkYXRlIENSVEMg bGltaXRzLiBXaGljaCB5b3UgYWxzbyBjYWxsIGZyb20gdGhlIGNydGMncyAtPm1vZGVfZml4dXAK ZnVuY3Rpb24uCgpJbiBzaG9ydCBteSBjb21wbGFpbiBoZXJlIGlzIHRoYXQgdGhpcyBpcyBvbmx5 IGEgcGFydGlhbCBzb2x1dGlvbiBvZiB0aGUKbGFyZ2VyIHByb2JsZW0sIHNwZWNpZmljIGZvciB5 b3VyIGRyaXZlci4gVGhhdCBraW5kIG9mIGNvZGUgaXMgYmV0dGVyIHB1dAppbnRvIGRyaXZlcnMs IHVudGlsIHdlIGhhdmUgYSBjbGVhciB1bmRlcnN0YW5kaW5nIHRvIHR5cGUgdXAgc29tZXRoaW5n CmNvbXBsZXRlIGluIHRoZSBoZWxwZXJzLiBTaGFyZWQgY29kZSBpcyBpbW8gb3ZlcnJhdGVkIDot KQotRGFuaWVsCi0tIApEYW5pZWwgVmV0dGVyClNvZnR3YXJlIEVuZ2luZWVyLCBJbnRlbCBDb3Jw b3JhdGlvbgpodHRwOi8vYmxvZy5mZndsbC5jaApfX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0 cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9s aXN0aW5mby9kcmktZGV2ZWwK