From: Daniel Vetter Subject: Re: [RFC][PATCH 1/2] drm/probe-helper: Add mode_valid check to drm_crtc_helper_funcs Date: Tue, 14 Feb 2017 22:49:32 +0100 Message-ID: <20170214214932.GF11138@dvetter-linux.ger.corp.intel.com> References: <1487100302-9445-1-git-send-email-john.stultz@linaro.org> <1487100302-9445-2-git-send-email-john.stultz@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-it0-x241.google.com (mail-it0-x241.google.com [IPv6:2607:f8b0:4001:c0b::241]) by gabe.freedesktop.org (Postfix) with ESMTPS id 634286E815 for ; Tue, 14 Feb 2017 21:49:37 +0000 (UTC) Received: by mail-it0-x241.google.com with SMTP id r141so7455736ita.1 for ; Tue, 14 Feb 2017 13:49:37 -0800 (PST) Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: John Stultz Cc: Chen Feng , lkml , dri-devel , Xinliang Liu , Xinwei Kong , Rongrong Zou , Daniel Vetter List-Id: dri-devel@lists.freedesktop.org T24gVHVlLCBGZWIgMTQsIDIwMTcgYXQgMDE6MDc6MjFQTSAtMDgwMCwgSm9obiBTdHVsdHogd3Jv dGU6Cj4gT24gVHVlLCBGZWIgMTQsIDIwMTcgYXQgMTI6MzIgUE0sIERhbmllbCBTdG9uZSA8ZGFu aWVsQGZvb2lzaGJhci5vcmc+IHdyb3RlOgo+ID4gSGkgSm9obiwKPiA+Cj4gPiBPbiAxNCBGZWJy dWFyeSAyMDE3IGF0IDE5OjI1LCBKb2huIFN0dWx0eiA8am9obi5zdHVsdHpAbGluYXJvLm9yZz4g d3JvdGU6Cj4gPj4gK3N0YXRpYyBlbnVtIGRybV9tb2RlX3N0YXR1cwo+ID4+ICtkcm1fY29ubmVj dG9yX2NoZWNrX2NydGNfbW9kZXMoc3RydWN0IGRybV9jb25uZWN0b3IgKmNvbm5lY3RvciwKPiA+ PiArICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgc3RydWN0IGRybV9kaXNwbGF5X21vZGUg Km1vZGUpCj4gPj4gK3sKPiA+PiArICAgICAgIHN0cnVjdCBkcm1fZGV2aWNlICpkZXYgPSBjb25u ZWN0b3ItPmRldjsKPiA+PiArICAgICAgIGNvbnN0IHN0cnVjdCBkcm1fY3J0Y19oZWxwZXJfZnVu Y3MgKmNydGNfZnVuY3M7Cj4gPj4gKyAgICAgICBzdHJ1Y3QgZHJtX2NydGMgKmM7Cj4gPj4gKwo+ ID4+ICsgICAgICAgaWYgKG1vZGUtPnN0YXR1cyAhPSBNT0RFX09LKQo+ID4+ICsgICAgICAgICAg ICAgICByZXR1cm4gbW9kZS0+c3RhdHVzOwo+ID4+ICsKPiA+PiArICAgICAgIC8qIENoZWNrIGFs bCB0aGUgY3J0Y3Mgb24gYSBjb25uZWN0b3IgdG8gbWFrZSBzdXJlIHRoZSBtb2RlIGlzIHZhbGlk ICovCj4gPj4gKyAgICAgICBkcm1fZm9yX2VhY2hfY3J0YyhjLCBkZXYpIHsKPiA+PiArICAgICAg ICAgICAgICAgY3J0Y19mdW5jcyA9IGMtPmhlbHBlcl9wcml2YXRlOwo+ID4+ICsgICAgICAgICAg ICAgICBpZiAoY3J0Y19mdW5jcyAmJiBjcnRjX2Z1bmNzLT5tb2RlX3ZhbGlkKQo+ID4+ICsgICAg ICAgICAgICAgICAgICAgICAgIG1vZGUtPnN0YXR1cyA9IGNydGNfZnVuY3MtPm1vZGVfdmFsaWQo YywgbW9kZSk7Cj4gPj4gKyAgICAgICAgICAgICAgIGlmIChtb2RlLT5zdGF0dXMgIT0gTU9ERV9P SykKPiA+PiArICAgICAgICAgICAgICAgICAgICAgICBicmVhazsKPiA+PiArICAgICAgIH0KPiA+ PiArICAgICAgIHJldHVybiBtb2RlLT5zdGF0dXM7Cj4gPj4gK30KPiA+Cj4gPiBIbSwgdGhhdCdz IHVuZm9ydHVuYXRlOiBpdCBsaW1pdHMgdGhlIG1vZGUgbGlzdCBmb3IgZXZlcnkgY29ubmVjdG9y LAo+ID4gdG8gdGhvc2Ugd2hpY2ggYXJlIHN1cHBvcnRlZCBieSBldmVyeSBzaW5nbGUgQ1JUQy4g U28gaWYgeW91IGhhdmUgb25lCj4gPiBDUlRDIHNlcnZpbmcgbG93LXJlcyBMVkRTLCBhbmQgYW5v dGhlciBzZXJ2aW5nIGhpZ2hlci1yZXMgSERNSSwKPiA+IHN1ZGRlbmx5IHlvdSBjYW4ndCBnZXQg YmlnZ2VyIG1vZGVzIG9uIEhETUkuIFRoZSBpZGVhIHNlZW1zIHNvdW5kCj4gPiBlbm91Z2gsIGJ1 dCBhIGxpdHRsZSBtb3JlIG51YW5jZSBtaWdodCBiZSBnb29kIC4uLgo+IAo+IFllYS4gVGhhdCBp cyBub3QgbXkgaW50ZW50IGF0IGFsbCBJJ20ganVzdCB0cnlpbmcgdG8gZ2V0IHRoZSBkcm1fY3J0 Ywo+IGF0dGFjaGVkIHRvIHRoZSBjb25uZWN0b3IgdGhhdCB3ZSdyZSBnZXR0aW5nIHRoZSBFRElE IG1vZGUgbGluZXMgZnJvbS4KPiBJIGhhZCB0cmllZCBnb2luZyBjb25uZWN0b3ItPmVuY29kZXIt PmNydGMsIGJ1dCBhdCB0aGUgdGltZSB0aGlzIGlzCj4gY2FsbGVkLCB0aGUgZW5jb2RlciBpcyBu dWxsLiBTbyBSb2Igc3VnZ2VzdGVkIHRoZSBmb3JfZWFjaF9jcnRjKCksIGFuZAo+IEkgZ3Vlc3Mg SSBtaXN0b29rIHRoYXQgZm9yIGJlaW5nIGVhY2ggY3J0YyBvbiB0aGUgY29ubmVjdG9yLgo+IAo+ IFRoYW5rcyBmb3IgcG9pbnRpbmcgb3V0IHRoaXMgaXNzdWUuIEZyb20gRGFuaWVsJ3MgZmVlZGJh Y2sgaXQgbG9va3MKPiBsaWtlIEkgbmVlZCB0byBzdGFydCBvdmVyIGZyb20gc2NyYXRjaCB0aG91 Z2gsIHNvIGxpdHRsZSB3b3JyeSB0aGlzCj4gaW1wbGVtZW50YXRpb24gd2lsbCBnbyBtdWNoIGZ1 cnRoZXIuCgpXZWxsIHlvdXIgaWRlYSB3YXMgc29tZXdoYXQgcmlnaHQsIGJ1dCBsb2dpYyBpbnZl cnRlZC4gSW4gLT5tb2RlX3ZhbGlkIHdlCm5lZWQgdG8gY2hlY2sgd2hldGhlciBhbnkgZW5jb2Rl ci9jcnRjIGNvbWJvIGNvdWxkIHN1cHBvcnQgdGhlIG1vZGUuIFdoaWNoCm1lYW5zIHlvdSBuZWVk IHRvIHJlamVjdCBpdCBvbmx5IHdoZW4gdGhlcmUncyBubyBlbmNvZGVyL2NydGMgY29tYm8gdGhh dApjb3VsZCBzdXBwb3J0IHRoZSBtb2RlICh5b3UgcmVqZWN0IGl0IGlmIHRoZXJlJ3Mgb25seSBv bmUgY3J0YyB3aGljaCBjYW4ndApoYW5kbGUgaXQpLgoKT24gdGhlIC0+bW9kZV9maXh1cC9hdG9t aWNfY2hlY2sgY2FsbGJhY2tzIG90b2ggd2UgbmVlZCB0byByZWplY3QgdGhlIG1vZGUKd2hlbiBp dCdzIG5vdCBzdWl0YWJsZSBmb3IgdGhlIGN1cnJlbnQgY2hhaW4gKGFzIGRlc2NyaWJlZCBpbiB0 aGUgYXRvbWljCnN0YXRlcykuIFRoYXQgbGl0dGxlIGRpZmZlcmVuY2UgaXMgd2h5IHRoaXMgaXMg bm90IGFuIGVudGlyZWx5IHRyaXZpYWwKcHJvYmxlbSwgYW5kIHllcyB0aGVyZSdzIGxvdHMgb2Yg aHcgb3V0IHRoZXJlIHdoZXJlIHRoaXMgbWF0dGVycy4KLURhbmllbAotLSAKRGFuaWVsIFZldHRl cgpTb2Z0d2FyZSBFbmdpbmVlciwgSW50ZWwgQ29ycG9yYXRpb24KaHR0cDovL2Jsb2cuZmZ3bGwu Y2gKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRl dmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8v bGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg==