Date: Thu, 16 Feb 2017 10:34:46 +0800 From: Antonio Quartulli Message-ID: <20170216023446.GJ12961@...2182...> References: <20170213183826.73008-1-O2Graphics@...2243...> <2b6b9f32-ef12-ea5f-ec3b-298f49bba1ec@...1856...> MIME-Version: 1.0 In-Reply-To: Subject: Re: [Openvpn-devel] [PATCH] Fix building with LibreSSL 2.5.1 by cleaning a hack. Similar to what is done in curl: https://github.com/curl/curl/blob/028391df5d84d9fae3433afdee9261d565900355/lib/vtls/openssl.c#L603-L619 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 8bit Content-Disposition: inline To: Olivier W Cc: openvpn-devel@lists.sourceforge.net On Wed, Feb 15, 2017 at 10:34:16PM +0100, Olivier W wrote: > Hello Steffan, > > 2017-02-14 23:00 GMT+01:00 Steffan Karger : > > > Code still looks good, patch looks a lot better (applies cleanly now), > > but could use an extra newline in the subject. But that doesn't warrant > > an extra patch iteration, so ACK. > > Great, thanks! > Yes, I don't know why my commit has a long line i the subject, when I > used "git commit --amend" to change the message, "Similar to what..." > was on a new line. You need to put an empty line between the subject and the body. For example: my commit message this is the body and can be multiline random text here... and here... Cheers, -- Antonio Quartulli