Received: from eggs.gnu.org ([2001:4830:134:3::10]:50283) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cejVc-0005OP-RW for qemu-devel@nongnu.org; Fri, 17 Feb 2017 09:27:42 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cejVb-0000xt-VX for qemu-devel@nongnu.org; Fri, 17 Feb 2017 09:27:40 -0500 Date: Fri, 17 Feb 2017 15:27:27 +0100 From: Kevin Wolf Message-ID: <20170217142727.GK5338@noname.redhat.com> References: <20170217005127.21010-1-nirsof@gmail.com> <20170217005127.21010-2-nirsof@gmail.com> <20170217091435.GB5338@noname.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Subject: Re: [Qemu-devel] [PATCH 1/3] qemu-img: Add tests for raw image preallocation List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Nir Soffer Cc: qemu-devel@nongnu.org, qemu-block@nongnu.org Am 17.02.2017 um 15:20 hat Nir Soffer geschrieben: > On Fri, Feb 17, 2017 at 11:14 AM, Kevin Wolf wrote: > > Am 17.02.2017 um 01:51 hat Nir Soffer geschrieben: > >> Add tests for creating raw image with and without the preallocation > >> option. > >> > >> Signed-off-by: Nir Soffer > > > > Looks good, but 175 is already (multiply) taken. Not making this a > > blocker, but I just want to remind everyone to check the mailing list > > for pending patches which add new tests before using a new number in > > order to avoid unnecessary rebases for everyone. In general, it's as > > easy as searching for the string "175.out" in the mailbox. > > > > The next free one seems to be 177 currently. > > Thanks, will change to 177 in the next version. If there needs to be a next version for other reasons. Otherwise it's not important enough to respin, it just means that someone else will have to rebase. > For next patches, what do you mean by "pending"? patches sent > to the block mailing list? Yes, that's what I'm looking for when I add a new test case myself. It's just an easy way to avoid stepping on each others toes. Kevin