Received: from eggs.gnu.org ([2001:4830:134:3::10]:52184) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cgkel-00042m-LE for qemu-devel@nongnu.org; Wed, 22 Feb 2017 23:05:28 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cgkei-0003Qk-Hd for qemu-devel@nongnu.org; Wed, 22 Feb 2017 23:05:27 -0500 Received: from mx1.redhat.com ([209.132.183.28]:59762) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cgkei-0003Qa-8a for qemu-devel@nongnu.org; Wed, 22 Feb 2017 23:05:24 -0500 Date: Thu, 23 Feb 2017 01:05:19 -0300 From: Eduardo Habkost Message-ID: <20170223040519.GL2778@thinpad.lan.raisama.net> References: <20170222192647.19690-1-ehabkost@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Subject: Re: [Qemu-devel] [libvirt] [PATCH RESEND] qdev: Make "hotplugged" property read-only List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake Cc: qemu-devel@nongnu.org, "Michael S. Tsirkin" , libvir-list@redhat.com, Laine Stump , Igor Mammedov , Paolo Bonzini , Andreas =?iso-8859-1?Q?F=E4rber?= On Wed, Feb 22, 2017 at 04:43:37PM -0600, Eric Blake wrote: > On 02/22/2017 01:26 PM, Eduardo Habkost wrote: > > The "hotplugged" property is user visible, but it was never meant > > to be set by the user. There are probably multiple ways to break > > or crash device code by overriding the property. For example, we > > recently fixed a crash in rtc_set_memory() related to the > > property (commit 26ef65beab852caf2b1ef4976e3473f2d525164d). > > > > There has been some discussion about making management software > > use "hotplugged=on" on migration, to indicate devices that were > > hotplugged in the migration source. There were other suggestions > > to address this, like including the "hotplugged" field in the > > migration stream instead of requiring it to be set propertly. > > s/propertly/properly/ Actually, I think I meant "requiring it to be set explicitly". I will fix this in my branch. Thanks! > > > > > Whatever solution we choose in the future, this patch disables > > setting "hotplugged" explicitly in the command-line by now, > > because the ability to set the property is unused, untested, and > > undocumented. > > > > Signed-off-by: Eduardo Habkost > > --- > > hw/core/qdev.c | 9 +-------- > > 1 file changed, 1 insertion(+), 8 deletions(-) > > Reviewed-by: Eric Blake Thanks! > > > > > diff --git a/hw/core/qdev.c b/hw/core/qdev.c > > index 06ba02e2a3..800c9ca23f 100644 > > --- a/hw/core/qdev.c > > +++ b/hw/core/qdev.c > > @@ -1016,13 +1016,6 @@ static bool device_get_hotplugged(Object *obj, Error **err) > > return dev->hotplugged; > > } > > > > -static void device_set_hotplugged(Object *obj, bool value, Error **err) > > -{ > > - DeviceState *dev = DEVICE(obj); > > - > > - dev->hotplugged = value; > > -} > > - > > static void device_initfn(Object *obj) > > { > > DeviceState *dev = DEVICE(obj); > > @@ -1042,7 +1035,7 @@ static void device_initfn(Object *obj) > > object_property_add_bool(obj, "hotpluggable", > > device_get_hotpluggable, NULL, NULL); > > object_property_add_bool(obj, "hotplugged", > > - device_get_hotplugged, device_set_hotplugged, > > + device_get_hotplugged, NULL, > > &error_abort); > > > > class = object_get_class(OBJECT(dev)); > > > > -- > Eric Blake eblake redhat com +1-919-301-3266 > Libvirt virtualization library http://libvirt.org > -- Eduardo