From: Sinclair Yeh Subject: Re: [PATCH v2] Revert "drm/vmwgfx: Replace numeric parameter like 0444 with macro" Date: Fri, 24 Feb 2017 11:06:05 -0800 Message-ID: <20170224190603.GA24809@syeh-m01.local> References: <20170204181727.15426-1-sunny@sunbase.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from NAM03-DM3-obe.outbound.protection.outlook.com (mail-dm3nam03on0073.outbound.protection.outlook.com [104.47.41.73]) by gabe.freedesktop.org (Postfix) with ESMTPS id 172066E1D6 for ; Fri, 24 Feb 2017 19:06:17 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20170204181727.15426-1-sunny@sunbase.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: =?iso-8859-1?B?2Hl2aW5kIEEu?= Holm Cc: Thomas Hellstrom , VMware Graphics , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org SGkgT3l2aW5kLAoKVGhhbmtzIGZvciBsb29raW5nIGF0IHRoaXMuCgpBdCB0aGlzIG1vbWVudCwg SSBkb24ndCByZWFsbHkgc2VlIGEgYmVuZWZpdCBvbmUgd2F5IG9yIGFudGhlciwgc28KSSBhbSBn b2luZyB0byBzdGljayB3aXRoIHRoZSBtYWNybyB2ZXJzaW9uIGZvciBub3csIGNoYW5naW5nIHRo ZSBvbmUKcmVtYWluaW5nIG1vZHVsZV9wYXJhbV9uYW1lZCgpIHlvdSBtZW50aW9uZWQgdG8gdXNp bmcgdGhlIG1hY3JvcyB0bwprZWVwIHRoaW5ncyBjb25zaXN0ZW50LgoKSWYgb25lIGRheSB3ZSBo YXZlIGEgcGFyYW10ZXIgd2l0aCBhIGxvbmcgT1Jpbmcgb2YgdGhlIG1hY3JvcywgdGhlbgp3ZSBj YW4gcmV2aXNpdCB0aGlzIGRlY2lzaW9uLgoKU2luY2xhaXIKCk9uIFNhdCwgRmViIDA0LCAyMDE3 IGF0IDA3OjE3OjI3UE0gKzAxMDAsIMOYeXZpbmQgQS4gSG9sbSB3cm90ZToKPiBUaGlzIHJldmVy dHMgY29tbWl0IDJkOGU2MGU4YjA3NDJiN2E1Y2RkYzgwNmZlMzhiYjgxZWU4NzZjMzMuCj4gCj4g VGhlIGNvbW1pdCBiZWxvbmdzIHRvIHRoZSBzZXJpZXMgb2YgMTI4NSBwYXRjaGVzIHNlbnQgdG8g TEtNTCBvbgo+IDIwMTYtMDgtMDIsIGl0IGNoYW5nZXMgdGhlIHJlcHJlc2VudGF0aW9uIG9mIGZp bGUgcGVybWlzc2lvbnMgZnJvbSB0aGUKPiBvY3RhbCB2YWx1ZSAiMDYwMCIgdG8gIlNfSVJVU1Ig fCBTX0lXVVNSIi4KPiAKPiBUaGUgZ2VuZXJhbCBjb25zZW5zdXMgd2FzIHRoYXQgdGhlIGNoYW5n ZXMgZG9lcyBub3QgaW5jcmVhc2UKPiByZWFkYWJpbGl0eSwgcXVpdGUgdGhlIG9wcG9zaXRlOyAw NjAwIGlzIGVhc2llciB0byBwYXJzZSBtZW50YWxseSB0aGFuCj4gU19JUlVTUiB8IFNfSVdVU1Iu Cj4gCj4gSXQgYWxzbyBjYXVzZXMgYXJndW1lbnQgaW5jb25zaXN0ZW5jeSwgZHVlIHRvIGNvbW1p dCAwNDMxOWQ4OWZiZWMKPiAoImRybS92bXdnZng6IEFkZCBhbiBvcHRpb24gdG8gY2hhbmdlIGFz c3VtZWQgRkIgYnBwIikgdGhhdCBhZGRlZAo+IGFub3RoZXIgY2FsbCB0byBtb2R1bGVfcGFyYW1f bmFtZWQoKSB3aGVyZSB0aGUgcGVybWlzc2lvbnMgYXJlIHdyaXR0ZW4KPiBhcyAwNjAwLgo+IAo+ IFNpZ25lZC1vZmYtYnk6IMOYeXZpbmQgQS4gSG9sbSA8c3VubnlAc3VuYmFzZS5vcmc+Cj4gLS0t Cj4gVGhpcyBpcyBhIHJlc2VuZCBvZiB0aGUgcGF0Y2ggb3JpZ2luYWxseSBzZW50IG9uIDIwMTct MDEtMTYuIFRoZSBvbmx5Cj4gZGlmZmVyZW5jZSBmcm9tIHYxIGlzIGFuIGltcHJvdmVkIGNvbW1p dCBtZXNzYWdlIHdpdGggc29tZSBtb3JlIGRldGFpbHMuCj4gCj4gIGRyaXZlcnMvZ3B1L2RybS92 bXdnZngvdm13Z2Z4X2Rydi5jIHwgMTAgKysrKystLS0tLQo+ICAxIGZpbGUgY2hhbmdlZCwgNSBp bnNlcnRpb25zKCspLCA1IGRlbGV0aW9ucygtKQo+IAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dw dS9kcm0vdm13Z2Z4L3Ztd2dmeF9kcnYuYyBiL2RyaXZlcnMvZ3B1L2RybS92bXdnZngvdm13Z2Z4 X2Rydi5jCj4gaW5kZXggMTgwNjFhNGJjMmYyLi5lOGFlM2RjNDc2ZDEgMTAwNjQ0Cj4gLS0tIGEv ZHJpdmVycy9ncHUvZHJtL3Ztd2dmeC92bXdnZnhfZHJ2LmMKPiArKysgYi9kcml2ZXJzL2dwdS9k cm0vdm13Z2Z4L3Ztd2dmeF9kcnYuYwo+IEBAIC0yNDEsMTUgKzI0MSwxNSBAQCBzdGF0aWMgaW50 IHZtd2dmeF9wbV9ub3RpZmllcihzdHJ1Y3Qgbm90aWZpZXJfYmxvY2sgKm5iLCB1bnNpZ25lZCBs b25nIHZhbCwKPiAgCQkJICAgICAgdm9pZCAqcHRyKTsKPiAgCj4gIE1PRFVMRV9QQVJNX0RFU0Mo ZW5hYmxlX2ZiZGV2LCAiRW5hYmxlIHZtd2dmeCBmYmRldiIpOwo+IC1tb2R1bGVfcGFyYW1fbmFt ZWQoZW5hYmxlX2ZiZGV2LCBlbmFibGVfZmJkZXYsIGludCwgU19JUlVTUiB8IFNfSVdVU1IpOwo+ ICttb2R1bGVfcGFyYW1fbmFtZWQoZW5hYmxlX2ZiZGV2LCBlbmFibGVfZmJkZXYsIGludCwgMDYw MCk7Cj4gIE1PRFVMRV9QQVJNX0RFU0MoZm9yY2VfZG1hX2FwaSwgIkZvcmNlIHVzaW5nIHRoZSBE TUEgQVBJIGZvciBUVE0gcGFnZXMiKTsKPiAtbW9kdWxlX3BhcmFtX25hbWVkKGZvcmNlX2RtYV9h cGksIHZtd19mb3JjZV9pb21tdSwgaW50LCBTX0lSVVNSIHwgU19JV1VTUik7Cj4gK21vZHVsZV9w YXJhbV9uYW1lZChmb3JjZV9kbWFfYXBpLCB2bXdfZm9yY2VfaW9tbXUsIGludCwgMDYwMCk7Cj4g IE1PRFVMRV9QQVJNX0RFU0MocmVzdHJpY3RfaW9tbXUsICJUcnkgdG8gbGltaXQgSU9NTVUgdXNh Z2UgZm9yIFRUTSBwYWdlcyIpOwo+IC1tb2R1bGVfcGFyYW1fbmFtZWQocmVzdHJpY3RfaW9tbXUs IHZtd19yZXN0cmljdF9pb21tdSwgaW50LCBTX0lSVVNSIHwgU19JV1VTUik7Cj4gK21vZHVsZV9w YXJhbV9uYW1lZChyZXN0cmljdF9pb21tdSwgdm13X3Jlc3RyaWN0X2lvbW11LCBpbnQsIDA2MDAp Owo+ICBNT0RVTEVfUEFSTV9ERVNDKGZvcmNlX2NvaGVyZW50LCAiRm9yY2UgY29oZXJlbnQgVFRN IHBhZ2VzIik7Cj4gLW1vZHVsZV9wYXJhbV9uYW1lZChmb3JjZV9jb2hlcmVudCwgdm13X2ZvcmNl X2NvaGVyZW50LCBpbnQsIFNfSVJVU1IgfCBTX0lXVVNSKTsKPiArbW9kdWxlX3BhcmFtX25hbWVk KGZvcmNlX2NvaGVyZW50LCB2bXdfZm9yY2VfY29oZXJlbnQsIGludCwgMDYwMCk7Cj4gIE1PRFVM RV9QQVJNX0RFU0MocmVzdHJpY3RfZG1hX21hc2ssICJSZXN0cmljdCBETUEgbWFzayB0byA0NCBi aXRzIHdpdGggSU9NTVUiKTsKPiAtbW9kdWxlX3BhcmFtX25hbWVkKHJlc3RyaWN0X2RtYV9tYXNr LCB2bXdfcmVzdHJpY3RfZG1hX21hc2ssIGludCwgU19JUlVTUiB8IFNfSVdVU1IpOwo+ICttb2R1 bGVfcGFyYW1fbmFtZWQocmVzdHJpY3RfZG1hX21hc2ssIHZtd19yZXN0cmljdF9kbWFfbWFzaywg aW50LCAwNjAwKTsKPiAgTU9EVUxFX1BBUk1fREVTQyhhc3N1bWVfMTZicHAsICJBc3N1bWUgMTYt YnBwIHdoZW4gZmlsdGVyaW5nIG1vZGVzIik7Cj4gIG1vZHVsZV9wYXJhbV9uYW1lZChhc3N1bWVf MTZicHAsIHZtd19hc3N1bWVfMTZicHAsIGludCwgMDYwMCk7Cj4gIAo+IC0tIAo+IDIuMTIuMC5y YzAKPiAKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJp LWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBz Oi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg==