X-GM-THRID: 6390824128052461568 X-Received: by 10.176.86.11 with SMTP id y11mr1415246uaa.11.1487979695412; Fri, 24 Feb 2017 15:41:35 -0800 (PST) X-BeenThere: outreachy-kernel@googlegroups.com Received: by 10.157.54.152 with SMTP id h24ls8705942otc.30.gmail; Fri, 24 Feb 2017 15:41:35 -0800 (PST) X-Received: by 10.200.39.228 with SMTP id x33mr1636431qtx.71.1487979695056; Fri, 24 Feb 2017 15:41:35 -0800 (PST) Return-Path: Received: from mail-pg0-x244.google.com (mail-pg0-x244.google.com. [2607:f8b0:400e:c05::244]) by gmr-mx.google.com with ESMTPS id f7si1847514pfk.5.2017.02.24.15.41.35 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 24 Feb 2017 15:41:35 -0800 (PST) Received-SPF: pass (google.com: domain of arushisinghal19971997@gmail.com designates 2607:f8b0:400e:c05::244 as permitted sender) client-ip=2607:f8b0:400e:c05::244; Authentication-Results: gmr-mx.google.com; dkim=pass header.i=@gmail.com; spf=pass (google.com: domain of arushisinghal19971997@gmail.com designates 2607:f8b0:400e:c05::244 as permitted sender) smtp.mailfrom=arushisinghal19971997@gmail.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gmail.com Received: by mail-pg0-x244.google.com with SMTP id 1so4701715pgz.2 for ; Fri, 24 Feb 2017 15:41:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:mime-version:content-disposition :user-agent; bh=PM6A5kBWX4qgbVxiZwSsGhxYq9A89lU8TbzNA1AFAkQ=; b=rOScs2mekaodU7QOFyaJ+QxwR0shLbTmFA9uVhdLHnxe8bin+3+ZxF4dVIo61PIewe 9Sw6u0y9khr06BWShMtBrQuXF3/9mTQf1vrCsBqeCHB19zoJCZON7H7xWBWtRP8md9Ui okFnhu0cVud0aepwexJE0E5zrnEGwvUciBfqAYS3K5PqqyY3LRCTXYNZAddx6ELVyU85 t/npAc9XOVcP8kNLNL0np3Tpg4L/Ny6QhTe9mAiKTOuDCndrDJTmXGm2FEYvUMKlN36C YjKz66xnvU0W2u07RtSMOm2oRKVBbGUTVPt3kpxDdlYwmoZR6lBQ7RE1Vtj+vl2PTYYH AF/Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:mime-version :content-disposition:user-agent; bh=PM6A5kBWX4qgbVxiZwSsGhxYq9A89lU8TbzNA1AFAkQ=; b=f2+PaOcfsHBYpdn4zP/7cUtoTmjHJI894pr3N+8Tx53O0AZFdNOuGCUtW1an0aw5P4 +bjtqK03Hz6ld+XVZXcy8tMNPaQBykmbmdOQvPhXXHnHTssrlReBb/ODKp2zFMuQ3bpv TneUEjF2dYyNoitHDhNoOPuu/97MkdoVMX7ZLHjmW7weA5mWos8GlSo8HdGLwjgfX0Hl HRvvzTQZmMO1JpgWHVB6o7o4U/LfrFEfLDfARBnegVMaEc2ModoCv8jOq/a0XfH3kEr2 u8hG8qz4kPLY3IgmH6pBFEnr5bgfDwW1mHyRZwxAes0d7gtr1QkUPPvOQFn1oOychZ35 csLA== X-Gm-Message-State: AMke39lzfmS3ck0g+x7olbLMCgPPnrnsALbou6RZJRm0+YwUgWkTRMjvzLV/y//2FWtmZw== X-Received: by 10.99.3.16 with SMTP id 16mr363717pgd.150.1487979694729; Fri, 24 Feb 2017 15:41:34 -0800 (PST) Return-Path: Received: from arushi-HP-Pavilion-Notebook ([14.139.82.6]) by smtp.gmail.com with ESMTPSA id 2sm16917707pfv.100.2017.02.24.15.41.32 (version=TLS1 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 24 Feb 2017 15:41:33 -0800 (PST) Date: Sat, 25 Feb 2017 05:11:30 +0530 From: Arushi Singhal To: arnaud.patard@rtp-net.org Cc: Greg Kroah-Hartman , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, outreachy-kernel@googlegroups.com Subject: [PATCH v2] staging: xgifb: correct the multiple line dereference Message-ID: <20170224234130.GA608@arushi-HP-Pavilion-Notebook> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.5.21 (2010-09-15) Error was reported by checkpatch.pl as WARNING: Avoid multiple line dereference... And If there is boolean operator then it is fixed by Splitting line at boolean operator.This is a coding style error. The changes are made such that the other errors does not generate beacause of this change like line exceeding 80 characters length. Signed-off-by: Arushi Singhal --- changes in v2 - changes done such that no other errors can generate. --- drivers/staging/xgifb/XGI_main_26.c | 21 +++++++++------------ drivers/staging/xgifb/vb_setmode.c | 14 +++++++------- 2 files changed, 16 insertions(+), 19 deletions(-) diff --git a/drivers/staging/xgifb/XGI_main_26.c b/drivers/staging/xgifb/XGI_main_26.c index 6930f7eb741b..651987398d42 100644 --- a/drivers/staging/xgifb/XGI_main_26.c +++ b/drivers/staging/xgifb/XGI_main_26.c @@ -878,30 +878,27 @@ static void XGIfb_post_setmode(struct xgifb_video_info *xgifb_info) } if ((filter >= 0) && (filter <= 7)) { + const u8 *f = XGI_TV_filter[filter_tb].filter[filter]; + pr_debug("FilterTable[%d]-%d: %*ph\n", filter_tb, filter, - 4, XGI_TV_filter[filter_tb]. - filter[filter]); + 4, f); xgifb_reg_set( XGIPART2, 0x35, - (XGI_TV_filter[filter_tb]. - filter[filter][0])); - xgifb_reg_set( + (f[0])); + xgifb_reg_set( XGIPART2, 0x36, - (XGI_TV_filter[filter_tb]. - filter[filter][1])); - xgifb_reg_set( + (f[1])); + xgifb_reg_set( XGIPART2, 0x37, - (XGI_TV_filter[filter_tb]. - filter[filter][2])); + (f[2])); xgifb_reg_set( XGIPART2, 0x38, - (XGI_TV_filter[filter_tb]. - filter[filter][3])); + (f[3])); } } } diff --git a/drivers/staging/xgifb/vb_setmode.c b/drivers/staging/xgifb/vb_setmode.c index 7c7c8c8f1df3..1220d0cea87d 100644 --- a/drivers/staging/xgifb/vb_setmode.c +++ b/drivers/staging/xgifb/vb_setmode.c @@ -221,8 +221,8 @@ static unsigned char XGI_AjustCRT2Rate(unsigned short ModeIdIndex, for (; XGI330_RefIndex[RefreshRateTableIndex + (*i)].ModeID == tempbx; (*i)--) { - infoflag = XGI330_RefIndex[RefreshRateTableIndex + (*i)]. - Ext_InfoFlag; + infoflag = + XGI330_RefIndex[RefreshRateTableIndex + (*i)].Ext_InfoFlag; if (infoflag & tempax) return 1; @@ -231,8 +231,8 @@ static unsigned char XGI_AjustCRT2Rate(unsigned short ModeIdIndex, } for ((*i) = 0;; (*i)++) { - infoflag = XGI330_RefIndex[RefreshRateTableIndex + (*i)]. - Ext_InfoFlag; + infoflag = + XGI330_RefIndex[RefreshRateTableIndex + (*i)].Ext_InfoFlag; if (XGI330_RefIndex[RefreshRateTableIndex + (*i)].ModeID != tempbx) { return 0; @@ -5092,8 +5092,8 @@ unsigned short XGI_GetRatePtrCRT2(struct xgi_hw_device_info *pXGIHWDE, i = 0; do { - if (XGI330_RefIndex[RefreshRateTableIndex + i]. - ModeID != ModeNo) + if (XGI330_RefIndex[RefreshRateTableIndex + i].ModeID + != ModeNo) break; temp = XGI330_RefIndex[RefreshRateTableIndex + i].Ext_InfoFlag; temp &= ModeTypeMask; @@ -5484,7 +5484,7 @@ unsigned char XGISetModeNew(struct xgifb_video_info *xgifb_info, return 0; pVBInfo->ModeType = XGI330_EModeIDTable[ModeIdIndex]. - Ext_ModeFlag & ModeTypeMask; + Ext_ModeFlag & ModeTypeMask; pVBInfo->SetFlag = 0; pVBInfo->VBInfo = DisableCRT2Display; -- 2.11.0