From: Imre Deak Subject: Re: [PATCH 2/2] drm/i915: Remove duplicate DDI enabling logic from MST path Date: Tue, 28 Feb 2017 16:33:46 +0200 Message-ID: <20170228143346.GC13937@ideak-desk.fi.intel.com> References: <20170228071452.20404-1-ander.conselvan.de.oliveira@intel.com> <20170228072113.21530-2-ander.conselvan.de.oliveira@intel.com> <20170228135952.GB13937@ideak-desk.fi.intel.com> <20170228140931.GK31595@intel.com> Reply-To: imre.deak@intel.com Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by gabe.freedesktop.org (Postfix) with ESMTPS id BBB216E729 for ; Tue, 28 Feb 2017 14:33:48 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20170228140931.GK31595@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Cc: Ander Conselvan de Oliveira , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gVHVlLCBGZWIgMjgsIDIwMTcgYXQgMDQ6MDk6MzFQTSArMDIwMCwgVmlsbGUgU3lyasOkbMOk IHdyb3RlOgo+IE9uIFR1ZSwgRmViIDI4LCAyMDE3IGF0IDAzOjU5OjUyUE0gKzAyMDAsIEltcmUg RGVhayB3cm90ZToKPiA+IE9uIFR1ZSwgRmViIDI4LCAyMDE3IGF0IDA5OjIxOjEzQU0gKzAyMDAs IEFuZGVyIENvbnNlbHZhbiBkZSBPbGl2ZWlyYSB3cm90ZToKPiA+ID4gVGhlIGxvZ2ljIHRvIGVu YWJsZSBhIERESSBpbiBpbnRlbF9tc3RfcHJlX2VuYWJsZV9kcCgpIGlzIGVzc2VudGlhbGx5Cj4g PiA+IHRoZSBzYW1lIGFzIGluIGludGVsX2RkaV9wcmVfZW5hYmxlX2RwKCkuIFNvIHJldXNlIHRo ZSBsYXR0ZXIgZnVuY3Rpb24KPiA+ID4gYnkgY2FsbGluZyB0aGUgcG9zdF9kaXNhYmxlIGhvb2sg b24gdGhlIGludGVsX2RpZ19wb3J0IGluc3RlYWQgb2YKPiA+ICAgICAgICAgICAgICAgICAgXnBy ZV9lbmFibGUKPiA+ID4gZHVwbGljYXRpbmcgdGhhdCBjb2RlLgo+ID4gPiAKPiA+ID4gQ2M6IFZp bGxlIFN5cmrDpGzDpCA8dmlsbGUuc3lyamFsYUBsaW51eC5pbnRlbC5jb20+Cj4gPiA+IFNpZ25l ZC1vZmYtYnk6IEFuZGVyIENvbnNlbHZhbiBkZSBPbGl2ZWlyYSA8YW5kZXIuY29uc2VsdmFuLmRl Lm9saXZlaXJhQGludGVsLmNvbT4KPiA+ID4gLS0tCj4gPiA+ICBkcml2ZXJzL2dwdS9kcm0vaTkx NS9pbnRlbF9kZGkuYyAgICB8ICAyICsrCj4gPiA+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRl bF9kcF9tc3QuYyB8IDIzICsrKy0tLS0tLS0tLS0tLS0tLS0tLS0tCj4gPiA+ICAyIGZpbGVzIGNo YW5nZWQsIDUgaW5zZXJ0aW9ucygrKSwgMjAgZGVsZXRpb25zKC0pCj4gPiA+IAo+ID4gPiBkaWZm IC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGRpLmMgYi9kcml2ZXJzL2dwdS9k cm0vaTkxNS9pbnRlbF9kZGkuYwo+ID4gPiBpbmRleCBlOTAxM2YxLi43MWFhZGRmIDEwMDY0NAo+ ID4gPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kZGkuYwo+ID4gPiArKysgYi9k cml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kZGkuYwo+ID4gPiBAQCAtMTY5NSw2ICsxNjk1LDgg QEAgc3RhdGljIHZvaWQgaW50ZWxfZGRpX3ByZV9lbmFibGVfZHAoc3RydWN0IGludGVsX2VuY29k ZXIgKmVuY29kZXIsCj4gPiA+ICAJZW51bSBwb3J0IHBvcnQgPSBpbnRlbF9kZGlfZ2V0X2VuY29k ZXJfcG9ydChlbmNvZGVyKTsKPiA+ID4gIAlzdHJ1Y3QgaW50ZWxfZGlnaXRhbF9wb3J0ICpkaWdf cG9ydCA9IGVuY190b19kaWdfcG9ydCgmZW5jb2Rlci0+YmFzZSk7Cj4gPiA+ICAKPiA+ID4gKwlX QVJOX09OKGxpbmtfbXN0ICYmIHBvcnQgPT0gUE9SVF9BKTsKPiA+ID4gKwo+ID4gCj4gPiBTbyBJ SVVDLCB0aGlzIHdhc24ndCB1c2VkIGJlZm9yZSBmb3IgTVNUIGFuZCBzbyBsaW5rX21zdCB3YXMg YWx3YXlzCj4gPiBmYWxzZS4KPiAKPiBUaGUgTVNUIGNvZGUgZXhwbGljaXRseSBwYXNzZXMgJ3Ry dWUnIGhlcmUuCgpZZXMsIGFmdGVyIHRoZSBjaGFuZ2UuIEkgd2FzIGp1c3Qgd29uZGVyaW5nIHdo eSB0aGlzIHdhc24ndCB1c2VkIGZvciBNU1QKYmVmb3JlLgoKPiAKPiA+IEFsc28gbGlua19tc3Q9 dHJ1ZSBpbXBsaWVzIHR5cGUgPT0gSU5URUxfT1VUUFVUX0RQLCBhcyB0aGlzIHdpbGwKPiA+IGJl IGNhbGxlZCBmb3IgdGhlIHByaW1hcnkgZW5jb2Rlci4gQWZ0ZXIgdGhlIGNoYW5nZSBjcnRjLT5j b25maWcgd2lsbCBiZQo+ID4gdXNlZCBpbnN0ZWFkIG9mIHRoZSAobmV3KSBwaXBlX2NvbmZpZywg YnV0IHRoaXMgaXMgZmluZSBzaW5jZSB0aGUgdHdvCj4gPiBhcmUgdGhlIHNhbWUgaW4gdGhlIGVu YWJsZSBob29rcy4KPiAKPiBOb3BlLiBBRkFJQ1MgdGhpcyBzaG91bGQgZXhwbG9kZSB0b3RhbGx5 IHNpbmNlIGVuY29kZXItPmNydGMgZm9yIHRoZQo+IHByaW1hcnkgd2lsbCBiZSBOVUxMLiBJIGd1 ZXNzIE1hYXJ0ZW4gZGlkbid0IHlldCBudWtlIGFsbCBjcnRjLT5jb25maWcKPiB1c2FnZSBmcm9t IHRoZSBkZGkgY29kZSAob3IgaGUgZGlkIGJ1dCB0aGUgcGF0Y2hlcyBkaWRuJ3QgZ2V0IHJldmll d2VkKS4KCkVyciwgcmlnaHQuIFNvIHRoaXMgd291bGQgbmVlZCBmaXJzdCBjaGFuZ2luZyB0byB1 c2UgY3J0Yy0+Y29uZmlnIHRvCnBpcGVfY29uZmlnIGluIGludGVsX2RkaV9wcmVfZW5hYmxlLgoK LS1JbXJlCgo+IAo+ID4gTG9va3Mgb2sgdG8gbWU6Cj4gPiAKPiA+IFJldmlld2VkLWJ5OiBJbXJl IERlYWsgPGltcmUuZGVha0BpbnRlbC5jb20+Cj4gPiAKPiA+ID4gIAlpbnRlbF9kcF9zZXRfbGlu a19wYXJhbXMoaW50ZWxfZHAsIGxpbmtfcmF0ZSwgbGFuZV9jb3VudCwKPiA+ID4gIAkJCQkgbGlu a19tc3QpOwo+ID4gPiAgCWlmIChlbmNvZGVyLT50eXBlID09IElOVEVMX09VVFBVVF9FRFApCj4g PiA+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kcF9tc3QuYyBiL2Ry aXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2RwX21zdC5jCj4gPiA+IGluZGV4IGE4MzM0ZTEuLjA5 NGNiZGMgMTAwNjQ0Cj4gPiA+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2RwX21z dC5jCj4gPiA+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2RwX21zdC5jCj4gPiA+ IEBAIC0xNTksMjYgKzE1OSw5IEBAIHN0YXRpYyB2b2lkIGludGVsX21zdF9wcmVfZW5hYmxlX2Rw KHN0cnVjdCBpbnRlbF9lbmNvZGVyICplbmNvZGVyLAo+ID4gPiAgCj4gPiA+ICAJRFJNX0RFQlVH X0tNUygiJWRcbiIsIGludGVsX2RwLT5hY3RpdmVfbXN0X2xpbmtzKTsKPiA+ID4gIAo+ID4gPiAt CWlmIChpbnRlbF9kcC0+YWN0aXZlX21zdF9saW5rcyA9PSAwKSB7Cj4gPiA+IC0JCWludGVsX2Rk aV9jbGtfc2VsZWN0KCZpbnRlbF9kaWdfcG9ydC0+YmFzZSwKPiA+ID4gLQkJCQkgICAgIHBpcGVf Y29uZmlnLT5zaGFyZWRfZHBsbCk7Cj4gPiA+IC0KPiA+ID4gLQkJaW50ZWxfZGlzcGxheV9wb3dl cl9nZXQoZGV2X3ByaXYsCj4gPiA+IC0JCQkJCWludGVsX2RpZ19wb3J0LT5kZGlfaW9fcG93ZXJf ZG9tYWluKTsKPiA+ID4gLQo+ID4gPiAtCQlpbnRlbF9wcmVwYXJlX2RwX2RkaV9idWZmZXJzKCZp bnRlbF9kaWdfcG9ydC0+YmFzZSk7Cj4gPiA+IC0JCWludGVsX2RwX3NldF9saW5rX3BhcmFtcyhp bnRlbF9kcCwKPiA+ID4gLQkJCQkJIHBpcGVfY29uZmlnLT5wb3J0X2Nsb2NrLAo+ID4gPiAtCQkJ CQkgcGlwZV9jb25maWctPmxhbmVfY291bnQsCj4gPiA+IC0JCQkJCSB0cnVlKTsKPiA+ID4gLQo+ ID4gPiAtCQlpbnRlbF9kZGlfaW5pdF9kcF9idWZfcmVnKCZpbnRlbF9kaWdfcG9ydC0+YmFzZSk7 Cj4gPiA+IC0KPiA+ID4gLQkJaW50ZWxfZHBfc2lua19kcG1zKGludGVsX2RwLCBEUk1fTU9ERV9E UE1TX09OKTsKPiA+ID4gLQo+ID4gPiAtCQlpbnRlbF9kcF9zdGFydF9saW5rX3RyYWluKGludGVs X2RwKTsKPiA+ID4gLQkJaW50ZWxfZHBfc3RvcF9saW5rX3RyYWluKGludGVsX2RwKTsKPiA+ID4g LQl9Cj4gPiA+ICsJaWYgKGludGVsX2RwLT5hY3RpdmVfbXN0X2xpbmtzID09IDApCj4gPiA+ICsJ CWludGVsX2RpZ19wb3J0LT5iYXNlLnByZV9lbmFibGUoJmludGVsX2RpZ19wb3J0LT5iYXNlLAo+ ID4gPiArCQkJCQkJcGlwZV9jb25maWcsIE5VTEwpOwo+ID4gPiAgCj4gPiA+ICAJcmV0ID0gZHJt X2RwX21zdF9hbGxvY2F0ZV92Y3BpKCZpbnRlbF9kcC0+bXN0X21nciwKPiA+ID4gIAkJCQkgICAg ICAgY29ubmVjdG9yLT5wb3J0LAo+ID4gPiAtLSAKPiA+ID4gMi45LjMKPiA+ID4gCj4gPiA+IF9f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCj4gPiA+IEludGVs LWdmeCBtYWlsaW5nIGxpc3QKPiA+ID4gSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwo+ ID4gPiBodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVs LWdmeAo+ID4gX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18K PiA+IEludGVsLWdmeCBtYWlsaW5nIGxpc3QKPiA+IEludGVsLWdmeEBsaXN0cy5mcmVlZGVza3Rv cC5vcmcKPiA+IGh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8v aW50ZWwtZ2Z4Cj4gCj4gLS0gCj4gVmlsbGUgU3lyasOkbMOkCj4gSW50ZWwgT1RDCl9fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkludGVsLWdmeCBtYWlsaW5n IGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVk ZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo=