From: Arkadiusz Hiler Subject: Re: [PATCH v6] drm/i915/guc: Simplify intel_guc_init_hw() Date: Mon, 13 Mar 2017 13:43:39 +0100 Message-ID: <20170313124338.GA5550@ahiler-desk.igk.intel.com> References: <20170307152500.6760-8-arkadiusz.hiler@intel.com> <20170310114606.17793-1-arkadiusz.hiler@intel.com> <20170310121106.GA102444@mwajdecz-MOBL1.ger.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by gabe.freedesktop.org (Postfix) with ESMTPS id AECF36E27E for ; Mon, 13 Mar 2017 12:43:43 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20170310121106.GA102444@mwajdecz-MOBL1.ger.corp.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Michal Wajdeczko Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gRnJpLCBNYXIgMTAsIDIwMTcgYXQgMDE6MTE6MDZQTSArMDEwMCwgTWljaGFsIFdhamRlY3pr byB3cm90ZToKPiBPbiBGcmksIE1hciAxMCwgMjAxNyBhdCAxMjo0NjowNlBNICswMTAwLCBBcmth ZGl1c3ogSGlsZXIgd3JvdGU6Cj4gPiBDdXJyZW50IHZlcnNpb24gb2YgaW50ZWxfZ3VjX2luaXRf aHcoKSBkb2VzIGEgbG90Ogo+ID4gIC0gY2FyZXMgYWJvdXQgc3VibWlzc2lvbgo+ID4gIC0gbG9h ZHMgaHVjCj4gPiAgLSBpbXBsZW1lbnQgV0EKPiA+IAo+ID4gVGhpcyBjaGFuZ2Ugb2ZmbG9hZHMg c29tZSBvZiB0aGUgbG9naWMgdG8gaW50ZWxfdWNfaW5pdF9odygpLCB3aGljaCBub3cKPiA+IGNh cmVzIGFib3V0IHRoZSBhYm92ZS4KPiA+IAo+ID4gdjI6IHJlbmFtZSBndWNfaHdfcmVzZXQgYW5k IGZpeCB0eXBvIGluIGRlZmluZSBuYW1lIChNLiBXYWpkZWN6a28pCj4gPiB2MzogcmVuYW1lIG9u Y2UgYWdhaW4KPiA+IHY0OiByZW1vdmUgc3B1cmlvdXMgY29tbWVudHMgYW5kIGFkZCBzb21lIHN0 eWxlIChKLiBMYWh0aW5lbikKPiA+IHY1OiBmbG93IGNoYW5nZXMsIGdvdCByaWQgb2YgZGVhZCBj aGVja3MgKE0uIFdhamRlY3prbykKPiA+IHY2OiByZWJhc2UKPiA+IAo+ID4gQ2M6IEFudXNoYSBT cml2YXRzYSA8YW51c2hhLnNyaXZhdHNhQGludGVsLmNvbT4KPiA+IENjOiBNaWNoYWwgV2luaWFy c2tpIDxtaWNoYWwud2luaWFyc2tpQGludGVsLmNvbT4KPiA+IENjOiBNaWNoYWwgV2FqZGVjemtv IDxtaWNoYWwud2FqZGVjemtvQGludGVsLmNvbT4KPiA+IENjOiBEYW5pZWxlIENlcmFvbG8gU3B1 cmlvIDxkYW5pZWxlLmNlcmFvbG9zcHVyaW9AaW50ZWwuY29tPgo+ID4gQ2M6IEpvb25hcyBMYWh0 aW5lbiA8am9vbmFzLmxhaHRpbmVuQGxpbnV4LmludGVsLmNvbT4KPiA+IFNpZ25lZC1vZmYtYnk6 IEFya2FkaXVzeiBIaWxlciA8YXJrYWRpdXN6LmhpbGVyQGludGVsLmNvbT4KPiA+IC0tLQo+IAo+ IHNuaXAKPiAKPiA+IEBAIC0zOTcsNDIgKzM3OSwyMiBAQCBpbnQgaW50ZWxfZ3VjX2luaXRfaHco c3RydWN0IGludGVsX2d1YyAqZ3VjKQo+ID4gIHsKPiA+ICAJc3RydWN0IGRybV9pOTE1X3ByaXZh dGUgKmRldl9wcml2ID0gZ3VjX3RvX2k5MTUoZ3VjKTsKPiA+ICAJY29uc3QgY2hhciAqZndfcGF0 aCA9IGd1Yy0+ZncucGF0aDsKPiA+IC0JaW50IHJldHJpZXMsIHJldCwgZXJyOwo+ID4gKwlpbnQg cmV0Owo+ID4gIAo+ID4gIAlEUk1fREVCVUdfRFJJVkVSKCJHdUMgZncgc3RhdHVzOiBwYXRoICVz LCBmZXRjaCAlcywgbG9hZCAlc1xuIiwKPiA+ICAJCWZ3X3BhdGgsCj4gPiAgCQlpbnRlbF91Y19m d19zdGF0dXNfcmVwcihndWMtPmZ3LmZldGNoX3N0YXR1cyksCj4gPiAgCQlpbnRlbF91Y19md19z dGF0dXNfcmVwcihndWMtPmZ3LmxvYWRfc3RhdHVzKSk7Cj4gPiAgCj4gPiAtCS8qIExvYWRpbmcg Zm9yYmlkZGVuLCBvciBubyBmaXJtd2FyZSB0byBsb2FkPyAqLwo+ID4gLQlpZiAoIWk5MTUuZW5h YmxlX2d1Y19sb2FkaW5nKSB7Cj4gPiAtCQllcnIgPSAwOwo+ID4gLQkJZ290byBmYWlsOwo+ID4g LQl9IGVsc2UgaWYgKGZ3X3BhdGggPT0gTlVMTCkgewo+ID4gLQkJLyogRGV2aWNlIGlzIGtub3du IHRvIGhhdmUgbm8gdUNvZGUgKGUuZy4gbm8gR3VDKSAqLwo+ID4gLQkJZXJyID0gLUVOWElPOwo+ ID4gLQkJZ290byBmYWlsOwo+ID4gKwlpZiAoIWZ3X3BhdGgpIHsKPiA+ICsJCXJldHVybiAtRU5Y SU87Cj4gPiAgCX0gZWxzZSBpZiAoKmZ3X3BhdGggPT0gJ1wwJykgewo+ID4gLQkJLyogRGV2aWNl IGhhcyBhIEd1QyBidXQgd2UgZG9uJ3Qga25vdyB3aGF0IGYvdyB0byBsb2FkPyAqLwo+ID4gIAkJ V0FSTigxLCAiTm8gR3VDIGZpcm13YXJlIGtub3duIGZvciB0aGlzIHBsYXRmb3JtIVxuIik7Cj4g PiAtCQllcnIgPSAtRU5PREVWOwo+ID4gLQkJZ290byBmYWlsOwo+ID4gKwkJcmV0dXJuIC1FTk9E RVY7Cj4gPiAgCX0KPiA+ICAKPiA+IC0JLyogRmV0Y2ggZmFpbGVkLCBvciBhbHJlYWR5IGZldGNo ZWQgYnV0IGZhaWxlZCB0byBsb2FkPyAqLwo+ID4gLQlpZiAoZ3VjLT5mdy5mZXRjaF9zdGF0dXMg IT0gSU5URUxfVUNfRklSTVdBUkVfU1VDQ0VTUykgewo+ID4gLQkJZXJyID0gLUVJTzsKPiA+IC0J CWdvdG8gZmFpbDsKPiA+IC0JfSBlbHNlIGlmIChndWMtPmZ3LmxvYWRfc3RhdHVzID09IElOVEVM X1VDX0ZJUk1XQVJFX0ZBSUwpIHsKPiA+IC0JCWVyciA9IC1FTk9FWEVDOwo+ID4gLQkJZ290byBm YWlsOwo+ID4gLQl9Cj4gPiAtCj4gPiAtCWd1Y19pbnRlcnJ1cHRzX3JlbGVhc2UoZGV2X3ByaXYp Owo+ID4gLQlnZW45X3Jlc2V0X2d1Y19pbnRlcnJ1cHRzKGRldl9wcml2KTsKPiA+IC0KPiA+IC0J LyogV2UgbmVlZCB0byBub3RpZnkgdGhlIGd1YyB3aGVuZXZlciB3ZSBjaGFuZ2UgdGhlIEdHVFQg Ki8KPiA+IC0JaTkxNV9nZ3R0X2VuYWJsZV9ndWMoZGV2X3ByaXYpOwo+ID4gKwlpZiAoZ3VjLT5m dy5mZXRjaF9zdGF0dXMgIT0gSU5URUxfVUNfRklSTVdBUkVfU1VDQ0VTUykKPiA+ICsJCXJldHVy biAtRUlPOwo+IAo+IEFib3ZlIGZ3X3BhdGggY2hlY2tzIHNlZW0gdG8gYmUgcmVkdW5kYW50IGFz IHdlIGFsc28gbG9vayBmb3IgZmV0Y2ggc3RhdHVzIGhlcmUuCgpHb3QgcmlkIG9mIGl0IGluIHRo ZSBwYXRoIHNpbXBsaWZ5aW5nIHBhdGNoLiBUaGFua3MuCgo+ID4gQEAgLTYzLDYgKzg0LDk4IEBA IHZvaWQgaW50ZWxfdWNfaW5pdF9mdyhzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYp Cj4gPiAgCWludGVsX2d1Y19pbml0X2Z3KCZkZXZfcHJpdi0+Z3VjKTsKPiA+ICB9Cj4gPiAgCj4g PiAraW50IGludGVsX3VjX2luaXRfaHcoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2 KQo+ID4gK3sKPiA+ICsJaW50IHJldCwgYXR0ZW1wdHM7Cj4gPiArCWNvbnN0IGludCBndWNfd2Ff aGFzaF9jaGVja19ub3Rfc2V0X2F0dGVtcHRzID0gMzsKPiAKPiBJbiBhbGwgb3RoZXIgcGxhY2Vz LCB3ZSBwdXQgY29uc3QgdmFycyBkZWZpbml0aW9ucyBhcyBmaXJzdCBzdGF0ZW1lbnRzLgo+IEFu ZCBtYXliZSB0aGlzIGNvbnN0IHNob3VsZCBiZSBhY2NvbXBhbmllZCBieSB0aGUgLyogV2EgKi8g Y29tbWVudAo+IHRoYXQgaXMgc2hvd24gYmVsb3cuIEFsc28gY2hhbmdpbmcgcHJlZml4IHRvICJn ZW45IiBtYXliZSBoZWxwZnVsCgpXZW50IHdpdGggdXNpbmcgaXQgZGlyZWN0bHksIGFzIEpvb25h cyBzdWdnZXN0ZWQuIFRoZSBjdXJyZW50IGlmLWVsc2UKc3RhdGVtZW50IG1ha2VzIG1lYW5pbmcg b2J2aW91cyBlbm91Z2ggd2l0aG91dCBoYXZpbmcgdGhlIG5lZWQgdG8gbmFtZQppdC4KCi0tIApD aGVlcnMsCkFyZWsKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3Jn Cmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4 Cg==