Return-Path: Received: from mx2.suse.de ([195.135.220.15]:42017 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754360AbdCTLNy (ORCPT ); Mon, 20 Mar 2017 07:13:54 -0400 Date: Sun, 19 Mar 2017 19:08:42 +0100 From: Jan Kara To: Amir Goldstein Cc: Jan Kara , linux-fsdevel , Miklos Szeredi , Paul Moore Subject: Re: [PATCH 09/33] fsnotify: Remove indirection from mark list addition Message-ID: <20170319180842.GD1844@quack2.suse.cz> References: <20170315104632.7037-1-jack@suse.cz> <20170315104632.7037-10-jack@suse.cz> <20170316075802.GL12989@quack2.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Thu 16-03-17 17:52:46, Amir Goldstein wrote: > >> This chunk has become overly convoluted IMO. > >> How about something like this: > >> > >> conn = fsnotify_connector_get(connp, lock); > >> > >> spin_lock(&mark->lock); > >> spin_lock(lock); > >> > >> Where fsnotify_connector_get() acquires and releases only the object lock > >> and only for the case of allocating a new connector. > > > > Agreed and changed. > > > > Looks very neat now. > You may add > Reviewed-by: Amir Goldstein > > (based on commit 6e23640 on your testing branch) > > I believe that addresses the last of my review comments. > Let me know if I missed any Rvb tag. Thanks for review! All patches have your tag now. Honza -- Jan Kara SUSE Labs, CR