From: Jason Gunthorpe Subject: Re: [PATCH] tpm/tpm_crb: mark PM functions as __maybe_unused Date: Mon, 20 Mar 2017 17:04:30 -0600 Message-ID: <20170320230430.GA25163@obsidianresearch.com> References: <20170320091755.1043811-1-arnd@arndb.de> <5B8DA87D05A7694D9FA63FD143655C1B543B032E@hasmsx108.ger.corp.intel.com> <5B8DA87D05A7694D9FA63FD143655C1B543B0620@hasmsx108.ger.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <5B8DA87D05A7694D9FA63FD143655C1B543B0620-Jy8z56yoSI8MvF1YICWikbfspsVTdybXVpNB7YpNyf8@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: tpmdd-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org To: "Winkler, Tomas" Cc: Arnd Bergmann , "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "tpmdd-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org" List-Id: tpmdd-devel@lists.sourceforge.net On Mon, Mar 20, 2017 at 11:01:36PM +0000, Winkler, Tomas wrote: > I believe that in this case the #ifdefs can be done correctly quite > easily, but now I'm not against your solution as well, just maybe > put some of this info to the commit message. I perfer fewer ifdefs, it makes it more maintainable.. The compiler will remove unused static functions. Jason ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot