From: Thierry Reding Subject: Re: [PATCH v3 10/10] drm/rockchip: Remove unnecessary NULL check Date: Tue, 21 Mar 2017 12:13:12 +0100 Message-ID: <20170321111312.GB30407@ulmo.ba.sec> References: <20170321081358.27237-1-thierry.reding@gmail.com> <20170321081358.27237-11-thierry.reding@gmail.com> <20170321102704.gmppuklsifvac5nj@phenom.ffwll.local> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0060273105==" Return-path: In-Reply-To: <20170321102704.gmppuklsifvac5nj@phenom.ffwll.local> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Daniel Vetter Cc: Daniel Vetter , intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org --===============0060273105== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="8GpibOaaTibBMecb" Content-Disposition: inline --8GpibOaaTibBMecb Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Mar 21, 2017 at 11:27:04AM +0100, Daniel Vetter wrote: > On Tue, Mar 21, 2017 at 09:13:58AM +0100, Thierry Reding wrote: > > From: Thierry Reding > >=20 > > The expression &private->fbdev_helper can never be NULL, so the check is > > completely unnecessary. > >=20 > > Signed-off-by: Thierry Reding >=20 > On the 3 drivers patches (all except exynos): >=20 > Reviewed-by: Daniel Vetter >=20 > For merging, do you want to push it all through drm-misc? Or planning on > sending a pull request to Dave? I think this is perfect material for drm-misc. I'll resend v4 shortly with a build fix and the fix Andrzej pointed out folded into the Exynos driver. Thierry --8GpibOaaTibBMecb Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEiOrDCAFJzPfAjcif3SOs138+s6EFAljRCsUACgkQ3SOs138+ s6Fp5BAAhPl3ooT/CembYXlrmpjyo8xlAyvJrxJlpqmDp/gENI0o740xbiuHYz64 TMbWtHVSMaFvH+DJI4EvMfkEq8AF5Kv4Px2g9QzemS2Z/sVAXLc8Rj1KAGzBqbXs vdmOM66aatPSSg1xC9NefpYgep2lb3zCk/xrIlANXzwnpI4uFJ9KmxyoMiIU15NQ p2jMYDidkniLnI47dHjA+uQdTn6UhRdZYMc6KRtYOdASWn/axwTS9bgg8mj69q6P mOKPVaaFId447T+ej6V7JwmYpKwKp7W6LPfSGGe7AjlGecXmoVb7rmvg8TT2QBoR A3ikBlEb49eUl6Lb6zUYS9Aa9bdgC6ceuy0DSJkEaLUowofLGRGF+uFRPSJNS5Px 7tjJzlTrsKjSH6FDPNUcMzJQem+HXCmc7pf9U4Qym2HQffuV29JDXmu1dg4iADMU EVeGxUcMALk8nQRB+874m8D1J8g0HwYtFoYWynfoNoxk5rl6T/dMvecs9fF96JJh oOg5VnkWmZnKTBu/gkkPDuJkHV0OiW6Kp3IQjR2l/LXVlipjhbeTJ/M5e+tFgcZA XzyPFLEcFA7kCJHTMMUScfBjlJjqar7jr2GIY/49Isiu3OdTgjq2/MYTZRbSuWBs tOSFbr5WgOWytHpIA6ajQfn5xULsOsYz2ef76PDeiuY0EsHlJgo= =2sY4 -----END PGP SIGNATURE----- --8GpibOaaTibBMecb-- --===============0060273105== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4 IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg== --===============0060273105==--