From: Ben Widawsky Subject: Re: [PATCH 2/5] drm: Remove fb hsub/vsub alignment requirement Date: Tue, 21 Mar 2017 13:26:23 -0700 Message-ID: <20170321202622.GA18818@mail.bwidawsk.net> References: <20170321181218.10042-1-ville.syrjala@linux.intel.com> <20170321181218.10042-3-ville.syrjala@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <20170321181218.10042-3-ville.syrjala@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: ville.syrjala@linux.intel.com Cc: intel-gfx@lists.freedesktop.org, Jason Ekstrand , dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org T24gMTctMDMtMjEgMjA6MTI6MTUsIFZpbGxlIFN5cmrDpGzDpCB3cm90ZToKPkZyb206IFZpbGxl IFN5cmrDpGzDpCA8dmlsbGUuc3lyamFsYUBsaW51eC5pbnRlbC5jb20+Cj4KPkFsbG93IGZyYW1l YnVmZmVycyBkaW1lc2lvbnMgdG8gYmUgbWlzYWxpZ25lZCB3LnIudC4gdGhlIHN1YnNhbXBsaW5n Cj5mYWN0b3JzLiBObyByZWFsIHJlYXNvbiB0aGUgY29yZSBzaG91bGQgaGF2ZSB0byBlbmZvcmNl IHRoaXMsIGFuZAo+aXQgZGVmaW5pdGVseSBzdGFydHMgdG8gY2F1c2UgdXMgaXNzdWVzIHdpdGgg dGhlIGk5MTUgQ0NTIHN1cHBvcnQuCj5TbyBsZXQncyBqdXN0IGxpZnQgdGhlIHJlc3RyaWN0aW9u Lgo+Cj5MZXQncyBzdGFydCB0byByb3VuZCB1cCB3aGVuIGNvbXB1dGluZyB0aGUgY29sb3IgcGxh bmUgZGltZXNpb25zCj5zbyB0aGF0IHdlJ2xsIG5vdCBlbmQgdXAgd2l0aCB0b28gbG93IGFuIGVz dGltYXRlIGZvciB0aGUgbWVtb3J5Cj5yZXF1aXJlbWVudHMgYW5kIHdoYXRub3QuCj4KPkNjOiBC ZW4gV2lkYXdza3kgPGJlbkBid2lkYXdzay5uZXQ+Cj5DYzogSmFzb24gRWtzdHJhbmQgPGphc29u QGpsZWtzdHJhbmQubmV0Pgo+U2lnbmVkLW9mZi1ieTogVmlsbGUgU3lyasOkbMOkIDx2aWxsZS5z eXJqYWxhQGxpbnV4LmludGVsLmNvbT4KCkJvdGggMSBhbmQgMiBhcmU6ClJldmlld2VkLWJ5OiBC ZW4gV2lkYXdza3kgPGJlbkBid2lkYXdzay5uZXQ+Cgo+LS0tCj4gZHJpdmVycy9ncHUvZHJtL2Ry bV9mcmFtZWJ1ZmZlci5jIHwgOCArKysrLS0tLQo+IDEgZmlsZSBjaGFuZ2VkLCA0IGluc2VydGlv bnMoKyksIDQgZGVsZXRpb25zKC0pCj4KPmRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vZHJt X2ZyYW1lYnVmZmVyLmMgYi9kcml2ZXJzL2dwdS9kcm0vZHJtX2ZyYW1lYnVmZmVyLmMKPmluZGV4 IDExMzhmOTBhN2Q1ZC4uNjllNGMxNDg3NDIwIDEwMDY0NAo+LS0tIGEvZHJpdmVycy9ncHUvZHJt L2RybV9mcmFtZWJ1ZmZlci5jCj4rKysgYi9kcml2ZXJzL2dwdS9kcm0vZHJtX2ZyYW1lYnVmZmVy LmMKPkBAIC0xMzIsNyArMTMyLDcgQEAgc3RhdGljIGludCBmYl9wbGFuZV93aWR0aChpbnQgd2lk dGgsCj4gCWlmIChwbGFuZSA9PSAwKQo+IAkJcmV0dXJuIHdpZHRoOwo+Cj4tCXJldHVybiB3aWR0 aCAvIGZvcm1hdC0+aHN1YjsKPisJcmV0dXJuIERJVl9ST1VORF9VUCh3aWR0aCwgZm9ybWF0LT5o c3ViKTsKPiB9Cj4KPiBzdGF0aWMgaW50IGZiX3BsYW5lX2hlaWdodChpbnQgaGVpZ2h0LAo+QEAg LTE0MSw3ICsxNDEsNyBAQCBzdGF0aWMgaW50IGZiX3BsYW5lX2hlaWdodChpbnQgaGVpZ2h0LAo+ IAlpZiAocGxhbmUgPT0gMCkKPiAJCXJldHVybiBoZWlnaHQ7Cj4KPi0JcmV0dXJuIGhlaWdodCAv IGZvcm1hdC0+dnN1YjsKPisJcmV0dXJuIERJVl9ST1VORF9VUChoZWlnaHQsIGZvcm1hdC0+dnN1 Yik7Cj4gfQo+Cj4gc3RhdGljIGludCBmcmFtZWJ1ZmZlcl9jaGVjayhjb25zdCBzdHJ1Y3QgZHJt X21vZGVfZmJfY21kMiAqcikKPkBAIC0xNTgsMTIgKzE1OCwxMiBAQCBzdGF0aWMgaW50IGZyYW1l YnVmZmVyX2NoZWNrKGNvbnN0IHN0cnVjdCBkcm1fbW9kZV9mYl9jbWQyICpyKQo+IAkJcmV0dXJu IC1FSU5WQUw7Cj4gCX0KPgo+LQlpZiAoci0+d2lkdGggPT0gMCB8fCByLT53aWR0aCAlIGluZm8t PmhzdWIpIHsKPisJaWYgKHItPndpZHRoID09IDApIHsKPiAJCURSTV9ERUJVR19LTVMoImJhZCBm cmFtZWJ1ZmZlciB3aWR0aCAldVxuIiwgci0+d2lkdGgpOwo+IAkJcmV0dXJuIC1FSU5WQUw7Cj4g CX0KPgo+LQlpZiAoci0+aGVpZ2h0ID09IDAgfHwgci0+aGVpZ2h0ICUgaW5mby0+dnN1Yikgewo+ KwlpZiAoci0+aGVpZ2h0ID09IDApIHsKPiAJCURSTV9ERUJVR19LTVMoImJhZCBmcmFtZWJ1ZmZl ciBoZWlnaHQgJXVcbiIsIHItPmhlaWdodCk7Cj4gCQlyZXR1cm4gLUVJTlZBTDsKPiAJfQo+LS0g Cj4yLjEwLjIKPgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f XwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcK aHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK