From: Liam Breck Subject: [PATCH v12.6 09/11] power: bq27xxx_battery: Flag identical register maps when in debug mode Date: Sun, 9 Apr 2017 22:07:10 -0700 Message-ID: <20170410050712.930-6-liam@networkimprov.net> References: <20170410050712.930-1-liam@networkimprov.net> Return-path: Received: from mail-pg0-f68.google.com ([74.125.83.68]:34922 "EHLO mail-pg0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751198AbdDJFHr (ORCPT ); Mon, 10 Apr 2017 01:07:47 -0400 Received: by mail-pg0-f68.google.com with SMTP id g2so24239426pge.2 for ; Sun, 09 Apr 2017 22:07:47 -0700 (PDT) In-Reply-To: <20170410050712.930-1-liam@networkimprov.net> Sender: linux-pm-owner@vger.kernel.org List-Id: linux-pm@vger.kernel.org To: "Andrew F. Davis" , linux-pm@vger.kernel.org Cc: Liam Breck From: Liam Breck We tie multiple chips to unique register maps. When supporting a new chip, it's easy to add a duplicate map by mistake. In debug mode we now scan the register maps for duplicates. Signed-off-by: Liam Breck --- drivers/power/supply/bq27xxx_battery.c | 21 +++++++++++++++++++++ 1 file changed, 21 insertions(+) diff --git a/drivers/power/supply/bq27xxx_battery.c b/drivers/power/supply/bq27xxx_battery.c index cebaf59..9b0b6b2 100644 --- a/drivers/power/supply/bq27xxx_battery.c +++ b/drivers/power/supply/bq27xxx_battery.c @@ -1919,6 +1919,25 @@ static void bq27xxx_external_power_changed(struct power_supply *psy) schedule_delayed_work(&di->work, 0); } +#ifdef DEBUG +static void bq27xxx_battery_dbg_regs_dupes(struct bq27xxx_device_info *di) +{ + const size_t max = ARRAY_SIZE(bq27xxx_regs); + int a, b; + + for (a = 1; a < max-1; a++) { + for (b = a+1; b < max; b++) { + if (!memcmp(bq27xxx_regs[a], bq27xxx_regs[b], + sizeof(bq27xxx_regs[0]))) + dev_warn(di->dev, + "bq27xxx_regs[%d] & [%d] are identical\n", a, b); + } + } +} +#else +static inline void bq27xxx_battery_dbg_regs_dupes(struct bq27xxx_device_info *di) {} +#endif + int bq27xxx_battery_setup(struct bq27xxx_device_info *di) { struct power_supply_desc *psy_desc; @@ -1927,6 +1946,8 @@ int bq27xxx_battery_setup(struct bq27xxx_device_info *di) .drv_data = di, }; + bq27xxx_battery_dbg_regs_dupes(di); + di->unseal_key = bq27xxx_unseal_keys[di->chip]; di->dm_regs = bq27xxx_dm_regs[di->chip]; di->chip = bq27xxx_chips[di->chip]; -- 2.9.3