From: Boris Brezillon Subject: Re: [PATCH] drm/atomic: Acquire connection_mutex lock in drm_helper_probe_single_connector_modes, v4. Date: Mon, 10 Apr 2017 12:16:40 +0200 Message-ID: <20170410121640.58ff94ad@bbrezillon> References: <1491504920-4017-1-git-send-email-maarten.lankhorst@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1491504920-4017-1-git-send-email-maarten.lankhorst@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Maarten Lankhorst Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org SGkgTWFhcnRlZW4sCgpTb3JyeSBmb3IgdGhlIGxhdGUgcmV2aWV3LCBJIHdhcyBvbiB2YWNhdGlv biBsYXN0IHdlZWsuCgpPbiBUaHUsICA2IEFwciAyMDE3IDIwOjU1OjIwICswMjAwCk1hYXJ0ZW4g TGFua2hvcnN0IDxtYWFydGVuLmxhbmtob3JzdEBsaW51eC5pbnRlbC5jb20+IHdyb3RlOgoKPiBt b2RlX3ZhbGlkKCkgY2FsbGVkIGZyb20gZHJtX2hlbHBlcl9wcm9iZV9zaW5nbGVfY29ubmVjdG9y X21vZGVzKCkKPiBtYXkgbmVlZCB0byBsb29rIGF0IGNvbm5lY3Rvci0+c3RhdGUgYmVjYXVzZSB3 aGF0IGEgdmFsaWQgbW9kZSBpcyBtYXkKPiBkZXBlbmQgb24gY29ubmVjdG9yIHByb3BlcnRpZXMg YmVpbmcgc2V0LiBGb3IgZXhhbXBsZSBzb21lIEhETUkgbW9kZXMKPiBtaWdodCBiZSByZWplY3Rl ZCB3aGVuIGEgY29ubmVjdG9yIHByb3BlcnR5IGZvcmNlcyB0aGUgY29ubmVjdG9yCj4gaW50byBE VkkgbW9kZS4KPiAKPiBTb21lIGltcGxlbWVudGF0aW9ucyBvZiBkZXRlY3QoKSBhbHJlYWR5IGxv Y2sgYWxsIHN0YXRlLAo+IHNvIHdlIGhhdmUgdG8gcGFzcyBhbiBhY3F1aXJlX2N0eCB0byB0aGVt IHRvIHByZXZlbnQgYSBkZWFkbG9jay4KPiAKPiBUaGlzIG1lYW5zIGNoYW5naW5nIHRoZSBmdW5j dGlvbiBzaWduYXR1cmUgb2YgZGV0ZWN0KCkgc2xpZ2h0bHksCj4gYW5kIHBhc3NpbmcgdGhlIGFj cXVpcmVfY3R4IGZvciBsb2NraW5nIG11bHRpcGxlIGNydGMncy4KPiBGb3IgdGhlIGNhbGxiYWNr cywgaXQgd2lsbCBhbHdheXMgYmUgbm9uLXplcm8uIFRvIGFsbG93IGNhbGxlcnMKPiBub3QgdG8g d29ycnkgYWJvdXQgdGhpcywgZHJtX2hlbHBlcl9wcm9iZV9kZXRlY3RfY3R4IGlzIGFkZGVkCj4g d2hpY2ggbWlnaHQgaGFuZGxlIC1FREVBRExLIGZvciB5b3UuCj4gCj4gQ2hhbmdlcyBzaW5jZSB2 MToKPiAtIEFsd2F5cyBzZXQgY3R4IHBhcmFtZXRlci4KPiBDaGFuZ2VzIHNpbmNlIHYyOgo+IC0g QWx3YXlzIHRha2UgY29ubmVjdGlvbl9tdXRleCB3aGVuIHByb2JpbmcuCj4gQ2hhbmdlcyBzaW5j ZSB2MzoKPiAtIFJlbW92ZSB0aGUgY3R4IGZyb20gaW50ZWxfZHBfbG9uZ19wdWxzZSwgYW5kIGFk ZAo+ICAgV0FSTl9PTighY29ubmVjdGlvbl9tdXRleCkgKGRhbnZldCkKPiAtIFVwZGF0ZSBkb2Nz IHRvIGNsYXJpZnkgdGhlIGxvY2tpbmcgc2l0dWF0aW9uLiAoZGFudmV0KQoKTWF5YmUgdGhpcyBp cyBzb21ldGhpbmcgRFJNLXNwZWNpZmljLCBidXQgdXN1YWxseSB3ZSBwdXQgdGhlIGNoYW5nZWxv ZwphZnRlciB0aGUgJy0tLScgdG8gYXZvaWQgaGF2aW5nIGl0IGluIHRoZSBmaW5hbCBjb21taXQu CgpTYW1lIGdvZXMgZm9yIHRoZSAiLCB2NCIgc3VmZml4IGluIHRoZSBjb21taXQgdGl0bGUsIGl0 IHNob3VsZCBiZQonW1BBVENIIHZYXSA8Y29tbWl0IGRlc2NyaXB0aW9uPicuCgo+IAo+IFNpZ25l ZC1vZmYtYnk6IE1hYXJ0ZW4gTGFua2hvcnN0IDxtYWFydGVuLmxhbmtob3JzdEBsaW51eC5pbnRl bC5jb20+Cj4gQ2M6IEJvcmlzIEJyZXppbGxvbiA8Ym9yaXMuYnJlemlsbG9uQGZyZWUtZWxlY3Ry b25zLmNvbT4KPiBSZXZpZXdlZC1ieTogRGFuaWVsIFZldHRlciA8ZGFuaWVsLnZldHRlckBmZnds bC5jaD4KPiAtLS0KPiAgZHJpdmVycy9ncHUvZHJtL2RybV9wcm9iZV9oZWxwZXIuYyAgICAgICB8 IDEwMCArKysrKysrKysrKysrKysrKysrKysrKysrKysrLS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9p OTE1L2ludGVsX2NydC5jICAgICAgICAgfCAgMjUgKysrKy0tLS0KPiAgZHJpdmVycy9ncHUvZHJt L2k5MTUvaW50ZWxfZGlzcGxheS5jICAgICB8ICAyNSArKysrLS0tLQo+ICBkcml2ZXJzL2dwdS9k cm0vaTkxNS9pbnRlbF9kcC5jICAgICAgICAgIHwgIDIxICsrKy0tLS0KPiAgZHJpdmVycy9ncHUv ZHJtL2k5MTUvaW50ZWxfZHJ2LmggICAgICAgICB8ICAgOCArLS0KPiAgZHJpdmVycy9ncHUvZHJt L2k5MTUvaW50ZWxfaG90cGx1Zy5jICAgICB8ICAgMyArLQo+ICBkcml2ZXJzL2dwdS9kcm0vaTkx NS9pbnRlbF90di5jICAgICAgICAgIHwgIDIxICsrKy0tLS0KPiAgaW5jbHVkZS9kcm0vZHJtX2Nv bm5lY3Rvci5oICAgICAgICAgICAgICB8ICAgNiArKwo+ICBpbmNsdWRlL2RybS9kcm1fY3J0Y19o ZWxwZXIuaCAgICAgICAgICAgIHwgICAzICsKPiAgaW5jbHVkZS9kcm0vZHJtX21vZGVzZXRfaGVs cGVyX3Z0YWJsZXMuaCB8ICAzNiArKysrKysrKysrKwo+ICAxMCBmaWxlcyBjaGFuZ2VkLCAxODcg aW5zZXJ0aW9ucygrKSwgNjEgZGVsZXRpb25zKC0pCj4gCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMv Z3B1L2RybS9kcm1fcHJvYmVfaGVscGVyLmMgYi9kcml2ZXJzL2dwdS9kcm0vZHJtX3Byb2JlX2hl bHBlci5jCj4gaW5kZXggZWZiNWU1ZThjZTYyLi4xYjBjMTRhYjNmZmYgMTAwNjQ0Cj4gLS0tIGEv ZHJpdmVycy9ncHUvZHJtL2RybV9wcm9iZV9oZWxwZXIuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2Ry bS9kcm1fcHJvYmVfaGVscGVyLmMKPiBAQCAtMTY5LDEyICsxNjksNzMgQEAgdm9pZCBkcm1fa21z X2hlbHBlcl9wb2xsX2VuYWJsZShzdHJ1Y3QgZHJtX2RldmljZSAqZGV2KQo+ICBFWFBPUlRfU1lN Qk9MKGRybV9rbXNfaGVscGVyX3BvbGxfZW5hYmxlKTsKPiAgCj4gIHN0YXRpYyBlbnVtIGRybV9j b25uZWN0b3Jfc3RhdHVzCj4gLWRybV9jb25uZWN0b3JfZGV0ZWN0KHN0cnVjdCBkcm1fY29ubmVj dG9yICpjb25uZWN0b3IsIGJvb2wgZm9yY2UpCj4gK2RybV9oZWxwZXJfcHJvYmVfZGV0ZWN0X2N0 eChzdHJ1Y3QgZHJtX2Nvbm5lY3RvciAqY29ubmVjdG9yLCBib29sIGZvcmNlKQoKVGhlIGZ1bmN0 aW9uIG5hbWUgaXMgbWlzbGVhZGluZyBJTUhPLiBBRkFJVSwgdGhpcyBoZWxwZXIgaXMKaW5zdGFu dGlhdGluZyBhIG5ldyBjb250ZXh0IGJlY2F1c2UgdGhlIGNhbGxlciBkaWQgbm90IHByb3ZpZGUg b25lLCBzbwpob3cgYWJvdXQgcmVuYW1pbmcgaXQgZHJtX2hlbHBlcl9wcm9iZV9kZXRlY3Rfbm9f Y3R4KCk/Cgo+ICB7Cj4gLQlyZXR1cm4gY29ubmVjdG9yLT5mdW5jcy0+ZGV0ZWN0ID8KPiAtCQlj b25uZWN0b3ItPmZ1bmNzLT5kZXRlY3QoY29ubmVjdG9yLCBmb3JjZSkgOgo+IC0JCWNvbm5lY3Rv cl9zdGF0dXNfY29ubmVjdGVkOwo+ICsJY29uc3Qgc3RydWN0IGRybV9jb25uZWN0b3JfaGVscGVy X2Z1bmNzICpmdW5jcyA9IGNvbm5lY3Rvci0+aGVscGVyX3ByaXZhdGU7Cj4gKwlzdHJ1Y3QgZHJt X21vZGVzZXRfYWNxdWlyZV9jdHggY3R4Owo+ICsJaW50IHJldDsKPiArCj4gKwlkcm1fbW9kZXNl dF9hY3F1aXJlX2luaXQoJmN0eCwgMCk7Cj4gKwo+ICtyZXRyeToKPiArCXJldCA9IGRybV9tb2Rl c2V0X2xvY2soJmNvbm5lY3Rvci0+ZGV2LT5tb2RlX2NvbmZpZy5jb25uZWN0aW9uX211dGV4LCAm Y3R4KTsKPiArCWlmICghcmV0KSB7Cj4gKwkJaWYgKGZ1bmNzLT5kZXRlY3RfY3R4KQo+ICsJCQly ZXQgPSBmdW5jcy0+ZGV0ZWN0X2N0eChjb25uZWN0b3IsICZjdHgsIGZvcmNlKTsKPiArCQllbHNl IGlmIChjb25uZWN0b3ItPmZ1bmNzLT5kZXRlY3QpCj4gKwkJCXJldCA9IGNvbm5lY3Rvci0+ZnVu Y3MtPmRldGVjdChjb25uZWN0b3IsIGZvcmNlKTsKPiArCQllbHNlCj4gKwkJCXJldCA9IGNvbm5l Y3Rvcl9zdGF0dXNfY29ubmVjdGVkOwo+ICsJfQo+ICsKPiArCWlmIChyZXQgPT0gLUVERUFETEsp IHsKPiArCQlkcm1fbW9kZXNldF9iYWNrb2ZmKCZjdHgpOwo+ICsJCWdvdG8gcmV0cnk7Cj4gKwl9 Cj4gKwo+ICsJaWYgKFdBUk5fT04ocmV0IDwgMCkpCj4gKwkJcmV0ID0gY29ubmVjdG9yX3N0YXR1 c191bmtub3duOwo+ICsKPiArCWRybV9tb2Rlc2V0X2Ryb3BfbG9ja3MoJmN0eCk7Cj4gKwlkcm1f bW9kZXNldF9hY3F1aXJlX2ZpbmkoJmN0eCk7Cj4gKwo+ICsJcmV0dXJuIHJldDsKPiArfQoKWy4u Ll0KCj4gIAkvKioKPiArCSAqIEBkZXRlY3RfY3R4Ogo+ICsJICoKPiArCSAqIENoZWNrIHRvIHNl ZSBpZiBhbnl0aGluZyBpcyBhdHRhY2hlZCB0byB0aGUgY29ubmVjdG9yLiBUaGUgcGFyYW1ldGVy Cj4gKwkgKiBmb3JjZSBpcyBzZXQgdG8gZmFsc2Ugd2hpbHN0IHBvbGxpbmcsIHRydWUgd2hlbiBj aGVja2luZyB0aGUKPiArCSAqIGNvbm5lY3RvciBkdWUgdG8gYSB1c2VyIHJlcXVlc3QuIGZvcmNl IGNhbiBiZSB1c2VkIGJ5IHRoZSBkcml2ZXIgdG8KPiArCSAqIGF2b2lkIGV4cGVuc2l2ZSwgZGVz dHJ1Y3RpdmUgb3BlcmF0aW9ucyBkdXJpbmcgYXV0b21hdGVkIHByb2JpbmcuCj4gKwkgKgo+ICsJ ICogVGhpcyBjYWxsYmFjayBpcyBvcHRpb25hbCwgaWYgbm90IGltcGxlbWVudGVkIHRoZSBjb25u ZWN0b3Igd2lsbCBiZQo+ICsJICogY29uc2lkZXJlZCBhcyBhbHdheXMgYmVpbmcgYXR0YWNoZWQu Cj4gKwkgKgo+ICsJICogVGhpcyBpcyB0aGUgYXRvbWljIHZlcnNpb24gb2YgJmRybV9jb25uZWN0 b3JfZnVuY3MuZGV0ZWN0Lgo+ICsJICoKPiArCSAqIFRvIGF2b2lkIHJhY2VzIGFnYWluc3QgY29u Y3VycmVudCBjb25uZWN0b3Igc3RhdGUgdXBkYXRlcywgdGhlCj4gKwkgKiBoZWxwZXIgbGlicmFy aWVzIGFsd2F5cyBjYWxsIHRoaXMgd2l0aCBjdHggc2V0IHRvIGEgdmFsaWQgY29udGV4dCwKPiAr CSAqIGFuZCAmZHJtX21vZGVfY29uZmlnLmNvbm5lY3Rpb25fbXV0ZXggd2lsbCBhbHdheXMgYmUg bG9ja2VkIHdpdGgKPiArCSAqIHRoZSBjdHggcGFyYW1ldGVyIHNldCB0byB0aGlzIGN0eC4gVGhp cyBhbGxvd3MgdGFraW5nIGFkZGl0aW9uYWwKPiArCSAqIGxvY2tzIGFzIHJlcXVpcmVkLgo+ICsJ ICoKPiArCSAqIFJFVFVSTlM6Cj4gKwkgKgo+ICsJICogJmRybV9jb25uZWN0b3Jfc3RhdHVzIGlu ZGljYXRpbmcgdGhlIGNvbm5lY3RvcidzIHN0YXR1cywKPiArCSAqIG9yIHRoZSBlcnJvciBjb2Rl IHJldHVybmVkIGJ5IGRybV9tb2Rlc2V0X2xvY2soKSwgLUVERUFETEsuCj4gKwkgKi8KPiArCWlu dCAoKmRldGVjdF9jdHgpKHN0cnVjdCBkcm1fY29ubmVjdG9yICpjb25uZWN0b3IsCj4gKwkJCSAg c3RydWN0IGRybV9tb2Rlc2V0X2FjcXVpcmVfY3R4ICpjdHgsCj4gKwkJCSAgYm9vbCBmb3JjZSk7 CgpBRkFJVSAoY29ycmVjdCBtZSBpZiBJJ20gd3JvbmcpLCB0aG9zZSB3aG8gZG9uJ3QgY2FyZSBh Ym91dCB0aGUgY3R4CmJlY2F1c2UgdGhleSBkb24ndCBuZWVkIHRvIHRha2UgZXh0cmEgbG9ja3Mg Y2FuIGp1c3QgaWdub3JlIGl0LiBJZiB0aGlzCmlzIHRoZSBjYXNlLCBJIHdvbmRlciBpZiB3ZSBz aG91bGRuJ3QgcGF0Y2ggYWxsIGRyaXZlcnMgdG8gdXNlIHRoZSBuZXcKcHJvdG90eXBlIGluc3Rl YWQgb2YgYWRkaW5nIGEgbmV3IG1ldGhvZCAod2hpY2ggYWRkcyB0byB0aGUgRFJNIEFQSQpjb21w bGV4aXR5LCBldmVuIGlmIGl0J3Mgd2VsbCBkb2N1bWVudGVkIDstKSkuCgpBbnl3YXksIHRoaXMg aXMganVzdCBteSBvcGluaW9uLCBhbmQgRGFuaWVsIHdhcyBva2F5IHdpdGggdGhhdCwgc28KZG9u J3QgYm90aGVyIGNoYW5naW5nIHRoYXQgcmlnaHQgbm93LgoKUmVnYXJkcywKCkJvcmlzCl9fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWls aW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZy ZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo=