From: Edward O'Callaghan Subject: [libdrm] amdgpu/: concisely && consistently check null ptrs in canonical form Date: Wed, 19 Apr 2017 02:20:32 +1000 Message-ID: <20170418162032.16101-1-funfunctor@folklore1984.net> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: amd-gfx-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Sender: "amd-gfx" To: amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org QmUgY29uc2lzdGVudCBhbmQgdXNlIHRoZSBjYW5vbmljYWwgZm9ybSB3aGlsZSBzYW5pdHkgY2hl Y2tpbmcKbnVsbCBwb2ludGVycywgYWxzbyBjb21iaW5lIGEgZmV3IGJyYW5jaGVzIGZvciBicmV2 aXR5LgoKU2lnbmVkLW9mZi1ieTogRWR3YXJkIE8nQ2FsbGFnaGFuIDxmdW5mdW5jdG9yQGZvbGts b3JlMTk4NC5uZXQ+Ci0tLQogYW1kZ3B1L2FtZGdwdV9iby5jICAgICAgIHwgIDIgKy0KIGFtZGdw dS9hbWRncHVfY3MuYyAgICAgICB8IDM2ICsrKysrKysrKysrLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLQogYW1kZ3B1L2FtZGdwdV9ncHVfaW5mby5jIHwgIDUgKysrLS0KIDMgZmlsZXMgY2hhbmdl ZCwgMTUgaW5zZXJ0aW9ucygrKSwgMjggZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvYW1kZ3B1 L2FtZGdwdV9iby5jIGIvYW1kZ3B1L2FtZGdwdV9iby5jCmluZGV4IDlhZGZmZmEuLjVhYzQ1NmIg MTAwNjQ0Ci0tLSBhL2FtZGdwdS9hbWRncHVfYm8uYworKysgYi9hbWRncHUvYW1kZ3B1X2JvLmMK QEAgLTY1Miw3ICs2NTIsNyBAQCBpbnQgYW1kZ3B1X2JvX2xpc3RfdXBkYXRlKGFtZGdwdV9ib19s aXN0X2hhbmRsZSBoYW5kbGUsCiAJCXJldHVybiAtRUlOVkFMOwogCiAJbGlzdCA9IG1hbGxvYyhu dW1iZXJfb2ZfcmVzb3VyY2VzICogc2l6ZW9mKHN0cnVjdCBkcm1fYW1kZ3B1X2JvX2xpc3RfZW50 cnkpKTsKLQlpZiAobGlzdCA9PSBOVUxMKQorCWlmICghbGlzdCkKIAkJcmV0dXJuIC1FTk9NRU07 CiAKIAlhcmdzLmluLm9wZXJhdGlvbiA9IEFNREdQVV9CT19MSVNUX09QX1VQREFURTsKZGlmZiAt LWdpdCBhL2FtZGdwdS9hbWRncHVfY3MuYyBiL2FtZGdwdS9hbWRncHVfY3MuYwppbmRleCBmYjVi M2E4Li43ZmJiYTk2IDEwMDY0NAotLS0gYS9hbWRncHUvYW1kZ3B1X2NzLmMKKysrIGIvYW1kZ3B1 L2FtZGdwdV9jcy5jCkBAIC01OSwxMyArNTksMTEgQEAgaW50IGFtZGdwdV9jc19jdHhfY3JlYXRl KGFtZGdwdV9kZXZpY2VfaGFuZGxlIGRldiwKIAlpbnQgaSwgaiwgazsKIAlpbnQgcjsKIAotCWlm IChOVUxMID09IGRldikKLQkJcmV0dXJuIC1FSU5WQUw7Ci0JaWYgKE5VTEwgPT0gY29udGV4dCkK KwlpZiAoIWRldiB8fCAhY29udGV4dCkKIAkJcmV0dXJuIC1FSU5WQUw7CiAKIAlncHVfY29udGV4 dCA9IGNhbGxvYygxLCBzaXplb2Yoc3RydWN0IGFtZGdwdV9jb250ZXh0KSk7Ci0JaWYgKE5VTEwg PT0gZ3B1X2NvbnRleHQpCisJaWYgKCFncHVfY29udGV4dCkKIAkJcmV0dXJuIC1FTk9NRU07CiAK IAlncHVfY29udGV4dC0+ZGV2ID0gZGV2OwpAQCAtMTEwLDcgKzEwOCw3IEBAIGludCBhbWRncHVf Y3NfY3R4X2ZyZWUoYW1kZ3B1X2NvbnRleHRfaGFuZGxlIGNvbnRleHQpCiAJaW50IGksIGosIGs7 CiAJaW50IHI7CiAKLQlpZiAoTlVMTCA9PSBjb250ZXh0KQorCWlmICghY29udGV4dCkKIAkJcmV0 dXJuIC1FSU5WQUw7CiAKIAlwdGhyZWFkX211dGV4X2Rlc3Ryb3koJmNvbnRleHQtPnNlcXVlbmNl X211dGV4KTsKQEAgLTMzMCw5ICszMjgsNyBAQCBpbnQgYW1kZ3B1X2NzX3N1Ym1pdChhbWRncHVf Y29udGV4dF9oYW5kbGUgY29udGV4dCwKIAl1aW50MzJfdCBpOwogCWludCByOwogCi0JaWYgKE5V TEwgPT0gY29udGV4dCkKLQkJcmV0dXJuIC1FSU5WQUw7Ci0JaWYgKE5VTEwgPT0gaWJzX3JlcXVl c3QpCisJaWYgKCFjb250ZXh0IHx8ICFpYnNfcmVxdWVzdCkKIAkJcmV0dXJuIC1FSU5WQUw7CiAK IAlyID0gMDsKQEAgLTQxNiwxMSArNDEyLDcgQEAgaW50IGFtZGdwdV9jc19xdWVyeV9mZW5jZV9z dGF0dXMoc3RydWN0IGFtZGdwdV9jc19mZW5jZSAqZmVuY2UsCiAJYm9vbCBidXN5ID0gdHJ1ZTsK IAlpbnQgcjsKIAotCWlmIChOVUxMID09IGZlbmNlKQotCQlyZXR1cm4gLUVJTlZBTDsKLQlpZiAo TlVMTCA9PSBleHBpcmVkKQotCQlyZXR1cm4gLUVJTlZBTDsKLQlpZiAoTlVMTCA9PSBmZW5jZS0+ Y29udGV4dCkKKwlpZiAoIWZlbmNlIHx8ICFleHBpcmVkIHx8ICFmZW5jZS0+Y29udGV4dCkKIAkJ cmV0dXJuIC1FSU5WQUw7CiAJaWYgKGZlbmNlLT5pcF90eXBlID49IEFNREdQVV9IV19JUF9OVU0p CiAJCXJldHVybiAtRUlOVkFMOwpAQCAtNDQ3LDExICs0MzksMTEgQEAgaW50IGFtZGdwdV9jc19j cmVhdGVfc2VtYXBob3JlKGFtZGdwdV9zZW1hcGhvcmVfaGFuZGxlICpzZW0pCiB7CiAJc3RydWN0 IGFtZGdwdV9zZW1hcGhvcmUgKmdwdV9zZW1hcGhvcmU7CiAKLQlpZiAoTlVMTCA9PSBzZW0pCisJ aWYgKCFzZW0pCiAJCXJldHVybiAtRUlOVkFMOwogCiAJZ3B1X3NlbWFwaG9yZSA9IGNhbGxvYygx LCBzaXplb2Yoc3RydWN0IGFtZGdwdV9zZW1hcGhvcmUpKTsKLQlpZiAoTlVMTCA9PSBncHVfc2Vt YXBob3JlKQorCWlmICghZ3B1X3NlbWFwaG9yZSkKIAkJcmV0dXJuIC1FTk9NRU07CiAKIAlhdG9t aWNfc2V0KCZncHVfc2VtYXBob3JlLT5yZWZjb3VudCwgMSk7CkBAIC00NjYsMTQgKzQ1OCwxMiBA QCBpbnQgYW1kZ3B1X2NzX3NpZ25hbF9zZW1hcGhvcmUoYW1kZ3B1X2NvbnRleHRfaGFuZGxlIGN0 eCwKIAkJCSAgICAgICB1aW50MzJfdCByaW5nLAogCQkJICAgICAgIGFtZGdwdV9zZW1hcGhvcmVf aGFuZGxlIHNlbSkKIHsKLQlpZiAoTlVMTCA9PSBjdHgpCisJaWYgKCFjdHggfHwgIXNlbSkKIAkJ cmV0dXJuIC1FSU5WQUw7CiAJaWYgKGlwX3R5cGUgPj0gQU1ER1BVX0hXX0lQX05VTSkKIAkJcmV0 dXJuIC1FSU5WQUw7CiAJaWYgKHJpbmcgPj0gQU1ER1BVX0NTX01BWF9SSU5HUykKIAkJcmV0dXJu IC1FSU5WQUw7Ci0JaWYgKE5VTEwgPT0gc2VtKQotCQlyZXR1cm4gLUVJTlZBTDsKIAkvKiBzZW0g aGFzIGJlZW4gc2lnbmFsZWQgKi8KIAlpZiAoc2VtLT5zaWduYWxfZmVuY2UuY29udGV4dCkKIAkJ cmV0dXJuIC1FSU5WQUw7CkBAIC00OTQsMTQgKzQ4NCwxMiBAQCBpbnQgYW1kZ3B1X2NzX3dhaXRf c2VtYXBob3JlKGFtZGdwdV9jb250ZXh0X2hhbmRsZSBjdHgsCiAJCQkgICAgIHVpbnQzMl90IHJp bmcsCiAJCQkgICAgIGFtZGdwdV9zZW1hcGhvcmVfaGFuZGxlIHNlbSkKIHsKLQlpZiAoTlVMTCA9 PSBjdHgpCisJaWYgKCFjdHggfHwgIXNlbSkKIAkJcmV0dXJuIC1FSU5WQUw7CiAJaWYgKGlwX3R5 cGUgPj0gQU1ER1BVX0hXX0lQX05VTSkKIAkJcmV0dXJuIC1FSU5WQUw7CiAJaWYgKHJpbmcgPj0g QU1ER1BVX0NTX01BWF9SSU5HUykKIAkJcmV0dXJuIC1FSU5WQUw7Ci0JaWYgKE5VTEwgPT0gc2Vt KQotCQlyZXR1cm4gLUVJTlZBTDsKIAkvKiBtdXN0IHNpZ25hbCBmaXJzdCAqLwogCWlmIChOVUxM ID09IHNlbS0+c2lnbmFsX2ZlbmNlLmNvbnRleHQpCiAJCXJldHVybiAtRUlOVkFMOwpAQCAtNTE0 LDkgKzUwMiw3IEBAIGludCBhbWRncHVfY3Nfd2FpdF9zZW1hcGhvcmUoYW1kZ3B1X2NvbnRleHRf aGFuZGxlIGN0eCwKIAogc3RhdGljIGludCBhbWRncHVfY3NfcmVzZXRfc2VtKGFtZGdwdV9zZW1h cGhvcmVfaGFuZGxlIHNlbSkKIHsKLQlpZiAoTlVMTCA9PSBzZW0pCi0JCXJldHVybiAtRUlOVkFM OwotCWlmIChOVUxMID09IHNlbS0+c2lnbmFsX2ZlbmNlLmNvbnRleHQpCisJaWYgKCFzZW0gfHwg IXNlbS0+c2lnbmFsX2ZlbmNlLmNvbnRleHQpCiAJCXJldHVybiAtRUlOVkFMOwogCiAJc2VtLT5z aWduYWxfZmVuY2UuY29udGV4dCA9IE5VTEw7OwpAQCAtNTMwLDcgKzUxNiw3IEBAIHN0YXRpYyBp bnQgYW1kZ3B1X2NzX3Jlc2V0X3NlbShhbWRncHVfc2VtYXBob3JlX2hhbmRsZSBzZW0pCiAKIHN0 YXRpYyBpbnQgYW1kZ3B1X2NzX3VucmVmZXJlbmNlX3NlbShhbWRncHVfc2VtYXBob3JlX2hhbmRs ZSBzZW0pCiB7Ci0JaWYgKE5VTEwgPT0gc2VtKQorCWlmICghc2VtKQogCQlyZXR1cm4gLUVJTlZB TDsKIAogCWlmICh1cGRhdGVfcmVmZXJlbmNlcygmc2VtLT5yZWZjb3VudCwgTlVMTCkpCmRpZmYg LS1naXQgYS9hbWRncHUvYW1kZ3B1X2dwdV9pbmZvLmMgYi9hbWRncHUvYW1kZ3B1X2dwdV9pbmZv LmMKaW5kZXggZjRiOTRjOS4uMWVmZmZjNiAxMDA2NDQKLS0tIGEvYW1kZ3B1L2FtZGdwdV9ncHVf aW5mby5jCisrKyBiL2FtZGdwdS9hbWRncHVfZ3B1X2luZm8uYwpAQCAtMjM0LDggKzIzNCw5IEBA IGRybV9wcml2YXRlIGludCBhbWRncHVfcXVlcnlfZ3B1X2luZm9faW5pdChhbWRncHVfZGV2aWNl X2hhbmRsZSBkZXYpCiBpbnQgYW1kZ3B1X3F1ZXJ5X2dwdV9pbmZvKGFtZGdwdV9kZXZpY2VfaGFu ZGxlIGRldiwKIAkJCXN0cnVjdCBhbWRncHVfZ3B1X2luZm8gKmluZm8pCiB7Ci0JaWYgKChkZXYg PT0gTlVMTCkgfHwgKGluZm8gPT0gTlVMTCkpCisJaWYgKCFkZXYgfHwgIWluZm8pCiAJCXJldHVy biAtRUlOVkFMOworCiAJLyogR2V0IEFTSUMgaW5mbyovCiAJKmluZm8gPSBkZXYtPmluZm87CiAK QEAgLTMwMCw3ICszMDEsNyBAQCBpbnQgYW1kZ3B1X3F1ZXJ5X2dkc19pbmZvKGFtZGdwdV9kZXZp Y2VfaGFuZGxlIGRldiwKIAlzdHJ1Y3QgZHJtX2FtZGdwdV9pbmZvX2dkcyBnZHNfY29uZmlnID0g e307CiAgICAgICAgIGludCByOwogCi0JaWYgKGdkc19pbmZvID09IE5VTEwpCisJaWYgKCFnZHNf aW5mbykKIAkJcmV0dXJuIC1FSU5WQUw7CiAKICAgICAgICAgciA9IGFtZGdwdV9xdWVyeV9pbmZv KGRldiwgQU1ER1BVX0lORk9fR0RTX0NPTkZJRywKLS0gCjIuOS4zCgpfX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwphbWQtZ2Z4IG1haWxpbmcgbGlzdAphbWQt Z2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9t YWlsbWFuL2xpc3RpbmZvL2FtZC1nZngK