From: Jan Kara Date: Mon, 24 Apr 2017 17:56:14 +0200 Subject: [Cluster-devel] [PATCH v3 08/20] mm: ensure that we set mapping error if writeout() fails In-Reply-To: <20170424132259.8680-9-jlayton@redhat.com> References: <20170424132259.8680-1-jlayton@redhat.com> <20170424132259.8680-9-jlayton@redhat.com> Message-ID: <20170424155614.GI23988@quack2.suse.cz> List-Id: To: cluster-devel.redhat.com MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On Mon 24-04-17 09:22:47, Jeff Layton wrote: > If writepage fails during a page migration, then we need to ensure that > fsync will see it by flagging the mapping. > > Signed-off-by: Jeff Layton Looks good to me. You can add: Reviewed-by: Jan Kara Honza > --- > mm/migrate.c | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/mm/migrate.c b/mm/migrate.c > index 738f1d5f8350..3a59830bdae2 100644 > --- a/mm/migrate.c > +++ b/mm/migrate.c > @@ -792,7 +792,11 @@ static int writeout(struct address_space *mapping, struct page *page) > /* unlocked. Relock */ > lock_page(page); > > - return (rc < 0) ? -EIO : -EAGAIN; > + if (rc < 0) { > + mapping_set_error(mapping, rc); > + return -EIO; > + } > + return -EAGAIN; > } > > /* > -- > 2.9.3 > > -- Jan Kara SUSE Labs, CR