From: Jan Kara Date: Mon, 24 Apr 2017 17:57:55 +0200 Subject: [Cluster-devel] [PATCH v3 09/20] 9p: set mapping error when writeback fails in launder_page In-Reply-To: <20170424132259.8680-10-jlayton@redhat.com> References: <20170424132259.8680-1-jlayton@redhat.com> <20170424132259.8680-10-jlayton@redhat.com> Message-ID: <20170424155755.GJ23988@quack2.suse.cz> List-Id: To: cluster-devel.redhat.com MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On Mon 24-04-17 09:22:48, Jeff Layton wrote: > launder_page is just writeback under the page lock. We still need to > mark the mapping for errors there when they occur. > > Signed-off-by: Jeff Layton Looks good. You can add: Reviewed-by: Jan Kara Honza > --- > fs/9p/vfs_addr.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/fs/9p/vfs_addr.c b/fs/9p/vfs_addr.c > index adaf6f6dd858..7af6e6501698 100644 > --- a/fs/9p/vfs_addr.c > +++ b/fs/9p/vfs_addr.c > @@ -223,8 +223,11 @@ static int v9fs_launder_page(struct page *page) > v9fs_fscache_wait_on_page_write(inode, page); > if (clear_page_dirty_for_io(page)) { > retval = v9fs_vfs_writepage_locked(page); > - if (retval) > + if (retval) { > + if (retval != -EAGAIN) > + mapping_set_error(page->mapping, retval); > return retval; > + } > } > return 0; > } > -- > 2.9.3 > > -- Jan Kara SUSE Labs, CR