From: Brian Starkey Subject: Re: [PATCH i-g-t 7/7] lib/igt_kms: Use kernel command line mode if specified Date: Tue, 25 Apr 2017 18:06:39 +0100 Message-ID: <20170425170638.GA2414@e106950-lin.cambridge.arm.com> References: <1493138713-2319-1-git-send-email-brian.starkey@arm.com> <1493138713-2319-8-git-send-email-brian.starkey@arm.com> <20170425165817.GQ30290@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from foss.arm.com (foss.arm.com [217.140.101.70]) by gabe.freedesktop.org (Postfix) with ESMTP id 7A3276E09A for ; Tue, 25 Apr 2017 17:06:45 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20170425165817.GQ30290@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Cc: intel-gfx@lists.freedesktop.org, liviu.dudau@arm.com List-Id: intel-gfx@lists.freedesktop.org T24gVHVlLCBBcHIgMjUsIDIwMTcgYXQgMDc6NTg6MThQTSArMDMwMCwgVmlsbGUgU3lyasOkbMOk IHdyb3RlOgo+T24gVHVlLCBBcHIgMjUsIDIwMTcgYXQgMDU6NDU6MTNQTSArMDEwMCwgQnJpYW4g U3RhcmtleSB3cm90ZToKPj4gSWYgInZpZGVvPSIgaXMgc3BlY2lmaWVkIG9uIHRoZSBrZXJuZWwg Y29tbWFuZC1saW5lLCB1c2UgaXQgdG8gb3ZlcnJpZGUKPj4gdGhlIGRlZmF1bHQgbW9kZSBpbiBr bXN0ZXN0X2dldF9jb25uZWN0b3JfZGVmYXVsdF9tb2RlLgo+Pgo+PiBJZiBhIG1vZGUgb3ZlcnJp ZGUgd2FzIHByb3ZpZGVkIG9uIHRoZSBjb21tYW5kLWxpbmUsIGl0IHdhcyBwcm9iYWJseSBmb3IK Pj4gZ29vZCByZWFzb24gc28gd2Ugc2hvdWxkIGhvbm9yIGl0Lgo+Cj5Jc24ndCB0aGUga2VybmVs IG1hcmtpbmcgdGhlIGNtZGxpbmUgbW9kZSBhcyBwcmVmZXJyZWQgYWxyZWFkeT8gQW5kIGlmCj5u b3QsIG1heWJlIGl0IHNob3VsZC4KPgoKSXQgZG9lc24ndCBhcyBmYXIgYXMgSSd2ZSBzZWVuLiBJ dCB1c2VzIHRoZSBjbWRsaW5lIG1vZGUgZm9yIHNldHRpbmcKdXAgdGhlIGZiZGV2IGVtdWxhdGlv biBidXQgSSBkb24ndCB0aGluayBpdCBtYXJrcyB0aGUgbW9kZSBsaXN0IChvciB3ZQphcmVuJ3Qg Y2FsbGluZyB0aGUgaGVscGVyIHRoYXQgZG9lcyBpdCkuCgpJJ2xsIGhhdmUgYSBsb29rIGF0IHdo YXQgaXQgd291bGQgdGFrZSB0byBkbyB0aGF0LgoKLUJyaWFuCgo+Pgo+PiBTaWduZWQtb2ZmLWJ5 OiBCcmlhbiBTdGFya2V5IDxicmlhbi5zdGFya2V5QGFybS5jb20+Cj4+IC0tLQo+PiAgbGliL2ln dF9rbXMuYyB8ICAxMzUgKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysr KysrKysrKysrKysrKysrCj4+ICAxIGZpbGUgY2hhbmdlZCwgMTM1IGluc2VydGlvbnMoKykKPj4K Pj4gZGlmZiAtLWdpdCBhL2xpYi9pZ3Rfa21zLmMgYi9saWIvaWd0X2ttcy5jCj4+IGluZGV4IDQ3 NGFhMDA1YjlmYS4uOTdmODBhNDYzNTRkIDEwMDY0NAo+PiAtLS0gYS9saWIvaWd0X2ttcy5jCj4+ ICsrKyBiL2xpYi9pZ3Rfa21zLmMKPj4gQEAgLTc2Niw2ICs3NjYsMTMxIEBAIHZvaWQga21zdGVz dF9mb3JjZV9lZGlkKGludCBkcm1fZmQsIGRybU1vZGVDb25uZWN0b3IgKmNvbm5lY3RvciwKPj4g IAlpZ3RfYXNzZXJ0KHJldCAhPSAtMSk7Cj4+ICB9Cj4+Cj4+ICsvKgo+PiArICogRXh0cmFjdCB4 cmVzLCB5cmVzLCByZWZyZXNoIGFuZCBpbnRlcmxhY2VkIGZyb20gYSBzdHJpbmcgb2YgdGhlIGZv cm06Cj4+ICsgKiAgIDx4cmVzPng8eXJlcz5bTV1bUl1bLTxicHA+XVtAPHJlZnJlc2g+XVtpXVtt XVtlRGRdCj4+ICsgKiB4cmVzIGFuZCB5cmVzIG11c3QgYmUgc3BlY2lmaWVkLCByZWZyZXNoIGlz IG9wdGlvbmFsIGFuZCB3aWxsIGJlIHNldCB0bwo+PiArICogLTEgaWYgbm90IHByZXNlbnQuIGlu dGVybGFjZWQgZGVmYXVsdHMgdG8gZmFsc2UuCj4+ICsgKi8KPj4gK3N0YXRpYyBpbnQgcGFyc2Vf Y21kbGluZV9tb2RlKGNoYXIgKnZpZGVvX3N0ciwgdW5zaWduZWQgaW50ICp4cmVzLAo+PiArCQkJ ICAgICAgdW5zaWduZWQgaW50ICp5cmVzLAo+PiArCQkJICAgICAgaW50ICpyZWZyZXNoLCBib29s ICppbnRlcmxhY2VkKQo+PiArewo+PiArCWludCBtYXRjaCwgbGVuID0gc3RybGVuKHZpZGVvX3N0 cik7Cj4+ICsJY2hhciAqdG9rZW4gPSBzdHJ0b2sodmlkZW9fc3RyLCAiQCIpOwo+PiArCj4+ICsJ aWYgKCF0b2tlbikKPj4gKwkJcmV0dXJuIC0xOwo+PiArCj4+ICsJKmludGVybGFjZWQgPSBmYWxz ZTsKPj4gKwkqcmVmcmVzaCA9IC0xOwo+PiArCj4+ICsJbWF0Y2ggPSBzc2NhbmYodG9rZW4sICIl ZHglZCIsIHhyZXMsIHlyZXMpOwo+PiArCWlmIChtYXRjaCAhPSAyKQo+PiArCQlyZXR1cm4gLTE7 Cj4+ICsKPj4gKwlpZiAoc3RybGVuKHRva2VuKSA8IGxlbiAtIDEpIHsKPj4gKwkJdG9rZW4gKz0g c3RybGVuKHRva2VuKSArIDE7Cj4+ICsKPj4gKwkJbWF0Y2ggPSBzc2NhbmYodG9rZW4sICIlZCIs IHJlZnJlc2gpOwo+PiArCQlpZiAobWF0Y2ggIT0gMSB8fCAoKnJlZnJlc2ggPCAwKSkKPj4gKwkJ CXJldHVybiAtMTsKPj4gKwo+PiArCQlpZiAoc3RyY2hyKHRva2VuLCAnaScpKQo+PiArCQkJKmlu dGVybGFjZWQgPSB0cnVlOwo+PiArCX0KPj4gKwo+PiArCXJldHVybiAwOwo+PiArfQo+PiArCj4+ ICtzdGF0aWMgY29uc3QgZHJtTW9kZU1vZGVJbmZvICoKPj4gK2Nvbm5lY3Rvcl9tYXRjaF9jbWRs aW5lX21vZGUoY29uc3QgZHJtTW9kZUNvbm5lY3RvciAqY29ubmVjdG9yLAo+PiArCQkJICAgICB1 bnNpZ25lZCBpbnQgeHJlcywgdW5zaWduZWQgaW50IHlyZXMsIGludCByZWZyZXNoLAo+PiArCQkJ ICAgICBib29sIGludGVybGFjZWQpCj4+ICt7Cj4+ICsJY29uc3QgZHJtTW9kZU1vZGVJbmZvICpt b2RlID0gTlVMTDsKPj4gKwlpbnQgaTsKPj4gKwo+PiArCWZvciAoaSA9IDA7IGkgPCBjb25uZWN0 b3ItPmNvdW50X21vZGVzOyBpKyspIHsKPj4gKwkJbW9kZSA9ICZjb25uZWN0b3ItPm1vZGVzW2ld Owo+PiArCQlpZiAobW9kZS0+aGRpc3BsYXkgPT0geHJlcyAmJgo+PiArCQkgICAgbW9kZS0+dmRp c3BsYXkgPT0geXJlcyAmJgo+PiArCQkgICAgKHJlZnJlc2ggPCAwIHx8IHJlZnJlc2ggPT0gbW9k ZS0+dnJlZnJlc2gpICYmCj4+ICsJCSAgICBpbnRlcmxhY2VkID09ICEhKG1vZGUtPmZsYWdzICYg RFJNX01PREVfRkxBR19JTlRFUkxBQ0UpKQo+PiArCQkJcmV0dXJuIG1vZGU7Cj4+ICsJfQo+PiAr Cj4+ICsJcmV0dXJuIE5VTEw7Cj4+ICt9Cj4+ICsKPj4gK3N0YXRpYyBjb25zdCBkcm1Nb2RlTW9k ZUluZm8gKgo+PiAra21zdGVzdF9nZXRfY21kbGluZV9tb2RlKGludCBkcm1fZmQsIGRybU1vZGVD b25uZWN0b3IgKmNvbm5lY3RvcikKPj4gK3sKPj4gKwljaGFyIGMsICpzdHIgPSBOVUxMLCAqY3Vy c29yLCAqY29ubl9uYW1lID0gTlVMTDsKPj4gKwljb25zdCBkcm1Nb2RlTW9kZUluZm8gKm1vZGUg PSBOVUxMOwo+PiArCXVuc2lnbmVkIGludCBzaXplID0gMDsKPj4gKwlGSUxFICpmcCA9IE5VTEw7 Cj4+ICsKPj4gKwlmcCA9IGZvcGVuKCIvcHJvYy9jbWRsaW5lIiwgInIiKTsKPj4gKwlpZiAoIWZw KQo+PiArCQlyZXR1cm4gTlVMTDsKPj4gKwo+PiArCS8qIGxzZWVrL2ZzZWVrK2Z0ZWxsL3N0YXQg ZG9uJ3Qgd29yayBvbiAvcHJvYy9jbWRsaW5lICovCj4+ICsJd2hpbGUgKGZyZWFkKCZjLCAxLCAx LCBmcCkpCj4+ICsJCXNpemUrKzsKPj4gKwlyZXdpbmQoZnApOwo+PiArCj4+ICsJc3RyID0gY2Fs bG9jKDEsIHNpemUgKyAxKTsKPj4gKwlpZiAoIXN0cikKPj4gKwkJZ290byBkb25lOwo+PiArCj4+ ICsJaWYgKGZyZWFkKHN0ciwgMSwgc2l6ZSwgZnApICE9IHNpemUpCj4+ICsJCWdvdG8gZG9uZTsK Pj4gKwo+PiArCWlmICghYXNwcmludGYoJmNvbm5fbmFtZSwgIiVzLSVkOiIsCj4+ICsJCSAgICAg IGttc3Rlc3RfY29ubmVjdG9yX3R5cGVfc3RyKGNvbm5lY3Rvci0+Y29ubmVjdG9yX3R5cGUpLAo+ PiArCQkgICAgICBjb25uZWN0b3ItPmNvbm5lY3Rvcl90eXBlX2lkKSkKPj4gKwkJZ290byBkb25l Owo+PiArCj4+ICsJY3Vyc29yID0gc3RyOwo+PiArCXdoaWxlICgoY3Vyc29yID0gc3Ryc3RyKGN1 cnNvciwgInZpZGVvPSIpKSkgewo+PiArCQl1bnNpZ25lZCBpbnQgeHJlcywgeXJlczsKPj4gKwkJ Ym9vbCBpbnRlcmxhY2VkOwo+PiArCQlpbnQgcmVmcmVzaDsKPj4gKwo+PiArCQljdXJzb3IgKz0g c3RybGVuKCJ2aWRlbz0iKTsKPj4gKwkJY3Vyc29yID0gc3RydG9rKGN1cnNvciwgIiBcbiIpOwo+ PiArCQlpZiAoIWN1cnNvcikKPj4gKwkJCWJyZWFrOwo+PiArCj4+ICsJCS8qIFN0cmlwIHRoZSBu YW1lIGlmIGl0IG1hdGNoZXMgb3VycyAqLwo+PiArCQlpZiAoIXN0cm5jbXAoY3Vyc29yLCBjb25u X25hbWUsIHN0cmxlbihjb25uX25hbWUpKSkKPj4gKwkJCWN1cnNvciArPSBzdHJsZW4oY29ubl9u YW1lKTsKPj4gKwo+PiArCQkvKgo+PiArCQkgKiBDb25zaWRlciB0aGlzICJ2aWRlbz0iIHNwZWNp ZmljYXRpb24gb25seSBpZiBpdCBoYXMgbm8KPj4gKwkJICogbmFtZS4gSWYgdGhlIG5hbWUgbWF0 Y2hlZCwgd2Ugd291bGQgaGF2ZSBhbHJlYWR5IHN0cmlwcGVkIGl0Cj4+ICsJCSAqIGFib3ZlCj4+ ICsJCSAqLwo+PiArCQlpZiAoIXN0cnN0cihjdXJzb3IsICI6IikgJiYKPj4gKwkJICAgICFwYXJz ZV9jbWRsaW5lX21vZGUoY3Vyc29yLCAmeHJlcywgJnlyZXMsICZyZWZyZXNoLCAmaW50ZXJsYWNl ZCkpIHsKPj4gKwkJCW1vZGUgPSBjb25uZWN0b3JfbWF0Y2hfY21kbGluZV9tb2RlKGNvbm5lY3Rv ciwgeHJlcywKPj4gKwkJCQkJCQkgICAgeXJlcywgcmVmcmVzaCwKPj4gKwkJCQkJCQkgICAgaW50 ZXJsYWNlZCk7Cj4+ICsJCQlpZiAobW9kZSkKPj4gKwkJCQlicmVhazsKPj4gKwkJfQo+PiArCj4+ ICsJCWN1cnNvciArPSBzdHJsZW4oY3Vyc29yKSArIDE7Cj4+ICsJfQo+PiArCj4+ICtkb25lOgo+ PiArCWZyZWUoY29ubl9uYW1lKTsKPj4gKwlmcmVlKHN0cik7Cj4+ICsJZmNsb3NlKGZwKTsKPj4g KwlyZXR1cm4gbW9kZTsKPj4gK30KPj4gKwo+PiAgLyoqCj4+ICAgKiBrbXN0ZXN0X2dldF9jb25u ZWN0b3JfZGVmYXVsdF9tb2RlOgo+PiAgICogQGRybV9mZDogRFJNIGZkCj4+IEBAIC03NzMsNiAr ODk4LDggQEAgdm9pZCBrbXN0ZXN0X2ZvcmNlX2VkaWQoaW50IGRybV9mZCwgZHJtTW9kZUNvbm5l Y3RvciAqY29ubmVjdG9yLAo+PiAgICogQG1vZGU6IGxpYmRybSBtb2RlCj4+ICAgKgo+PiAgICog UmV0cmlldmVzIHRoZSBkZWZhdWx0IG1vZGUgZm9yIEBjb25uZWN0b3IgYW5kIHN0b3JlcyBpdCBp biBAbW9kZS4KPj4gKyAqIElmIHZpZGVvPSBpcyBzcGVjaWZpZWQgKG9wdGlvbmFsbHkgZm9yIHRo aXMgc3BlY2lmaWMgY29ubmVjdG9yKSBvbiB0aGUKPj4gKyAqIGtlcm5lbCBjb21tYW5kIGxpbmUs IHRoZW4gaXQgaXMgdXNlZCBhcyB0aGUgZGVmYXVsdC4KPj4gICAqCj4+ICAgKiBSZXR1cm5zOiB0 cnVlIG9uIHN1Y2Nlc3MsIGZhbHNlIG9uIGZhaWx1cmUKPj4gICAqLwo+PiBAQCAtNzgwLDYgKzkw Nyw3IEBAIGJvb2wga21zdGVzdF9nZXRfY29ubmVjdG9yX2RlZmF1bHRfbW9kZShpbnQgZHJtX2Zk LCBkcm1Nb2RlQ29ubmVjdG9yICpjb25uZWN0b3IsCj4+ICAJCQkJCWRybU1vZGVNb2RlSW5mbyAq bW9kZSkKPj4gIHsKPj4gIAlpbnQgaTsKPj4gKwljb25zdCBkcm1Nb2RlTW9kZUluZm8gKmNtZGxp bmVfbW9kZTsKPj4KPj4gIAlpZiAoIWNvbm5lY3Rvci0+Y291bnRfbW9kZXMpIHsKPj4gIAkJaWd0 X3dhcm4oIm5vIG1vZGVzIGZvciBjb25uZWN0b3IgJWRcbiIsCj4+IEBAIC03ODcsNiArOTE1LDEz IEBAIGJvb2wga21zdGVzdF9nZXRfY29ubmVjdG9yX2RlZmF1bHRfbW9kZShpbnQgZHJtX2ZkLCBk cm1Nb2RlQ29ubmVjdG9yICpjb25uZWN0b3IsCj4+ICAJCXJldHVybiBmYWxzZTsKPj4gIAl9Cj4+ Cj4+ICsJY21kbGluZV9tb2RlID0ga21zdGVzdF9nZXRfY21kbGluZV9tb2RlKGRybV9mZCwgY29u bmVjdG9yKTsKPj4gKwlpZiAoY21kbGluZV9tb2RlKSB7Cj4+ICsJCSptb2RlID0gKmNtZGxpbmVf bW9kZTsKPj4gKwkJaWd0X2RlYnVnKCJVc2luZyBjbWRsaW5lIG1vZGVcbiIpOwo+PiArCQlyZXR1 cm4gdHJ1ZTsKPj4gKwl9Cj4+ICsKPj4gIAlmb3IgKGkgPSAwOyBpIDwgY29ubmVjdG9yLT5jb3Vu dF9tb2RlczsgaSsrKSB7Cj4+ICAJCWlmIChpID09IDAgfHwKPj4gIAkJICAgIGNvbm5lY3Rvci0+ bW9kZXNbaV0udHlwZSAmIERSTV9NT0RFX1RZUEVfUFJFRkVSUkVEKSB7Cj4+IC0tCj4+IDEuNy45 LjUKPj4KPj4gX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18K Pj4gSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdAo+PiBJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Au b3JnCj4+IGh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50 ZWwtZ2Z4Cj4KPi0tIAo+VmlsbGUgU3lyasOkbMOkCj5JbnRlbCBPVEMKX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJ bnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Au b3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg==