From: Imre Deak Subject: Re: [PATCH 5/8] drm/i915: Check error return when converting pipe to connector Date: Wed, 26 Apr 2017 17:20:11 +0300 Message-ID: <20170426142011.GA15301@ideak-desk.fi.intel.com> References: <1493214013-15580-1-git-send-email-imre.deak@intel.com> <1493214013-15580-6-git-send-email-imre.deak@intel.com> <87vaprs1f3.fsf@intel.com> Reply-To: imre.deak@intel.com Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by gabe.freedesktop.org (Postfix) with ESMTPS id 5EAC989A5E for ; Wed, 26 Apr 2017 14:20:14 +0000 (UTC) Content-Disposition: inline In-Reply-To: <87vaprs1f3.fsf@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Jani Nikula Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gV2VkLCBBcHIgMjYsIDIwMTcgYXQgMDU6MTI6MzJQTSArMDMwMCwgSmFuaSBOaWt1bGEgd3Jv dGU6Cj4gT24gV2VkLCAyNiBBcHIgMjAxNywgSW1yZSBEZWFrIDxpbXJlLmRlYWtAaW50ZWwuY29t PiB3cm90ZToKPiA+IEFuIGVycm9yIGZyb20gaW50ZWxfZ2V0X3BpcGVfZnJvbV9jb25uZWN0b3Io KSB3b3VsZCBtZWFuIGEgYnVnIHNvbWV3aGVyZQo+ID4gZWxzZSwgYnV0IHdlIHN0aWxsIHNob3Vs ZCBjaGVjayBmb3IgaXQgdG8gcHJldmVudCBzb21lIG90aGVyIG1vcmUKPiA+IG9ic2N1cmUgYnVn IGxhdGVyLgo+IAo+IERvIGNoZWNrIGZvciBpbnZhbGlkIHBpcGUsIGJ1dCBwbGVhc2UganVzdCBs aW1wIG9uIGluc3RlYWQgb2YgYmFpbGluZwo+IG91dCBvZiB0aGUgZnVuY3Rpb25zLiBTZWUgbm90 ZXMgaW5saW5lLgo+IAo+IEJSLAo+IEphbmkuCj4gCj4gPgo+ID4gU2lnbmVkLW9mZi1ieTogSW1y ZSBEZWFrIDxpbXJlLmRlYWtAaW50ZWwuY29tPgo+ID4gLS0tCj4gPiAgZHJpdmVycy9ncHUvZHJt L2k5MTUvaW50ZWxfcGFuZWwuYyB8IDE0ICsrKysrKysrKysrKy0tCj4gPiAgMSBmaWxlIGNoYW5n ZWQsIDEyIGluc2VydGlvbnMoKyksIDIgZGVsZXRpb25zKC0pCj4gPgo+ID4gZGlmZiAtLWdpdCBh L2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3BhbmVsLmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkx NS9pbnRlbF9wYW5lbC5jCj4gPiBpbmRleCBjYjUwYzUyLi5kYmUwNWVjIDEwMDY0NAo+ID4gLS0t IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfcGFuZWwuYwo+ID4gKysrIGIvZHJpdmVycy9n cHUvZHJtL2k5MTUvaW50ZWxfcGFuZWwuYwo+ID4gQEAgLTg4OCwxMCArODg4LDE0IEBAIHN0YXRp YyB2b2lkIHBjaF9lbmFibGVfYmFja2xpZ2h0KHN0cnVjdCBpbnRlbF9jb25uZWN0b3IgKmNvbm5l Y3RvcikKPiA+ICAJc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2ID0gdG9faTkxNShj b25uZWN0b3ItPmJhc2UuZGV2KTsKPiA+ICAJc3RydWN0IGludGVsX3BhbmVsICpwYW5lbCA9ICZj b25uZWN0b3ItPnBhbmVsOwo+ID4gIAllbnVtIHBpcGUgcGlwZSA9IGludGVsX2dldF9waXBlX2Zy b21fY29ubmVjdG9yKGNvbm5lY3Rvcik7Cj4gPiAtCWVudW0gdHJhbnNjb2RlciBjcHVfdHJhbnNj b2RlciA9Cj4gPiAtCQlpbnRlbF9waXBlX3RvX2NwdV90cmFuc2NvZGVyKGRldl9wcml2LCBwaXBl KTsKPiA+ICsJZW51bSB0cmFuc2NvZGVyIGNwdV90cmFuc2NvZGVyOwo+ID4gIAl1MzIgY3B1X2N0 bDIsIHBjaF9jdGwxLCBwY2hfY3RsMjsKPiA+ICAKPiA+ICsJaWYgKFdBUk5fT05fT05DRShwaXBl ID09IElOVkFMSURfUElQRSkpCj4gPiArCQlyZXR1cm47Cj4gCj4gUGxlYXNlIGp1c3QgYXNzaWdu IGUuZy4gVFJBTlNDT0RFUl9FRFAgdG8gY3B1X3RyYW5zY29kZXIgaW4gdGhpcyBjYXNlLAo+IGdv IG9uLCBhbmQgaG9wZSBmb3IgdGhlIGJlc3QuIERvIGxlYXZlIHRoZSB3YXJuIGluIHBsYWNlIHRo b3VnaC4KPiAKPiA+ICsKPiA+ICsJY3B1X3RyYW5zY29kZXIgPSBpbnRlbF9waXBlX3RvX2NwdV90 cmFuc2NvZGVyKGRldl9wcml2LCBwaXBlKTsKPiA+ICsKPiA+ICAJY3B1X2N0bDIgPSBJOTE1X1JF QUQoQkxDX1BXTV9DUFVfQ1RMMik7Cj4gPiAgCWlmIChjcHVfY3RsMiAmIEJMTV9QV01fRU5BQkxF KSB7Cj4gPiAgCQlEUk1fREVCVUdfS01TKCJjcHUgYmFja2xpZ2h0IGFscmVhZHkgZW5hYmxlZFxu Iik7Cj4gPiBAQCAtOTczLDYgKzk3Nyw5IEBAIHN0YXRpYyB2b2lkIGk5NjVfZW5hYmxlX2JhY2ts aWdodChzdHJ1Y3QgaW50ZWxfY29ubmVjdG9yICpjb25uZWN0b3IpCj4gPiAgCWVudW0gcGlwZSBw aXBlID0gaW50ZWxfZ2V0X3BpcGVfZnJvbV9jb25uZWN0b3IoY29ubmVjdG9yKTsKPiA+ICAJdTMy IGN0bCwgY3RsMiwgZnJlcTsKPiA+ICAKPiA+ICsJaWYgKFdBUk5fT05fT05DRShwaXBlID09IElO VkFMSURfUElQRSkpCj4gPiArCQlyZXR1cm47Cj4gCj4gU2FtZSBoZXJlLCBwbGVhc2UganVzdCBh c3NpZ24gZS5nLiBQSVBFX0EgaGVyZSB3aXRoIHRoZSB3YXJuaW5nLCBhbmQKPiBsaW1wIG9uLgo+ IAo+ID4gKwo+ID4gIAljdGwyID0gSTkxNV9SRUFEKEJMQ19QV01fQ1RMMik7Cj4gPiAgCWlmIChj dGwyICYgQkxNX1BXTV9FTkFCTEUpIHsKPiA+ICAJCURSTV9ERUJVR19LTVMoImJhY2tsaWdodCBh bHJlYWR5IGVuYWJsZWRcbiIpOwo+ID4gQEAgLTEwOTMsNiArMTEwMCw5IEBAIHZvaWQgaW50ZWxf cGFuZWxfZW5hYmxlX2JhY2tsaWdodChzdHJ1Y3QgaW50ZWxfY29ubmVjdG9yICpjb25uZWN0b3Ip Cj4gPiAgCWlmICghcGFuZWwtPmJhY2tsaWdodC5wcmVzZW50KQo+ID4gIAkJcmV0dXJuOwo+ID4g IAo+ID4gKwlpZiAoV0FSTl9PTl9PTkNFKHBpcGUgPT0gSU5WQUxJRF9QSVBFKSkKPiA+ICsJCXJl dHVybjsKPiAKPiBIZXJlLCBwaXBlIGlzIG9ubHkgdXNlZCBmb3IgdGhlIGRlYnVnIGxvZ2dpbmcs IGp1c3Qgc2tpcCB0aGF0IGluc3RlYWQuCgpPaywgY2FuIGRvLiBUaGlzIHdvdWxkIG1ha2UgdGhp bmdzIGluY29uc2lzdGVudCB3cnQuCnZsdl9lbmFibGUvZGlzYWJsZV9iYWNrbGlnaHQoKSB0aG91 Z2gsIHNvIGFyZSB5b3Ugb2sgaWYgSSBjaGFuZ2UgdGhvc2UKdG9vIGFjY29yZGluZ2x5PwoKLS1J bXJlCgo+IAo+ID4gKwo+ID4gIAlEUk1fREVCVUdfS01TKCJwaXBlICVjXG4iLCBwaXBlX25hbWUo cGlwZSkpOwo+ID4gIAo+ID4gIAltdXRleF9sb2NrKCZkZXZfcHJpdi0+YmFja2xpZ2h0X2xvY2sp Owo+IAo+IC0tIAo+IEphbmkgTmlrdWxhLCBJbnRlbCBPcGVuIFNvdXJjZSBUZWNobm9sb2d5IENl bnRlcgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRl bC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6 Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK