From: Imre Deak Subject: Re: [PATCH v2 5/8] drm/i915: Check error return when converting pipe to connector Date: Thu, 27 Apr 2017 11:28:45 +0300 Message-ID: <20170427082845.GA4327@ideak-desk.fi.intel.com> References: <1493214013-15580-6-git-send-email-imre.deak@intel.com> <1493227086-3807-3-git-send-email-imre.deak@intel.com> <87mvb2s4wg.fsf@intel.com> Reply-To: imre.deak@intel.com Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by gabe.freedesktop.org (Postfix) with ESMTPS id 575376E6BF for ; Thu, 27 Apr 2017 08:28:48 +0000 (UTC) Content-Disposition: inline In-Reply-To: <87mvb2s4wg.fsf@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Jani Nikula Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gVGh1LCBBcHIgMjcsIDIwMTcgYXQgMTA6MDk6MzVBTSArMDMwMCwgSmFuaSBOaWt1bGEgd3Jv dGU6Cj4gT24gV2VkLCAyNiBBcHIgMjAxNywgSW1yZSBEZWFrIDxpbXJlLmRlYWtAaW50ZWwuY29t PiB3cm90ZToKPiA+IEFuIGVycm9yIGZyb20gaW50ZWxfZ2V0X3BpcGVfZnJvbV9jb25uZWN0b3Io KSB3b3VsZCBtZWFuIGEgYnVnIHNvbWV3aGVyZQo+ID4gZWxzZSwgYnV0IHdlIHN0aWxsIHNob3Vs ZCBjaGVjayBmb3IgaXQgdG8gcHJldmVudCBzb21lIG90aGVyIG1vcmUKPiA+IG9ic2N1cmUgYnVn IGxhdGVyLgo+ID4KPiA+IHYyOgo+ID4gLSBGYWxsIGJhY2sgdG8gYSByZWFzb25hYmxlIGRlZmF1 bHQgaW5zdGVhZCBvZiBiYWlsaW5nIG91dCBpbiBjYXNlIG9mCj4gPiAgIGVycm9yLiAoSmFuaSkK PiA+Cj4gPiBDYzogSmFuaSBOaWt1bGEgPGphbmkubmlrdWxhQGludGVsLmNvbT4KPiA+IFNpZ25l ZC1vZmYtYnk6IEltcmUgRGVhayA8aW1yZS5kZWFrQGludGVsLmNvbT4KPiA+IC0tLQo+ID4gIGRy aXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3BhbmVsLmMgfCAxNyArKysrKysrKysrKysrKy0tLQo+ ID4gIDEgZmlsZSBjaGFuZ2VkLCAxNCBpbnNlcnRpb25zKCspLCAzIGRlbGV0aW9ucygtKQo+ID4K PiA+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9wYW5lbC5jIGIvZHJp dmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfcGFuZWwuYwo+ID4gaW5kZXggY2I1MGM1Mi4uMzUwOGY0 MiAxMDA2NDQKPiA+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3BhbmVsLmMKPiA+ ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3BhbmVsLmMKPiA+IEBAIC04ODgsMTAg Kzg4OCwxNCBAQCBzdGF0aWMgdm9pZCBwY2hfZW5hYmxlX2JhY2tsaWdodChzdHJ1Y3QgaW50ZWxf Y29ubmVjdG9yICpjb25uZWN0b3IpCj4gPiAgCXN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZf cHJpdiA9IHRvX2k5MTUoY29ubmVjdG9yLT5iYXNlLmRldik7Cj4gPiAgCXN0cnVjdCBpbnRlbF9w YW5lbCAqcGFuZWwgPSAmY29ubmVjdG9yLT5wYW5lbDsKPiA+ICAJZW51bSBwaXBlIHBpcGUgPSBp bnRlbF9nZXRfcGlwZV9mcm9tX2Nvbm5lY3Rvcihjb25uZWN0b3IpOwo+ID4gLQllbnVtIHRyYW5z Y29kZXIgY3B1X3RyYW5zY29kZXIgPQo+ID4gLQkJaW50ZWxfcGlwZV90b19jcHVfdHJhbnNjb2Rl cihkZXZfcHJpdiwgcGlwZSk7Cj4gPiArCWVudW0gdHJhbnNjb2RlciBjcHVfdHJhbnNjb2RlcjsK PiA+ICAJdTMyIGNwdV9jdGwyLCBwY2hfY3RsMSwgcGNoX2N0bDI7Cj4gPiAgCj4gPiArCWlmICgh V0FSTl9PTl9PTkNFKHBpcGUgPT0gSU5WQUxJRF9QSVBFKSkKPiA+ICsJCWNwdV90cmFuc2NvZGVy ID0gaW50ZWxfcGlwZV90b19jcHVfdHJhbnNjb2RlcihkZXZfcHJpdiwgcGlwZSk7Cj4gPiArCWVs c2UKPiA+ICsJCWNwdV90cmFuc2NvZGVyID0gVFJBTlNDT0RFUl9FRFA7Cj4gPiArCj4gPiAgCWNw dV9jdGwyID0gSTkxNV9SRUFEKEJMQ19QV01fQ1BVX0NUTDIpOwo+ID4gIAlpZiAoY3B1X2N0bDIg JiBCTE1fUFdNX0VOQUJMRSkgewo+ID4gIAkJRFJNX0RFQlVHX0tNUygiY3B1IGJhY2tsaWdodCBh bHJlYWR5IGVuYWJsZWRcbiIpOwo+ID4gQEAgLTk3Myw2ICs5NzcsOSBAQCBzdGF0aWMgdm9pZCBp OTY1X2VuYWJsZV9iYWNrbGlnaHQoc3RydWN0IGludGVsX2Nvbm5lY3RvciAqY29ubmVjdG9yKQo+ ID4gIAllbnVtIHBpcGUgcGlwZSA9IGludGVsX2dldF9waXBlX2Zyb21fY29ubmVjdG9yKGNvbm5l Y3Rvcik7Cj4gPiAgCXUzMiBjdGwsIGN0bDIsIGZyZXE7Cj4gPiAgCj4gPiArCWlmIChXQVJOX09O X09OQ0UocGlwZSA9PSBJTlZBTElEX1BJUEUpKQo+ID4gKwkJcGlwZSA9IFBJUEVfQTsKPiA+ICsK PiA+ICAJY3RsMiA9IEk5MTVfUkVBRChCTENfUFdNX0NUTDIpOwo+ID4gIAlpZiAoY3RsMiAmIEJM TV9QV01fRU5BQkxFKSB7Cj4gPiAgCQlEUk1fREVCVUdfS01TKCJiYWNrbGlnaHQgYWxyZWFkeSBl bmFibGVkXG4iKTsKPiA+IEBAIC0xMDM3LDYgKzEwNDQsOSBAQCBzdGF0aWMgdm9pZCBieHRfZW5h YmxlX2JhY2tsaWdodChzdHJ1Y3QgaW50ZWxfY29ubmVjdG9yICpjb25uZWN0b3IpCj4gPiAgCWVu dW0gcGlwZSBwaXBlID0gaW50ZWxfZ2V0X3BpcGVfZnJvbV9jb25uZWN0b3IoY29ubmVjdG9yKTsK PiA+ICAJdTMyIHB3bV9jdGwsIHZhbDsKPiA+ICAKPiA+ICsJaWYgKFdBUk5fT05fT05DRShwaXBl KSA9PSBQSVBFX0lOVkFMSUQpCj4gCj4gTGUgcGlwZSBpbnZhbGlkPyBJIHRoaW5rIHlvdSBtZWFu IElOVkFMSURfUElQRSBoZXJlLgoKQXJnLCBmb3Jnb3QgZ2l0IGFkZCBhdCBzb21lIHBvaW50Li4K Ci0tSW1yZQoKPiAKPiBCUiwKPiBKYW5pLgo+IAo+ID4gKwkJcGlwZSA9IFBJUEVfQTsKPiA+ICsK PiA+ICAJLyogQ29udHJvbGxlciAxIHVzZXMgdGhlIHV0aWxpdHkgcGluLiAqLwo+ID4gIAlpZiAo cGFuZWwtPmJhY2tsaWdodC5jb250cm9sbGVyID09IDEpIHsKPiA+ICAJCXZhbCA9IEk5MTVfUkVB RChVVElMX1BJTl9DVEwpOwo+ID4gQEAgLTEwOTMsNyArMTEwMyw4IEBAIHZvaWQgaW50ZWxfcGFu ZWxfZW5hYmxlX2JhY2tsaWdodChzdHJ1Y3QgaW50ZWxfY29ubmVjdG9yICpjb25uZWN0b3IpCj4g PiAgCWlmICghcGFuZWwtPmJhY2tsaWdodC5wcmVzZW50KQo+ID4gIAkJcmV0dXJuOwo+ID4gIAo+ ID4gLQlEUk1fREVCVUdfS01TKCJwaXBlICVjXG4iLCBwaXBlX25hbWUocGlwZSkpOwo+ID4gKwlp ZiAoIVdBUk5fT05fT05DRShwaXBlID09IElOVkFMSURfUElQRSkpCj4gPiArCQlEUk1fREVCVUdf S01TKCJwaXBlICVjXG4iLCBwaXBlX25hbWUocGlwZSkpOwo+ID4gIAo+ID4gIAltdXRleF9sb2Nr KCZkZXZfcHJpdi0+YmFja2xpZ2h0X2xvY2spOwo+IAo+IC0tIAo+IEphbmkgTmlrdWxhLCBJbnRl bCBPcGVuIFNvdXJjZSBUZWNobm9sb2d5IENlbnRlcgpfX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBs aXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1h bi9saXN0aW5mby9pbnRlbC1nZngK