From: Imre Deak Subject: Re: [PATCH v3 5/8] drm/i915: Check error return when converting pipe to connector Date: Thu, 27 Apr 2017 14:56:00 +0300 Message-ID: <20170427115600.GC4327@ideak-desk.fi.intel.com> References: <1493227086-3807-3-git-send-email-imre.deak@intel.com> <1493282214-11808-1-git-send-email-imre.deak@intel.com> <20170427114955.GL30290@intel.com> Reply-To: imre.deak@intel.com Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by gabe.freedesktop.org (Postfix) with ESMTPS id BA6F66E123 for ; Thu, 27 Apr 2017 11:56:03 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20170427114955.GL30290@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Cc: Jani Nikula , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gVGh1LCBBcHIgMjcsIDIwMTcgYXQgMDI6NDk6NTVQTSArMDMwMCwgVmlsbGUgU3lyasOkbMOk IHdyb3RlOgo+IE9uIFRodSwgQXByIDI3LCAyMDE3IGF0IDExOjM2OjU0QU0gKzAzMDAsIEltcmUg RGVhayB3cm90ZToKPiA+IEFuIGVycm9yIGZyb20gaW50ZWxfZ2V0X3BpcGVfZnJvbV9jb25uZWN0 b3IoKSB3b3VsZCBtZWFuIGEgYnVnIHNvbWV3aGVyZQo+ID4gZWxzZSwgYnV0IHdlIHN0aWxsIHNo b3VsZCBjaGVjayBmb3IgaXQgdG8gcHJldmVudCBzb21lIG90aGVyIG1vcmUKPiA+IG9ic2N1cmUg YnVnIGxhdGVyLgo+ID4gCj4gPiB2MjoKPiA+IC0gRmFsbCBiYWNrIHRvIGEgcmVhc29uYWJsZSBk ZWZhdWx0IGluc3RlYWQgb2YgYmFpbGluZyBvdXQgaW4gY2FzZSBvZgo+ID4gICBlcnJvci4gKEph bmkpCj4gPiB2MzoKPiA+IC0gRml4IHMvUElQRV9JTlZBTElEL0lOVkFMSURfUElQRS8gdHlwby4g KEphbmkpCj4gPiAKPiA+IENjOiBKYW5pIE5pa3VsYSA8amFuaS5uaWt1bGFAaW50ZWwuY29tPgo+ ID4gU2lnbmVkLW9mZi1ieTogSW1yZSBEZWFrIDxpbXJlLmRlYWtAaW50ZWwuY29tPgo+ID4gLS0t Cj4gPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfcGFuZWwuYyB8IDE3ICsrKysrKysrKysr KysrLS0tCj4gPiAgMSBmaWxlIGNoYW5nZWQsIDE0IGluc2VydGlvbnMoKyksIDMgZGVsZXRpb25z KC0pCj4gPiAKPiA+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9wYW5l bC5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfcGFuZWwuYwo+ID4gaW5kZXggY2I1MGM1 Mi4uZDFhYmJmMSAxMDA2NDQKPiA+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3Bh bmVsLmMKPiA+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3BhbmVsLmMKPiA+IEBA IC04ODgsMTAgKzg4OCwxNCBAQCBzdGF0aWMgdm9pZCBwY2hfZW5hYmxlX2JhY2tsaWdodChzdHJ1 Y3QgaW50ZWxfY29ubmVjdG9yICpjb25uZWN0b3IpCj4gPiAgCXN0cnVjdCBkcm1faTkxNV9wcml2 YXRlICpkZXZfcHJpdiA9IHRvX2k5MTUoY29ubmVjdG9yLT5iYXNlLmRldik7Cj4gPiAgCXN0cnVj dCBpbnRlbF9wYW5lbCAqcGFuZWwgPSAmY29ubmVjdG9yLT5wYW5lbDsKPiA+ICAJZW51bSBwaXBl IHBpcGUgPSBpbnRlbF9nZXRfcGlwZV9mcm9tX2Nvbm5lY3Rvcihjb25uZWN0b3IpOwo+ID4gLQll bnVtIHRyYW5zY29kZXIgY3B1X3RyYW5zY29kZXIgPQo+ID4gLQkJaW50ZWxfcGlwZV90b19jcHVf dHJhbnNjb2RlcihkZXZfcHJpdiwgcGlwZSk7Cj4gPiArCWVudW0gdHJhbnNjb2RlciBjcHVfdHJh bnNjb2RlcjsKPiA+ICAJdTMyIGNwdV9jdGwyLCBwY2hfY3RsMSwgcGNoX2N0bDI7Cj4gPiAgCj4g PiArCWlmICghV0FSTl9PTl9PTkNFKHBpcGUgPT0gSU5WQUxJRF9QSVBFKSkKPiA+ICsJCWNwdV90 cmFuc2NvZGVyID0gaW50ZWxfcGlwZV90b19jcHVfdHJhbnNjb2RlcihkZXZfcHJpdiwgcGlwZSk7 Cj4gPiArCWVsc2UKPiA+ICsJCWNwdV90cmFuc2NvZGVyID0gVFJBTlNDT0RFUl9FRFA7Cj4gPiAr Cj4gPiAgCWNwdV9jdGwyID0gSTkxNV9SRUFEKEJMQ19QV01fQ1BVX0NUTDIpOwo+ID4gIAlpZiAo Y3B1X2N0bDIgJiBCTE1fUFdNX0VOQUJMRSkgewo+ID4gIAkJRFJNX0RFQlVHX0tNUygiY3B1IGJh Y2tsaWdodCBhbHJlYWR5IGVuYWJsZWRcbiIpOwo+ID4gQEAgLTk3Myw2ICs5NzcsOSBAQCBzdGF0 aWMgdm9pZCBpOTY1X2VuYWJsZV9iYWNrbGlnaHQoc3RydWN0IGludGVsX2Nvbm5lY3RvciAqY29u bmVjdG9yKQo+ID4gIAllbnVtIHBpcGUgcGlwZSA9IGludGVsX2dldF9waXBlX2Zyb21fY29ubmVj dG9yKGNvbm5lY3Rvcik7Cj4gPiAgCXUzMiBjdGwsIGN0bDIsIGZyZXE7Cj4gPiAgCj4gPiArCWlm IChXQVJOX09OX09OQ0UocGlwZSA9PSBJTlZBTElEX1BJUEUpKQo+ID4gKwkJcGlwZSA9IFBJUEVf QTsKPiA+ICsKPiA+ICAJY3RsMiA9IEk5MTVfUkVBRChCTENfUFdNX0NUTDIpOwo+ID4gIAlpZiAo Y3RsMiAmIEJMTV9QV01fRU5BQkxFKSB7Cj4gPiAgCQlEUk1fREVCVUdfS01TKCJiYWNrbGlnaHQg YWxyZWFkeSBlbmFibGVkXG4iKTsKPiA+IEBAIC0xMDM3LDYgKzEwNDQsOSBAQCBzdGF0aWMgdm9p ZCBieHRfZW5hYmxlX2JhY2tsaWdodChzdHJ1Y3QgaW50ZWxfY29ubmVjdG9yICpjb25uZWN0b3Ip Cj4gPiAgCWVudW0gcGlwZSBwaXBlID0gaW50ZWxfZ2V0X3BpcGVfZnJvbV9jb25uZWN0b3IoY29u bmVjdG9yKTsKPiA+ICAJdTMyIHB3bV9jdGwsIHZhbDsKPiA+ICAKPiA+ICsJaWYgKFdBUk5fT05f T05DRShwaXBlKSA9PSBJTlZBTElEX1BJUEUpCj4gICAgICAgICAgICAgICAgICAgICAgICAgICAg ICBeCj4gCj4gSXNuJ3QgdGhhdCB0aGluZyBpbiB0aGUgd3JvbmcgcGxhY2U/CgpZZXMsIHRoYW5r cyBmb3IgY2F0Y2hpbmcgaXQuCgo+IAo+ID4gKwkJcGlwZSA9IFBJUEVfQTsKPiA+ICsKPiA+ICAJ LyogQ29udHJvbGxlciAxIHVzZXMgdGhlIHV0aWxpdHkgcGluLiAqLwo+ID4gIAlpZiAocGFuZWwt PmJhY2tsaWdodC5jb250cm9sbGVyID09IDEpIHsKPiA+ICAJCXZhbCA9IEk5MTVfUkVBRChVVElM X1BJTl9DVEwpOwo+ID4gQEAgLTEwOTMsNyArMTEwMyw4IEBAIHZvaWQgaW50ZWxfcGFuZWxfZW5h YmxlX2JhY2tsaWdodChzdHJ1Y3QgaW50ZWxfY29ubmVjdG9yICpjb25uZWN0b3IpCj4gPiAgCWlm ICghcGFuZWwtPmJhY2tsaWdodC5wcmVzZW50KQo+ID4gIAkJcmV0dXJuOwo+ID4gIAo+ID4gLQlE Uk1fREVCVUdfS01TKCJwaXBlICVjXG4iLCBwaXBlX25hbWUocGlwZSkpOwo+ID4gKwlpZiAoIVdB Uk5fT05fT05DRShwaXBlID09IElOVkFMSURfUElQRSkpCj4gPiArCQlEUk1fREVCVUdfS01TKCJw aXBlICVjXG4iLCBwaXBlX25hbWUocGlwZSkpOwo+ID4gIAo+ID4gIAltdXRleF9sb2NrKCZkZXZf cHJpdi0+YmFja2xpZ2h0X2xvY2spOwo+ID4gIAo+ID4gLS0gCj4gPiAyLjUuMAo+ID4gCj4gPiBf X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwo+ID4gSW50ZWwt Z2Z4IG1haWxpbmcgbGlzdAo+ID4gSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwo+ID4g aHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK PiAKPiAtLSAKPiBWaWxsZSBTeXJqw6Rsw6QKPiBJbnRlbCBPVEMKX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRl bC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3Jn L21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg==