From: Jarkko Sakkinen Subject: Re: [PATCH] tpm_tis: Issue a TPM2_Shutdown for TPM2 devices. Date: Sat, 29 Apr 2017 14:48:29 +0300 Message-ID: <20170429114829.sm3qcy6xsslpbwip@intel.com> References: <20170427182659.403-1-joshz@google.com> <20170428121226.7xnpfbxcjszrnz5d@intel.com> <20170428152748.GA32017@obsidianresearch.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: tpmdd-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org To: Josh Zimmerman Cc: tpmdd-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org, rafael-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org List-Id: tpmdd-devel@lists.sourceforge.net On Fri, Apr 28, 2017 at 11:27:16AM -0700, Josh Zimmerman wrote: > It sounds like there are several intertwined issues here. I'd like to > keep this patch relatively minimal, so here are my current thoughts on > a path forward: > > * Refactor references to chip->ops to go through tpm_try_get_ops, as > mentioned in the previous patch > * Have a common tpm_shutdown method in tpm-chip.c that device specific > drivers call (or that is just registered automatically for all > devices?) that nulls out chip->ops (to prevent any commands being > issued after tpm2_shutdown) and sends tpm2_shutdown > > This would leave further device refactoring for a future patch. > > Before I spend too much time on this, does this seem like a reasonable > approach? Anything I'm missing? > > Thanks, > Josh I think this sounds like a plan. /Jarkko ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot