From: Imre Deak Subject: Re: [PATCH v7 11/15] drm/i915: Support variable cursor height on ivb+ Date: Fri, 5 May 2017 18:42:45 +0300 Message-ID: <20170505154245.GC31871@ideak-desk.fi.intel.com> References: <20170327185546.2977-1-ville.syrjala@linux.intel.com> <20170327185546.2977-12-ville.syrjala@linux.intel.com> Reply-To: imre.deak@intel.com Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by gabe.freedesktop.org (Postfix) with ESMTPS id 4DC206E6D0 for ; Fri, 5 May 2017 15:42:50 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20170327185546.2977-12-ville.syrjala@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: ville.syrjala@linux.intel.com Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gTW9uLCBNYXIgMjcsIDIwMTcgYXQgMDk6NTU6NDJQTSArMDMwMCwgdmlsbGUuc3lyamFsYUBs aW51eC5pbnRlbC5jb20gd3JvdGU6Cj4gRnJvbTogVmlsbGUgU3lyasOkbMOkIDx2aWxsZS5zeXJq YWxhQGxpbnV4LmludGVsLmNvbT4KPiAKPiBJVkIgaW50cm9kdWNlZCB0aGUgQ1VSX0ZCQ19DVEwg cmVnaXN0ZXIgd2hpY2ggYWxsb3dzIHJlZHVjaW5nIHRoZSBjdXJzb3IKPiBoZWlnaHQgZG93biB0 byA4IGxpbmVzIGZyb20gdGhlIG90aGVyd2lzZSBzcXVhcmUgY3Vyc29yIGRpbWVuc2lvbnMuCj4g SW1wbGVtZW50IHN1cHBvcnQgZm9yIGl0LiBDVVJfRkJDX0NUTCBjYW4ndCBiZSB1c2VkIHdoZW4g dGhlIGN1cnNvcgo+IGlzIHJvdGF0ZWQuCj4gCj4gQ29tbWFuZGVlciB0aGUgb3RoZXJ3aXNlIHVu dXNlZCBjdXJzb3ItPmN1cnNvci5zaXplIHRvIHRyYWNrIHRoZQo+IGN1cnJlbnQgdmFsdWUgb2Yg Q1VSX0ZCQ19DVEwgdG8gb3B0aW1pemUgYXdheSByZWR1bmRhbnQgQ1VSX0ZCQ19DVEwKPiB3cml0 ZXMsIGFuZCB0byBub3RpY2Ugd2hlbiB3ZSBuZWVkIHRvIGFybSB0aGUgdXBkYXRlIHZpYSBDVVJC QVNFIGlmCj4ganVzdCBDVVJfRkJDX0NUTCBjaGFuZ2VzLgo+IAo+IHYyOiBSZXZlcnNlIHRoZSBn ZW4gY2hlY2sgdG8gbWFrZSBpdCBzYW5lCj4gdjM6IE9ubHkgZW5hYmxlIENVUl9GQkNfQ1RMIHdo ZW4gY3Vyc29yIGlzIGVuYWJsZWQsIGFkYXB0IHRvCj4gICAgIGVhcmxpZXIgY29kZSBjaGFuZ2Vz IHdoaWNoIG1lYW5zIHdlIG5vdyBhY3R1YWxseSB0dXJuIG9mZgo+ICAgICB0aGUgY3Vyc29yIHdo ZW4gd2UncmUgc3VwcG9zZWQgdG8gdW5saWtlIHYyCj4gdjQ6IEFkZCBhIGNvbW1lbnQgYWJvdXQg cm90YXRpb24gdnMuIENVUl9GQkNfQ1RMLAo+ICAgICByZWJhc2UgZHVlIHRvICdkaXJ0eScgKENo cmlzKQo+IHY1OiBSZWJhc2UgdG8gdGhlIGF0b21pYyB3b3JsZAo+ICAgICBIYW5kbGUgMTgwIGRl Z3JlZSByb3RhdGlvbgo+ICAgICBBZGQgSEFTX0NVUl9GQkMoKQo+IHY2OiBSZWJhc2UKPiB2Nzog UmViYXNlIGR1ZSB0byBJOTE1X1dSSVRFX0ZXL3VuY29yZS5sb2NrCj4gICAgIHMvc2l6ZS9mYmNf Y3RsLwo+IAo+IFNpZ25lZC1vZmYtYnk6IFZpbGxlIFN5cmrDpGzDpCA8dmlsbGUuc3lyamFsYUBs aW51eC5pbnRlbC5jb20+CgpOaXRwaWNrOiBjdXJzb3Iuc2l6ZSBjb3VsZCd2ZSBiZWVuIGNoYW5n ZWQgdG8gYmUgYSB1bmlvbiBvZiBzaXplLGZiX2N0bAp0b28uIEVpdGhlciB3YXkgbG9va3Mgb2s6 ClJldmlld2VkLWJ5OiBJbXJlIERlYWsgPGltcmUuZGVha0BpbnRlbC5jb20+Cgo+IC0tLQo+ICBk cml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2Rydi5oICAgICAgfCAgMSArCj4gIGRyaXZlcnMvZ3B1 L2RybS9pOTE1L2k5MTVfcmVnLmggICAgICB8ICA1ICsrKystCj4gIGRyaXZlcnMvZ3B1L2RybS9p OTE1L2ludGVsX2Rpc3BsYXkuYyB8IDM4ICsrKysrKysrKysrKysrKysrKysrKysrKysrKysrLS0t LS0tLQo+ICAzIGZpbGVzIGNoYW5nZWQsIDM2IGluc2VydGlvbnMoKyksIDggZGVsZXRpb25zKC0p Cj4gCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZHJ2LmggYi9kcml2 ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2Rydi5oCj4gaW5kZXggODZmMDk3ZGI4ZWY2Li45NTI0Y2Uw NDQyYWQgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9kcnYuaAo+ICsr KyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZHJ2LmgKPiBAQCAtMjkyNyw2ICsyOTI3LDcg QEAgaW50ZWxfaW5mbyhjb25zdCBzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYpCj4g ICNkZWZpbmUgSEFTX0ZXX0JMQyhkZXZfcHJpdikgCShJTlRFTF9HRU4oZGV2X3ByaXYpID4gMikK PiAgI2RlZmluZSBIQVNfUElQRV9DWFNSKGRldl9wcml2KSAoKGRldl9wcml2KS0+aW5mby5oYXNf cGlwZV9jeHNyKQo+ICAjZGVmaW5lIEhBU19GQkMoZGV2X3ByaXYpCSgoZGV2X3ByaXYpLT5pbmZv Lmhhc19mYmMpCj4gKyNkZWZpbmUgSEFTX0NVUl9GQkMoZGV2X3ByaXYpCSghSEFTX0dNQ0hfRElT UExBWShkZXZfcHJpdikgJiYgSU5URUxfSU5GTyhkZXZfcHJpdiktPmdlbiA+PSA3KQo+ICAKPiAg I2RlZmluZSBIQVNfSVBTKGRldl9wcml2KQkoSVNfSFNXX1VMVChkZXZfcHJpdikgfHwgSVNfQlJP QURXRUxMKGRldl9wcml2KSkKPiAgCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1 L2k5MTVfcmVnLmggYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X3JlZy5oCj4gaW5kZXggNGQ5 N2Q5ZmIyYWQwLi45MDI3ZGViYjFjZjkgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5 MTUvaTkxNV9yZWcuaAo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfcmVnLmgKPiBA QCAtNTQ0Nyw3ICs1NDQ3LDkgQEAgZW51bSB7Cj4gICNkZWZpbmUgICBDVVJTT1JfUE9TX1NJR04g ICAgICAgMHg4MDAwCj4gICNkZWZpbmUgICBDVVJTT1JfWF9TSElGVCAgICAgICAgMAo+ICAjZGVm aW5lICAgQ1VSU09SX1lfU0hJRlQgICAgICAgIDE2Cj4gLSNkZWZpbmUgQ1VSU0laRQkJCV9NTUlP KDB4NzAwYTApCj4gKyNkZWZpbmUgQ1VSU0laRQkJCV9NTUlPKDB4NzAwYTApIC8qIDg0NS84NjUg Ki8KPiArI2RlZmluZSBfQ1VSX0ZCQ19DVExfQQkJMHg3MDBhMCAvKiBpdmIrICovCj4gKyNkZWZp bmUgICBDVVJfRkJDX0NUTF9FTgkoMSA8PCAzMSkKPiAgI2RlZmluZSBfQ1VSQkNOVFIJCTB4NzAw YzAKPiAgI2RlZmluZSBfQ1VSQkJBU0UJCTB4NzAwYzQKPiAgI2RlZmluZSBfQ1VSQlBPUwkJMHg3 MDBjOAo+IEBAIC01NDYzLDYgKzU0NjUsNyBAQCBlbnVtIHsKPiAgI2RlZmluZSBDVVJDTlRSKHBp cGUpIF9DVVJTT1IyKHBpcGUsIF9DVVJBQ05UUikKPiAgI2RlZmluZSBDVVJCQVNFKHBpcGUpIF9D VVJTT1IyKHBpcGUsIF9DVVJBQkFTRSkKPiAgI2RlZmluZSBDVVJQT1MocGlwZSkgX0NVUlNPUjIo cGlwZSwgX0NVUkFQT1MpCj4gKyNkZWZpbmUgQ1VSX0ZCQ19DVEwocGlwZSkgX0NVUlNPUjIocGlw ZSwgX0NVUl9GQkNfQ1RMX0EpCj4gIAo+ICAjZGVmaW5lIENVUlNPUl9BX09GRlNFVCAweDcwMDgw Cj4gICNkZWZpbmUgQ1VSU09SX0JfT0ZGU0VUIDB4NzAwYzAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVy cy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50 ZWxfZGlzcGxheS5jCj4gaW5kZXggYzZlMDI2ZTYxN2U1Li41M2VjOWQzMDQzN2UgMTAwNjQ0Cj4g LS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5jCj4gKysrIGIvZHJpdmVy cy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5jCj4gQEAgLTkzNjQsMTcgKzkzNjQsMTYgQEAg c3RhdGljIHUzMiBpOXh4X2N1cnNvcl9jdGwoY29uc3Qgc3RydWN0IGludGVsX2NydGNfc3RhdGUg KmNydGNfc3RhdGUsCj4gIAo+ICBzdGF0aWMgYm9vbCBpOXh4X2N1cnNvcl9zaXplX29rKGNvbnN0 IHN0cnVjdCBpbnRlbF9wbGFuZV9zdGF0ZSAqcGxhbmVfc3RhdGUpCj4gIHsKPiArCXN0cnVjdCBk cm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiA9Cj4gKwkJdG9faTkxNShwbGFuZV9zdGF0ZS0+YmFz ZS5wbGFuZS0+ZGV2KTsKPiAgCWludCB3aWR0aCA9IHBsYW5lX3N0YXRlLT5iYXNlLmNydGNfdzsK PiAgCWludCBoZWlnaHQgPSBwbGFuZV9zdGF0ZS0+YmFzZS5jcnRjX2g7Cj4gIAo+ICAJaWYgKCFp bnRlbF9jdXJzb3Jfc2l6ZV9vayhwbGFuZV9zdGF0ZSkpCj4gIAkJcmV0dXJuIGZhbHNlOwo+ICAK PiAtCS8qCj4gLQkgKiBDdXJzb3JzIGFyZSBsaW1pdGVkIHRvIGEgZmV3IHBvd2VyLW9mLXR3bwo+ IC0JICogc2l6ZXMsIGFuZCB0aGV5IG11c3QgYmUgc3F1YXJlLgo+IC0JICovCj4gLQlzd2l0Y2gg KHdpZHRoIHwgaGVpZ2h0KSB7Cj4gKwkvKiBDdXJzb3Igd2lkdGggaXMgbGltaXRlZCB0byBhIGZl dyBwb3dlci1vZi10d28gc2l6ZXMgKi8KPiArCXN3aXRjaCAod2lkdGgpIHsKPiAgCWNhc2UgMjU2 Ogo+ICAJY2FzZSAxMjg6Cj4gIAljYXNlIDY0Ogo+IEBAIC05MzgzLDYgKzkzODIsMjEgQEAgc3Rh dGljIGJvb2wgaTl4eF9jdXJzb3Jfc2l6ZV9vayhjb25zdCBzdHJ1Y3QgaW50ZWxfcGxhbmVfc3Rh dGUgKnBsYW5lX3N0YXRlKQo+ICAJCXJldHVybiBmYWxzZTsKPiAgCX0KPiAgCj4gKwkvKgo+ICsJ ICogSVZCKyBoYXZlIENVUl9GQkNfQ1RMIHdoaWNoIGFsbG93cyBhbiBhcmJpdHJhcnkgY3Vyc29y Cj4gKwkgKiBoZWlnaHQgZnJvbSA4IGxpbmVzIHVwIHRvIHRoZSBjdXJzb3Igd2lkdGgsIHdoZW4g dGhlCj4gKwkgKiBjdXJzb3IgaXMgbm90IHJvdGF0ZWQuIEV2ZXJ5dGhpbmcgZWxzZSByZXF1aXJl cyBzcXVhcmUKPiArCSAqIGN1cnNvcnMuCj4gKwkgKi8KPiArCWlmIChIQVNfQ1VSX0ZCQyhkZXZf cHJpdikgJiYKPiArCSAgICBwbGFuZV9zdGF0ZS0+YmFzZS5yb3RhdGlvbiAmIERSTV9ST1RBVEVf MCkgewo+ICsJCWlmIChoZWlnaHQgPCA4IHx8IGhlaWdodCA+IHdpZHRoKQo+ICsJCQlyZXR1cm4g ZmFsc2U7Cj4gKwl9IGVsc2Ugewo+ICsJCWlmIChoZWlnaHQgIT0gd2lkdGgpCj4gKwkJCXJldHVy biBmYWxzZTsKPiArCX0KPiArCj4gIAlyZXR1cm4gdHJ1ZTsKPiAgfQo+ICAKPiBAQCAtOTQ0NCwx MiArOTQ1OCwxNSBAQCBzdGF0aWMgdm9pZCBpOXh4X3VwZGF0ZV9jdXJzb3Ioc3RydWN0IGludGVs X3BsYW5lICpwbGFuZSwKPiAgewo+ICAJc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2 ID0gdG9faTkxNShwbGFuZS0+YmFzZS5kZXYpOwo+ICAJZW51bSBwaXBlIHBpcGUgPSBwbGFuZS0+ cGlwZTsKPiAtCXUzMiBjbnRsID0gMCwgYmFzZSA9IDAsIHBvcyA9IDA7Cj4gKwl1MzIgY250bCA9 IDAsIGJhc2UgPSAwLCBwb3MgPSAwLCBmYmNfY3RsID0gMDsKPiAgCXVuc2lnbmVkIGxvbmcgaXJx ZmxhZ3M7Cj4gIAo+ICAJaWYgKHBsYW5lX3N0YXRlICYmIHBsYW5lX3N0YXRlLT5iYXNlLnZpc2li bGUpIHsKPiAgCQljbnRsID0gcGxhbmVfc3RhdGUtPmN0bDsKPiAgCj4gKwkJaWYgKHBsYW5lX3N0 YXRlLT5iYXNlLmNydGNfaCAhPSBwbGFuZV9zdGF0ZS0+YmFzZS5jcnRjX3cpCj4gKwkJCWZiY19j dGwgPSBDVVJfRkJDX0NUTF9FTiB8IChwbGFuZV9zdGF0ZS0+YmFzZS5jcnRjX2ggLSAxKTsKPiAr Cj4gIAkJYmFzZSA9IGludGVsX2N1cnNvcl9iYXNlKHBsYW5lX3N0YXRlKTsKPiAgCQlwb3MgPSBp bnRlbF9jdXJzb3JfcG9zaXRpb24ocGxhbmVfc3RhdGUpOwo+ICAJfQo+IEBAIC05NDU5LDEwICs5 NDc2LDE0IEBAIHN0YXRpYyB2b2lkIGk5eHhfdXBkYXRlX2N1cnNvcihzdHJ1Y3QgaW50ZWxfcGxh bmUgKnBsYW5lLAo+ICAJaWYgKHBsYW5lLT5jdXJzb3IuY250bCAhPSBjbnRsKQo+ICAJCUk5MTVf V1JJVEVfRlcoQ1VSQ05UUihwaXBlKSwgY250bCk7Cj4gIAo+ICsJaWYgKHBsYW5lLT5jdXJzb3Iu c2l6ZSAhPSBmYmNfY3RsKQo+ICsJCUk5MTVfV1JJVEVfRlcoQ1VSX0ZCQ19DVEwocGlwZSksIGZi Y19jdGwpOwo+ICsKPiAgCWlmIChjbnRsKQo+ICAJCUk5MTVfV1JJVEVfRlcoQ1VSUE9TKHBpcGUp LCBwb3MpOwo+ICAKPiAgCWlmIChwbGFuZS0+Y3Vyc29yLmNudGwgIT0gY250bCB8fAo+ICsJICAg IHBsYW5lLT5jdXJzb3Iuc2l6ZSAhPSBmYmNfY3RsIHx8Cj4gIAkgICAgcGxhbmUtPmN1cnNvci5i YXNlICE9IGJhc2UpCj4gIAkJSTkxNV9XUklURV9GVyhDVVJCQVNFKHBpcGUpLCBiYXNlKTsKPiAg Cj4gQEAgLTk0NzIsNiArOTQ5Myw3IEBAIHN0YXRpYyB2b2lkIGk5eHhfdXBkYXRlX2N1cnNvcihz dHJ1Y3QgaW50ZWxfcGxhbmUgKnBsYW5lLAo+ICAKPiAgCXBsYW5lLT5jdXJzb3IuY250bCA9IGNu dGw7Cj4gIAlwbGFuZS0+Y3Vyc29yLmJhc2UgPSBiYXNlOwo+ICsJcGxhbmUtPmN1cnNvci5zaXpl ID0gZmJjX2N0bDsKPiAgfQo+ICAKPiAgc3RhdGljIHZvaWQgaTl4eF9kaXNhYmxlX2N1cnNvcihz dHJ1Y3QgaW50ZWxfcGxhbmUgKnBsYW5lLAo+IEBAIC0xMzg0NCw3ICsxMzg2Niw5IEBAIGludGVs X2N1cnNvcl9wbGFuZV9jcmVhdGUoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2LAo+ ICAKPiAgCWN1cnNvci0+Y3Vyc29yLmJhc2UgPSB+MDsKPiAgCWN1cnNvci0+Y3Vyc29yLmNudGwg PSB+MDsKPiAtCWN1cnNvci0+Y3Vyc29yLnNpemUgPSB+MDsKPiArCj4gKwlpZiAoSVNfSTg0NUco ZGV2X3ByaXYpIHx8IElTX0k4NjVHKGRldl9wcml2KSB8fCBIQVNfQ1VSX0ZCQyhkZXZfcHJpdikp Cj4gKwkJY3Vyc29yLT5jdXJzb3Iuc2l6ZSA9IH4wOwo+ICAKPiAgCXJldCA9IGRybV91bml2ZXJz YWxfcGxhbmVfaW5pdCgmZGV2X3ByaXYtPmRybSwgJmN1cnNvci0+YmFzZSwKPiAgCQkJCSAgICAg ICAwLCAmaW50ZWxfY3Vyc29yX3BsYW5lX2Z1bmNzLAo+IC0tIAo+IDIuMTAuMgo+IAo+IF9fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCj4gSW50ZWwtZ2Z4IG1h aWxpbmcgbGlzdAo+IEludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKPiBodHRwczovL2xp c3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeApfX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBs aXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVz a3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK