From: Imre Deak Subject: Re: [PATCH 13/15] drm/i915: Handle fb offset and src coordinates for cursors Date: Fri, 5 May 2017 23:53:07 +0300 Message-ID: <20170505205307.GB24641@ideak-desk.fi.intel.com> References: <20170327185546.2977-1-ville.syrjala@linux.intel.com> <20170327185546.2977-14-ville.syrjala@linux.intel.com> Reply-To: imre.deak@intel.com Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by gabe.freedesktop.org (Postfix) with ESMTPS id AC4536E04B for ; Fri, 5 May 2017 20:53:09 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20170327185546.2977-14-ville.syrjala@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: ville.syrjala@linux.intel.com Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gTW9uLCBNYXIgMjcsIDIwMTcgYXQgMDk6NTU6NDRQTSArMDMwMCwgdmlsbGUuc3lyamFsYUBs aW51eC5pbnRlbC5jb20gd3JvdGU6Cj4gRnJvbTogVmlsbGUgU3lyasOkbMOkIDx2aWxsZS5zeXJq YWxhQGxpbnV4LmludGVsLmNvbT4KPiAKPiBUaGUgY3Vyc29yIHBsYW5lIGRvZXNuJ3QgaGF2ZSBh bnkga2luZCBvZiBzb3VyY2Ugb2Zmc2V0IHJlZ2lzdGVyLCBzbwo+IHRoZSBvbmx5IGZvcm0gb2Yg cGFubmluZyBwb3NzaWJsZSBpcyB2aWEgYSB0aGUgYmFzZSBhZGRyZXNzIHJlZ2lzdGVyLgo+IFRo ZSBhbGlnbm1lbnQgcmVxdWlyZWQgYnkgQ1VSQkFTRSByYW5nZXMgZnJvbSAzMkIgdG8gMTZLaUIg ZGVwZW5kaW5nCj4gb24gdGhlIHBsYXRmb3JtLiBMZXQncyBtYWtlIHN1cmUgdGhlIHVzZXIgZGlk bid0IGFzayBmb3Igc29tZXRoaW5nCj4gd2UgY2FuJ3QgZG8uCj4gCj4gT2J2aW91c2x5IHRoaXMg aXMgaW1wb3NzaWJsZSB0byBoaXQgdmlhIHRoZSBsZWdhY3kgY3Vyc29yIGlvY3RsIHNpbmNlCj4g dGhlIHNyYyBvZmZzZXRzIGFyZSBhbHdheXMgMCwgYnV0IHZpYSB0aGUgcGxhbmUvYXRvbWljIGlv Y3RscyB0aGUgdXNlcgo+IGNhbiBhc2sgZm9yIHByZXR0eSBtdWNoIGFueXRoaW5nIHNvIHdlIGhh dmUgdG8gZGVhbCB3aXRoIHRoaXMuCj4gCj4gU2lnbmVkLW9mZi1ieTogVmlsbGUgU3lyasOkbMOk IDx2aWxsZS5zeXJqYWxhQGxpbnV4LmludGVsLmNvbT4KClJldmlld2VkLWJ5OiBJbXJlIERlYWsg PGltcmUuZGVha0BpbnRlbC5jb20+Cgo+IC0tLQo+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRl bF9kaXNwbGF5LmMgfCAyNyArKysrKysrKysrKysrKysrKysrKysrKysrLS0KPiAgMSBmaWxlIGNo YW5nZWQsIDI1IGluc2VydGlvbnMoKyksIDIgZGVsZXRpb25zKC0pCj4gCj4gZGlmZiAtLWdpdCBh L2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rpc3BsYXkuYyBiL2RyaXZlcnMvZ3B1L2RybS9p OTE1L2ludGVsX2Rpc3BsYXkuYwo+IGluZGV4IDNhMWQ3ZDY1MzBlYy4uNDIwZDMwNmUzMWM5IDEw MDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rpc3BsYXkuYwo+ICsrKyBi L2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rpc3BsYXkuYwo+IEBAIC0yMzk2LDExICsyMzk2 LDE3IEBAIHUzMiBpbnRlbF9jb21wdXRlX3RpbGVfb2Zmc2V0KGludCAqeCwgaW50ICp5LAo+ICAJ CQkgICAgICBjb25zdCBzdHJ1Y3QgaW50ZWxfcGxhbmVfc3RhdGUgKnN0YXRlLAo+ICAJCQkgICAg ICBpbnQgcGxhbmUpCj4gIHsKPiAtCWNvbnN0IHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZf cHJpdiA9IHRvX2k5MTUoc3RhdGUtPmJhc2UucGxhbmUtPmRldik7Cj4gKwlzdHJ1Y3QgaW50ZWxf cGxhbmUgKmludGVsX3BsYW5lID0gdG9faW50ZWxfcGxhbmUoc3RhdGUtPmJhc2UucGxhbmUpOwo+ ICsJc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2ID0gdG9faTkxNShpbnRlbF9wbGFu ZS0+YmFzZS5kZXYpOwo+ICAJY29uc3Qgc3RydWN0IGRybV9mcmFtZWJ1ZmZlciAqZmIgPSBzdGF0 ZS0+YmFzZS5mYjsKPiAgCXVuc2lnbmVkIGludCByb3RhdGlvbiA9IHN0YXRlLT5iYXNlLnJvdGF0 aW9uOwo+ICAJaW50IHBpdGNoID0gaW50ZWxfZmJfcGl0Y2goZmIsIHBsYW5lLCByb3RhdGlvbik7 Cj4gLQl1MzIgYWxpZ25tZW50ID0gaW50ZWxfc3VyZl9hbGlnbm1lbnQoZmIsIHBsYW5lKTsKPiAr CXUzMiBhbGlnbm1lbnQ7Cj4gKwo+ICsJaWYgKGludGVsX3BsYW5lLT5pZCA9PSBQTEFORV9DVVJT T1IpCj4gKwkJYWxpZ25tZW50ID0gaW50ZWxfY3Vyc29yX2FsaWdubWVudChkZXZfcHJpdik7Cj4g KwllbHNlCj4gKwkJYWxpZ25tZW50ID0gaW50ZWxfc3VyZl9hbGlnbm1lbnQoZmIsIHBsYW5lKTsK PiAgCj4gIAlyZXR1cm4gX2ludGVsX2NvbXB1dGVfdGlsZV9vZmZzZXQoZGV2X3ByaXYsIHgsIHks IGZiLCBwbGFuZSwgcGl0Y2gsCj4gIAkJCQkJICByb3RhdGlvbiwgYWxpZ25tZW50KTsKPiBAQCAt OTE0OSw2ICs5MTU1LDggQEAgc3RhdGljIHUzMiBpbnRlbF9jdXJzb3JfYmFzZShjb25zdCBzdHJ1 Y3QgaW50ZWxfcGxhbmVfc3RhdGUgKnBsYW5lX3N0YXRlKQo+ICAJZWxzZQo+ICAJCWJhc2UgPSBp bnRlbF9wbGFuZV9nZ3R0X29mZnNldChwbGFuZV9zdGF0ZSk7Cj4gIAo+ICsJYmFzZSArPSBwbGFu ZV9zdGF0ZS0+bWFpbi5vZmZzZXQ7Cj4gKwo+ICAJLyogSUxLKyBkbyB0aGlzIGF1dG9tYWdpY2Fs bHkgKi8KPiAgCWlmIChIQVNfR01DSF9ESVNQTEFZKGRldl9wcml2KSAmJgo+ICAJICAgIHBsYW5l X3N0YXRlLT5iYXNlLnJvdGF0aW9uICYgRFJNX1JPVEFURV8xODApCj4gQEAgLTkxOTQsNiArOTIw Miw4IEBAIHN0YXRpYyBpbnQgaW50ZWxfY2hlY2tfY3Vyc29yKHN0cnVjdCBpbnRlbF9jcnRjX3N0 YXRlICpjcnRjX3N0YXRlLAo+ICAJCQkgICAgICBzdHJ1Y3QgaW50ZWxfcGxhbmVfc3RhdGUgKnBs YW5lX3N0YXRlKQo+ICB7Cj4gIAljb25zdCBzdHJ1Y3QgZHJtX2ZyYW1lYnVmZmVyICpmYiA9IHBs YW5lX3N0YXRlLT5iYXNlLmZiOwo+ICsJaW50IHNyY194LCBzcmNfeTsKPiArCXUzMiBvZmZzZXQ7 Cj4gIAlpbnQgcmV0Owo+ICAKPiAgCXJldCA9IGRybV9wbGFuZV9oZWxwZXJfY2hlY2tfc3RhdGUo JnBsYW5lX3N0YXRlLT5iYXNlLAo+IEBAIC05MjEyLDYgKzkyMjIsMTkgQEAgc3RhdGljIGludCBp bnRlbF9jaGVja19jdXJzb3Ioc3RydWN0IGludGVsX2NydGNfc3RhdGUgKmNydGNfc3RhdGUsCj4g IAkJcmV0dXJuIC1FSU5WQUw7Cj4gIAl9Cj4gIAo+ICsJc3JjX3ggPSBwbGFuZV9zdGF0ZS0+YmFz ZS5zcmNfeCA+PiAxNjsKPiArCXNyY195ID0gcGxhbmVfc3RhdGUtPmJhc2Uuc3JjX3kgPj4gMTY7 Cj4gKwo+ICsJaW50ZWxfYWRkX2ZiX29mZnNldHMoJnNyY194LCAmc3JjX3ksIHBsYW5lX3N0YXRl LCAwKTsKPiArCW9mZnNldCA9IGludGVsX2NvbXB1dGVfdGlsZV9vZmZzZXQoJnNyY194LCAmc3Jj X3ksIHBsYW5lX3N0YXRlLCAwKTsKPiArCj4gKwlpZiAoc3JjX3ggIT0gMCB8fCBzcmNfeSAhPSAw KSB7Cj4gKwkJRFJNX0RFQlVHX0tNUygiQXJiaXRyYXJ5IGN1cnNvciBwYW5uaW5nIG5vdCBzdXBw b3J0ZWRcbiIpOwo+ICsJCXJldHVybiAtRUlOVkFMOwo+ICsJfQo+ICsKPiArCXBsYW5lX3N0YXRl LT5tYWluLm9mZnNldCA9IG9mZnNldDsKPiArCj4gIAlyZXR1cm4gMDsKPiAgfQo+ICAKPiAtLSAK PiAyLjEwLjIKPiAKPiBfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fXwo+IEludGVsLWdmeCBtYWlsaW5nIGxpc3QKPiBJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0 b3Aub3JnCj4gaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9p bnRlbC1nZngKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18K SW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0 dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg==