From: Jason Gunthorpe Subject: Re: [PATCH v3] Add "shutdown" to "struct class". Date: Mon, 15 May 2017 11:45:33 -0600 Message-ID: <20170515174533.GB6229@obsidianresearch.com> References: <20170515173438.13420-1-joshz@google.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: tpmdd-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org To: Josh Zimmerman Cc: Greg Kroah-Hartman , tpmdd-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: tpmdd-devel@lists.sourceforge.net On Mon, May 15, 2017 at 10:39:08AM -0700, Josh Zimmerman wrote: > (Continuing thread from patch v1) > > > On Sat, May 13, 2017 at 12:43:11PM +0000, Winkler, Tomas wrote: > > > > > The TPM class has some common shutdown code that must be executed > > > > > for all drivers. This adds some needed functionality for that > > > > > > > > The issue with this is, that on some platforms the only storage can be > > > > eMMC and TPM is using it,. It has to be ensured that the storage > > > > device won't go down before TPM2_shutdown is called. And there is no > > > > direct device hierarchy to ensure an orderly shutdown. > > > > > > Something will have to use the new device links stuff to define that > > > dependency, but that seems unrelated to this patch? > > > > > > Yep, it's not directly related to this specific patch, this is more relevant particularly to TPM2_shutdown. > > Jason, do you want me to do that in my patch on the tpmdd-devel list? > If so, mind giving me a documentation pointer or two? I'm not familiar > with this area. No.. Ordering power management events is something someone with knowledge of the specific emmc platform is going to have to tackle.. It isn't really a core problem, platform specific code will have to setup the needed device links to order power management properly.. Jason ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot