From: Liviu Dudau Subject: Re: [PATCH v2 2/3] drm: Create a format/modifier blob Date: Wed, 17 May 2017 00:24:41 +0100 Message-ID: <20170516232440.GE24388@bart.dudau.co.uk> References: <20170516213126.8269-1-ben@bwidawsk.net> <20170516213126.8269-2-ben@bwidawsk.net> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <20170516213126.8269-2-ben@bwidawsk.net> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Ben Widawsky Cc: Intel GFX , "Kristian H . Kristensen" , DRI Development , Daniel Stone List-Id: dri-devel@lists.freedesktop.org T24gVHVlLCBNYXkgMTYsIDIwMTcgYXQgMDI6MzE6MjVQTSAtMDcwMCwgQmVuIFdpZGF3c2t5IHdy b3RlOgo+IFVwZGF0ZWQgYmxvYiBsYXlvdXQgKFJvYiwgRGFuaWVsLCBLcmlzdGlhbiwgeGVycGkp Cj4gCj4gdjI6Cj4gKiBSZW1vdmVkIF9fcGFja2VkLCBhbmQgYWxpZ25tZW50ICguKykKPiAqIEZp eCBpbmRlbnQgaW4gZHJtX2Zvcm1hdF9tb2RpZmllciBmaWVsZHMgKExpdml1KQo+ICogUmVtb3Zl IGR1cGxpY2F0ZWQgbW9kaWZpZXIgPiA2NCBjaGVjayAoTGl2aXUpCj4gKiBDaGFuZ2UgY29tbWVu dCBhYm91dCBtb2RpZmllciAoTGl2aXUpCj4gKiBSZW1vdmUgYXJndW1lbnRzIHRvIGJsb2IgY3Jl YXRpb24sIHVzZSBwbGFuZSBpbnN0ZWFkIChMaXZpdSkKPiAqIEZpeCBkYXRhIHR5cGVzIChCZW4p Cj4gKiBNYWtlIHRoZSBibG9iIHBhcnQgb2YgdWFwaSAoRGFuaWVsKQoKVGhhbmtzIGZvciB1cGRh dGluZyB0aGUgcGF0Y2ghCgo+IAo+IENjOiBSb2IgQ2xhcmsgPHJvYmRjbGFya0BnbWFpbC5jb20+ Cj4gQ2M6IERhbmllbCBTdG9uZSA8ZGFuaWVsc0Bjb2xsYWJvcmEuY29tPgo+IENjOiBLcmlzdGlh biBILiBLcmlzdGVuc2VuIDxob2Vnc2JlcmdAZ21haWwuY29tPgo+IENjOiBMaXZpdSBEdWRhdSA8 bGl2aXVAZHVkYXUuY28udWs+Cj4gU2lnbmVkLW9mZi1ieTogQmVuIFdpZGF3c2t5IDxiZW5AYndp ZGF3c2submV0Pgo+IFJldmlld2VkLWJ5OiBEYW5pZWwgU3RvbmUgPGRhbmllbHNAY29sbGFib3Jh LmNvbT4KCkxvb2tzIGdvb2QgdG8gbWUhClJldmlld2VkLWJ5OiBMaXZpdSBEdWRhdSA8bGl2aXVA ZHVkYXUuY28udWs+CgpCZXN0IHJlZ2FyZHMsCkxpdml1Cgo+IC0tLQo+ICBkcml2ZXJzL2dwdS9k cm0vZHJtX21vZGVfY29uZmlnLmMgfCAgNyArKysKPiAgZHJpdmVycy9ncHUvZHJtL2RybV9wbGFu ZS5jICAgICAgIHwgODkgKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrCj4g IGluY2x1ZGUvZHJtL2RybV9tb2RlX2NvbmZpZy5oICAgICB8ICA2ICsrKwo+ICBpbmNsdWRlL3Vh cGkvZHJtL2RybV9tb2RlLmggICAgICAgfCA1MCArKysrKysrKysrKysrKysrKysrKysrCj4gIDQg ZmlsZXMgY2hhbmdlZCwgMTUyIGluc2VydGlvbnMoKykKPiAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVy cy9ncHUvZHJtL2RybV9tb2RlX2NvbmZpZy5jIGIvZHJpdmVycy9ncHUvZHJtL2RybV9tb2RlX2Nv bmZpZy5jCj4gaW5kZXggZDk4NjIyNTlhMmE3Li42YmZiYzM4MzlkZjUgMTAwNjQ0Cj4gLS0tIGEv ZHJpdmVycy9ncHUvZHJtL2RybV9tb2RlX2NvbmZpZy5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJt L2RybV9tb2RlX2NvbmZpZy5jCj4gQEAgLTMzNyw2ICszMzcsMTMgQEAgc3RhdGljIGludCBkcm1f bW9kZV9jcmVhdGVfc3RhbmRhcmRfcHJvcGVydGllcyhzdHJ1Y3QgZHJtX2RldmljZSAqZGV2KQo+ ICAJCXJldHVybiAtRU5PTUVNOwo+ICAJZGV2LT5tb2RlX2NvbmZpZy5nYW1tYV9sdXRfc2l6ZV9w cm9wZXJ0eSA9IHByb3A7Cj4gIAo+ICsJcHJvcCA9IGRybV9wcm9wZXJ0eV9jcmVhdGUoZGV2LAo+ ICsJCQkJICAgRFJNX01PREVfUFJPUF9JTU1VVEFCTEUgfCBEUk1fTU9ERV9QUk9QX0JMT0IsCj4g KwkJCQkgICAiSU5fRk9STUFUUyIsIDApOwo+ICsJaWYgKCFwcm9wKQo+ICsJCXJldHVybiAtRU5P TUVNOwo+ICsJZGV2LT5tb2RlX2NvbmZpZy5tb2RpZmllcnMgPSBwcm9wOwo+ICsKPiAgCXJldHVy biAwOwo+ICB9Cj4gIAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vZHJtX3BsYW5lLmMg Yi9kcml2ZXJzL2dwdS9kcm0vZHJtX3BsYW5lLmMKPiBpbmRleCAyMDIwMzg3MWUwNmQuLmY1YjAz MmI1Zjc2MSAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vZHJtX3BsYW5lLmMKPiArKysg Yi9kcml2ZXJzL2dwdS9kcm0vZHJtX3BsYW5lLmMKPiBAQCAtNjIsNiArNjIsOTIgQEAgc3RhdGlj IHVuc2lnbmVkIGludCBkcm1fbnVtX3BsYW5lcyhzdHJ1Y3QgZHJtX2RldmljZSAqZGV2KQo+ICAJ cmV0dXJuIG51bTsKPiAgfQo+ICAKPiArc3RhdGljIGlubGluZSB1MzIgKgo+ICtmb3JtYXRzX3B0 cihzdHJ1Y3QgZHJtX2Zvcm1hdF9tb2RpZmllcl9ibG9iICpibG9iKQo+ICt7Cj4gKwlyZXR1cm4g KHUzMiAqKSgoKGNoYXIgKilibG9iKSArIGJsb2ItPmZvcm1hdHNfb2Zmc2V0KTsKPiArfQo+ICsK PiArc3RhdGljIGlubGluZSBzdHJ1Y3QgZHJtX2Zvcm1hdF9tb2RpZmllciAqCj4gK21vZGlmaWVy c19wdHIoc3RydWN0IGRybV9mb3JtYXRfbW9kaWZpZXJfYmxvYiAqYmxvYikKPiArewo+ICsJcmV0 dXJuIChzdHJ1Y3QgZHJtX2Zvcm1hdF9tb2RpZmllciAqKSgoKGNoYXIgKilibG9iKSArIGJsb2It Pm1vZGlmaWVyc19vZmZzZXQpOwo+ICt9Cj4gKwo+ICtzdGF0aWMgaW50IGNyZWF0ZV9pbl9mb3Jt YXRfYmxvYihzdHJ1Y3QgZHJtX2RldmljZSAqZGV2LCBzdHJ1Y3QgZHJtX3BsYW5lICpwbGFuZSkK PiArewo+ICsJY29uc3Qgc3RydWN0IGRybV9tb2RlX2NvbmZpZyAqY29uZmlnID0gJmRldi0+bW9k ZV9jb25maWc7Cj4gKwljb25zdCB1aW50NjRfdCAqdGVtcF9tb2RpZmllcnMgPSBwbGFuZS0+bW9k aWZpZXJzOwo+ICsJdW5zaWduZWQgaW50IGZvcm1hdF9tb2RpZmllcl9jb3VudCA9IDA7Cj4gKwlz dHJ1Y3QgZHJtX3Byb3BlcnR5X2Jsb2IgKmJsb2IgPSBOVUxMOwo+ICsJc3RydWN0IGRybV9mb3Jt YXRfbW9kaWZpZXIgKm1vZDsKPiArCXNpemVfdCBibG9iX3NpemUgPSAwLCBmb3JtYXRzX3NpemUs IG1vZGlmaWVyc19zaXplOwo+ICsJc3RydWN0IGRybV9mb3JtYXRfbW9kaWZpZXJfYmxvYiAqYmxv Yl9kYXRhOwo+ICsJaW50IGksIGosIHJldCA9IDA7Cj4gKwo+ICsJaWYgKHBsYW5lLT5tb2RpZmll cnMpCj4gKwkJd2hpbGUgKCp0ZW1wX21vZGlmaWVycysrICE9IERSTV9GT1JNQVRfTU9EX0lOVkFM SUQpCj4gKwkJCWZvcm1hdF9tb2RpZmllcl9jb3VudCsrOwo+ICsKPiArCWZvcm1hdHNfc2l6ZSA9 IHNpemVvZigqcGxhbmUtPmZvcm1hdF90eXBlcykgKiBwbGFuZS0+Zm9ybWF0X2NvdW50Owo+ICsJ aWYgKFdBUk5fT04oIWZvcm1hdHNfc2l6ZSkpIHsKPiArCQkvKiAwIGZvcm1hdHMgYXJlIG5ldmVy IGV4cGVjdGVkICovCj4gKwkJcmV0dXJuIDA7Cj4gKwl9Cj4gKwo+ICsJbW9kaWZpZXJzX3NpemUg PQo+ICsJCXNpemVvZihzdHJ1Y3QgZHJtX2Zvcm1hdF9tb2RpZmllcikgKiBmb3JtYXRfbW9kaWZp ZXJfY291bnQ7Cj4gKwo+ICsJYmxvYl9zaXplID0gc2l6ZW9mKHN0cnVjdCBkcm1fZm9ybWF0X21v ZGlmaWVyX2Jsb2IpOwo+ICsJYmxvYl9zaXplICs9IEFMSUdOKGZvcm1hdHNfc2l6ZSwgOCk7Cj4g KwlibG9iX3NpemUgKz0gbW9kaWZpZXJzX3NpemU7Cj4gKwo+ICsJYmxvYiA9IGRybV9wcm9wZXJ0 eV9jcmVhdGVfYmxvYihkZXYsIGJsb2Jfc2l6ZSwgTlVMTCk7Cj4gKwlpZiAoSVNfRVJSKGJsb2Ip KQo+ICsJCXJldHVybiAtMTsKPiArCj4gKwlibG9iX2RhdGEgPSAoc3RydWN0IGRybV9mb3JtYXRf bW9kaWZpZXJfYmxvYiAqKWJsb2ItPmRhdGE7Cj4gKwlibG9iX2RhdGEtPnZlcnNpb24gPSBGT1JN QVRfQkxPQl9DVVJSRU5UOwo+ICsJYmxvYl9kYXRhLT5jb3VudF9mb3JtYXRzID0gcGxhbmUtPmZv cm1hdF9jb3VudDsKPiArCWJsb2JfZGF0YS0+Zm9ybWF0c19vZmZzZXQgPSBzaXplb2Yoc3RydWN0 IGRybV9mb3JtYXRfbW9kaWZpZXJfYmxvYik7Cj4gKwlibG9iX2RhdGEtPmNvdW50X21vZGlmaWVy cyA9IGZvcm1hdF9tb2RpZmllcl9jb3VudDsKPiArCj4gKwkvKiBNb2RpZmllcnMgb2Zmc2V0IGlz IGEgcG9pbnRlciB0byBhIHN0cnVjdCB3aXRoIGEgNjQgYml0IGZpZWxkIHNvIGl0Cj4gKwkgKiBz aG91bGQgYmUgbmF0dXJhbGx5IGFsaWduZWQgdG8gOEIuCj4gKwkgKi8KPiArCWJsb2JfZGF0YS0+ bW9kaWZpZXJzX29mZnNldCA9Cj4gKwkJQUxJR04oYmxvYl9kYXRhLT5mb3JtYXRzX29mZnNldCAr IGZvcm1hdHNfc2l6ZSwgOCk7Cj4gKwo+ICsJbWVtY3B5KGZvcm1hdHNfcHRyKGJsb2JfZGF0YSks IHBsYW5lLT5mb3JtYXRfdHlwZXMsIGZvcm1hdHNfc2l6ZSk7Cj4gKwo+ICsJLyogSWYgd2UgY2Fu J3QgZGV0ZXJtaW5lIHN1cHBvcnQsIGp1c3QgYmFpbCAqLwo+ICsJaWYgKCFwbGFuZS0+ZnVuY3Mt PmZvcm1hdF9tb2Rfc3VwcG9ydGVkKQo+ICsJCWdvdG8gZG9uZTsKPiArCj4gKwltb2QgPSBtb2Rp ZmllcnNfcHRyKGJsb2JfZGF0YSk7Cj4gKwlmb3IgKGkgPSAwOyBpIDwgZm9ybWF0X21vZGlmaWVy X2NvdW50OyBpKyspIHsKPiArCQlmb3IgKGogPSAwOyBqIDwgcGxhbmUtPmZvcm1hdF9jb3VudDsg aisrKSB7Cj4gKwkJCWlmIChwbGFuZS0+ZnVuY3MtPmZvcm1hdF9tb2Rfc3VwcG9ydGVkKHBsYW5l LAo+ICsJCQkJCQkJICAgICAgIHBsYW5lLT5mb3JtYXRfdHlwZXNbal0sCj4gKwkJCQkJCQkgICAg ICAgcGxhbmUtPm1vZGlmaWVyc1tpXSkpIHsKPiArCj4gKwkJCQltb2QtPmZvcm1hdHMgfD0gMSA8 PCBqOwo+ICsJCQl9Cj4gKwkJfQo+ICsKPiArCQltb2QtPm1vZGlmaWVyID0gcGxhbmUtPm1vZGlm aWVyc1tpXTsKPiArCQltb2QtPm9mZnNldCA9IDA7Cj4gKwkJbW9kLT5wYWQgPSAwOwo+ICsJCW1v ZCsrOwo+ICsJfQo+ICsKPiArZG9uZToKPiArCWRybV9vYmplY3RfYXR0YWNoX3Byb3BlcnR5KCZw bGFuZS0+YmFzZSwgY29uZmlnLT5tb2RpZmllcnMsCj4gKwkJCQkgICBibG9iLT5iYXNlLmlkKTsK PiArCj4gKwlyZXR1cm4gcmV0Owo+ICt9Cj4gKwo+ICAvKioKPiAgICogZHJtX3VuaXZlcnNhbF9w bGFuZV9pbml0IC0gSW5pdGlhbGl6ZSBhIG5ldyB1bml2ZXJzYWwgcGxhbmUgb2JqZWN0Cj4gICAq IEBkZXY6IERSTSBkZXZpY2UKPiBAQCAtMTgwLDYgKzI2Niw5IEBAIGludCBkcm1fdW5pdmVyc2Fs X3BsYW5lX2luaXQoc3RydWN0IGRybV9kZXZpY2UgKmRldiwgc3RydWN0IGRybV9wbGFuZSAqcGxh bmUsCj4gIAkJZHJtX29iamVjdF9hdHRhY2hfcHJvcGVydHkoJnBsYW5lLT5iYXNlLCBjb25maWct PnByb3Bfc3JjX2gsIDApOwo+ICAJfQo+ICAKPiArCWlmIChjb25maWctPmFsbG93X2ZiX21vZGlm aWVycykKPiArCQljcmVhdGVfaW5fZm9ybWF0X2Jsb2IoZGV2LCBwbGFuZSk7Cj4gKwo+ICAJcmV0 dXJuIDA7Cj4gIH0KPiAgRVhQT1JUX1NZTUJPTChkcm1fdW5pdmVyc2FsX3BsYW5lX2luaXQpOwo+ IGRpZmYgLS1naXQgYS9pbmNsdWRlL2RybS9kcm1fbW9kZV9jb25maWcuaCBiL2luY2x1ZGUvZHJt L2RybV9tb2RlX2NvbmZpZy5oCj4gaW5kZXggNDI5ODE3MTExODliLi4wMzc3NmU2NTk4MTEgMTAw NjQ0Cj4gLS0tIGEvaW5jbHVkZS9kcm0vZHJtX21vZGVfY29uZmlnLmgKPiArKysgYi9pbmNsdWRl L2RybS9kcm1fbW9kZV9jb25maWcuaAo+IEBAIC03NTcsNiArNzU3LDEyIEBAIHN0cnVjdCBkcm1f bW9kZV9jb25maWcgewo+ICAJICovCj4gIAlib29sIGFsbG93X2ZiX21vZGlmaWVyczsKPiAgCj4g KwkvKioKPiArCSAqIEBtb2RpZmllcnM6IFBsYW5lIHByb3BlcnR5IHRvIGxpc3Qgc3VwcG9ydCBt b2RpZmllci9mb3JtYXQKPiArCSAqIGNvbWJpbmF0aW9uLgo+ICsJICovCj4gKwlzdHJ1Y3QgZHJt X3Byb3BlcnR5ICptb2RpZmllcnM7Cj4gKwo+ICAJLyogY3Vyc29yIHNpemUgKi8KPiAgCXVpbnQz Ml90IGN1cnNvcl93aWR0aCwgY3Vyc29yX2hlaWdodDsKPiAgCj4gZGlmZiAtLWdpdCBhL2luY2x1 ZGUvdWFwaS9kcm0vZHJtX21vZGUuaCBiL2luY2x1ZGUvdWFwaS9kcm0vZHJtX21vZGUuaAo+IGlu ZGV4IDhjNjdmYzAzZDUzZC4uN2FkNTY3OTAzZmRjIDEwMDY0NAo+IC0tLSBhL2luY2x1ZGUvdWFw aS9kcm0vZHJtX21vZGUuaAo+ICsrKyBiL2luY2x1ZGUvdWFwaS9kcm0vZHJtX21vZGUuaAo+IEBA IC02NjUsNiArNjY1LDU2IEBAIHN0cnVjdCBkcm1fbW9kZV9hdG9taWMgewo+ICAJX191NjQgdXNl cl9kYXRhOwo+ICB9Owo+ICAKPiArc3RydWN0IGRybV9mb3JtYXRfbW9kaWZpZXJfYmxvYiB7Cj4g KyNkZWZpbmUgRk9STUFUX0JMT0JfQ1VSUkVOVCAxCj4gKwkvKiBWZXJzaW9uIG9mIHRoaXMgYmxv YiBmb3JtYXQgKi8KPiArCXUzMiB2ZXJzaW9uOwo+ICsKPiArCS8qIEZsYWdzICovCj4gKwl1MzIg ZmxhZ3M7Cj4gKwo+ICsJLyogTnVtYmVyIG9mIGZvdXJjYyBmb3JtYXRzIHN1cHBvcnRlZCAqLwo+ ICsJdTMyIGNvdW50X2Zvcm1hdHM7Cj4gKwo+ICsJLyogV2hlcmUgaW4gdGhpcyBibG9iIHRoZSBm b3JtYXRzIGV4aXN0IChpbiBieXRlcykgKi8KPiArCXUzMiBmb3JtYXRzX29mZnNldDsKPiArCj4g KwkvKiBOdW1iZXIgb2YgZHJtX2Zvcm1hdF9tb2RpZmllcnMgKi8KPiArCXUzMiBjb3VudF9tb2Rp ZmllcnM7Cj4gKwo+ICsJLyogV2hlcmUgaW4gdGhpcyBibG9iIHRoZSBtb2RpZmllcnMgZXhpc3Qg KGluIGJ5dGVzKSAqLwo+ICsJdTMyIG1vZGlmaWVyc19vZmZzZXQ7Cj4gKwo+ICsJLyogdTMyIGZv cm1hdHNbXSAqLwo+ICsJLyogc3RydWN0IGRybV9mb3JtYXRfbW9kaWZpZXIgbW9kaWZpZXJzW10g Ki8KPiArfTsKPiArCj4gK3N0cnVjdCBkcm1fZm9ybWF0X21vZGlmaWVyIHsKPiArCS8qIEJpdG1h c2sgb2YgZm9ybWF0cyBpbiBnZXRfcGxhbmUgZm9ybWF0IGxpc3QgdGhpcyBpbmZvIGFwcGxpZXMg dG8uIFRoZQo+ICsJICogb2Zmc2V0IGFsbG93cyBhIHNsaWRpbmcgd2luZG93IG9mIHdoaWNoIDY0 IGZvcm1hdHMgKGJpdHMpLgo+ICsJICoKPiArCSAqIFNvbWUgZXhhbXBsZXM6Cj4gKwkgKiBJbiB0 b2RheSdzIHdvcmxkIHdpdGggPCA2NSBmb3JtYXRzLCBhbmQgZm9ybWF0cyAwLCBhbmQgMiBhcmUK PiArCSAqIHN1cHBvcnRlZAo+ICsJICogMHgwMDAwMDAwMDAwMDAwMDA1Cj4gKwkgKgkJICBeLW9m ZnNldCA9IDAsIGZvcm1hdHMgPSA1Cj4gKwkgKgo+ICsJICogSWYgdGhlIG51bWJlciBmb3JtYXRz IGdyZXcgdG8gMTI4LCBhbmQgZm9ybWF0cyA5OC0xMDIgYXJlCj4gKwkgKiBzdXBwb3J0ZWQgd2l0 aCB0aGUgbW9kaWZpZXI6Cj4gKwkgKgo+ICsJICogMHgwMDAwMDAzYzAwMDAwMDAwIDAwMDAwMDAw MDAwMDAwMDAKPiArCSAqCQkgIF4KPiArCSAqCQkgIHxfX29mZnNldCA9IDY0LCBmb3JtYXRzID0g MHgzYzAwMDAwMDAwCj4gKwkgKgo+ICsJICovCj4gKwlfX3U2NCBmb3JtYXRzOwo+ICsJX191MzIg b2Zmc2V0Owo+ICsJX191MzIgcGFkOwo+ICsKPiArCS8qIFRoZSBtb2RpZmllciB0aGF0IGFwcGxp ZXMgdG8gdGhlID5nZXRfcGxhbmUgZm9ybWF0IGxpc3QgYml0bWFzay4gKi8KPiArCV9fdTY0IG1v ZGlmaWVyOwo+ICt9Owo+ICsKPiAgLyoqCj4gICAqIENyZWF0ZSBhIG5ldyAnYmxvYicgZGF0YSBw cm9wZXJ0eSwgY29weWluZyBsZW5ndGggYnl0ZXMgZnJvbSBkYXRhIHBvaW50ZXIsCj4gICAqIGFu ZCByZXR1cm5pbmcgbmV3IGJsb2IgSUQuCj4gLS0gCj4gMi4xMy4wCj4gCl9fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QK SW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9w Lm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo=