From: Ben Widawsky Subject: Re: [Intel-gfx] [PATCH v2 2/3] drm: Create a format/modifier blob Date: Wed, 17 May 2017 17:46:18 -0700 Message-ID: <20170518004618.GC2334@mail.bwidawsk.net> References: <20170516213126.8269-1-ben@bwidawsk.net> <20170516213126.8269-2-ben@bwidawsk.net> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Emil Velikov Cc: Intel GFX , "Kristian H . Kristensen" , Daniel Stone , DRI Development List-Id: dri-devel@lists.freedesktop.org T24gMTctMDUtMTcgMDE6MDY6MTYsIEVtaWwgVmVsaWtvdiB3cm90ZToKPkhpIEJlbiwKPgo+T24g MTYgTWF5IDIwMTcgYXQgMjI6MzEsIEJlbiBXaWRhd3NreSA8YmVuQGJ3aWRhd3NrLm5ldD4gd3Jv dGU6Cj4+IFVwZGF0ZWQgYmxvYiBsYXlvdXQgKFJvYiwgRGFuaWVsLCBLcmlzdGlhbiwgeGVycGkp Cj4+Cj4+IHYyOgo+PiAqIFJlbW92ZWQgX19wYWNrZWQsIGFuZCBhbGlnbm1lbnQgKC4rKQo+PiAq IEZpeCBpbmRlbnQgaW4gZHJtX2Zvcm1hdF9tb2RpZmllciBmaWVsZHMgKExpdml1KQo+PiAqIFJl bW92ZSBkdXBsaWNhdGVkIG1vZGlmaWVyID4gNjQgY2hlY2sgKExpdml1KQo+PiAqIENoYW5nZSBj b21tZW50IGFib3V0IG1vZGlmaWVyIChMaXZpdSkKPj4gKiBSZW1vdmUgYXJndW1lbnRzIHRvIGJs b2IgY3JlYXRpb24sIHVzZSBwbGFuZSBpbnN0ZWFkIChMaXZpdSkKPj4gKiBGaXggZGF0YSB0eXBl cyAoQmVuKQo+PiAqIE1ha2UgdGhlIGJsb2IgcGFydCBvZiB1YXBpIChEYW5pZWwpCj4+Cj4+IENj OiBSb2IgQ2xhcmsgPHJvYmRjbGFya0BnbWFpbC5jb20+Cj4+IENjOiBEYW5pZWwgU3RvbmUgPGRh bmllbHNAY29sbGFib3JhLmNvbT4KPj4gQ2M6IEtyaXN0aWFuIEguIEtyaXN0ZW5zZW4gPGhvZWdz YmVyZ0BnbWFpbC5jb20+Cj4+IENjOiBMaXZpdSBEdWRhdSA8bGl2aXVAZHVkYXUuY28udWs+Cj4+ IFNpZ25lZC1vZmYtYnk6IEJlbiBXaWRhd3NreSA8YmVuQGJ3aWRhd3NrLm5ldD4KPj4gUmV2aWV3 ZWQtYnk6IERhbmllbCBTdG9uZSA8ZGFuaWVsc0Bjb2xsYWJvcmEuY29tPgo+Cj5JIHRoaW5rIHRo aXMgaXMgYWxtb3N0IHBlcmZlY3QsIGJhcnJpbmcgdGhlIFVBUEkgbml0cGljay4KPlRoZSByZXN0 IGlzIHNvbWV3aGF0IG9mIGEgYmlrZXNoZWRkaW5nLgo+Cj5XaXRoIHRoZSBVQVBJIHJlc29sdmVk LCByZWdhcmRsZXNzIG9mIHRoZSByZXN0Cj5SZXZpZXdlZC1ieTogRW1pbCBWZWxpa292IDxlbWls LmwudmVsaWtvdkBnbWFpbC5jb20+Cj4KPgo+PiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vZHJtX3Bs YW5lLmMKPj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2RybV9wbGFuZS5jCj4KPj4gK3N0YXRpYyBp bnQgY3JlYXRlX2luX2Zvcm1hdF9ibG9iKHN0cnVjdCBkcm1fZGV2aWNlICpkZXYsIHN0cnVjdCBk cm1fcGxhbmUgKnBsYW5lKQo+PiArewo+PiArICAgICAgIGNvbnN0IHN0cnVjdCBkcm1fbW9kZV9j b25maWcgKmNvbmZpZyA9ICZkZXYtPm1vZGVfY29uZmlnOwo+PiArICAgICAgIGNvbnN0IHVpbnQ2 NF90ICp0ZW1wX21vZGlmaWVycyA9IHBsYW5lLT5tb2RpZmllcnM7Cj4+ICsgICAgICAgdW5zaWdu ZWQgaW50IGZvcm1hdF9tb2RpZmllcl9jb3VudCA9IDA7Cj4+ICsgICAgICAgc3RydWN0IGRybV9w cm9wZXJ0eV9ibG9iICpibG9iID0gTlVMTDsKPj4gKyAgICAgICBzdHJ1Y3QgZHJtX2Zvcm1hdF9t b2RpZmllciAqbW9kOwo+PiArICAgICAgIHNpemVfdCBibG9iX3NpemUgPSAwLCBmb3JtYXRzX3Np emUsIG1vZGlmaWVyc19zaXplOwo+VGhlcmUncyBubyBuZWVkIHRvIGluaXRpYWxpemUgYmxvYiBh bmQgYmxvYl9zaXplIGhlcmUuCj4KPj4gKyAgICAgICBzdHJ1Y3QgZHJtX2Zvcm1hdF9tb2RpZmll cl9ibG9iICpibG9iX2RhdGE7Cj4+ICsgICAgICAgaW50IGksIGosIHJldCA9IDA7Cj5NYWtlIGkg YW5kIGogdW5zaWduZWQgdG8gbWF0Y2ggZm9ybWF0X21vZGlmaWVyX2NvdW50IGFuZAo+cGxhbmUt PmZvcm1hdF9jb3VudCByZXNwZWN0aXZlbHkuCj5UaGVuIGV4cGFuZCByZXQgaW4gdGhlIG9ubHkg cGxhY2Ugd2hlcmUgaXQncyB1c2VkPwo+CgpPaC4gcmV0IGhhcyBsb3N0IGl0J3MgdXRpbGl0eSBv dmVyIHRoZSBpdGVyYXRpb25zIG9mIHRoaXMgcGF0Y2guIE1ha2UgaSBhbmQgagp1bnNpZ25lZCBh bmQgZHJvcHBlZCByZXQuCgo+PiArCj4+ICsgICAgICAgaWYgKHBsYW5lLT5tb2RpZmllcnMpCj4+ ICsgICAgICAgICAgICAgICB3aGlsZSAoKnRlbXBfbW9kaWZpZXJzKysgIT0gRFJNX0ZPUk1BVF9N T0RfSU5WQUxJRCkKPj4gKyAgICAgICAgICAgICAgICAgICAgICAgZm9ybWF0X21vZGlmaWVyX2Nv dW50Kys7Cj4+ICsKPj4gKyAgICAgICBmb3JtYXRzX3NpemUgPSBzaXplb2YoKnBsYW5lLT5mb3Jt YXRfdHlwZXMpICogcGxhbmUtPmZvcm1hdF9jb3VudDsKPj4gKyAgICAgICBpZiAoV0FSTl9PTigh Zm9ybWF0c19zaXplKSkgewo+PiArICAgICAgICAgICAgICAgLyogMCBmb3JtYXRzIGFyZSBuZXZl ciBleHBlY3RlZCAqLwo+PiArICAgICAgICAgICAgICAgcmV0dXJuIDA7Cj4+ICsgICAgICAgfQo+ PiArCj4+ICsgICAgICAgbW9kaWZpZXJzX3NpemUgPQo+PiArICAgICAgICAgICAgICAgc2l6ZW9m KHN0cnVjdCBkcm1fZm9ybWF0X21vZGlmaWVyKSAqIGZvcm1hdF9tb2RpZmllcl9jb3VudDsKPj4g Kwo+PiArICAgICAgIGJsb2Jfc2l6ZSA9IHNpemVvZihzdHJ1Y3QgZHJtX2Zvcm1hdF9tb2RpZmll cl9ibG9iKTsKPj4gKyAgICAgICBibG9iX3NpemUgKz0gQUxJR04oZm9ybWF0c19zaXplLCA4KTsK PldvcnRoIGhhdmluZyB0aGUgIk1vZGlmaWVycyBvZmZzZXQgaXMgYSBwb2ludGVyLi4uIiBjb21t ZW50IG1vdmVkL2NvcGllZCBoZXJlPwo+CgpZZXMgaXQgaXMuCgo+PiArICAgICAgIGJsb2Jfc2l6 ZSArPSBtb2RpZmllcnNfc2l6ZTsKPj4gKwo+PiArICAgICAgIGJsb2IgPSBkcm1fcHJvcGVydHlf Y3JlYXRlX2Jsb2IoZGV2LCBibG9iX3NpemUsIE5VTEwpOwo+PiArICAgICAgIGlmIChJU19FUlIo YmxvYikpCj4+ICsgICAgICAgICAgICAgICByZXR1cm4gLTE7Cj4+ICsKPk1heWJlIHByb3BhZ2F0 ZSB0aGUgZXhhY3QgZXJyb3IuLi4gSG1tIHdlIGRvbid0IHNlZW0gdG8gY2hlY2sgaWYKPmNyZWF0 ZV9pbl9mb3JtYXRfYmxvYiBmYWlscyBlaXRoZXIgc28gcGVyaGFwcyBpdCdzIG5vdCB3b3J0aCBp dC4KPgo+CgpJbiB0aGlzIGNhc2UgaXQncyBhbG1vc3QgZGVmaW5pdGVseSBFTk9NRU0uIEFsbCB2 YWx1ZXMgc2hvdWxkIGJlIHZlcmlmaWVkIC0gSQp0aGluayB0aGUgb3RoZXIgZXJyb3JzIGFyZSB0 aGVyZSBmb3Igd2hlbiB1c2Vyc3BhY2UgaXMgdXRpbGl6aW5nIGJsb2IgY3JlYXRpb24uCgpTbyBJ J2xsIGp1c3QgbGVhdmUgaXQuCgo+PiAtLS0gYS9pbmNsdWRlL3VhcGkvZHJtL2RybV9tb2RlLmgK Pj4gKysrIGIvaW5jbHVkZS91YXBpL2RybS9kcm1fbW9kZS5oCj4+IEBAIC02NjUsNiArNjY1LDU2 IEBAIHN0cnVjdCBkcm1fbW9kZV9hdG9taWMgewo+PiAgICAgICAgIF9fdTY0IHVzZXJfZGF0YTsK Pj4gIH07Cj4+Cj4+ICtzdHJ1Y3QgZHJtX2Zvcm1hdF9tb2RpZmllcl9ibG9iIHsKPj4gKyNkZWZp bmUgRk9STUFUX0JMT0JfQ1VSUkVOVCAxCj4+ICsgICAgICAgLyogVmVyc2lvbiBvZiB0aGlzIGJs b2IgZm9ybWF0ICovCj4+ICsgICAgICAgdTMyIHZlcnNpb247Cj4+ICsKPj4gKyAgICAgICAvKiBG bGFncyAqLwo+PiArICAgICAgIHUzMiBmbGFnczsKPj4gKwo+PiArICAgICAgIC8qIE51bWJlciBv ZiBmb3VyY2MgZm9ybWF0cyBzdXBwb3J0ZWQgKi8KPj4gKyAgICAgICB1MzIgY291bnRfZm9ybWF0 czsKPj4gKwo+PiArICAgICAgIC8qIFdoZXJlIGluIHRoaXMgYmxvYiB0aGUgZm9ybWF0cyBleGlz dCAoaW4gYnl0ZXMpICovCj4+ICsgICAgICAgdTMyIGZvcm1hdHNfb2Zmc2V0Owo+PiArCj4+ICsg ICAgICAgLyogTnVtYmVyIG9mIGRybV9mb3JtYXRfbW9kaWZpZXJzICovCj4+ICsgICAgICAgdTMy IGNvdW50X21vZGlmaWVyczsKPj4gKwo+PiArICAgICAgIC8qIFdoZXJlIGluIHRoaXMgYmxvYiB0 aGUgbW9kaWZpZXJzIGV4aXN0IChpbiBieXRlcykgKi8KPj4gKyAgICAgICB1MzIgbW9kaWZpZXJz X29mZnNldDsKPj4gKwo+PiArICAgICAgIC8qIHUzMiBmb3JtYXRzW10gKi8KPj4gKyAgICAgICAv KiBzdHJ1Y3QgZHJtX2Zvcm1hdF9tb2RpZmllciBtb2RpZmllcnNbXSAqLwo+PiArfTsKPj4gKwo+ PiArc3RydWN0IGRybV9mb3JtYXRfbW9kaWZpZXIgewo+PiArICAgICAgIC8qIEJpdG1hc2sgb2Yg Zm9ybWF0cyBpbiBnZXRfcGxhbmUgZm9ybWF0IGxpc3QgdGhpcyBpbmZvIGFwcGxpZXMgdG8uIFRo ZQo+PiArICAgICAgICAqIG9mZnNldCBhbGxvd3MgYSBzbGlkaW5nIHdpbmRvdyBvZiB3aGljaCA2 NCBmb3JtYXRzIChiaXRzKS4KPj4gKyAgICAgICAgKgo+PiArICAgICAgICAqIFNvbWUgZXhhbXBs ZXM6Cj4+ICsgICAgICAgICogSW4gdG9kYXkncyB3b3JsZCB3aXRoIDwgNjUgZm9ybWF0cywgYW5k IGZvcm1hdHMgMCwgYW5kIDIgYXJlCj4+ICsgICAgICAgICogc3VwcG9ydGVkCj4+ICsgICAgICAg ICogMHgwMDAwMDAwMDAwMDAwMDA1Cj4+ICsgICAgICAgICogICAgICAgICAgICAgICAgXi1vZmZz ZXQgPSAwLCBmb3JtYXRzID0gNQo+PiArICAgICAgICAqCj4+ICsgICAgICAgICogSWYgdGhlIG51 bWJlciBmb3JtYXRzIGdyZXcgdG8gMTI4LCBhbmQgZm9ybWF0cyA5OC0xMDIgYXJlCj4+ICsgICAg ICAgICogc3VwcG9ydGVkIHdpdGggdGhlIG1vZGlmaWVyOgpHPj4gKyAgICAgICAgKgo+PiArICAg ICAgICAqIDB4MDAwMDAwM2MwMDAwMDAwMCAwMDAwMDAwMDAwMDAwMDAwCj4+ICsgICAgICAgICog ICAgICAgICAgICAgICAgXgo+PiArICAgICAgICAqICAgICAgICAgICAgICAgIHxfX29mZnNldCA9 IDY0LCBmb3JtYXRzID0gMHgzYzAwMDAwMDAwCj4+ICsgICAgICAgICoKPj4gKyAgICAgICAgKi8K Pj4gKyAgICAgICBfX3U2NCBmb3JtYXRzOwo+PiArICAgICAgIF9fdTMyIG9mZnNldDsKPj4gKyAg ICAgICBfX3UzMiBwYWQ7Cj4+ICsKPj4gKyAgICAgICAvKiBUaGUgbW9kaWZpZXIgdGhhdCBhcHBs aWVzIHRvIHRoZSA+Z2V0X3BsYW5lIGZvcm1hdCBsaXN0IGJpdG1hc2suICovCj4+ICsgICAgICAg X191NjQgbW9kaWZpZXI7Cj5QbGVhc2UgZHJvcCB0aGUgbGVhZGluZyBfXyBmcm9tIHRoZSB0eXBl IG5hbWVzIGluIFVBUEkgaGVhZGVycy4KPgoKTWFueSBvdGhlciBzdHJ1Y3R1cmVzIGhhdmUgdGhl IF9fLCBjYW4geW91IGV4cGxhaW4gd2h5IHBsZWFzZSAodGhpcyBoYXMgcHJvYmFibHkKYmVlbiBi ZWF0ZW4gdG8gZGVhdGggYWxyZWFkeTsgYnV0IEkgZG9uJ3Qga25vdyk/Cgo+UmVnYXJkcywKPkVt aWwKCi0tIApCZW4gV2lkYXdza3ksIEludGVsIE9wZW4gU291cmNlIFRlY2hub2xvZ3kgQ2VudGVy Cl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZl bCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xp c3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo=