Return-Path: Received: from mx1.redhat.com ([209.132.183.28]:58410 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752007AbdEYLFK (ORCPT ); Thu, 25 May 2017 07:05:10 -0400 From: Jeff Layton To: Alexander Viro Cc: linux-fsdevel@vger.kernel.org Subject: [PATCH] fs: remove unnecessary NULL f_mapping check in sync_file_range Date: Thu, 25 May 2017 07:05:09 -0400 Message-Id: <20170525110509.9434-1-jlayton@redhat.com> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: fsync codepath assumes that f_mapping can never be NULL, but sync_file_range has a check for that. Remove the one from sync_file_range as I don't see how you'd ever get a NULL pointer in here. Signed-off-by: Jeff Layton --- fs/sync.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/fs/sync.c b/fs/sync.c index 11ba023434b1..45ecf6854595 100644 --- a/fs/sync.c +++ b/fs/sync.c @@ -335,11 +335,6 @@ SYSCALL_DEFINE4(sync_file_range, int, fd, loff_t, offset, loff_t, nbytes, goto out_put; mapping = f.file->f_mapping; - if (!mapping) { - ret = -EINVAL; - goto out_put; - } - ret = 0; if (flags & SYNC_FILE_RANGE_WAIT_BEFORE) { ret = filemap_fdatawait_range(mapping, offset, endbyte); -- 2.9.4