From: Imre Deak Subject: Re: [PATCH 04/17] drm/i915/cnl: Allow dynamic cdclk changes on CNL Date: Fri, 9 Jun 2017 16:00:09 +0300 Message-ID: <20170609130009.GC3167@ideak-desk.fi.intel.com> References: <1496959406-6031-1-git-send-email-rodrigo.vivi@intel.com> <1496959406-6031-4-git-send-email-rodrigo.vivi@intel.com> Reply-To: imre.deak@intel.com Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by gabe.freedesktop.org (Postfix) with ESMTPS id 311DB6E5F3 for ; Fri, 9 Jun 2017 13:00:27 +0000 (UTC) Content-Disposition: inline In-Reply-To: <1496959406-6031-4-git-send-email-rodrigo.vivi@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Rodrigo Vivi Cc: Sanyog Kale , intel-gfx@lists.freedesktop.org, Dhinakaran Pandiyan List-Id: intel-gfx@lists.freedesktop.org T24gVGh1LCBKdW4gMDgsIDIwMTcgYXQgMDM6MDM6MTNQTSAtMDcwMCwgUm9kcmlnbyBWaXZpIHdy b3RlOgo+IEFsbCB0aGUgbG93IGxldmVsIGNkY2xrIGJpdHMgYXJlIHByZXNlbnQsIHNvIGxldCdz IGFkZCB0aGUgcmVxdWlyZWQKPiBob29rcyB0byByZWNvbmZpZ3VyZSBjZGNsayBvbiB0aGUgZmx5 Lgo+IAo+IHYyOiBSZWJhc2UgZHVlIHRvIGNubF9zYW5pdGl6ZV9jZGNsaygpCj4gdjM6IFJlYmFz ZWQgYnkgUm9kcmlnbyBvbiB0b3Agb2YgVmlsbGUncyBjZGNsayByZXdvcmsuCj4gdjQ6IFJlYmFz ZSBtb3ZpbmcgY25sX2NhbGNfY2RjbGsgdXAgdG8gZm9sbG93IHNhbWUgb3JkZXIKPiAgICAgYXMg cHJldmlvdXMgcGxhdGZvcm1zLgo+IHYyOiBTcXVhc2ggZHJtL2k5MTUvY25sOiBBZGp1c3QgbWlu IHBpeGVsIHJhdGUuIHRvIGFkZHJlc3MKPiAgICAgdGhlIGN1cnJlbnQgbGltaXRhdGlvbiB3aGVy ZSBDRENMSyBjYW5ub3QgYmUgc2V0IHRvIDE2OE1Iego+ICAgICBpZiBhdWRpbyBpcyB1c2VkIHdp dGggOTZNSHouIChJbXJlKQo+IAo+IENjOiBJbXJlIERlYWsgPGltcmUuZGVha0BpbnRlbC5jb20+ Cj4gQ2M6IERoaW5ha2FyYW4gUGFuZGl5YW4gPGRoaW5ha2FyYW4ucGFuZGl5YW5AaW50ZWwuY29t Pgo+IFNpZ25lZC1vZmYtYnk6IFZpbGxlIFN5cmrDpGzDpCA8dmlsbGUuc3lyamFsYUBsaW51eC5p bnRlbC5jb20+Cj4gU2lnbmVkLW9mZi1ieTogUm9kcmlnbyBWaXZpIDxyb2RyaWdvLnZpdmlAaW50 ZWwuY29tPgo+IAo+IENhbm5vbmxha2UgYWxzbyBuZWVkcyB0byBhZGp1c3QgdGhlIG1pbmltYWwg cGl4ZWwgcmF0ZQo+IGFzIGdlbjkgcGxhdGZvcm1zLiBTcGVjaWFsbHkgZm9yIHRoZSBBemFsaWEg YXVkaW8gY2FzZS4KPiAKPiBDYzogRGhpbmFrYXJhbiBQYW5kaXlhbiA8ZGhpbmFrYXJhbi5wYW5k aXlhbkBpbnRlbC5jb20+Cj4gQ2M6IFNhbnlvZyBLYWxlIDxzYW55b2cuci5rYWxlQGludGVsLmNv bT4KPiBTaWduZWQtb2ZmLWJ5OiBSb2RyaWdvIFZpdmkgPHJvZHJpZ28udml2aUBpbnRlbC5jb20+ Cj4gLS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2NkY2xrLmMgfCA1NiArKysrKysr KysrKysrKysrKysrKysrKysrKysrKysrKysrKystLQo+ICAxIGZpbGUgY2hhbmdlZCwgNTMgaW5z ZXJ0aW9ucygrKSwgMyBkZWxldGlvbnMoLSkKPiAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUv ZHJtL2k5MTUvaW50ZWxfY2RjbGsuYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2NkY2xr LmMKPiBpbmRleCAzNWExNDMyLi4xZDdjZmM1IDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2Ry bS9pOTE1L2ludGVsX2NkY2xrLmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9j ZGNsay5jCj4gQEAgLTE0MDAsNiArMTQwMCwxNiBAQCB2b2lkIGJ4dF91bmluaXRfY2RjbGsoc3Ry dWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2KQo+ICAJYnh0X3NldF9jZGNsayhkZXZfcHJp diwgJmNkY2xrX3N0YXRlKTsKPiAgfQo+ICAKPiArc3RhdGljIGludCBjbmxfY2FsY19jZGNsayhp bnQgbWF4X3BpeGNsaykKPiArewo+ICsJaWYgKG1heF9waXhjbGsgPiAzMzYwMDApCj4gKwkJcmV0 dXJuIDUyODAwMDsKPiArCWVsc2UgaWYgKG1heF9waXhjbGsgPiAxNjgwMDApCj4gKwkJcmV0dXJu IDMzNjAwMDsKPiArCWVsc2UKPiArCQlyZXR1cm4gMTY4MDAwOwo+ICt9Cj4gKwo+ICBzdGF0aWMg dm9pZCBjbmxfY2RjbGtfcGxsX3VwZGF0ZShzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3By aXYsCj4gIAkJCQkgc3RydWN0IGludGVsX2NkY2xrX3N0YXRlICpjZGNsa19zdGF0ZSkKPiAgewo+ IEBAIC0xNjQxLDcgKzE2NTEsNyBAQCB2b2lkIGNubF9pbml0X2NkY2xrKHN0cnVjdCBkcm1faTkx NV9wcml2YXRlICpkZXZfcHJpdikKPiAgCj4gIAljZGNsa19zdGF0ZSA9IGRldl9wcml2LT5jZGNs ay5odzsKPiAgCj4gLQljZGNsa19zdGF0ZS5jZGNsayA9IDE2ODAwMDsKPiArCWNkY2xrX3N0YXRl LmNkY2xrID0gY25sX2NhbGNfY2RjbGsoMCk7Cj4gIAljZGNsa19zdGF0ZS52Y28gPSBjbmxfY2Rj bGtfcGxsX3ZjbyhkZXZfcHJpdiwgY2RjbGtfc3RhdGUuY2RjbGspOwo+ICAKPiAgCWNubF9zZXRf Y2RjbGsoZGV2X3ByaXYsICZjZGNsa19zdGF0ZSk7Cj4gQEAgLTE3NjgsNyArMTc3OCw3IEBAIHN0 YXRpYyBpbnQgaW50ZWxfbWF4X3BpeGVsX3JhdGUoc3RydWN0IGRybV9hdG9taWNfc3RhdGUgKnN0 YXRlKQo+ICAKPiAgCQlwaXhlbF9yYXRlID0gY3J0Y19zdGF0ZS0+cGl4ZWxfcmF0ZTsKPiAgCj4g LQkJaWYgKElTX0JST0FEV0VMTChkZXZfcHJpdikgfHwgSVNfR0VOOShkZXZfcHJpdikpCj4gKwkJ aWYgKElTX0JST0FEV0VMTChkZXZfcHJpdikgfHwgSU5URUxfR0VOKGRldl9wcml2KSA+PSA5KQoK V2UgaGF2ZSB0byByZW1lbWJlciB0byBjaGVjayB0aGlzIG9uIG5ld2VyIHBsYXRmb3JtcywgbG9v a3Mgb2sgZm9yCm5vdzoKUmV2aWV3ZWQtYnk6IEltcmUgRGVhayA8aW1yZS5kZWFrQGludGVsLmNv bT4KCj4gIAkJCXBpeGVsX3JhdGUgPQo+ICAJCQkJYmR3X2FkanVzdF9taW5fcGlwZV9waXhlbF9y YXRlKGNydGNfc3RhdGUsCj4gIAkJCQkJCQkgICAgICAgcGl4ZWxfcmF0ZSk7Cj4gQEAgLTE5Mjks NiArMTkzOSw0MCBAQCBzdGF0aWMgaW50IGJ4dF9tb2Rlc2V0X2NhbGNfY2RjbGsoc3RydWN0IGRy bV9hdG9taWNfc3RhdGUgKnN0YXRlKQo+ICAJcmV0dXJuIDA7Cj4gIH0KPiAgCj4gK3N0YXRpYyBp bnQgY25sX21vZGVzZXRfY2FsY19jZGNsayhzdHJ1Y3QgZHJtX2F0b21pY19zdGF0ZSAqc3RhdGUp Cj4gK3sKPiArCXN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiA9IHRvX2k5MTUoc3Rh dGUtPmRldik7Cj4gKwlzdHJ1Y3QgaW50ZWxfYXRvbWljX3N0YXRlICppbnRlbF9zdGF0ZSA9Cj4g KwkJdG9faW50ZWxfYXRvbWljX3N0YXRlKHN0YXRlKTsKPiArCWludCBtYXhfcGl4Y2xrID0gaW50 ZWxfbWF4X3BpeGVsX3JhdGUoc3RhdGUpOwo+ICsJaW50IGNkY2xrLCB2Y287Cj4gKwo+ICsJY2Rj bGsgPSBjbmxfY2FsY19jZGNsayhtYXhfcGl4Y2xrKTsKPiArCXZjbyA9IGNubF9jZGNsa19wbGxf dmNvKGRldl9wcml2LCBjZGNsayk7Cj4gKwo+ICsJaWYgKGNkY2xrID4gZGV2X3ByaXYtPm1heF9j ZGNsa19mcmVxKSB7Cj4gKwkJRFJNX0RFQlVHX0tNUygicmVxdWVzdGVkIGNkY2xrICglZCBrSHop IGV4Y2VlZHMgbWF4ICglZCBrSHopXG4iLAo+ICsJCQkgICAgICBjZGNsaywgZGV2X3ByaXYtPm1h eF9jZGNsa19mcmVxKTsKPiArCQlyZXR1cm4gLUVJTlZBTDsKPiArCX0KPiArCj4gKwlpbnRlbF9z dGF0ZS0+Y2RjbGsubG9naWNhbC52Y28gPSB2Y287Cj4gKwlpbnRlbF9zdGF0ZS0+Y2RjbGsubG9n aWNhbC5jZGNsayA9IGNkY2xrOwo+ICsKPiArCWlmICghaW50ZWxfc3RhdGUtPmFjdGl2ZV9jcnRj cykgewo+ICsJCWNkY2xrID0gY25sX2NhbGNfY2RjbGsoMCk7Cj4gKwkJdmNvID0gY25sX2NkY2xr X3BsbF92Y28oZGV2X3ByaXYsIGNkY2xrKTsKPiArCj4gKwkJaW50ZWxfc3RhdGUtPmNkY2xrLmFj dHVhbC52Y28gPSB2Y287Cj4gKwkJaW50ZWxfc3RhdGUtPmNkY2xrLmFjdHVhbC5jZGNsayA9IGNk Y2xrOwo+ICsJfSBlbHNlIHsKPiArCQlpbnRlbF9zdGF0ZS0+Y2RjbGsuYWN0dWFsID0KPiArCQkJ aW50ZWxfc3RhdGUtPmNkY2xrLmxvZ2ljYWw7Cj4gKwl9Cj4gKwo+ICsJcmV0dXJuIDA7Cj4gK30K PiArCj4gIHN0YXRpYyBpbnQgaW50ZWxfY29tcHV0ZV9tYXhfZG90Y2xrKHN0cnVjdCBkcm1faTkx NV9wcml2YXRlICpkZXZfcHJpdikKPiAgewo+ICAJaW50IG1heF9jZGNsa19mcmVxID0gZGV2X3By aXYtPm1heF9jZGNsa19mcmVxOwo+IEBAIC0xOTYwLDcgKzIwMDQsOSBAQCBzdGF0aWMgaW50IGlu dGVsX2NvbXB1dGVfbWF4X2RvdGNsayhzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYp Cj4gICAqLwo+ICB2b2lkIGludGVsX3VwZGF0ZV9tYXhfY2RjbGsoc3RydWN0IGRybV9pOTE1X3By aXZhdGUgKmRldl9wcml2KQo+ICB7Cj4gLQlpZiAoSVNfR0VOOV9CQyhkZXZfcHJpdikpIHsKPiAr CWlmIChJU19DQU5OT05MQUtFKGRldl9wcml2KSkgewo+ICsJCWRldl9wcml2LT5tYXhfY2RjbGtf ZnJlcSA9IDUyODAwMDsKPiArCX0gZWxzZSBpZiAoSVNfR0VOOV9CQyhkZXZfcHJpdikpIHsKPiAg CQl1MzIgbGltaXQgPSBJOTE1X1JFQUQoU0tMX0RGU00pICYgU0tMX0RGU01fQ0RDTEtfTElNSVRf TUFTSzsKPiAgCQlpbnQgbWF4X2NkY2xrLCB2Y287Cj4gIAo+IEBAIC0yMTU3LDYgKzIyMDMsMTAg QEAgdm9pZCBpbnRlbF9pbml0X2NkY2xrX2hvb2tzKHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpk ZXZfcHJpdikKPiAgCQlkZXZfcHJpdi0+ZGlzcGxheS5zZXRfY2RjbGsgPSBza2xfc2V0X2NkY2xr Owo+ICAJCWRldl9wcml2LT5kaXNwbGF5Lm1vZGVzZXRfY2FsY19jZGNsayA9Cj4gIAkJCXNrbF9t b2Rlc2V0X2NhbGNfY2RjbGs7Cj4gKwl9IGVsc2UgaWYgKElTX0NBTk5PTkxBS0UoZGV2X3ByaXYp KSB7Cj4gKwkJZGV2X3ByaXYtPmRpc3BsYXkuc2V0X2NkY2xrID0gY25sX3NldF9jZGNsazsKPiAr CQlkZXZfcHJpdi0+ZGlzcGxheS5tb2Rlc2V0X2NhbGNfY2RjbGsgPQo+ICsJCQljbmxfbW9kZXNl dF9jYWxjX2NkY2xrOwo+ICAJfQo+ICAKPiAgCWlmIChJU19DQU5OT05MQUtFKGRldl9wcml2KSkK PiAtLSAKPiAxLjkuMQo+IApfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3Rv cC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRl bC1nZngK