From: Imre Deak Subject: Re: [PATCH 04/17] drm/i915/cnl: Allow dynamic cdclk changes on CNL Date: Fri, 9 Jun 2017 22:02:09 +0300 Message-ID: <20170609190209.GA23660@ideak-desk.fi.intel.com> References: <1496959406-6031-1-git-send-email-rodrigo.vivi@intel.com> <1496959406-6031-4-git-send-email-rodrigo.vivi@intel.com> <20170609143455.GX12629@intel.com> Reply-To: imre.deak@intel.com Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by gabe.freedesktop.org (Postfix) with ESMTPS id 9E91A6E6D6 for ; Fri, 9 Jun 2017 19:02:11 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20170609143455.GX12629@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Cc: Sanyog Kale , intel-gfx@lists.freedesktop.org, Dhinakaran Pandiyan , Rodrigo Vivi List-Id: intel-gfx@lists.freedesktop.org T24gRnJpLCBKdW4gMDksIDIwMTcgYXQgMDU6MzQ6NTVQTSArMDMwMCwgVmlsbGUgU3lyasOkbMOk IHdyb3RlOgo+IE9uIFRodSwgSnVuIDA4LCAyMDE3IGF0IDAzOjAzOjEzUE0gLTA3MDAsIFJvZHJp Z28gVml2aSB3cm90ZToKPiA+IEFsbCB0aGUgbG93IGxldmVsIGNkY2xrIGJpdHMgYXJlIHByZXNl bnQsIHNvIGxldCdzIGFkZCB0aGUgcmVxdWlyZWQKPiA+IGhvb2tzIHRvIHJlY29uZmlndXJlIGNk Y2xrIG9uIHRoZSBmbHkuCj4gPiAKPiA+IHYyOiBSZWJhc2UgZHVlIHRvIGNubF9zYW5pdGl6ZV9j ZGNsaygpCj4gPiB2MzogUmViYXNlZCBieSBSb2RyaWdvIG9uIHRvcCBvZiBWaWxsZSdzIGNkY2xr IHJld29yay4KPiA+IHY0OiBSZWJhc2UgbW92aW5nIGNubF9jYWxjX2NkY2xrIHVwIHRvIGZvbGxv dyBzYW1lIG9yZGVyCj4gPiAgICAgYXMgcHJldmlvdXMgcGxhdGZvcm1zLgo+ID4gdjI6IFNxdWFz aCBkcm0vaTkxNS9jbmw6IEFkanVzdCBtaW4gcGl4ZWwgcmF0ZS4gdG8gYWRkcmVzcwo+ID4gICAg IHRoZSBjdXJyZW50IGxpbWl0YXRpb24gd2hlcmUgQ0RDTEsgY2Fubm90IGJlIHNldCB0byAxNjhN SHoKPiA+ICAgICBpZiBhdWRpbyBpcyB1c2VkIHdpdGggOTZNSHouIChJbXJlKQo+ID4gCj4gPiBD YzogSW1yZSBEZWFrIDxpbXJlLmRlYWtAaW50ZWwuY29tPgo+ID4gQ2M6IERoaW5ha2FyYW4gUGFu ZGl5YW4gPGRoaW5ha2FyYW4ucGFuZGl5YW5AaW50ZWwuY29tPgo+ID4gU2lnbmVkLW9mZi1ieTog VmlsbGUgU3lyasOkbMOkIDx2aWxsZS5zeXJqYWxhQGxpbnV4LmludGVsLmNvbT4KPiA+IFNpZ25l ZC1vZmYtYnk6IFJvZHJpZ28gVml2aSA8cm9kcmlnby52aXZpQGludGVsLmNvbT4KPiA+IAo+ID4g Q2Fubm9ubGFrZSBhbHNvIG5lZWRzIHRvIGFkanVzdCB0aGUgbWluaW1hbCBwaXhlbCByYXRlCj4g PiBhcyBnZW45IHBsYXRmb3Jtcy4gU3BlY2lhbGx5IGZvciB0aGUgQXphbGlhIGF1ZGlvIGNhc2Uu Cj4gPiAKPiA+IENjOiBEaGluYWthcmFuIFBhbmRpeWFuIDxkaGluYWthcmFuLnBhbmRpeWFuQGlu dGVsLmNvbT4KPiA+IENjOiBTYW55b2cgS2FsZSA8c2FueW9nLnIua2FsZUBpbnRlbC5jb20+Cj4g PiBTaWduZWQtb2ZmLWJ5OiBSb2RyaWdvIFZpdmkgPHJvZHJpZ28udml2aUBpbnRlbC5jb20+Cj4g PiAtLS0KPiA+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9jZGNsay5jIHwgNTYgKysrKysr KysrKysrKysrKysrKysrKysrKysrKysrKysrKysrLS0KPiA+ICAxIGZpbGUgY2hhbmdlZCwgNTMg aW5zZXJ0aW9ucygrKSwgMyBkZWxldGlvbnMoLSkKPiA+IAo+ID4gZGlmZiAtLWdpdCBhL2RyaXZl cnMvZ3B1L2RybS9pOTE1L2ludGVsX2NkY2xrLmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRl bF9jZGNsay5jCj4gPiBpbmRleCAzNWExNDMyLi4xZDdjZmM1IDEwMDY0NAo+ID4gLS0tIGEvZHJp dmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfY2RjbGsuYwo+ID4gKysrIGIvZHJpdmVycy9ncHUvZHJt L2k5MTUvaW50ZWxfY2RjbGsuYwo+ID4gQEAgLTE0MDAsNiArMTQwMCwxNiBAQCB2b2lkIGJ4dF91 bmluaXRfY2RjbGsoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2KQo+ID4gIAlieHRf c2V0X2NkY2xrKGRldl9wcml2LCAmY2RjbGtfc3RhdGUpOwo+ID4gIH0KPiA+ICAKPiA+ICtzdGF0 aWMgaW50IGNubF9jYWxjX2NkY2xrKGludCBtYXhfcGl4Y2xrKQo+ID4gK3sKPiA+ICsJaWYgKG1h eF9waXhjbGsgPiAzMzYwMDApCj4gPiArCQlyZXR1cm4gNTI4MDAwOwo+ID4gKwllbHNlIGlmICht YXhfcGl4Y2xrID4gMTY4MDAwKQo+ID4gKwkJcmV0dXJuIDMzNjAwMDsKPiA+ICsJZWxzZQo+ID4g KwkJcmV0dXJuIDE2ODAwMDsKPiA+ICt9Cj4gPiArCj4gPiAgc3RhdGljIHZvaWQgY25sX2NkY2xr X3BsbF91cGRhdGUoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2LAo+ID4gIAkJCQkg c3RydWN0IGludGVsX2NkY2xrX3N0YXRlICpjZGNsa19zdGF0ZSkKPiA+ICB7Cj4gPiBAQCAtMTY0 MSw3ICsxNjUxLDcgQEAgdm9pZCBjbmxfaW5pdF9jZGNsayhzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0 ZSAqZGV2X3ByaXYpCj4gPiAgCj4gPiAgCWNkY2xrX3N0YXRlID0gZGV2X3ByaXYtPmNkY2xrLmh3 Owo+ID4gIAo+ID4gLQljZGNsa19zdGF0ZS5jZGNsayA9IDE2ODAwMDsKPiA+ICsJY2RjbGtfc3Rh dGUuY2RjbGsgPSBjbmxfY2FsY19jZGNsaygwKTsKPiA+ICAJY2RjbGtfc3RhdGUudmNvID0gY25s X2NkY2xrX3BsbF92Y28oZGV2X3ByaXYsIGNkY2xrX3N0YXRlLmNkY2xrKTsKPiA+ICAKPiA+ICAJ Y25sX3NldF9jZGNsayhkZXZfcHJpdiwgJmNkY2xrX3N0YXRlKTsKPiA+IEBAIC0xNzY4LDcgKzE3 NzgsNyBAQCBzdGF0aWMgaW50IGludGVsX21heF9waXhlbF9yYXRlKHN0cnVjdCBkcm1fYXRvbWlj X3N0YXRlICpzdGF0ZSkKPiA+ICAKPiA+ICAJCXBpeGVsX3JhdGUgPSBjcnRjX3N0YXRlLT5waXhl bF9yYXRlOwo+ID4gIAo+ID4gLQkJaWYgKElTX0JST0FEV0VMTChkZXZfcHJpdikgfHwgSVNfR0VO OShkZXZfcHJpdikpCj4gPiArCQlpZiAoSVNfQlJPQURXRUxMKGRldl9wcml2KSB8fCBJTlRFTF9H RU4oZGV2X3ByaXYpID49IDkpCj4gPiAgCQkJcGl4ZWxfcmF0ZSA9Cj4gPiAgCQkJCWJkd19hZGp1 c3RfbWluX3BpcGVfcGl4ZWxfcmF0ZShjcnRjX3N0YXRlLAo+ID4gIAkJCQkJCQkgICAgICAgcGl4 ZWxfcmF0ZSk7Cj4gCj4gSSB0aGluayB5b3UgbWlnaHQgYWxzbyBoYXZlIHRvIGFkanVzdCBzb21l IG9mIHRoZSBjbG9jayBsaW1pdHMKPiB3aXRoaW4gYmR3X2FkanVzdF9taW5fcGlwZV9waXhlbF9y YXRlKCkuCgpZZXMsIHdlIG1pc3NlZCB0aGlzLiBUaGUgRFAvSEJSMi80LWxhbmVzL2F1ZGlvIHdv cmthcm91bmQgb24gQ05MIGlzIHRoZQpzYW1lIGFzIG9uIEdMSy4gU28gaW4gYmR3X2FkanVzdF9t aW5fcGlwZV9waXhlbF9yYXRlKCkgd2UgY291bGQgdXNlIHRoZQpzYW1lIGxpbWl0cyBhcyBvbiBH TEssIGV4Y2VwdCBJIGRvbid0IHVuZGVyc3RhbmQgdGhlIDJ4IG11bHRpcGxpZXIgdGhlcmUKaW4K CnBpeGVsX3JhdGUgPSBtYXgoMiAqIDMxNjgwMCwgcGl4ZWxfcmF0ZSk7CgphbmQKCnBpeGVsX3Jh dGUgPSBtYXgoMiAqIDIgKiA5NjAwMCwgcGl4ZWxfcmF0ZSk7CgpUaGlzIHBpeGVsX3JhdGUgdmFs dWUgd2lsbCBiZSBjb21wYXJlZCBhZ2FpbnN0IENEQ0xLIGxpbWl0IHZhbHVlcyBpbgpnbGtfY2Fs Y19jZGNsaygpIG5vdCBDRDJYQ0xLIGxpbWl0IHZhbHVlcy4gUmVtb3ZpbmcgdGhlIDJ4IG11bHRp cGxpZXIKZnJvbSB0aGUgYWJvdmUgcGl4ZWxfcmF0ZSB2YWx1ZXMgd291bGRuJ3QgY2hhbmdlIGFu eXRoaW5nIG9uIEdMSyBBRkFJQ1MKYW5kIGl0IHdvdWxkIGFsbG93IHVzIHRvIHVzZSB0aGUgc2Ft ZSBjb2RlIHRvIGNhbGN1bGF0ZSB0aGVzZSBvbiBHTEsKYW5kIENOTCAoYW5kIHNpbXBsaWZ5IHRo ZSBzZWNvbmQgcGl4ZWxfcmF0ZSBjYWxjdWxhdGlvbikuCgotLUltcmUKCj4gCj4gPiBAQCAtMTky OSw2ICsxOTM5LDQwIEBAIHN0YXRpYyBpbnQgYnh0X21vZGVzZXRfY2FsY19jZGNsayhzdHJ1Y3Qg ZHJtX2F0b21pY19zdGF0ZSAqc3RhdGUpCj4gPiAgCXJldHVybiAwOwo+ID4gIH0KPiA+ICAKPiA+ ICtzdGF0aWMgaW50IGNubF9tb2Rlc2V0X2NhbGNfY2RjbGsoc3RydWN0IGRybV9hdG9taWNfc3Rh dGUgKnN0YXRlKQo+ID4gK3sKPiA+ICsJc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2 ID0gdG9faTkxNShzdGF0ZS0+ZGV2KTsKPiA+ICsJc3RydWN0IGludGVsX2F0b21pY19zdGF0ZSAq aW50ZWxfc3RhdGUgPQo+ID4gKwkJdG9faW50ZWxfYXRvbWljX3N0YXRlKHN0YXRlKTsKPiA+ICsJ aW50IG1heF9waXhjbGsgPSBpbnRlbF9tYXhfcGl4ZWxfcmF0ZShzdGF0ZSk7Cj4gPiArCWludCBj ZGNsaywgdmNvOwo+ID4gKwo+ID4gKwljZGNsayA9IGNubF9jYWxjX2NkY2xrKG1heF9waXhjbGsp Owo+ID4gKwl2Y28gPSBjbmxfY2RjbGtfcGxsX3ZjbyhkZXZfcHJpdiwgY2RjbGspOwo+ID4gKwo+ ID4gKwlpZiAoY2RjbGsgPiBkZXZfcHJpdi0+bWF4X2NkY2xrX2ZyZXEpIHsKPiA+ICsJCURSTV9E RUJVR19LTVMoInJlcXVlc3RlZCBjZGNsayAoJWQga0h6KSBleGNlZWRzIG1heCAoJWQga0h6KVxu IiwKPiA+ICsJCQkgICAgICBjZGNsaywgZGV2X3ByaXYtPm1heF9jZGNsa19mcmVxKTsKPiA+ICsJ CXJldHVybiAtRUlOVkFMOwo+ID4gKwl9Cj4gPiArCj4gPiArCWludGVsX3N0YXRlLT5jZGNsay5s b2dpY2FsLnZjbyA9IHZjbzsKPiA+ICsJaW50ZWxfc3RhdGUtPmNkY2xrLmxvZ2ljYWwuY2RjbGsg PSBjZGNsazsKPiA+ICsKPiA+ICsJaWYgKCFpbnRlbF9zdGF0ZS0+YWN0aXZlX2NydGNzKSB7Cj4g PiArCQljZGNsayA9IGNubF9jYWxjX2NkY2xrKDApOwo+ID4gKwkJdmNvID0gY25sX2NkY2xrX3Bs bF92Y28oZGV2X3ByaXYsIGNkY2xrKTsKPiA+ICsKPiA+ICsJCWludGVsX3N0YXRlLT5jZGNsay5h Y3R1YWwudmNvID0gdmNvOwo+ID4gKwkJaW50ZWxfc3RhdGUtPmNkY2xrLmFjdHVhbC5jZGNsayA9 IGNkY2xrOwo+ID4gKwl9IGVsc2Ugewo+ID4gKwkJaW50ZWxfc3RhdGUtPmNkY2xrLmFjdHVhbCA9 Cj4gPiArCQkJaW50ZWxfc3RhdGUtPmNkY2xrLmxvZ2ljYWw7Cj4gPiArCX0KPiA+ICsKPiA+ICsJ cmV0dXJuIDA7Cj4gPiArfQo+ID4gKwo+ID4gIHN0YXRpYyBpbnQgaW50ZWxfY29tcHV0ZV9tYXhf ZG90Y2xrKHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdikKPiA+ICB7Cj4gPiAgCWlu dCBtYXhfY2RjbGtfZnJlcSA9IGRldl9wcml2LT5tYXhfY2RjbGtfZnJlcTsKPiA+IEBAIC0xOTYw LDcgKzIwMDQsOSBAQCBzdGF0aWMgaW50IGludGVsX2NvbXB1dGVfbWF4X2RvdGNsayhzdHJ1Y3Qg ZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYpCj4gPiAgICovCj4gPiAgdm9pZCBpbnRlbF91cGRh dGVfbWF4X2NkY2xrKHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdikKPiA+ICB7Cj4g PiAtCWlmIChJU19HRU45X0JDKGRldl9wcml2KSkgewo+ID4gKwlpZiAoSVNfQ0FOTk9OTEFLRShk ZXZfcHJpdikpIHsKPiA+ICsJCWRldl9wcml2LT5tYXhfY2RjbGtfZnJlcSA9IDUyODAwMDsKPiA+ ICsJfSBlbHNlIGlmIChJU19HRU45X0JDKGRldl9wcml2KSkgewo+ID4gIAkJdTMyIGxpbWl0ID0g STkxNV9SRUFEKFNLTF9ERlNNKSAmIFNLTF9ERlNNX0NEQ0xLX0xJTUlUX01BU0s7Cj4gPiAgCQlp bnQgbWF4X2NkY2xrLCB2Y287Cj4gPiAgCj4gPiBAQCAtMjE1Nyw2ICsyMjAzLDEwIEBAIHZvaWQg aW50ZWxfaW5pdF9jZGNsa19ob29rcyhzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYp Cj4gPiAgCQlkZXZfcHJpdi0+ZGlzcGxheS5zZXRfY2RjbGsgPSBza2xfc2V0X2NkY2xrOwo+ID4g IAkJZGV2X3ByaXYtPmRpc3BsYXkubW9kZXNldF9jYWxjX2NkY2xrID0KPiA+ICAJCQlza2xfbW9k ZXNldF9jYWxjX2NkY2xrOwo+ID4gKwl9IGVsc2UgaWYgKElTX0NBTk5PTkxBS0UoZGV2X3ByaXYp KSB7Cj4gPiArCQlkZXZfcHJpdi0+ZGlzcGxheS5zZXRfY2RjbGsgPSBjbmxfc2V0X2NkY2xrOwo+ ID4gKwkJZGV2X3ByaXYtPmRpc3BsYXkubW9kZXNldF9jYWxjX2NkY2xrID0KPiA+ICsJCQljbmxf bW9kZXNldF9jYWxjX2NkY2xrOwo+ID4gIAl9Cj4gPiAgCj4gPiAgCWlmIChJU19DQU5OT05MQUtF KGRldl9wcml2KSkKPiA+IC0tIAo+ID4gMS45LjEKPiAKPiAtLSAKPiBWaWxsZSBTeXJqw6Rsw6QK PiBJbnRlbCBPVEMKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3Jn Cmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4 Cg==