From: Jordan Crouse Subject: Re: [PATCH] drm/msm: fix locking inconsistency for gpu->hw_init() Date: Tue, 13 Jun 2017 09:04:02 -0600 Message-ID: <20170613150402.GA16178@jcrouse-lnx.qualcomm.com> References: <20170613132345.6046-1-robdclark@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <20170613132345.6046-1-robdclark@gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Rob Clark Cc: freedreno@lists.freedesktop.org, dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org T24gVHVlLCBKdW4gMTMsIDIwMTcgYXQgMDk6MjM6NDVBTSAtMDQwMCwgUm9iIENsYXJrIHdyb3Rl Ogo+IE1vc3QsIGJ1dCBub3QgYWxsLCBwYXRocyB3aGVyZSBjYWxsaW5nIHRoZSB3aXRoIHN0cnVj dF9tdXRleCBoZWxkLiAgVGhlCj4gZmFzdC1wYXRoIGluIG1zbV9nZW1fZ2V0X2lvdmEoKSAocGx1 cyBzb21lIHN1Yi1jb2RlLXBhdGhzIHRoYXQgb25seSBydW4KPiB0aGUgZmlyc3QgdGltZSkgd2Fz IG1hc2tpbmcgdGhpcyBpc3N1ZS4KPiAKPiBTbyBsZXRzIGp1c3QgYWx3YXlzIGhvbGQgc3RydWN0 X211dGV4IGZvciBod19pbml0KCkuICBBbmQgc3ByaW5rbGUgc29tZQo+IFdBUk5fT04oKSdzIGFu ZCBtaWdodF9sb2NrKCkgdG8gYXZvaWQgdGhpcyBzb3J0IG9mIHByb2JsZW0gaW4gdGhlCj4gZnV0 dXJlLgo+IAo+IFNpZ25lZC1vZmYtYnk6IFJvYiBDbGFyayA8cm9iZGNsYXJrQGdtYWlsLmNvbT4K CkFja2VkLWJ5OiBKb3JkYW4gQ3JvdXNlIDxqY3JvdXNlQGNvZGVhdXJvcmEub3JnPgoKPiAtLS0K PiAgZHJpdmVycy9ncHUvZHJtL21zbS9hZHJlbm8vYTV4eF9ncHUuYyAgICAgIHwgMTMgKysrKyst LS0tLS0tLQo+ICBkcml2ZXJzL2dwdS9kcm0vbXNtL2FkcmVuby9hNXh4X3Bvd2VyLmMgICAgfCAx MSArKysrLS0tLS0tLQo+ICBkcml2ZXJzL2dwdS9kcm0vbXNtL2FkcmVuby9hZHJlbm9fZGV2aWNl LmMgfCAgMiArKwo+ICBkcml2ZXJzL2dwdS9kcm0vbXNtL2FkcmVuby9hZHJlbm9fZ3B1LmMgICAg fCAgMiArLQo+ICBkcml2ZXJzL2dwdS9kcm0vbXNtL21zbV9nZW0uYyAgICAgICAgICAgICAgfCAg MyArKysKPiAgZHJpdmVycy9ncHUvZHJtL21zbS9tc21fZ3B1LmMgICAgICAgICAgICAgIHwgIDIg KysKPiAgNiBmaWxlcyBjaGFuZ2VkLCAxNyBpbnNlcnRpb25zKCspLCAxNiBkZWxldGlvbnMoLSkK PiAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL21zbS9hZHJlbm8vYTV4eF9ncHUuYyBi L2RyaXZlcnMvZ3B1L2RybS9tc20vYWRyZW5vL2E1eHhfZ3B1LmMKPiBpbmRleCBmYzlhODFhLi5k NWQ2MTk4IDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9tc20vYWRyZW5vL2E1eHhfZ3B1 LmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vbXNtL2FkcmVuby9hNXh4X2dwdS5jCj4gQEAgLTM4 NiwzMSArMzg2LDI4IEBAIHN0YXRpYyBzdHJ1Y3QgZHJtX2dlbV9vYmplY3QgKmE1eHhfdWNvZGVf bG9hZF9ibyhzdHJ1Y3QgbXNtX2dwdSAqZ3B1LAo+ICAJc3RydWN0IGRybV9nZW1fb2JqZWN0ICpi bzsKPiAgCXZvaWQgKnB0cjsKPiAgCj4gLQltdXRleF9sb2NrKCZkcm0tPnN0cnVjdF9tdXRleCk7 Cj4gIAlibyA9IG1zbV9nZW1fbmV3KGRybSwgZnctPnNpemUgLSA0LCBNU01fQk9fVU5DQUNIRUQp Owo+IC0JbXV0ZXhfdW5sb2NrKCZkcm0tPnN0cnVjdF9tdXRleCk7Cj4gLQo+ICAJaWYgKElTX0VS UihibykpCj4gIAkJcmV0dXJuIGJvOwo+ICAKPiAtCXB0ciA9IG1zbV9nZW1fZ2V0X3ZhZGRyKGJv KTsKPiArCXB0ciA9IG1zbV9nZW1fZ2V0X3ZhZGRyX2xvY2tlZChibyk7Cj4gIAlpZiAoIXB0cikg ewo+IC0JCWRybV9nZW1fb2JqZWN0X3VucmVmZXJlbmNlX3VubG9ja2VkKGJvKTsKPiArCQlkcm1f Z2VtX29iamVjdF91bnJlZmVyZW5jZShibyk7Cj4gIAkJcmV0dXJuIEVSUl9QVFIoLUVOT01FTSk7 Cj4gIAl9Cj4gIAo+ICAJaWYgKGlvdmEpIHsKPiAtCQlpbnQgcmV0ID0gbXNtX2dlbV9nZXRfaW92 YShibywgZ3B1LT5pZCwgaW92YSk7Cj4gKwkJaW50IHJldCA9IG1zbV9nZW1fZ2V0X2lvdmFfbG9j a2VkKGJvLCBncHUtPmlkLCBpb3ZhKTsKPiAgCj4gIAkJaWYgKHJldCkgewo+IC0JCQlkcm1fZ2Vt X29iamVjdF91bnJlZmVyZW5jZV91bmxvY2tlZChibyk7Cj4gKwkJCWRybV9nZW1fb2JqZWN0X3Vu cmVmZXJlbmNlKGJvKTsKPiAgCQkJcmV0dXJuIEVSUl9QVFIocmV0KTsKPiAgCQl9Cj4gIAl9Cj4g IAo+ICAJbWVtY3B5KHB0ciwgJmZ3LT5kYXRhWzRdLCBmdy0+c2l6ZSAtIDQpOwo+ICAKPiAtCW1z bV9nZW1fcHV0X3ZhZGRyKGJvKTsKPiArCW1zbV9nZW1fcHV0X3ZhZGRyX2xvY2tlZChibyk7Cj4g IAlyZXR1cm4gYm87Cj4gIH0KPiAgCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9tc20v YWRyZW5vL2E1eHhfcG93ZXIuYyBiL2RyaXZlcnMvZ3B1L2RybS9tc20vYWRyZW5vL2E1eHhfcG93 ZXIuYwo+IGluZGV4IDcyZDUyYzcuLjc4MzhmNWYgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUv ZHJtL21zbS9hZHJlbm8vYTV4eF9wb3dlci5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL21zbS9h ZHJlbm8vYTV4eF9wb3dlci5jCj4gQEAgLTI5NCwxNyArMjk0LDE0IEBAIHZvaWQgYTV4eF9ncG11 X3Vjb2RlX2luaXQoc3RydWN0IG1zbV9ncHUgKmdwdSkKPiAgCSAqLwo+ICAJYm9zaXplID0gKGNt ZHNfc2l6ZSArIChjbWRzX3NpemUgLyBUWVBFNF9NQVhfUEFZTE9BRCkgKyAxKSA8PCAyOwo+ICAK PiAtCW11dGV4X2xvY2soJmRybS0+c3RydWN0X211dGV4KTsKPiAgCWE1eHhfZ3B1LT5ncG11X2Jv ID0gbXNtX2dlbV9uZXcoZHJtLCBib3NpemUsIE1TTV9CT19VTkNBQ0hFRCk7Cj4gLQltdXRleF91 bmxvY2soJmRybS0+c3RydWN0X211dGV4KTsKPiAtCj4gIAlpZiAoSVNfRVJSKGE1eHhfZ3B1LT5n cG11X2JvKSkKPiAgCQlnb3RvIGVycjsKPiAgCj4gLQlpZiAobXNtX2dlbV9nZXRfaW92YShhNXh4 X2dwdS0+Z3BtdV9ibywgZ3B1LT5pZCwgJmE1eHhfZ3B1LT5ncG11X2lvdmEpKQo+ICsJaWYgKG1z bV9nZW1fZ2V0X2lvdmFfbG9ja2VkKGE1eHhfZ3B1LT5ncG11X2JvLCBncHUtPmlkLCAmYTV4eF9n cHUtPmdwbXVfaW92YSkpCj4gIAkJZ290byBlcnI7Cj4gIAo+IC0JcHRyID0gbXNtX2dlbV9nZXRf dmFkZHIoYTV4eF9ncHUtPmdwbXVfYm8pOwo+ICsJcHRyID0gbXNtX2dlbV9nZXRfdmFkZHJfbG9j a2VkKGE1eHhfZ3B1LT5ncG11X2JvKTsKPiAgCWlmICghcHRyKQo+ICAJCWdvdG8gZXJyOwo+ICAK PiBAQCAtMzIzLDcgKzMyMCw3IEBAIHZvaWQgYTV4eF9ncG11X3Vjb2RlX2luaXQoc3RydWN0IG1z bV9ncHUgKmdwdSkKPiAgCQljbWRzX3NpemUgLT0gX3NpemU7Cj4gIAl9Cj4gIAo+IC0JbXNtX2dl bV9wdXRfdmFkZHIoYTV4eF9ncHUtPmdwbXVfYm8pOwo+ICsJbXNtX2dlbV9wdXRfdmFkZHJfbG9j a2VkKGE1eHhfZ3B1LT5ncG11X2JvKTsKPiAgCWE1eHhfZ3B1LT5ncG11X2R3b3JkcyA9IGR3b3Jk czsKPiAgCj4gIAlnb3RvIG91dDsKPiBAQCAtMzMyLDcgKzMyOSw3IEBAIHZvaWQgYTV4eF9ncG11 X3Vjb2RlX2luaXQoc3RydWN0IG1zbV9ncHUgKmdwdSkKPiAgCWlmIChhNXh4X2dwdS0+Z3BtdV9p b3ZhKQo+ICAJCW1zbV9nZW1fcHV0X2lvdmEoYTV4eF9ncHUtPmdwbXVfYm8sIGdwdS0+aWQpOwo+ ICAJaWYgKGE1eHhfZ3B1LT5ncG11X2JvKQo+IC0JCWRybV9nZW1fb2JqZWN0X3VucmVmZXJlbmNl X3VubG9ja2VkKGE1eHhfZ3B1LT5ncG11X2JvKTsKPiArCQlkcm1fZ2VtX29iamVjdF91bnJlZmVy ZW5jZShhNXh4X2dwdS0+Z3BtdV9ibyk7Cj4gIAo+ICAJYTV4eF9ncHUtPmdwbXVfYm8gPSBOVUxM Owo+ICAJYTV4eF9ncHUtPmdwbXVfaW92YSA9IDA7Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1 L2RybS9tc20vYWRyZW5vL2FkcmVub19kZXZpY2UuYyBiL2RyaXZlcnMvZ3B1L2RybS9tc20vYWRy ZW5vL2FkcmVub19kZXZpY2UuYwo+IGluZGV4IDczNDVhMDEuLjU2ZmI1OWYgMTAwNjQ0Cj4gLS0t IGEvZHJpdmVycy9ncHUvZHJtL21zbS9hZHJlbm8vYWRyZW5vX2RldmljZS5jCj4gKysrIGIvZHJp dmVycy9ncHUvZHJtL21zbS9hZHJlbm8vYWRyZW5vX2RldmljZS5jCj4gQEAgLTE1OCw3ICsxNTgs OSBAQCBzdHJ1Y3QgbXNtX2dwdSAqYWRyZW5vX2xvYWRfZ3B1KHN0cnVjdCBkcm1fZGV2aWNlICpk ZXYpCj4gIAkJaW50IHJldDsKPiAgCj4gIAkJcG1fcnVudGltZV9nZXRfc3luYygmcGRldi0+ZGV2 KTsKPiArCQltdXRleF9sb2NrKCZkZXYtPnN0cnVjdF9tdXRleCk7Cj4gIAkJcmV0ID0gbXNtX2dw dV9od19pbml0KGdwdSk7Cj4gKwkJbXV0ZXhfdW5sb2NrKCZkZXYtPnN0cnVjdF9tdXRleCk7Cj4g IAkJcG1fcnVudGltZV9wdXRfc3luYygmcGRldi0+ZGV2KTsKPiAgCQlpZiAocmV0KSB7Cj4gIAkJ CWRldl9lcnIoZGV2LT5kZXYsICJncHUgaHcgaW5pdCBmYWlsZWQ6ICVkXG4iLCByZXQpOwo+IGRp ZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vbXNtL2FkcmVuby9hZHJlbm9fZ3B1LmMgYi9kcml2 ZXJzL2dwdS9kcm0vbXNtL2FkcmVuby9hZHJlbm9fZ3B1LmMKPiBpbmRleCA1YjYzZmM2Li45ZTA4 YjNlIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9tc20vYWRyZW5vL2FkcmVub19ncHUu Ywo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9tc20vYWRyZW5vL2FkcmVub19ncHUuYwo+IEBAIC02 NCw3ICs2NCw3IEBAIGludCBhZHJlbm9faHdfaW5pdChzdHJ1Y3QgbXNtX2dwdSAqZ3B1KQo+ICAK PiAgCURCRygiJXMiLCBncHUtPm5hbWUpOwo+ICAKPiAtCXJldCA9IG1zbV9nZW1fZ2V0X2lvdmEo Z3B1LT5yYi0+Ym8sIGdwdS0+aWQsICZncHUtPnJiX2lvdmEpOwo+ICsJcmV0ID0gbXNtX2dlbV9n ZXRfaW92YV9sb2NrZWQoZ3B1LT5yYi0+Ym8sIGdwdS0+aWQsICZncHUtPnJiX2lvdmEpOwo+ICAJ aWYgKHJldCkgewo+ICAJCWdwdS0+cmJfaW92YSA9IDA7Cj4gIAkJZGV2X2VycihncHUtPmRldi0+ ZGV2LCAiY291bGQgbm90IG1hcCByaW5nYnVmZmVyOiAlZFxuIiwgcmV0KTsKPiBkaWZmIC0tZ2l0 IGEvZHJpdmVycy9ncHUvZHJtL21zbS9tc21fZ2VtLmMgYi9kcml2ZXJzL2dwdS9kcm0vbXNtL21z bV9nZW0uYwo+IGluZGV4IDY4ZTUwOWIuLjEzOWJlNTQgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9n cHUvZHJtL21zbS9tc21fZ2VtLmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vbXNtL21zbV9nZW0u Ywo+IEBAIC0zMTQsNiArMzE0LDggQEAgaW50IG1zbV9nZW1fZ2V0X2lvdmFfbG9ja2VkKHN0cnVj dCBkcm1fZ2VtX29iamVjdCAqb2JqLCBpbnQgaWQsCj4gIAlzdHJ1Y3QgbXNtX2dlbV9vYmplY3Qg Km1zbV9vYmogPSB0b19tc21fYm8ob2JqKTsKPiAgCWludCByZXQgPSAwOwo+ICAKPiArCVdBUk5f T04oIW11dGV4X2lzX2xvY2tlZCgmb2JqLT5kZXYtPnN0cnVjdF9tdXRleCkpOwo+ICsKPiAgCWlm ICghbXNtX29iai0+ZG9tYWluW2lkXS5pb3ZhKSB7Cj4gIAkJc3RydWN0IG1zbV9kcm1fcHJpdmF0 ZSAqcHJpdiA9IG9iai0+ZGV2LT5kZXZfcHJpdmF0ZTsKPiAgCQlzdHJ1Y3QgcGFnZSAqKnBhZ2Vz ID0gZ2V0X3BhZ2VzKG9iaik7Cj4gQEAgLTM0NSw2ICszNDcsNyBAQCBpbnQgbXNtX2dlbV9nZXRf aW92YShzdHJ1Y3QgZHJtX2dlbV9vYmplY3QgKm9iaiwgaW50IGlkLCB1aW50NjRfdCAqaW92YSkK PiAgCSAqIGJvIGlzIGRlbGV0ZWQ6Cj4gIAkgKi8KPiAgCWlmIChtc21fb2JqLT5kb21haW5baWRd LmlvdmEpIHsKPiArCQltaWdodF9sb2NrKCZvYmotPmRldi0+c3RydWN0X211dGV4KTsKPiAgCQkq aW92YSA9IG1zbV9vYmotPmRvbWFpbltpZF0uaW92YTsKPiAgCQlyZXR1cm4gMDsKPiAgCX0KPiBk aWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL21zbS9tc21fZ3B1LmMgYi9kcml2ZXJzL2dwdS9k cm0vbXNtL21zbV9ncHUuYwo+IGluZGV4IDk3YjljMzguLjlmY2VkYTggMTAwNjQ0Cj4gLS0tIGEv ZHJpdmVycy9ncHUvZHJtL21zbS9tc21fZ3B1LmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vbXNt L21zbV9ncHUuYwo+IEBAIC0yMDMsNiArMjAzLDggQEAgaW50IG1zbV9ncHVfaHdfaW5pdChzdHJ1 Y3QgbXNtX2dwdSAqZ3B1KQo+ICB7Cj4gIAlpbnQgcmV0Owo+ICAKPiArCVdBUk5fT04oIW11dGV4 X2lzX2xvY2tlZCgmZ3B1LT5kZXYtPnN0cnVjdF9tdXRleCkpOwo+ICsKPiAgCWlmICghZ3B1LT5u ZWVkc19od19pbml0KQo+ICAJCXJldHVybiAwOwo+ICAKPiAtLSAKPiAyLjkuNAo+IAoKLS0gClRo ZSBRdWFsY29tbSBJbm5vdmF0aW9uIENlbnRlciwgSW5jLiBpcyBhIG1lbWJlciBvZiBDb2RlIEF1 cm9yYSBGb3J1bSwKYSBMaW51eCBGb3VuZGF0aW9uIENvbGxhYm9yYXRpdmUgUHJvamVjdApfX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFp bGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5m cmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK