From: Jordan Crouse Subject: Re: [PATCH 4/6] drm/msm: refactor how we handle vram carveout buffers Date: Tue, 13 Jun 2017 13:35:36 -0600 Message-ID: <20170613193536.GE16178@jcrouse-lnx.qualcomm.com> References: <20170613184948.8278-1-robdclark@gmail.com> <20170613184948.8278-5-robdclark@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <20170613184948.8278-5-robdclark@gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Rob Clark Cc: freedreno@lists.freedesktop.org, dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org T24gVHVlLCBKdW4gMTMsIDIwMTcgYXQgMDI6NDk6NDZQTSAtMDQwMCwgUm9iIENsYXJrIHdyb3Rl Ogo+IFB1bGwgc29tZSBvZiB0aGUgbG9naWMgb3V0IGludG8gbXNtX2dlbV9uZXcoKSAoc2luY2Ug d2UgZG9uJ3QgbmVlZCB0bwo+IGNhcmUgYWJvdXQgdGhlIGltcG9ydGVkLWJvIGNhc2UpLCBhbmQg ZG9uJ3QgZGVmZXIgYWxsb2NhdGluZyBwYWdlcy4gIFRoZQo+IGxhdHRlciBpcyBnZW5lcmFsbHkg YSBnb29kIGlkZWEsIHNpbmNlIGlmIHdlIGFyZSB1c2luZyBWUkFNIGNhcnZlb3V0IHRvCj4gYWxs b2NhdGUgY29udGlndW91cyBidWZmZXJzIChpZS4gbm8gSU9NTVUpLCB0aGUgYWxsb2NhdGlvbiBp cyBtb3JlCj4gbGlrZWx5IHRvIGZhaWwuICBTbyBmYWlsaW5nIGF0IGFsbG9jYXRpb24gdGltZSBp cyBhIG1vcmUgc2FuZSBvcHRpb24uCj4gUGx1cyB0aGlzIHNpbXBsaWZpZXMgdGhpbmdzIGluIHRo ZSBuZXh0IHBhdGNoLgo+IAo+IFNpZ25lZC1vZmYtYnk6IFJvYiBDbGFyayA8cm9iZGNsYXJrQGdt YWlsLmNvbT4KPiAtLS0KPiAgZHJpdmVycy9ncHUvZHJtL21zbS9tc21fZ2VtLmMgfCA0OCArKysr KysrKysrKysrKysrKysrKysrKystLS0tLS0tLS0tLS0tLS0tLS0tCj4gIDEgZmlsZSBjaGFuZ2Vk LCAyNyBpbnNlcnRpb25zKCspLCAyMSBkZWxldGlvbnMoLSkKPiAKPiBkaWZmIC0tZ2l0IGEvZHJp dmVycy9ncHUvZHJtL21zbS9tc21fZ2VtLmMgYi9kcml2ZXJzL2dwdS9kcm0vbXNtL21zbV9nZW0u Ywo+IGluZGV4IDJmNDcwYTYuLjc1NDQzMmMgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJt L21zbS9tc21fZ2VtLmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vbXNtL21zbV9nZW0uYwo+IEBA IC0zMjQsMTIgKzMyNCw4IEBAIGludCBtc21fZ2VtX2dldF9pb3ZhX2xvY2tlZChzdHJ1Y3QgZHJt X2dlbV9vYmplY3QgKm9iaiwKPiAgCQlpZiAoSVNfRVJSKHBhZ2VzKSkKPiAgCQkJcmV0dXJuIFBU Ul9FUlIocGFnZXMpOwo+ICAKPiAtCQlpZiAoaW9tbXVfcHJlc2VudCgmcGxhdGZvcm1fYnVzX3R5 cGUpKSB7Cj4gLQkJCXJldCA9IG1zbV9nZW1fbWFwX3ZtYShwcml2LT5hc3BhY2VbaWRdLCAmbXNt X29iai0+ZG9tYWluW2lkXSwKPiAtCQkJCQltc21fb2JqLT5zZ3QsIG9iai0+c2l6ZSA+PiBQQUdF X1NISUZUKTsKPiAtCQl9IGVsc2Ugewo+IC0JCQltc21fb2JqLT5kb21haW5baWRdLmlvdmEgPSBw aHlzYWRkcihvYmopOwo+IC0JCX0KPiArCQlyZXQgPSBtc21fZ2VtX21hcF92bWEocHJpdi0+YXNw YWNlW2lkXSwgJm1zbV9vYmotPmRvbWFpbltpZF0sCj4gKwkJCQltc21fb2JqLT5zZ3QsIG9iai0+ c2l6ZSA+PiBQQUdFX1NISUZUKTsKPiAgCX0KPiAgCj4gIAlpZiAoIXJldCkKPiBAQCAtNzY1LDcg Kzc2MSw2IEBAIHN0YXRpYyBpbnQgbXNtX2dlbV9uZXdfaW1wbChzdHJ1Y3QgZHJtX2RldmljZSAq ZGV2LAo+ICB7Cj4gIAlzdHJ1Y3QgbXNtX2RybV9wcml2YXRlICpwcml2ID0gZGV2LT5kZXZfcHJp dmF0ZTsKPiAgCXN0cnVjdCBtc21fZ2VtX29iamVjdCAqbXNtX29iajsKPiAtCWJvb2wgdXNlX3Zy YW0gPSBmYWxzZTsKPiAgCj4gIAlzd2l0Y2ggKGZsYWdzICYgTVNNX0JPX0NBQ0hFX01BU0spIHsK PiAgCWNhc2UgTVNNX0JPX1VOQ0FDSEVEOgo+IEBAIC03NzgsMjEgKzc3MywxMCBAQCBzdGF0aWMg aW50IG1zbV9nZW1fbmV3X2ltcGwoc3RydWN0IGRybV9kZXZpY2UgKmRldiwKPiAgCQlyZXR1cm4g LUVJTlZBTDsKPiAgCX0KPiAgCj4gLQlpZiAoIWlvbW11X3ByZXNlbnQoJnBsYXRmb3JtX2J1c190 eXBlKSkKPiAtCQl1c2VfdnJhbSA9IHRydWU7Cj4gLQllbHNlIGlmICgoZmxhZ3MgJiBNU01fQk9f U1RPTEVOKSAmJiBwcml2LT52cmFtLnNpemUpCj4gLQkJdXNlX3ZyYW0gPSB0cnVlOwo+IC0KPiAt CWlmIChXQVJOX09OKHVzZV92cmFtICYmICFwcml2LT52cmFtLnNpemUpKQo+IC0JCXJldHVybiAt RUlOVkFMOwo+IC0KPiAgCW1zbV9vYmogPSBremFsbG9jKHNpemVvZigqbXNtX29iaiksIEdGUF9L RVJORUwpOwo+ICAJaWYgKCFtc21fb2JqKQo+ICAJCXJldHVybiAtRU5PTUVNOwo+ICAKPiAtCWlm ICh1c2VfdnJhbSkKPiAtCQltc21fb2JqLT52cmFtX25vZGUgPSAmbXNtX29iai0+ZG9tYWluWzBd Lm5vZGU7Cj4gLQo+ICAJbXNtX29iai0+ZmxhZ3MgPSBmbGFnczsKPiAgCW1zbV9vYmotPm1hZHYg PSBNU01fTUFEVl9XSUxMTkVFRDsKPiAgCj4gQEAgLTgxNCwxMyArNzk4LDIzIEBAIHN0YXRpYyBp bnQgbXNtX2dlbV9uZXdfaW1wbChzdHJ1Y3QgZHJtX2RldmljZSAqZGV2LAo+ICBzdHJ1Y3QgZHJt X2dlbV9vYmplY3QgKm1zbV9nZW1fbmV3KHN0cnVjdCBkcm1fZGV2aWNlICpkZXYsCj4gIAkJdWlu dDMyX3Qgc2l6ZSwgdWludDMyX3QgZmxhZ3MpCj4gIHsKPiArCXN0cnVjdCBtc21fZHJtX3ByaXZh dGUgKnByaXYgPSBkZXYtPmRldl9wcml2YXRlOwo+ICAJc3RydWN0IGRybV9nZW1fb2JqZWN0ICpv YmogPSBOVUxMOwo+ICsJYm9vbCB1c2VfdnJhbSA9IGZhbHNlOwo+ICAJaW50IHJldDsKPiAgCj4g IAlXQVJOX09OKCFtdXRleF9pc19sb2NrZWQoJmRldi0+c3RydWN0X211dGV4KSk7Cj4gIAo+ICAJ c2l6ZSA9IFBBR0VfQUxJR04oc2l6ZSk7Cj4gIAo+ICsJaWYgKCFpb21tdV9wcmVzZW50KCZwbGF0 Zm9ybV9idXNfdHlwZSkpCj4gKwkJdXNlX3ZyYW0gPSB0cnVlOwo+ICsJZWxzZSBpZiAoKGZsYWdz ICYgTVNNX0JPX1NUT0xFTikgJiYgcHJpdi0+dnJhbS5zaXplKQo+ICsJCXVzZV92cmFtID0gdHJ1 ZTsKPiArCj4gKwlpZiAoV0FSTl9PTih1c2VfdnJhbSAmJiAhcHJpdi0+dnJhbS5zaXplKSkKPiAr CQlyZXR1cm4gRVJSX1BUUigtRUlOVkFMKTsKPiArCgpJIHdvdWxkIHNheSBXQVJOX09OQ0UgaGVy ZSBidXQgSSBndWVzcyBpZiB0aGUgZmlyc3QgYWxsb2NhdGlvbiBmYWlscyB3ZSBhcmVuJ3QKbWFr aW5nIGFueSBtb3JlLiBUaGlzIG1pZ2h0IGJlIHdvcnRoIGEgbmFzdHlncmFtIHRvIHRoZSBsb2cu Cgo+ICAJLyogRGlzYWxsb3cgemVybyBzaXplZCBvYmplY3RzIGFzIHRoZXkgbWFrZSB0aGUgdW5k ZXJseWluZwo+ICAJICogaW5mcmFzdHJ1Y3R1cmUgZ3J1bXB5Cj4gIAkgKi8KPiBAQCAtODMxLDEy ICs4MjUsMjQgQEAgc3RydWN0IGRybV9nZW1fb2JqZWN0ICptc21fZ2VtX25ldyhzdHJ1Y3QgZHJt X2RldmljZSAqZGV2LAo+ICAJaWYgKHJldCkKPiAgCQlnb3RvIGZhaWw7Cj4gIAo+IC0JaWYgKHVz ZV9wYWdlcyhvYmopKSB7Cj4gKwlpZiAodXNlX3ZyYW0pIHsKPiArCQlzdHJ1Y3QgbXNtX2dlbV9v YmplY3QgKm1zbV9vYmogPSB0b19tc21fYm8ob2JqKTsKPiArCQlzdHJ1Y3QgcGFnZSAqKnBhZ2Vz Owo+ICsKPiArCQltc21fb2JqLT52cmFtX25vZGUgPSAmbXNtX29iai0+ZG9tYWluWzBdLm5vZGU7 Cj4gKwkJZHJtX2dlbV9wcml2YXRlX29iamVjdF9pbml0KGRldiwgb2JqLCBzaXplKTsKPiArCj4g KwkJbXNtX29iai0+cGFnZXMgPSBnZXRfcGFnZXMob2JqKTsKPiArCQlwYWdlcyA9IGdldF9wYWdl cyhvYmopOwo+ICsJCWlmIChJU19FUlIocGFnZXMpKSB7Cj4gKwkJCXJldCA9IFBUUl9FUlIocGFn ZXMpOwo+ICsJCQlnb3RvIGZhaWw7Cj4gKwkJfQo+ICsJCW1zbV9vYmotPmRvbWFpblswXS5pb3Zh ID0gcGh5c2FkZHIob2JqKTsKPiArCX0gZWxzZSB7Cj4gIAkJcmV0ID0gZHJtX2dlbV9vYmplY3Rf aW5pdChkZXYsIG9iaiwgc2l6ZSk7Cj4gIAkJaWYgKHJldCkKPiAgCQkJZ290byBmYWlsOwo+IC0J fSBlbHNlIHsKPiAtCQlkcm1fZ2VtX3ByaXZhdGVfb2JqZWN0X2luaXQoZGV2LCBvYmosIHNpemUp Owo+ICAJfQo+ICAKPiAgCXJldHVybiBvYmo7Cj4gLS0gCj4gMi45LjQKPiAKCk90aGVyd2lzZSwK QWNrZWQtYnk6IEpvcmRhbiBDcm91c2UgPGpjcm91c2VAY29kZWF1cm9yYS5vcmc+Ci0tIApUaGUg UXVhbGNvbW0gSW5ub3ZhdGlvbiBDZW50ZXIsIEluYy4gaXMgYSBtZW1iZXIgb2YgQ29kZSBBdXJv cmEgRm9ydW0sCmEgTGludXggRm91bmRhdGlvbiBDb2xsYWJvcmF0aXZlIFByb2plY3QKX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVsIG1haWxp bmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJl ZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg==