From: Ben Widawsky Subject: Re: [PATCH 4/4] drm/i915: Add support for CCS modifiers Date: Fri, 21 Jul 2017 13:12:10 -0700 Message-ID: <20170721201210.GA17667@mail.bwidawsk.net> References: <20170623164544.7362-1-ben@bwidawsk.net> <20170623164544.7362-5-ben@bwidawsk.net> <20170629200208.GI12629@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <20170629200208.GI12629@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Ville =?utf-8?B?U3lyasOkbMOk?= Cc: Intel GFX , Daniel Stone , DRI Development List-Id: dri-devel@lists.freedesktop.org T24gMTctMDYtMjkgMjM6MDI6MDgsIFZpbGxlIFN5cmrDpGzDpCB3cm90ZToKPk9uIEZyaSwgSnVu IDIzLCAyMDE3IGF0IDA5OjQ1OjQ0QU0gLTA3MDAsIEJlbiBXaWRhd3NreSB3cm90ZToKPj4gdjI6 Cj4+IFN1cHBvcnQgc3ByaXRlIHBsYW5lLgo+PiBTdXBwb3J0IHBpcGUgQy9EIGxpbWl0YXRpb24g b24gR0VOOS4KPj4KPj4gVGhpcyByZXF1aXJlcyByZWJhc2Ugb24gdGhlIGNvcnJlY3QgVmlsbGUg cGF0Y2hlcwo+Pgo+PiBDYzogRGFuaWVsIFN0b25lIDxkYW5pZWxzQGNvbGxhYm9yYS5jb20+Cj4+ IENjOiBLcmlzdGlhbiBIw7hnc2JlcmcgPGtyaEBiaXRwbGFuZXQubmV0Pgo+PiBTaWduZWQtb2Zm LWJ5OiBCZW4gV2lkYXdza3kgPGJlbkBid2lkYXdzay5uZXQ+Cj4+IC0tLQo+PiAgZHJpdmVycy9n cHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5jIHwgMzQgKysrKysrKysrKysrKysrKysrKysrKysr Ky0tLS0tLQo+PiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfc3ByaXRlLmMgIHwgMzkgKysr KysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKystCj4+ICAyIGZpbGVzIGNoYW5nZWQsIDY2 IGluc2VydGlvbnMoKyksIDcgZGVsZXRpb25zKC0pCj4+Cj4+IGRpZmYgLS1naXQgYS9kcml2ZXJz L2dwdS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5LmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRl bF9kaXNwbGF5LmMKPj4gaW5kZXggODc3YTUxNTE0YzYxLi4yYTBlNWNkMjYwNTkgMTAwNjQ0Cj4+ IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rpc3BsYXkuYwo+PiArKysgYi9kcml2 ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5LmMKPj4gQEAgLTkzLDcgKzkzLDE3IEBAIHN0 YXRpYyBjb25zdCB1aW50MzJfdCBza2xfcHJpbWFyeV9mb3JtYXRzW10gPSB7Cj4+ICAJRFJNX0ZP Uk1BVF9WWVVZLAo+PiAgfTsKPj4KPj4gK3N0YXRpYyBjb25zdCB1aW50NjRfdCBza2xfZm9ybWF0 X21vZGlmaWVyc19ub2Njc1tdID0gewo+PiArCUk5MTVfRk9STUFUX01PRF9ZZl9USUxFRCwKPj4g KwlJOTE1X0ZPUk1BVF9NT0RfWV9USUxFRCwKPj4gKwlJOTE1X0ZPUk1BVF9NT0RfWF9USUxFRCwK Pj4gKwlEUk1fRk9STUFUX01PRF9MSU5FQVIsCj4+ICsJRFJNX0ZPUk1BVF9NT0RfSU5WQUxJRAo+ PiArfTsKPj4gKwo+PiAgc3RhdGljIGNvbnN0IHVpbnQ2NF90IHNrbF9mb3JtYXRfbW9kaWZpZXJz W10gPSB7Cj4KPk1heWJlIGNhbGxzIHRoaXMgX2Njc1tdIHRoZW4/Cj4KPj4gKwlJOTE1X0ZPUk1B VF9NT0RfWWZfVElMRURfQ0NTLAo+PiArCUk5MTVfRk9STUFUX01PRF9ZX1RJTEVEX0NDUywKPj4g IAlJOTE1X0ZPUk1BVF9NT0RfWWZfVElMRUQsCj4+ICAJSTkxNV9GT1JNQVRfTU9EX1lfVElMRUQs Cj4+ICAJSTkxNV9GT1JNQVRfTU9EX1hfVElMRUQsCj4+IEBAIC0xMzg3MiwxNyArMTM4ODIsMTMg QEAgc3RhdGljIGJvb2wgc2tsX21vZF9zdXBwb3J0ZWQodWludDMyX3QgZm9ybWF0LCB1aW50NjRf dCBtb2RpZmllcikKPj4gIAkJCXJldHVybiBmYWxzZTsKPj4gIAkJfQo+PiAgCWNhc2UgRFJNX0ZP Uk1BVF9SR0I1NjU6Cj4+IC0JY2FzZSBEUk1fRk9STUFUX1hSR0I4ODg4Ogo+PiAtCWNhc2UgRFJN X0ZPUk1BVF9YQkdSODg4ODoKPj4gLQljYXNlIERSTV9GT1JNQVRfQVJHQjg4ODg6Cj4+IC0JY2Fz ZSBEUk1fRk9STUFUX0FCR1I4ODg4Ogo+PiAgCWNhc2UgRFJNX0ZPUk1BVF9YUkdCMjEwMTAxMDoK Pj4gIAljYXNlIERSTV9GT1JNQVRfWEJHUjIxMDEwMTA6Cj4+ICAJY2FzZSBEUk1fRk9STUFUX1lV WVY6Cj4+ICAJY2FzZSBEUk1fRk9STUFUX1lWWVU6Cj4+ICAJY2FzZSBEUk1fRk9STUFUX1VZVlk6 Cj4+ICAJY2FzZSBEUk1fRk9STUFUX1ZZVVk6Cj4+IC0JCS8qIEFsbCBpOTE1IG1vZGlmaWVycyBh cmUgZmluZSAqLwo+PiArCQkvKiBBbGwgbm9uLWNjcyBpOTE1IG1vZGlmaWVycyBhcmUgZmluZSAq Lwo+PiAgCQlzd2l0Y2ggKG1vZGlmaWVyKSB7Cj4+ICAJCWNhc2UgRFJNX0ZPUk1BVF9NT0RfTElO RUFSOgo+PiAgCQljYXNlIEk5MTVfRk9STUFUX01PRF9YX1RJTEVEOgo+PiBAQCAtMTM4OTIsNiAr MTM4OTgsMTIgQEAgc3RhdGljIGJvb2wgc2tsX21vZF9zdXBwb3J0ZWQodWludDMyX3QgZm9ybWF0 LCB1aW50NjRfdCBtb2RpZmllcikKPj4gIAkJZGVmYXVsdDoKPj4gIAkJCXJldHVybiBmYWxzZTsK Pj4gIAkJfQo+PiArCWNhc2UgRFJNX0ZPUk1BVF9YUkdCODg4ODoKPj4gKwljYXNlIERSTV9GT1JN QVRfWEJHUjg4ODg6Cj4+ICsJY2FzZSBEUk1fRk9STUFUX0FSR0I4ODg4Ogo+PiArCWNhc2UgRFJN X0ZPUk1BVF9BQkdSODg4ODoKPj4gKwkJLyogQWxsIGk5MTUgbW9kaWZpZXJzIGFyZSBmaW5lICov Cj4+ICsJCXJldHVybiB0cnVlOwo+PiAgCWRlZmF1bHQ6Cj4+ICAJCXJldHVybiBmYWxzZTsKPj4g IAl9Cj4+IEBAIC0xNDEyMywxMyArMTQxMzUsMjMgQEAgaW50ZWxfcHJpbWFyeV9wbGFuZV9jcmVh dGUoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2LCBlbnVtIHBpcGUgcGlwZSkKPj4g IAlwcmltYXJ5LT5mcm9udGJ1ZmZlcl9iaXQgPSBJTlRFTF9GUk9OVEJVRkZFUl9QUklNQVJZKHBp cGUpOwo+PiAgCXByaW1hcnktPmNoZWNrX3BsYW5lID0gaW50ZWxfY2hlY2tfcHJpbWFyeV9wbGFu ZTsKPj4KPj4gLQlpZiAoSU5URUxfR0VOKGRldl9wcml2KSA+PSA5KSB7Cj4+ICsJaWYgKElOVEVM X0dFTihkZXZfcHJpdikgPj0gMTApIHsKPj4gIAkJaW50ZWxfcHJpbWFyeV9mb3JtYXRzID0gc2ts X3ByaW1hcnlfZm9ybWF0czsKPj4gIAkJbnVtX2Zvcm1hdHMgPSBBUlJBWV9TSVpFKHNrbF9wcmlt YXJ5X2Zvcm1hdHMpOwo+PiAgCQlpbnRlbF9mb3JtYXRfbW9kaWZpZXJzID0gc2tsX2Zvcm1hdF9t b2RpZmllcnM7Cj4+Cj4+ICAJCXByaW1hcnktPnVwZGF0ZV9wbGFuZSA9IHNreWxha2VfdXBkYXRl X3ByaW1hcnlfcGxhbmU7Cj4+ICAJCXByaW1hcnktPmRpc2FibGVfcGxhbmUgPSBza3lsYWtlX2Rp c2FibGVfcHJpbWFyeV9wbGFuZTsKPj4gKwl9IGVsc2UgaWYgKElOVEVMX0dFTihkZXZfcHJpdikg Pj0gOSkgewo+PiArCQlpbnRlbF9wcmltYXJ5X2Zvcm1hdHMgPSBza2xfcHJpbWFyeV9mb3JtYXRz Owo+PiArCQludW1fZm9ybWF0cyA9IEFSUkFZX1NJWkUoc2tsX3ByaW1hcnlfZm9ybWF0cyk7Cj4+ ICsJCWlmIChwaXBlID49IFBJUEVfQykKPgo+SSB0aGluayBJJ2Qga2VlcCB0aGUgZ2VuMTAgc3R1 ZmYgaW4gdGhlIHNhbWUgYnJhbmNoIHN0aWxsLiBBbHNvIHRoaXMKPm1pc3NlcyBHTEsuIFNvIG1h eWJlIHNvbWV0aGluZyBsaWtlIHRoaXM6Cj4KPmlmIChHRU4gPj0gMTAgfHwgSVNfR0xLIHx8IHBp cGUgIT0gUElQRV9DKQo+CgpJJ2QgcmVhbGx5IGxpa2UgdG8ga2VlcCB0aGUgcGlwZSBDIGxpbWl0 YXRpb24gaW4gdGhlIGdlbjkgYmxvY2ssIGJ1dCB5ZXMsIGl0IHdhcwptaXNzaW5nIEdMSy4gKFBh dGNoZXMgd2VyZSBvcmlnaW5hbGx5IHdyaXR0ZW4gYmVmb3JlIEdMSywgSSBiZWxpZXZlKSBUaGFu a3MgZm9yCmNhdGNoaW5nIHRoYXQuCgpJIHJlYWxseSBzdXNwZWN0IHdlJ3JlIGdvaW5nIHRvIG5l ZWQgdG8gc3BsaXQgZGlzcGxheSB2ZXJzaW9uIG91dCBvZiBJTlRFTF9HRU4uCk1heWJlIHlvdSBn dXlzIGFyZSBhbHJlYWR5IGRvaW5nIHRoaXMuCgpJJ20gZmluZSB3aXRoIGNjcyByZW5hbWUsIGFu ZCB5b3Ugd2VyZSByaWdodCBpbiB0aGUgcHJldmlvdXMgcGF0Y2ggYWJvdXQgaG93CnJlb3JnYW5p emluZyBtYWRlIHRoaXMgZGlmZiBuaWNlci4KPj4gKwkJCWludGVsX2Zvcm1hdF9tb2RpZmllcnMg PSBza2xfZm9ybWF0X21vZGlmaWVyczsKPj4gKwkJZWxzZQo+PiArCQkJaW50ZWxfZm9ybWF0X21v ZGlmaWVycyA9IHNrbF9mb3JtYXRfbW9kaWZpZXJzX25vY2NzOwo+PiArCj4+ICsJCXByaW1hcnkt PnVwZGF0ZV9wbGFuZSA9IHNreWxha2VfdXBkYXRlX3ByaW1hcnlfcGxhbmU7Cj4+ICsJCXByaW1h cnktPmRpc2FibGVfcGxhbmUgPSBza3lsYWtlX2Rpc2FibGVfcHJpbWFyeV9wbGFuZTsKPj4gIAl9 IGVsc2UgaWYgKElOVEVMX0dFTihkZXZfcHJpdikgPj0gNCkgewo+PiAgCQlpbnRlbF9wcmltYXJ5 X2Zvcm1hdHMgPSBpOTY1X3ByaW1hcnlfZm9ybWF0czsKPj4gIAkJbnVtX2Zvcm1hdHMgPSBBUlJB WV9TSVpFKGk5NjVfcHJpbWFyeV9mb3JtYXRzKTsKPj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1 L2RybS9pOTE1L2ludGVsX3Nwcml0ZS5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfc3By aXRlLmMKPj4gaW5kZXggZTgwODM0Y2IxZjRjLi5kZTQ0NTRhOGVmOWUgMTAwNjQ0Cj4+IC0tLSBh L2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3Nwcml0ZS5jCj4+ICsrKyBiL2RyaXZlcnMvZ3B1 L2RybS9pOTE1L2ludGVsX3Nwcml0ZS5jCj4+IEBAIC0xMDg1LDcgKzEwODUsMTcgQEAgc3RhdGlj IHVpbnQzMl90IHNrbF9wbGFuZV9mb3JtYXRzW10gPSB7Cj4+ICAJRFJNX0ZPUk1BVF9WWVVZLAo+ PiAgfTsKPj4KPj4gK3N0YXRpYyBjb25zdCB1aW50NjRfdCBza2xfcGxhbmVfZm9ybWF0X21vZGlm aWVyc19ub2Njc1tdID0gewo+PiArCUk5MTVfRk9STUFUX01PRF9ZZl9USUxFRCwKPj4gKwlJOTE1 X0ZPUk1BVF9NT0RfWV9USUxFRCwKPj4gKwlJOTE1X0ZPUk1BVF9NT0RfWF9USUxFRCwKPj4gKwlE Uk1fRk9STUFUX01PRF9MSU5FQVIsCj4+ICsJRFJNX0ZPUk1BVF9NT0RfSU5WQUxJRAo+PiArfTsK Pj4gKwo+PiAgc3RhdGljIGNvbnN0IHVpbnQ2NF90IHNrbF9wbGFuZV9mb3JtYXRfbW9kaWZpZXJz W10gPSB7Cj4KPkFnYWluIF9jY3NbXSBtYXliZT8KPgo+PiArCUk5MTVfRk9STUFUX01PRF9ZZl9U SUxFRF9DQ1MsCj4+ICsJSTkxNV9GT1JNQVRfTU9EX1lfVElMRURfQ0NTLAo+PiAgCUk5MTVfRk9S TUFUX01PRF9ZZl9USUxFRCwKPj4gIAlJOTE1X0ZPUk1BVF9NT0RfWV9USUxFRCwKPj4gIAlJOTE1 X0ZPUk1BVF9NT0RfWF9USUxFRCwKPj4gQEAgLTExMDgsNiArMTExOCwyMCBAQCBzdGF0aWMgYm9v bCBpbnRlbF9zcHJpdGVfcGxhbmVfZm9ybWF0X21vZF9zdXBwb3J0ZWQoc3RydWN0IGRybV9wbGFu ZSAqcGxhbmUsCj4+ICAJICAgIG1vZGlmaWVyICE9IERSTV9GT1JNQVRfTU9EX0xJTkVBUikKPj4g IAkJcmV0dXJuIGZhbHNlOwo+Pgo+PiArCXN3aXRjaCAobW9kaWZpZXIpIHsKPj4gKwljYXNlIEk5 MTVfRk9STUFUX01PRF9ZZl9USUxFRF9DQ1M6Cj4+ICsJY2FzZSBJOTE1X0ZPUk1BVF9NT0RfWV9U SUxFRF9DQ1M6Cj4+ICsJCXN3aXRjaCAoZm9ybWF0KSB7Cj4+ICsJCWNhc2UgRFJNX0ZPUk1BVF9B QkdSODg4ODoKPj4gKwkJY2FzZSBEUk1fRk9STUFUX0FSR0I4ODg4Ogo+PiArCQljYXNlIERSTV9G T1JNQVRfWEJHUjg4ODg6Cj4+ICsJCWNhc2UgRFJNX0ZPUk1BVF9YUkdCODg4ODoKPj4gKwkJCXJl dHVybiB0cnVlOwo+PiArCQlkZWZhdWx0Ogo+PiArCQkJcmV0dXJuIGZhbHNlOwo+PiArCQl9Cj4+ ICsJfQo+PiArCj4+ICAJc3dpdGNoIChmb3JtYXQpIHsKPj4gIAkJY2FzZSBEUk1fRk9STUFUX1hC R1IyMTAxMDEwOgo+PiAgCQljYXNlIERSTV9GT1JNQVRfQUJHUjIxMDEwMTA6Cj4+IEBAIC0xMTcz LDcgKzExOTcsNyBAQCBpbnRlbF9zcHJpdGVfcGxhbmVfY3JlYXRlKHN0cnVjdCBkcm1faTkxNV9w cml2YXRlICpkZXZfcHJpdiwKPj4gIAl9Cj4+ICAJaW50ZWxfcGxhbmUtPmJhc2Uuc3RhdGUgPSAm c3RhdGUtPmJhc2U7Cj4+Cj4+IC0JaWYgKElOVEVMX0dFTihkZXZfcHJpdikgPj0gOSkgewo+PiAr CWlmIChJTlRFTF9HRU4oZGV2X3ByaXYpID49IDEwKSB7Cj4+ICAJCWludGVsX3BsYW5lLT5jYW5f c2NhbGUgPSB0cnVlOwo+PiAgCQlzdGF0ZS0+c2NhbGVyX2lkID0gLTE7Cj4+Cj4+IEBAIC0xMTgz LDYgKzEyMDcsMTkgQEAgaW50ZWxfc3ByaXRlX3BsYW5lX2NyZWF0ZShzdHJ1Y3QgZHJtX2k5MTVf cHJpdmF0ZSAqZGV2X3ByaXYsCj4+ICAJCXBsYW5lX2Zvcm1hdHMgPSBza2xfcGxhbmVfZm9ybWF0 czsKPj4gIAkJbnVtX3BsYW5lX2Zvcm1hdHMgPSBBUlJBWV9TSVpFKHNrbF9wbGFuZV9mb3JtYXRz KTsKPj4gIAkJbW9kaWZpZXJzID0gc2tsX3BsYW5lX2Zvcm1hdF9tb2RpZmllcnM7Cj4+ICsJfSBl bHNlIGlmIChJTlRFTF9HRU4oZGV2X3ByaXYpID49IDkpIHsKPj4gKwkJaW50ZWxfcGxhbmUtPmNh bl9zY2FsZSA9IHRydWU7Cj4+ICsJCXN0YXRlLT5zY2FsZXJfaWQgPSAtMTsKPj4gKwo+PiArCQlp bnRlbF9wbGFuZS0+dXBkYXRlX3BsYW5lID0gc2tsX3VwZGF0ZV9wbGFuZTsKPj4gKwkJaW50ZWxf cGxhbmUtPmRpc2FibGVfcGxhbmUgPSBza2xfZGlzYWJsZV9wbGFuZTsKPj4gKwo+PiArCQlwbGFu ZV9mb3JtYXRzID0gc2tsX3BsYW5lX2Zvcm1hdHM7Cj4+ICsJCW51bV9wbGFuZV9mb3JtYXRzID0g QVJSQVlfU0laRShza2xfcGxhbmVfZm9ybWF0cyk7Cj4+ICsJCWlmIChwaXBlID49IFBJUEVfQykK Pj4gKwkJCW1vZGlmaWVycyA9IHNrbF9wbGFuZV9mb3JtYXRfbW9kaWZpZXJzX25vY2NzOwo+PiAr CQllbHNlCj4+ICsJCQltb2RpZmllcnMgPSBza2xfcGxhbmVfZm9ybWF0X21vZGlmaWVyczsKPj4g IAl9IGVsc2UgaWYgKElTX1ZBTExFWVZJRVcoZGV2X3ByaXYpIHx8IElTX0NIRVJSWVZJRVcoZGV2 X3ByaXYpKSB7Cj4+ICAJCWludGVsX3BsYW5lLT5jYW5fc2NhbGUgPSBmYWxzZTsKPj4gIAkJaW50 ZWxfcGxhbmUtPm1heF9kb3duc2NhbGUgPSAxOwo+PiAtLQo+PiAyLjEzLjEKPj4KPj4gX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KPj4gZHJpLWRldmVsIG1h aWxpbmcgbGlzdAo+PiBkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCj4+IGh0dHBzOi8v bGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCj4KPi0tIAo+ VmlsbGUgU3lyasOkbMOkCj5JbnRlbCBPVEMKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMu ZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlz dGluZm8vZHJpLWRldmVsCg==