From: Tom St Denis Subject: [PATCH umr 3/4] Various cleanups found by static analysis. Date: Mon, 24 Jul 2017 11:25:50 -0400 Message-ID: <20170724152551.29427-4-tom.stdenis@amd.com> References: <20170724152551.29427-1-tom.stdenis@amd.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20170724152551.29427-1-tom.stdenis-5C7GfCeVMHo@public.gmane.org> List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: amd-gfx-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Sender: "amd-gfx" To: amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Cc: Tom St Denis U2lnbmVkLW9mZi1ieTogVG9tIFN0IERlbmlzIDx0b20uc3RkZW5pc0BhbWQuY29tPgotLS0KIHNy Yy9hcHAvZW51bS5jICAgICAgICAgICAgICAgfCA0ICsrLS0KIHNyYy9saWIvY3JlYXRlX2FzaWNf aGVscGVyLmMgfCA1ICsrKysrCiBzcmMvbGliL2Rpc2NvdmVyLmMgICAgICAgICAgIHwgOSArKysr KysrLS0KIHNyYy9saWIvbW1pby5jICAgICAgICAgICAgICAgfCA4ICsrKysrKysrCiA0IGZpbGVz IGNoYW5nZWQsIDIyIGluc2VydGlvbnMoKyksIDQgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEv c3JjL2FwcC9lbnVtLmMgYi9zcmMvYXBwL2VudW0uYwppbmRleCAyYzRiNzY5NWUzY2IuLjkyM2Fi ZjkxMzFiMCAxMDA2NDQKLS0tIGEvc3JjL2FwcC9lbnVtLmMKKysrIGIvc3JjL2FwcC9lbnVtLmMK QEAgLTY2LDEwICs2NiwxMCBAQCB2b2lkIHVtcl9lbnVtZXJhdGVfZGV2aWNlcyh2b2lkKQogCQkJ YXNpY3NbZGV2aWNlcysrXS5wY29weSA9ICpwZGV2aWNlOwogCQkJeCA9IDE7CiAJCX0KLQl9IHdo aWxlIChwZGV2aWNlICYmIGRldmljZXMgPCBNQVhfREVWKTsKKwl9IHdoaWxlICh4ICYmIHBkZXZp Y2UgJiYgZGV2aWNlcyA8IE1BWF9ERVYpOwogCiAJLy8gbm93IHRyeSB0byBtYXRjaCBkZXZpY2Vz IGFnYWluc3QgaW5zdGFuY2VzCi0JZm9yICh5ID0gMDsgeSA8IE1BWF9ERVY7IHkrKykgeworCWZv ciAoeSA9IDA7IHkgPCBkZXZpY2VzOyB5KyspIHsKIAkJc25wcmludGYocGF0aCwgc2l6ZW9mKHBh dGgpLTEsICIvc3lzL2tlcm5lbC9kZWJ1Zy9kcmkvJWQvbmFtZSIsIHkpOwogCQlkcmkgPSBmb3Bl bihwYXRoLCAiciIpOwogCQlpZiAoZHJpKSB7CmRpZmYgLS1naXQgYS9zcmMvbGliL2NyZWF0ZV9h c2ljX2hlbHBlci5jIGIvc3JjL2xpYi9jcmVhdGVfYXNpY19oZWxwZXIuYwppbmRleCBkMGVlMzRh Yzk1MWUuLmZmY2EzNWQ3YWY5MyAxMDA2NDQKLS0tIGEvc3JjL2xpYi9jcmVhdGVfYXNpY19oZWxw ZXIuYworKysgYi9zcmMvbGliL2NyZWF0ZV9hc2ljX2hlbHBlci5jCkBAIC00OCw2ICs0OCwxMSBA QCBzdHJ1Y3QgdW1yX2FzaWMgKnVtcl9jcmVhdGVfYXNpY19oZWxwZXIoY2hhciAqbmFtZSwgaW50 IGZhbWlseSwgLi4uKQogCX0KIAl2YV9lbmQoYXApOwogCisJaWYgKCFhc2ljLT5ub19ibG9ja3Mp IHsKKwkJZnJlZShhc2ljKTsKKwkJcmV0dXJuIE5VTEw7CisJfQorCiAJYXNpYy0+YmxvY2tzID0g Y2FsbG9jKGFzaWMtPm5vX2Jsb2Nrcywgc2l6ZW9mKHN0cnVjdCB1bXJfaXBfYmxvY2sgKikpOwog CWlmICghYXNpYy0+YmxvY2tzKSB7CiAJCWZyZWUoYXNpYyk7CmRpZmYgLS1naXQgYS9zcmMvbGli L2Rpc2NvdmVyLmMgYi9zcmMvbGliL2Rpc2NvdmVyLmMKaW5kZXggMGM0ZWUxYzA5YWQ4Li4wZmMw NTM3MTJlMzcgMTAwNjQ0Ci0tLSBhL3NyYy9saWIvZGlzY292ZXIuYworKysgYi9zcmMvbGliL2Rp c2NvdmVyLmMKQEAgLTI2OSwyMCArMjY5LDI1IEBAIHN0cnVjdCB1bXJfYXNpYyAqdW1yX2Rpc2Nv dmVyX2FzaWMoc3RydWN0IHVtcl9vcHRpb25zICpvcHRpb25zKQogCQkJCWdvdG8gZXJyX3BjaTsK IAkJCX0KIAkJCXBjaV9pdGVyYXRvcl9kZXN0cm95KHBjaV9pdGVyKTsKKworCQkJLy8gZW5hYmxl IGRldmljZSBpZiBrZXJuZWwgbW9kdWxlIGlzbid0IHByZXNlbnQKKwkJCWlmIChhc2ljLT5vcHRp b25zLm5vX2tlcm5lbCkKKwkJCQlwY2lfZGV2aWNlX2VuYWJsZShhc2ljLT5wY2kucGRldmljZSk7 CisKIAkJCXBjaV9kZXZpY2VfcHJvYmUoYXNpYy0+cGNpLnBkZXZpY2UpOwogCiAJCQl1c2VfcmVn aW9uID0gNjsKIAkJCS8vIHRyeSB0byBkZXRlY3QgYmFzZWQgb24gQVNJQyBmYW1pbHkKIAkJCWlm IChhc2ljLT5mYW1pbHkgPD0gRkFNSUxZX1NJKSB7CiAJCQkJLy8gdHJ5IHJlZ2lvbiAyIGZvciBT SQotCQkJCWlmICgJYXNpYy0+cGNpLnBkZXZpY2UtPnJlZ2lvbnNbMl0uaXNfNjQgPT0gMCAmJgor CQkJCWlmIChhc2ljLT5wY2kucGRldmljZS0+cmVnaW9uc1syXS5pc182NCA9PSAwICYmCiAJCQkJ CWFzaWMtPnBjaS5wZGV2aWNlLT5yZWdpb25zWzJdLmlzX3ByZWZldGNoYWJsZSA9PSAwICYmCiAJ CQkJCWFzaWMtPnBjaS5wZGV2aWNlLT5yZWdpb25zWzJdLmlzX0lPID09IDApIHsKIAkJCQkJCXVz ZV9yZWdpb24gPSAyOwogCQkJCX0KIAkJCX0gZWxzZSBpZiAoYXNpYy0+ZmFtaWx5IDw9IEZBTUlM WV9WSSkgewogCQkJCS8vIHRyeSByZWdpb24gNSBmb3IgQ0lLLi5WSQotCQkJCWlmICgJYXNpYy0+ cGNpLnBkZXZpY2UtPnJlZ2lvbnNbNV0uaXNfNjQgPT0gMCAmJgorCQkJCWlmIChhc2ljLT5wY2ku cGRldmljZS0+cmVnaW9uc1s1XS5pc182NCA9PSAwICYmCiAJCQkJCWFzaWMtPnBjaS5wZGV2aWNl LT5yZWdpb25zWzVdLmlzX3ByZWZldGNoYWJsZSA9PSAwICYmCiAJCQkJCWFzaWMtPnBjaS5wZGV2 aWNlLT5yZWdpb25zWzVdLmlzX0lPID09IDApIHsKIAkJCQkJCXVzZV9yZWdpb24gPSA1OwpkaWZm IC0tZ2l0IGEvc3JjL2xpYi9tbWlvLmMgYi9zcmMvbGliL21taW8uYwppbmRleCA5ODc3MDRjYjk5 NDQuLjQ3ZTUxNTBkMzIwMSAxMDA2NDQKLS0tIGEvc3JjL2xpYi9tbWlvLmMKKysrIGIvc3JjL2xp Yi9tbWlvLmMKQEAgLTg4LDYgKzg4LDEwIEBAIHVpbnQzMl90IHVtcl9yZWFkX3JlZyhzdHJ1Y3Qg dW1yX2FzaWMgKmFzaWMsIHVpbnQ2NF90IGFkZHIsIGVudW0gcmVnY2xhc3MgdHlwZSkKIAlpZiAo YWRkciA9PSAweEZGRkZGRkZGKQogCQlmcHJpbnRmKHN0ZGVyciwgIltCVUddOiByZWFkaW5nIGZy b20gYWRkcj09MHhGRkZGRkZGRiBpcyBsaWtlbHkgYSBidWdcbiIpOwogCisJLy8gbG9wIG9mZiB0 b3AgYml0cyBpbiBuby1rZXJuZWwgbW9kZQorCWlmIChhc2ljLT5vcHRpb25zLm5vX2tlcm5lbCkK KwkJYWRkciAmPSAweEZGRkZGRjsKKwogCXN3aXRjaCAodHlwZSkgewogCQljYXNlIFJFR19NTUlP OgogCQkJaWYgKGFzaWMtPnBjaS5tZW0gJiYgIShhZGRyICYgfjB4RkZGRkZVTEwpKSB7IC8vIG9u bHkgdXNlIHBjaSBpZiBlbmFibGVkIGFuZCBub3QgdXNpbmcgaGlnaCBiaXRzIApAQCAtMTEzLDYg KzExNywxMCBAQCBpbnQgdW1yX3dyaXRlX3JlZyhzdHJ1Y3QgdW1yX2FzaWMgKmFzaWMsIHVpbnQ2 NF90IGFkZHIsIHVpbnQzMl90IHZhbHVlLCBlbnVtIHJlZwogCWlmIChhZGRyID09IDB4RkZGRkZG RkYpCiAJCWZwcmludGYoc3RkZXJyLCAiW0JVR106IHJlYWRpbmcgZnJvbSBhZGRyPT0weEZGRkZG RkZGIGlzIGxpa2VseSBhIGJ1Z1xuIik7CiAKKwkvLyBsb3Agb2ZmIHRvcCBiaXRzIGluIG5vLWtl cm5lbCBtb2RlCisJaWYgKGFzaWMtPm9wdGlvbnMubm9fa2VybmVsKQorCQlhZGRyICY9IDB4RkZG RkZGOworCiAJc3dpdGNoICh0eXBlKSB7CiAJCWNhc2UgUkVHX01NSU86CiAJCQlpZiAoYXNpYy0+ cGNpLm1lbSAmJiAhKGFkZHIgJiB+MHhGRkZGRlVMTCkpIHsKLS0gCjIuMTIuMAoKX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KYW1kLWdmeCBtYWlsaW5nIGxp c3QKYW1kLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3Rv cC5vcmcvbWFpbG1hbi9saXN0aW5mby9hbWQtZ2Z4Cg==