From: Tom St Denis Subject: [PATCH umr 3/4] Various cleanups found by static analysis. (v2) Date: Tue, 25 Jul 2017 13:23:23 -0400 Message-ID: <20170725172324.28365-4-tom.stdenis@amd.com> References: <20170725172324.28365-1-tom.stdenis@amd.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20170725172324.28365-1-tom.stdenis-5C7GfCeVMHo@public.gmane.org> List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: amd-gfx-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Sender: "amd-gfx" To: amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Cc: Tom St Denis U2lnbmVkLW9mZi1ieTogVG9tIFN0IERlbmlzIDx0b20uc3RkZW5pc0BhbWQuY29tPgpBY2tlZC1i eTogQWxleCBEZXVjaGVyIDxhbGV4YW5kZXIuZGV1Y2hlckBhbWQuY29tPgoKKHYyKTogVXBkYXRl ZCBlbnVtZXJhdGUgdG8gbm90IHN0b3Agb24gb3RoZXIgQU1EIFBDSSBkZXZpY2VzCi0tLQogc3Jj L2FwcC9lbnVtLmMgICAgICAgICAgICAgICB8IDQgKy0tLQogc3JjL2xpYi9jcmVhdGVfYXNpY19o ZWxwZXIuYyB8IDUgKysrKysKIHNyYy9saWIvZGlzY292ZXIuYyAgICAgICAgICAgfCA5ICsrKysr KystLQogc3JjL2xpYi9tbWlvLmMgICAgICAgICAgICAgICB8IDggKysrKysrKysKIDQgZmlsZXMg Y2hhbmdlZCwgMjEgaW5zZXJ0aW9ucygrKSwgNSBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9z cmMvYXBwL2VudW0uYyBiL3NyYy9hcHAvZW51bS5jCmluZGV4IDJjNGI3Njk1ZTNjYi4uMWM1NmZl NjQzNjE2IDEwMDY0NAotLS0gYS9zcmMvYXBwL2VudW0uYworKysgYi9zcmMvYXBwL2VudW0uYwpA QCAtNTUsNyArNTUsNiBAQCB2b2lkIHVtcl9lbnVtZXJhdGVfZGV2aWNlcyh2b2lkKQogCQlyZXR1 cm47CiAJfQogCWRvIHsKLQkJeCA9IDA7CiAJCWRvIHsKIAkJCXBkZXZpY2UgPSBwY2lfZGV2aWNl X25leHQocGNpX2l0ZXIpOwogCQl9IHdoaWxlIChwZGV2aWNlICYmIHBkZXZpY2UtPnZlbmRvcl9p ZCAhPSAweDEwMDIpOwpAQCAtNjQsMTIgKzYzLDExIEBAIHZvaWQgdW1yX2VudW1lcmF0ZV9kZXZp Y2VzKHZvaWQpCiAJCQlhc2ljc1tkZXZpY2VzXS5pbnN0YW5jZSA9IC0xOwogCQkJYXNpY3NbZGV2 aWNlc10uYXNpYy0+cGNpLnBkZXZpY2UgPSAmYXNpY3NbZGV2aWNlc10ucGNvcHk7CiAJCQlhc2lj c1tkZXZpY2VzKytdLnBjb3B5ID0gKnBkZXZpY2U7Ci0JCQl4ID0gMTsKIAkJfQogCX0gd2hpbGUg KHBkZXZpY2UgJiYgZGV2aWNlcyA8IE1BWF9ERVYpOwogCiAJLy8gbm93IHRyeSB0byBtYXRjaCBk ZXZpY2VzIGFnYWluc3QgaW5zdGFuY2VzCi0JZm9yICh5ID0gMDsgeSA8IE1BWF9ERVY7IHkrKykg eworCWZvciAoeSA9IDA7IHkgPCBkZXZpY2VzOyB5KyspIHsKIAkJc25wcmludGYocGF0aCwgc2l6 ZW9mKHBhdGgpLTEsICIvc3lzL2tlcm5lbC9kZWJ1Zy9kcmkvJWQvbmFtZSIsIHkpOwogCQlkcmkg PSBmb3BlbihwYXRoLCAiciIpOwogCQlpZiAoZHJpKSB7CmRpZmYgLS1naXQgYS9zcmMvbGliL2Ny ZWF0ZV9hc2ljX2hlbHBlci5jIGIvc3JjL2xpYi9jcmVhdGVfYXNpY19oZWxwZXIuYwppbmRleCBk MGVlMzRhYzk1MWUuLmZmY2EzNWQ3YWY5MyAxMDA2NDQKLS0tIGEvc3JjL2xpYi9jcmVhdGVfYXNp Y19oZWxwZXIuYworKysgYi9zcmMvbGliL2NyZWF0ZV9hc2ljX2hlbHBlci5jCkBAIC00OCw2ICs0 OCwxMSBAQCBzdHJ1Y3QgdW1yX2FzaWMgKnVtcl9jcmVhdGVfYXNpY19oZWxwZXIoY2hhciAqbmFt ZSwgaW50IGZhbWlseSwgLi4uKQogCX0KIAl2YV9lbmQoYXApOwogCisJaWYgKCFhc2ljLT5ub19i bG9ja3MpIHsKKwkJZnJlZShhc2ljKTsKKwkJcmV0dXJuIE5VTEw7CisJfQorCiAJYXNpYy0+Ymxv Y2tzID0gY2FsbG9jKGFzaWMtPm5vX2Jsb2Nrcywgc2l6ZW9mKHN0cnVjdCB1bXJfaXBfYmxvY2sg KikpOwogCWlmICghYXNpYy0+YmxvY2tzKSB7CiAJCWZyZWUoYXNpYyk7CmRpZmYgLS1naXQgYS9z cmMvbGliL2Rpc2NvdmVyLmMgYi9zcmMvbGliL2Rpc2NvdmVyLmMKaW5kZXggMGM0ZWUxYzA5YWQ4 Li4wZmMwNTM3MTJlMzcgMTAwNjQ0Ci0tLSBhL3NyYy9saWIvZGlzY292ZXIuYworKysgYi9zcmMv bGliL2Rpc2NvdmVyLmMKQEAgLTI2OSwyMCArMjY5LDI1IEBAIHN0cnVjdCB1bXJfYXNpYyAqdW1y X2Rpc2NvdmVyX2FzaWMoc3RydWN0IHVtcl9vcHRpb25zICpvcHRpb25zKQogCQkJCWdvdG8gZXJy X3BjaTsKIAkJCX0KIAkJCXBjaV9pdGVyYXRvcl9kZXN0cm95KHBjaV9pdGVyKTsKKworCQkJLy8g ZW5hYmxlIGRldmljZSBpZiBrZXJuZWwgbW9kdWxlIGlzbid0IHByZXNlbnQKKwkJCWlmIChhc2lj LT5vcHRpb25zLm5vX2tlcm5lbCkKKwkJCQlwY2lfZGV2aWNlX2VuYWJsZShhc2ljLT5wY2kucGRl dmljZSk7CisKIAkJCXBjaV9kZXZpY2VfcHJvYmUoYXNpYy0+cGNpLnBkZXZpY2UpOwogCiAJCQl1 c2VfcmVnaW9uID0gNjsKIAkJCS8vIHRyeSB0byBkZXRlY3QgYmFzZWQgb24gQVNJQyBmYW1pbHkK IAkJCWlmIChhc2ljLT5mYW1pbHkgPD0gRkFNSUxZX1NJKSB7CiAJCQkJLy8gdHJ5IHJlZ2lvbiAy IGZvciBTSQotCQkJCWlmICgJYXNpYy0+cGNpLnBkZXZpY2UtPnJlZ2lvbnNbMl0uaXNfNjQgPT0g MCAmJgorCQkJCWlmIChhc2ljLT5wY2kucGRldmljZS0+cmVnaW9uc1syXS5pc182NCA9PSAwICYm CiAJCQkJCWFzaWMtPnBjaS5wZGV2aWNlLT5yZWdpb25zWzJdLmlzX3ByZWZldGNoYWJsZSA9PSAw ICYmCiAJCQkJCWFzaWMtPnBjaS5wZGV2aWNlLT5yZWdpb25zWzJdLmlzX0lPID09IDApIHsKIAkJ CQkJCXVzZV9yZWdpb24gPSAyOwogCQkJCX0KIAkJCX0gZWxzZSBpZiAoYXNpYy0+ZmFtaWx5IDw9 IEZBTUlMWV9WSSkgewogCQkJCS8vIHRyeSByZWdpb24gNSBmb3IgQ0lLLi5WSQotCQkJCWlmICgJ YXNpYy0+cGNpLnBkZXZpY2UtPnJlZ2lvbnNbNV0uaXNfNjQgPT0gMCAmJgorCQkJCWlmIChhc2lj LT5wY2kucGRldmljZS0+cmVnaW9uc1s1XS5pc182NCA9PSAwICYmCiAJCQkJCWFzaWMtPnBjaS5w ZGV2aWNlLT5yZWdpb25zWzVdLmlzX3ByZWZldGNoYWJsZSA9PSAwICYmCiAJCQkJCWFzaWMtPnBj aS5wZGV2aWNlLT5yZWdpb25zWzVdLmlzX0lPID09IDApIHsKIAkJCQkJCXVzZV9yZWdpb24gPSA1 OwpkaWZmIC0tZ2l0IGEvc3JjL2xpYi9tbWlvLmMgYi9zcmMvbGliL21taW8uYwppbmRleCA5ODc3 MDRjYjk5NDQuLjQ3ZTUxNTBkMzIwMSAxMDA2NDQKLS0tIGEvc3JjL2xpYi9tbWlvLmMKKysrIGIv c3JjL2xpYi9tbWlvLmMKQEAgLTg4LDYgKzg4LDEwIEBAIHVpbnQzMl90IHVtcl9yZWFkX3JlZyhz dHJ1Y3QgdW1yX2FzaWMgKmFzaWMsIHVpbnQ2NF90IGFkZHIsIGVudW0gcmVnY2xhc3MgdHlwZSkK IAlpZiAoYWRkciA9PSAweEZGRkZGRkZGKQogCQlmcHJpbnRmKHN0ZGVyciwgIltCVUddOiByZWFk aW5nIGZyb20gYWRkcj09MHhGRkZGRkZGRiBpcyBsaWtlbHkgYSBidWdcbiIpOwogCisJLy8gbG9w IG9mZiB0b3AgYml0cyBpbiBuby1rZXJuZWwgbW9kZQorCWlmIChhc2ljLT5vcHRpb25zLm5vX2tl cm5lbCkKKwkJYWRkciAmPSAweEZGRkZGRjsKKwogCXN3aXRjaCAodHlwZSkgewogCQljYXNlIFJF R19NTUlPOgogCQkJaWYgKGFzaWMtPnBjaS5tZW0gJiYgIShhZGRyICYgfjB4RkZGRkZVTEwpKSB7 IC8vIG9ubHkgdXNlIHBjaSBpZiBlbmFibGVkIGFuZCBub3QgdXNpbmcgaGlnaCBiaXRzIApAQCAt MTEzLDYgKzExNywxMCBAQCBpbnQgdW1yX3dyaXRlX3JlZyhzdHJ1Y3QgdW1yX2FzaWMgKmFzaWMs IHVpbnQ2NF90IGFkZHIsIHVpbnQzMl90IHZhbHVlLCBlbnVtIHJlZwogCWlmIChhZGRyID09IDB4 RkZGRkZGRkYpCiAJCWZwcmludGYoc3RkZXJyLCAiW0JVR106IHJlYWRpbmcgZnJvbSBhZGRyPT0w eEZGRkZGRkZGIGlzIGxpa2VseSBhIGJ1Z1xuIik7CiAKKwkvLyBsb3Agb2ZmIHRvcCBiaXRzIGlu IG5vLWtlcm5lbCBtb2RlCisJaWYgKGFzaWMtPm9wdGlvbnMubm9fa2VybmVsKQorCQlhZGRyICY9 IDB4RkZGRkZGOworCiAJc3dpdGNoICh0eXBlKSB7CiAJCWNhc2UgUkVHX01NSU86CiAJCQlpZiAo YXNpYy0+cGNpLm1lbSAmJiAhKGFkZHIgJiB+MHhGRkZGRlVMTCkpIHsKLS0gCjIuMTIuMAoKX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KYW1kLWdmeCBtYWls aW5nIGxpc3QKYW1kLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVl ZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9hbWQtZ2Z4Cg==