Return-Path: Received: from mx2.suse.de ([195.135.220.15]:58113 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752031AbdHQRJL (ORCPT ); Thu, 17 Aug 2017 13:09:11 -0400 Date: Thu, 17 Aug 2017 19:09:08 +0200 From: Jan Kara To: Andreas Dilger Cc: Jan Kara , linux-fsdevel@vger.kernel.org, Wang Shilong Subject: Re: [PATCH 12/27] quota: Push dqio_sem down to ->get_next_id() Message-ID: <20170817170908.GE28850@quack2.suse.cz> References: <20170816154127.7048-1-jack@suse.cz> <20170816154127.7048-13-jack@suse.cz> <06DA9BC5-E5DA-48FB-B620-0AE6295239DF@dilger.ca> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <06DA9BC5-E5DA-48FB-B620-0AE6295239DF@dilger.ca> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Wed 16-08-17 11:08:12, Andreas Dilger wrote: > On Aug 16, 2017, at 9:41 AM, Jan Kara wrote: > > > > Push down acquisition of dqio_sem into ->get_next_id() callback. Mostly > > for consistency with other operations. > > > > Signed-off-by: Jan Kara > > I was initially thinking that this patch also needed to modify the > filesystem-specific code in a similar way, but ext4 and reiserfs > use dquot_get_next_id() internally, ocfs2 appears to have its own > locking, and XFS is doing completely its own thing. > > It is a bit confusing that there are both dquot_operation.get_next_id > as well as quota_format_ops.get_next_id methods that are similar but > not totally the same thing. It might make sense to rename the > quota_format_ops method like .get_next_id_format or similar to be able > to distinguish them? Yeah, they are two different levels of abstraction of the same operation. I agree that the fact that names are matching is a bit confusing. I'll think how to differentiate these names... Honza -- Jan Kara SUSE Labs, CR