Date: Thu, 31 Aug 2017 16:29:30 +0200
From: Cornelia Huck <cohuck@redhat.com>
Message-ID: <20170831162930.17657819.cohuck@redhat.com>
In-Reply-To: <aa375deb-69ba-e0a8-d617-bbb304207a12@redhat.com>
References: <20170830170601.15855-1-david@redhat.com>
	<20170830170601.15855-4-david@redhat.com>
	<09179efb-0930-bd84-ff22-1f4b23fa6a8e@redhat.com>
	<aa375deb-69ba-e0a8-d617-bbb304207a12@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v1 03/11] s390x: store cpu states inside
 machine state
To: David Hildenbrand <david@redhat.com>
Cc: Thomas Huth <thuth@redhat.com>, qemu-devel@nongnu.org, Richard Henderson <richard.henderson@linaro.org>, Aurelien Jarno <aurelien@aurel32.net>, borntraeger@de.ibm.com, Alexander Graf <agraf@suse.de>

On Thu, 31 Aug 2017 15:11:28 +0200
David Hildenbrand <david@redhat.com> wrote:

> >> +S390CPU *s390_cpu_addr2state(uint16_t cpu_addr)
> >> +{
> >> +    S390CcwMachineState *ms = S390_CCW_MACHINE(qdev_get_machine());
> >> +
> >> +    if (cpu_addr >= max_cpus) {
> >> +        return NULL;
> >> +    }
> >> +
> >> +    /* Fast lookup via CPU ID */
> >> +    return ms->cpus[cpu_addr];
> >> +}  
> > 
> > I wonder whether that function should rather go into a file in
> > target/s390x/ instead, since it is also used there and its prototype is
> > in cpu.h ?  
> 
> I thought about the same thing, but as it works directly on the machine,
> like ri_allowed() and friends. So I decided to keep it here for now.
> 
> I'll think about moving the definition also into
> include/hw/s390x/s390-virtio-ccw.h

It would be a bit nicer.